)]}'
{"scripts/oooq_common_functions.sh":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"123af0d53e71ef0bdbccfd22e23d0a1f0f78843b","unresolved":true,"context_lines":[{"line_number":29,"context_line":"            ;;"},{"line_number":30,"context_line":"        train|promotion-testing-hash-train)"},{"line_number":31,"context_line":"            echo \"stein\""},{"line_number":32,"context_line":"            ;;"},{"line_number":33,"context_line":"        queens)"},{"line_number":34,"context_line":"            echo \"pike\""},{"line_number":35,"context_line":"            ;;"}],"source_content_type":"text/x-sh","patch_set":1,"id":"c11f2e26_31502024","line":32,"range":{"start_line":32,"start_character":11,"end_line":32,"end_character":14},"updated":"2021-04-05 19:13:56.000000000","message":"Need to do it also in: https://opendev.org/openstack/tripleo-ci/src/branch/master/roles/run-test/templates/oooq_common_functions.sh.j2#L33-L37\nIt\u0027s the actual code we use.","commit_id":"1f817406f398ca639e927699fc6f33ff862625c5"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e10d9ab24f67002bb96a371e992cc437ab6ceb18","unresolved":true,"context_lines":[{"line_number":29,"context_line":"            ;;"},{"line_number":30,"context_line":"        train|promotion-testing-hash-train)"},{"line_number":31,"context_line":"            echo \"stein\""},{"line_number":32,"context_line":"            ;;"},{"line_number":33,"context_line":"        queens)"},{"line_number":34,"context_line":"            echo \"pike\""},{"line_number":35,"context_line":"            ;;"}],"source_content_type":"text/x-sh","patch_set":1,"id":"cc4c63b4_640ba79c","line":32,"range":{"start_line":32,"start_character":11,"end_line":32,"end_character":14},"in_reply_to":"c11f2e26_31502024","updated":"2021-04-06 07:55:37.000000000","message":"right... in fact for this reason I am going to update this review to just completely remove this script WDYT?\n\nI don\u0027t think it is being used anywhere any more (at least we shouldn\u0027t be since we now have the .j2 templates)\n\nI commented about that there https://review.opendev.org/c/openstack/tripleo-ci/+/782549/5/scripts/oooq_common_functions.sh#b34 (in the parent review before I posted this) and we discussed it just before you came to scrum yesterday.","commit_id":"1f817406f398ca639e927699fc6f33ff862625c5"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"117b6a237495e98ed8df22146c76ca19bfb45764","unresolved":true,"context_lines":[{"line_number":29,"context_line":"            ;;"},{"line_number":30,"context_line":"        train|promotion-testing-hash-train)"},{"line_number":31,"context_line":"            echo \"stein\""},{"line_number":32,"context_line":"            ;;"},{"line_number":33,"context_line":"        queens)"},{"line_number":34,"context_line":"            echo \"pike\""},{"line_number":35,"context_line":"            ;;"}],"source_content_type":"text/x-sh","patch_set":1,"id":"96fade2a_02905a02","line":32,"range":{"start_line":32,"start_character":11,"end_line":32,"end_character":14},"in_reply_to":"cc4c63b4_640ba79c","updated":"2021-04-06 08:20:30.000000000","message":"I\u0027m fine, but need to remove all other scripts too (which we generate from templates)","commit_id":"1f817406f398ca639e927699fc6f33ff862625c5"}]}