)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d2326ca42dcedd8f07160d59c62b631c8588f455","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Arx Cruz \u003carxcruz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-14 11:44:24 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tempest_test_excludelist to variabe list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a new variable on os_tempest to replace the"},{"line_number":10,"context_line":"tempest_test_blacklist that are being deprecated."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"36f8e103_dc6585dc","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":28},"updated":"2021-04-15 06:30:17.000000000","message":"did you mean tempest_test_includelist?","commit_id":"baa58f24703dd7bfd0740354f25157002c9ef0ae"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a7b7010d409099d1529625931ba0e093407971ed","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Arx Cruz \u003carxcruz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-15 11:37:33 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tempest_test_includelist to variabe list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a new variable on os_tempest to replace the"},{"line_number":10,"context_line":"tempest_test_whitelist that are being deprecated."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"10ac2f71_aa856c3f","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":39},"updated":"2021-04-16 07:00:15.000000000","message":"l","commit_id":"c959737dfb294920d0136d05d767543ed6b6e9c6"}],"roles/copy-quay/defaults/main.yml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"0a7df775801ff3a227119c275e0873fb037bade8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"go_packages:"},{"line_number":3,"context_line":"  - golang"},{"line_number":4,"context_line":"  - device-mapper-devel"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4fbbb173_219303b7","line":1,"updated":"2021-04-13 05:46:50.000000000","message":"I think it got mistakenly got pushed as the change is related to tempest","commit_id":"b0e0904b558de38dc29002f0a1e3d9facdf2044e"}],"roles/copy-quay/tasks/main.yml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"0a7df775801ff3a227119c275e0873fb037bade8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Install golang package and dependences"},{"line_number":3,"context_line":"  package:"},{"line_number":4,"context_line":"    name: \"{{ go_packages }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"89a12e14_2369962f","line":1,"updated":"2021-04-13 05:46:50.000000000","message":"I think it got mistakenly got pushed as the change is related to tempest","commit_id":"b0e0904b558de38dc29002f0a1e3d9facdf2044e"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"e5acfafe635c496bacfca42eaa319052850649c5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Install golang package and dependences"},{"line_number":3,"context_line":"  package:"},{"line_number":4,"context_line":"    name: \"{{ go_packages }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6d69d28c_85ae9b3b","line":1,"in_reply_to":"89a12e14_2369962f","updated":"2021-04-13 09:32:39.000000000","message":"Oops!","commit_id":"b0e0904b558de38dc29002f0a1e3d9facdf2044e"}],"roles/run-test/tasks/main.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"17c6d3511276c4c14cdaeb785fe6b0e525392444","unresolved":true,"context_lines":[{"line_number":31,"context_line":"          - \u0027tempest_test_image_path\u0027"},{"line_number":32,"context_line":"          - \u0027tempest_test_excludelist\u0027"},{"line_number":33,"context_line":"          - \u0027tempest_test_includelist\u0027"},{"line_number":34,"context_line":"          - \u0027tempest_test_whitelist\u0027"},{"line_number":35,"context_line":"          - \u0027tempest_use_skiplist\u0027"},{"line_number":36,"context_line":"          - \u0027tempest_whitelist\u0027"},{"line_number":37,"context_line":"          - \u0027tempest_workers\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"31b9d037_06bffe03","line":34,"updated":"2021-04-13 06:43:48.000000000","message":"we don\u0027t currently have tempest_test_blacklist in the allowed_overrides\nso why do we need to add tempest_test_excludelist here? \n\ni.e. if we aren\u0027t using tempest_test_blacklist in the featureset_overrides (looks like we aren\u0027t since it is missing here) let\u0027s not just add the exclude_list, until we actually need to?","commit_id":"b0e0904b558de38dc29002f0a1e3d9facdf2044e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9b7e2fc856882ab19de8406e4067731b56cd8485","unresolved":true,"context_lines":[{"line_number":31,"context_line":"          - \u0027tempest_test_image_path\u0027"},{"line_number":32,"context_line":"          - \u0027tempest_test_excludelist\u0027"},{"line_number":33,"context_line":"          - \u0027tempest_test_includelist\u0027"},{"line_number":34,"context_line":"          - \u0027tempest_test_whitelist\u0027"},{"line_number":35,"context_line":"          - \u0027tempest_use_skiplist\u0027"},{"line_number":36,"context_line":"          - \u0027tempest_whitelist\u0027"},{"line_number":37,"context_line":"          - \u0027tempest_workers\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7893eb3e_28625386","line":34,"in_reply_to":"1c532213_6dcf7a17","updated":"2021-04-14 06:32:11.000000000","message":"Sure, but let\u0027s add it to featureset_override if and when we need to.\n\nI didn\u0027t say let\u0027s not use \u0027tempest_test_excludelist\u0027 of course we can and will in the featuresets etc\n\nbut here is a special case it is about adding into the featureset_override. In general we are a bit careful about what we add here. SO unless there is a specific reason to add it, then let\u0027s not. As soon as such a reason arises, then we can add it no problem.\n\nWe have not had blacklist/excludelist here in the past, so lets not add it now \u0027just because\u0027.","commit_id":"b0e0904b558de38dc29002f0a1e3d9facdf2044e"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"e5acfafe635c496bacfca42eaa319052850649c5","unresolved":true,"context_lines":[{"line_number":31,"context_line":"          - \u0027tempest_test_image_path\u0027"},{"line_number":32,"context_line":"          - \u0027tempest_test_excludelist\u0027"},{"line_number":33,"context_line":"          - \u0027tempest_test_includelist\u0027"},{"line_number":34,"context_line":"          - \u0027tempest_test_whitelist\u0027"},{"line_number":35,"context_line":"          - \u0027tempest_use_skiplist\u0027"},{"line_number":36,"context_line":"          - \u0027tempest_whitelist\u0027"},{"line_number":37,"context_line":"          - \u0027tempest_workers\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1c532213_6dcf7a17","line":34,"in_reply_to":"31b9d037_06bffe03","updated":"2021-04-13 09:32:39.000000000","message":"Because it\u0027s available on os_tempest side, just to make sure we are in sync with them. Also I don\u0027t know the future if we need.","commit_id":"b0e0904b558de38dc29002f0a1e3d9facdf2044e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9b7e2fc856882ab19de8406e4067731b56cd8485","unresolved":true,"context_lines":[{"line_number":29,"context_line":"          - \u0027tempest_services\u0027"},{"line_number":30,"context_line":"          - \u0027tempest_tempest_conf_overrides\u0027"},{"line_number":31,"context_line":"          - \u0027tempest_test_image_path\u0027"},{"line_number":32,"context_line":"          - \u0027tempest_test_excludelist\u0027"},{"line_number":33,"context_line":"          - \u0027tempest_test_includelist\u0027"},{"line_number":34,"context_line":"          - \u0027tempest_test_whitelist\u0027"},{"line_number":35,"context_line":"          - \u0027tempest_use_skiplist\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"236c0cfa_7942ad64","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":37},"updated":"2021-04-14 06:32:11.000000000","message":"still think we shouldn\u0027t add it \u0027just because\u0027 ... if there isn\u0027t a need to add it then lets not add it here.\n\nWhen we need it we can add it?","commit_id":"5a8d404604d88393ca2ee2388cb456e16d10548d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"e5f9bf4cb8f323ee5f02d0a3e11ef817f29a61b3","unresolved":true,"context_lines":[{"line_number":29,"context_line":"          - \u0027tempest_services\u0027"},{"line_number":30,"context_line":"          - \u0027tempest_tempest_conf_overrides\u0027"},{"line_number":31,"context_line":"          - \u0027tempest_test_image_path\u0027"},{"line_number":32,"context_line":"          - \u0027tempest_test_excludelist\u0027"},{"line_number":33,"context_line":"          - \u0027tempest_test_includelist\u0027"},{"line_number":34,"context_line":"          - \u0027tempest_test_whitelist\u0027"},{"line_number":35,"context_line":"          - \u0027tempest_use_skiplist\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3ad4d012_bd316dcf","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":37},"in_reply_to":"236c0cfa_7942ad64","updated":"2021-04-14 09:45:58.000000000","message":"FINE! You win! :)","commit_id":"5a8d404604d88393ca2ee2388cb456e16d10548d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d2326ca42dcedd8f07160d59c62b631c8588f455","unresolved":true,"context_lines":[{"line_number":29,"context_line":"          - \u0027tempest_services\u0027"},{"line_number":30,"context_line":"          - \u0027tempest_tempest_conf_overrides\u0027"},{"line_number":31,"context_line":"          - \u0027tempest_test_image_path\u0027"},{"line_number":32,"context_line":"          - \u0027tempest_test_excludelist\u0027"},{"line_number":33,"context_line":"          - \u0027tempest_test_includelist\u0027"},{"line_number":34,"context_line":"          - \u0027tempest_test_whitelist\u0027"},{"line_number":35,"context_line":"          - \u0027tempest_use_skiplist\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ee3acffe_b77ce1c3","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":37},"in_reply_to":"3ad4d012_bd316dcf","updated":"2021-04-15 06:30:17.000000000","message":"thanks for the update \\o/ I will go out an celebrate my win tonight \n\"I\u0027d like to thank my parents ... \"\n\nso seriously our lives are already complicated enough we have a million repos and a million things going on all the time. How many times have we looked at some of our _own_ code and wondered \u0027why the hell did we do this\u0027 or \u0027is this thing even used any more\u0027 and typically we don\u0027t even know the answer to these questions.\n\nSo I want to avoid adding something if it is not necessary.","commit_id":"5a8d404604d88393ca2ee2388cb456e16d10548d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d2326ca42dcedd8f07160d59c62b631c8588f455","unresolved":true,"context_lines":[{"line_number":29,"context_line":"          - \u0027tempest_services\u0027"},{"line_number":30,"context_line":"          - \u0027tempest_tempest_conf_overrides\u0027"},{"line_number":31,"context_line":"          - \u0027tempest_test_image_path\u0027"},{"line_number":32,"context_line":"          - \u0027tempest_test_excludelist\u0027"},{"line_number":33,"context_line":"          - \u0027tempest_test_whitelist\u0027"},{"line_number":34,"context_line":"          - \u0027tempest_use_skiplist\u0027"},{"line_number":35,"context_line":"          - \u0027tempest_whitelist\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"880c667f_33f36754","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":37},"updated":"2021-04-15 06:30:17.000000000","message":"but this is the one I was complaining about? I think you wanted to add the tempest_test_includelist here?","commit_id":"baa58f24703dd7bfd0740354f25157002c9ef0ae"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a7b7010d409099d1529625931ba0e093407971ed","unresolved":true,"context_lines":[{"line_number":30,"context_line":"          - \u0027tempest_tempest_conf_overrides\u0027"},{"line_number":31,"context_line":"          - \u0027tempest_test_image_path\u0027"},{"line_number":32,"context_line":"          - \u0027tempest_test_includelist\u0027"},{"line_number":33,"context_line":"          - \u0027tempest_test_whitelist\u0027"},{"line_number":34,"context_line":"          - \u0027tempest_use_skiplist\u0027"},{"line_number":35,"context_line":"          - \u0027tempest_whitelist\u0027"},{"line_number":36,"context_line":"          - \u0027tempest_workers\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9b688e37_5f2979e5","line":33,"updated":"2021-04-16 07:00:15.000000000","message":"so i guess next step is to wire the includelist up everywhere we currently have whitelist and finally remove it from here.","commit_id":"c959737dfb294920d0136d05d767543ed6b6e9c6"}]}