)]}'
{"zuul.d/layout.yaml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"94daa661738079aef16be9932612049880c6dba8","unresolved":true,"context_lines":[{"line_number":13,"context_line":"      - tripleo-standalone-scenarios-pipeline"},{"line_number":14,"context_line":"      - tripleo-undercloud-jobs-pipeline"},{"line_number":15,"context_line":"      - tripleo-periodic"},{"line_number":16,"context_line":"      - tripleo-upgrades-master-pipeline"},{"line_number":17,"context_line":"    check:"},{"line_number":18,"context_line":"      jobs:"},{"line_number":19,"context_line":"        - openstack-tox-linters"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"af56ed59_be6f7927","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":40},"updated":"2021-07-05 13:26:37.000000000","message":"why do we need to run it on tripleo-ci repo? I doubt there is any code that affects upgrades here","commit_id":"8a853a515a55fbb0572f8c4aaa65f67f237413aa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6f2c6e530e9fc142fa55074ec31165ac9facc3a0","unresolved":true,"context_lines":[{"line_number":13,"context_line":"      - tripleo-standalone-scenarios-pipeline"},{"line_number":14,"context_line":"      - tripleo-undercloud-jobs-pipeline"},{"line_number":15,"context_line":"      - tripleo-periodic"},{"line_number":16,"context_line":"      - tripleo-upgrades-master-pipeline"},{"line_number":17,"context_line":"    check:"},{"line_number":18,"context_line":"      jobs:"},{"line_number":19,"context_line":"        - openstack-tox-linters"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"096e6f76_1e8e0776","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":40},"in_reply_to":"af56ed59_be6f7927","updated":"2021-07-06 11:30:53.000000000","message":"yeah fair point I think I will rethink this.\n\nmain reason it is there now is because we have the zuul layouts in tripleo-ci. In this change we are updating the tripleo-upgrades-master-pipeline template to make undercloud-upgrade voting. So without adding this template in the layout as above we could just merge this change without actually running the undercloud-upgrade (and it is still broken, latest on https://bugs.launchpad.net/tripleo/+bug/1934658 ) which would break the gate.\n\nI will leave it for now but remove before merge (once the upgrade job is green )","commit_id":"8a853a515a55fbb0572f8c4aaa65f67f237413aa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f47445b75022e2b5956f535673cc69544019f825","unresolved":true,"context_lines":[{"line_number":13,"context_line":"      - tripleo-standalone-scenarios-pipeline"},{"line_number":14,"context_line":"      - tripleo-undercloud-jobs-pipeline"},{"line_number":15,"context_line":"      - tripleo-periodic"},{"line_number":16,"context_line":"      - tripleo-upgrades-master-pipeline"},{"line_number":17,"context_line":"    check:"},{"line_number":18,"context_line":"      jobs:"},{"line_number":19,"context_line":"        - openstack-tox-linters"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"031fcd1a_7765f9b6","line":16,"range":{"start_line":16,"start_character":5,"end_line":16,"end_character":8},"updated":"2021-07-08 09:28:47.000000000","message":"leaving this here for now, so we can see the job running green before we merge. however we should remove before merging so setting worfklow -1 for that reason.","commit_id":"40b05ba0b959c975264099b22a4931130fad8789"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"47038a27e00fd3e855789af514c99e76afd54825","unresolved":true,"context_lines":[{"line_number":13,"context_line":"      - tripleo-standalone-scenarios-pipeline"},{"line_number":14,"context_line":"      - tripleo-undercloud-jobs-pipeline"},{"line_number":15,"context_line":"      - tripleo-periodic"},{"line_number":16,"context_line":"      - tripleo-upgrades-master-pipeline"},{"line_number":17,"context_line":"    check:"},{"line_number":18,"context_line":"      jobs:"},{"line_number":19,"context_line":"        - openstack-tox-linters"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5c99c6ed_50edc07d","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":2},"updated":"2021-07-13 09:40:08.000000000","message":"k going to remove this now so we can merge job is green in recent runs here","commit_id":"1fac2d6fce25728fb5a9e3d0e84b536d139145bc"}],"zuul.d/upgrades-jobs-templates.yaml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"b8c679fc728143dcd90daed89bbe6b9e71b460db","unresolved":true,"context_lines":[{"line_number":43,"context_line":"                - build"},{"line_number":44,"context_line":"            dependencies:"},{"line_number":45,"context_line":"              - tripleo-ci-centos-8-content-provider"},{"line_number":46,"context_line":"        - tripleo-ci-centos-8-undercloud-upgrade:"},{"line_number":47,"context_line":"            vars: *consumer_vars"},{"line_number":48,"context_line":"            irrelevant-files: \u0026undercloud_ignored"},{"line_number":49,"context_line":"              - ^.*\\.md$"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8e095803_930dd001","line":46,"updated":"2021-06-08 01:52:26.000000000","message":"word up","commit_id":"30a6058b416f6df9e3eb5fd2b84398fd461f8950"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"94daa661738079aef16be9932612049880c6dba8","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    name: tripleo-upgrades-wallaby-pipeline"},{"line_number":94,"context_line":"    check:"},{"line_number":95,"context_line":"      jobs:"},{"line_number":96,"context_line":"        - tripleo-ci-centos-8-content-provider"},{"line_number":97,"context_line":"        - tripleo-ci-centos-8-content-provider-victoria"},{"line_number":98,"context_line":"        - tripleo-ci-centos-8-scenario000-multinode-oooq-container-updates-wallaby:"},{"line_number":99,"context_line":"            irrelevant-files: *multinode_ignored"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"339e8854_adcd11af","line":96,"range":{"start_line":96,"start_character":38,"end_line":96,"end_character":46},"updated":"2021-07-05 13:26:37.000000000","message":"we should run -wallaby if this template runs on master (we upgrade here from victoria to wallaby, right?)\nin case it will run on wallaby and not on master, then we need below just \"..-oooq-container-updates\" not \"-oooq-container-updates-wallaby\"\nOr where is it supposed to run?","commit_id":"8a853a515a55fbb0572f8c4aaa65f67f237413aa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6f2c6e530e9fc142fa55074ec31165ac9facc3a0","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    name: tripleo-upgrades-wallaby-pipeline"},{"line_number":94,"context_line":"    check:"},{"line_number":95,"context_line":"      jobs:"},{"line_number":96,"context_line":"        - tripleo-ci-centos-8-content-provider"},{"line_number":97,"context_line":"        - tripleo-ci-centos-8-content-provider-victoria"},{"line_number":98,"context_line":"        - tripleo-ci-centos-8-scenario000-multinode-oooq-container-updates-wallaby:"},{"line_number":99,"context_line":"            irrelevant-files: *multinode_ignored"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1c303763_8fb15887","line":96,"range":{"start_line":96,"start_character":38,"end_line":96,"end_character":46},"in_reply_to":"339e8854_adcd11af","updated":"2021-07-06 11:30:53.000000000","message":"this content provider *is* wallaby so we have one for W and one for V, correct for the undercloud upgrade we go from victoria to wallaby.\n\nWe *could* make is content-provider-wallaby and content-provider-victoria in this template. But  then we would end up running one extra content provider (the situation we used to have).\n\nConsider this example zuul result https://review.opendev.org/c/openstack/tripleo-heat-templates/+/799552/1#message-9a28451afef125970ce3e3f05c3d1378d99affc1 \nIt is for stable/victoria. You can see we have content-provider and content-provider-ussuri. We don\u0027t have the explicit -victoria one there.\n\nThis is because the content-provider in that case is running for -victoria branch already for tripleo-heat-templates. So e.g. the scen1 standalone and all other jobs there are using the content-provider. \n\nIf we make this template declare explicitly -victoria and -wallaby it will work fine. But when we wire it up e.g. in tripleo-heat-templates, we would end up with 3 content providers:\n\ncontent-provider (from other templates, like scenario/standalone jobs)\ncontent-provider-wallaby, content-provider-victoria (from this template if we change it)\n\nwhere the content-provider and content-provider-wallaby will be building the same thing (when this is a wallaby branch).\n\nwdyt","commit_id":"8a853a515a55fbb0572f8c4aaa65f67f237413aa"}]}