)]}'
{"zuul.d/periodic.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e0b699e1800dbad7abda5ea70fd67e6e753e64eb","unresolved":true,"context_lines":[{"line_number":248,"context_line":"      extra_tags:"},{"line_number":249,"context_line":"        - undercloud-upgrade"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"- job:"},{"line_number":252,"context_line":"    name: tripleo-ci-centos-8-undercloud-upgrade-victoria"},{"line_number":253,"context_line":"    parent: tripleo-ci-base-singlenode-centos-8"},{"line_number":254,"context_line":"    branches: ^stable/victoria$"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0d57fe0b_365f777e","line":251,"updated":"2021-06-03 12:42:09.000000000","message":"you don\u0027t need to have the job definitions here they are already defined in the upgrades-jobs-templates.yaml please remove these","commit_id":"a78f44cda12fe3ccd3906cdadc295df4d8c1c03c"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"a6bcf1d78bfbaafc21b49d286257a1fddf85ea9f","unresolved":true,"context_lines":[{"line_number":80,"context_line":"        - tripleo-ci-centos-8-content-provider"},{"line_number":81,"context_line":"        - tripleo-ci-centos-8-content-provider-ussuri"},{"line_number":82,"context_line":"        - tripleo-ci-centos-8-standalone-upgrade-victoria:"},{"line_number":83,"context_line":"            vars: *consumer_vars"},{"line_number":84,"context_line":"            dependencies:"},{"line_number":85,"context_line":"              - tripleo-ci-centos-8-content-provider"},{"line_number":86,"context_line":"              - tripleo-ci-centos-8-content-provider-ussuri"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"109152f4_672131a8","line":83,"range":{"start_line":83,"start_character":18,"end_line":83,"end_character":19},"updated":"2021-06-04 09:49:40.000000000","message":"Where we define var - we need to use \"\u0026\" instead of \"*\"","commit_id":"7417dbbc8618ded01eb85b8717c81cf68bbc9aae"},{"author":{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},"change_message_id":"54a5b7201469e26c289e8e3bb56af3667032a8fe","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    name: tripleo-upgrades-victoria-pipeline"},{"line_number":78,"context_line":"    periodic:"},{"line_number":79,"context_line":"      jobs:"},{"line_number":80,"context_line":"        - tripleo-ci-centos-8-content-provider"},{"line_number":81,"context_line":"        - tripleo-ci-centos-8-content-provider-ussuri"},{"line_number":82,"context_line":"        - tripleo-ci-centos-8-standalone-upgrade-victoria:"},{"line_number":83,"context_line":"            vars: \u0026consumer_vars"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a981851b_1e95cc8c","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":46},"updated":"2021-06-04 10:04:57.000000000","message":"i think you will need to add         \nvars:\n  force_non_periodic: true\n\nfor all the jobs. refer #line number 27 from this file.","commit_id":"c58fcf7aba5f375fb177841458e7e9ad70cb93e6"},{"author":{"_account_id":31075,"name":"Pooja Jadhav","email":"pojadhav@redhat.com","username":"pojadhav"},"change_message_id":"2172c801260fa6071da344510e673f87c5593814","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    name: tripleo-upgrades-victoria-pipeline"},{"line_number":78,"context_line":"    periodic:"},{"line_number":79,"context_line":"      jobs:"},{"line_number":80,"context_line":"        - tripleo-ci-centos-8-content-provider"},{"line_number":81,"context_line":"        - tripleo-ci-centos-8-content-provider-ussuri"},{"line_number":82,"context_line":"        - tripleo-ci-centos-8-standalone-upgrade-victoria:"},{"line_number":83,"context_line":"            vars: \u0026consumer_vars"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c4f9fb38_8c612eca","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":46},"in_reply_to":"a981851b_1e95cc8c","updated":"2021-06-04 10:21:26.000000000","message":"Done","commit_id":"c58fcf7aba5f375fb177841458e7e9ad70cb93e6"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"7a7807530bf0737f64368811bf8d0cee018cd5ce","unresolved":true,"context_lines":[{"line_number":80,"context_line":"        - tripleo-ci-centos-8-content-provider"},{"line_number":81,"context_line":"        - tripleo-ci-centos-8-content-provider-ussuri"},{"line_number":82,"context_line":"        - tripleo-ci-centos-8-standalone-upgrade-victoria:"},{"line_number":83,"context_line":"            vars: \u0026consumer_vars"},{"line_number":84,"context_line":"            dependencies:"},{"line_number":85,"context_line":"              - tripleo-ci-centos-8-content-provider"},{"line_number":86,"context_line":"              - tripleo-ci-centos-8-content-provider-ussuri"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d92f0ef2_3641b94b","line":83,"range":{"start_line":83,"start_character":12,"end_line":83,"end_character":32},"updated":"2021-06-04 10:09:15.000000000","message":"We use alias in yaml to reduce the duplication.\n\nto define alias - \u0026\nto use alias - *\n\nThis is the first usage of alias in the file, and now you have correctly defined the alias.. Thank you for updating this.\n\nWe are missing value under this alias.\n\n\nI think you are using example from:-\n\nhttps://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/upgrades-jobs-templates.yaml#L56\n\n\nif you look in same file:-\n\nvar is defined here https://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/upgrades-jobs-templates.yaml#L38\n\n~~~\n            vars: \u0026consumer_vars\n              consumer_job: true\n              build_container_images: false\n              remove_tags:\n                - build\n~~~\n\nSo, you would need something similiar here.","commit_id":"c58fcf7aba5f375fb177841458e7e9ad70cb93e6"},{"author":{"_account_id":31075,"name":"Pooja Jadhav","email":"pojadhav@redhat.com","username":"pojadhav"},"change_message_id":"2172c801260fa6071da344510e673f87c5593814","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        - tripleo-ci-centos-8-content-provider"},{"line_number":81,"context_line":"        - tripleo-ci-centos-8-content-provider-ussuri"},{"line_number":82,"context_line":"        - tripleo-ci-centos-8-standalone-upgrade-victoria:"},{"line_number":83,"context_line":"            vars: \u0026consumer_vars"},{"line_number":84,"context_line":"            dependencies:"},{"line_number":85,"context_line":"              - tripleo-ci-centos-8-content-provider"},{"line_number":86,"context_line":"              - tripleo-ci-centos-8-content-provider-ussuri"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dd4f9fd2_8fd9f5f3","line":83,"range":{"start_line":83,"start_character":12,"end_line":83,"end_character":32},"in_reply_to":"d92f0ef2_3641b94b","updated":"2021-06-04 10:21:26.000000000","message":"Done","commit_id":"c58fcf7aba5f375fb177841458e7e9ad70cb93e6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"196d795356c2be550bf3045ee17937360ec538f1","unresolved":true,"context_lines":[{"line_number":84,"context_line":"            vars:"},{"line_number":85,"context_line":"              force_non_periodic: true"},{"line_number":86,"context_line":"        - tripleo-ci-centos-8-standalone-upgrade-victoria:"},{"line_number":87,"context_line":"            vars: \u0026consumer_vars"},{"line_number":88,"context_line":"              consumer_job: true"},{"line_number":89,"context_line":"              build_container_images: false"},{"line_number":90,"context_line":"              remove_tags:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"01c3abc0_649826d0","line":87,"range":{"start_line":87,"start_character":12,"end_line":87,"end_character":16},"updated":"2021-06-09 07:12:33.000000000","message":"i think it also needs the force_non_periodic here","commit_id":"7f8b2d514fa71d91ed2e05a272250dc1ebb69b92"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"49a9c60f373eb2b5f929a1d3574ea475315d53f7","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            vars: *multi_consumer_vars_periodic"},{"line_number":73,"context_line":"            dependencies:"},{"line_number":74,"context_line":"              - tripleo-ci-centos-7-content-provider-queens"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- project-template:"},{"line_number":77,"context_line":"    name: tripleo-upgrades-victoria-pipeline"},{"line_number":78,"context_line":"    periodic:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9d832d94_2ffdf970","line":75,"updated":"2021-06-10 06:25:18.000000000","message":"Looks good to me when comparing with\n\nhttps://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/upgrades-jobs-templates.yaml#L55-L158\n\nJust wondering why we are just adding upgrade jobs in periodic and not the update jobs?\n\n- tripleo-ci-centos-8-scenario000-multinode-oooq-container-updates-victoria\n- tripleo-ci-centos-8-scenario000-multinode-oooq-container-updates-ussuri","commit_id":"9f83c1d9fcff54a7332e27f2cefff82244da6588"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0839e34a6e0d8f0d4932eb86801b901e84e3b14f","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            vars: *multi_consumer_vars_periodic"},{"line_number":73,"context_line":"            dependencies:"},{"line_number":74,"context_line":"              - tripleo-ci-centos-7-content-provider-queens"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- project-template:"},{"line_number":77,"context_line":"    name: tripleo-upgrades-victoria-pipeline"},{"line_number":78,"context_line":"    periodic:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"c104a5a3_4258431b","line":75,"in_reply_to":"9d832d94_2ffdf970","updated":"2021-06-10 12:52:29.000000000","message":"+1 yeah lets add those too didn\u0027t notice that","commit_id":"9f83c1d9fcff54a7332e27f2cefff82244da6588"}]}