)]}'
{"roles/oooci-build-images/tasks/main.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5ac4398ba8617e101c3caca1bb0dcf2e429bdf82","unresolved":true,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    - name: check if overcloud-hardened-uefi-full images were built"},{"line_number":80,"context_line":"      stat:"},{"line_number":81,"context_line":"        path: \"{{ workspace }}/overcloud-hardened-uefi-full.qcow2\""},{"line_number":82,"context_line":"      register: overcloud_hardened_uefi_stat_result"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    - name: check if ipa images were built"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b6678782_b9859d5e","line":81,"updated":"2021-06-22 06:32:11.000000000","message":"since we are now adding something here which is specific to the uefi build I think we also need to make the relevant jobs run on these changes\n\ni.e. put \"roles/oooci-build-images\" like in https://opendev.org/openstack/tripleo-ci/src/commit/a59d2547c183c3ece538ab4376942efa851aa45b/zuul.d/build-image.yaml#L12\n\nat https://opendev.org/openstack/tripleo-ci/src/commit/a59d2547c183c3ece538ab4376942efa851aa45b/zuul.d/build-image.yaml#L55-L60","commit_id":"45c9ac3f1b613749bf1c733b0f7d5be16bf77583"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"dba7b514860cf58b765406f46a74bb1fb750e778","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    - name: check if overcloud-hardened-uefi-full images were built"},{"line_number":80,"context_line":"      stat:"},{"line_number":81,"context_line":"        path: \"{{ workspace }}/overcloud-hardened-uefi-full.qcow2\""},{"line_number":82,"context_line":"      register: overcloud_hardened_uefi_stat_result"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    - name: check if ipa images were built"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d0c10a76_43119157","line":81,"in_reply_to":"b6678782_b9859d5e","updated":"2021-06-22 23:31:11.000000000","message":"Good idea, done","commit_id":"45c9ac3f1b613749bf1c733b0f7d5be16bf77583"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1700111a88e7f48b135f7d6754e742221a08d117","unresolved":true,"context_lines":[{"line_number":126,"context_line":"    - name: Create md5sums for overcloud-hardened-uefi-full.qcow2"},{"line_number":127,"context_line":"      shell:"},{"line_number":128,"context_line":"        cmd: |"},{"line_number":129,"context_line":"          md5sum overcloud-hardened-uefi-full.qcow2 \u003e overcloud-hardened-uefi-full.qcow2.md5"},{"line_number":130,"context_line":"      args:"},{"line_number":131,"context_line":"        chdir: \"{{ ansible_user_dir }}\""},{"line_number":132,"context_line":"      when: overcloud_hardened_uefi_stat_result.stat.exists|bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4907a4f6_fd4e209b","line":129,"updated":"2021-06-23 04:47:45.000000000","message":"failing with overcloud-hardened-uefi-full.qcow2\nneeds {{ workspace }}/overcloud-hardened-uefi-full.qcow2 or may be better move to ansible_user_dir like other tar files to be consistent with location,","commit_id":"8d88c4ff090fadc9240bb6764073be5d6fc8eb98"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5a56c999821c4d31055de0f5c6e01a49dc529834","unresolved":true,"context_lines":[{"line_number":126,"context_line":"    - name: Create md5sums for overcloud-hardened-uefi-full.qcow2"},{"line_number":127,"context_line":"      shell:"},{"line_number":128,"context_line":"        cmd: |"},{"line_number":129,"context_line":"          md5sum overcloud-hardened-uefi-full.qcow2 \u003e overcloud-hardened-uefi-full.qcow2.md5"},{"line_number":130,"context_line":"      args:"},{"line_number":131,"context_line":"        chdir: \"{{ ansible_user_dir }}\""},{"line_number":132,"context_line":"      when: overcloud_hardened_uefi_stat_result.stat.exists|bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d2f2e181_181f1a0b","line":129,"in_reply_to":"4907a4f6_fd4e209b","updated":"2021-06-23 05:33:20.000000000","message":"It is moving to ansible_user_dir, see line #131. I wonder how is this different to the other 2 md5sum tasks on #100 and #119?","commit_id":"8d88c4ff090fadc9240bb6764073be5d6fc8eb98"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"a4d95ecda356342847ce90f90024b7804651961c","unresolved":true,"context_lines":[{"line_number":126,"context_line":"    - name: Create md5sums for overcloud-hardened-uefi-full.qcow2"},{"line_number":127,"context_line":"      shell:"},{"line_number":128,"context_line":"        cmd: |"},{"line_number":129,"context_line":"          md5sum overcloud-hardened-uefi-full.qcow2 \u003e overcloud-hardened-uefi-full.qcow2.md5"},{"line_number":130,"context_line":"      args:"},{"line_number":131,"context_line":"        chdir: \"{{ ansible_user_dir }}\""},{"line_number":132,"context_line":"      when: overcloud_hardened_uefi_stat_result.stat.exists|bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a5881aee_8313a74b","line":129,"in_reply_to":"d2f2e181_181f1a0b","updated":"2021-06-23 05:36:54.000000000","message":"Oh, tar creates the tar file in the new location. I\u0027ll create a block and add a move operation","commit_id":"8d88c4ff090fadc9240bb6764073be5d6fc8eb98"}],"zuul.d/build-image.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4ed4356d385af9b8ebda129658c2fcafef924108","unresolved":true,"context_lines":[{"line_number":193,"context_line":"- job:"},{"line_number":194,"context_line":"    name: tripleo-buildimage-overcloud-hardened-uefi-full-centos-8"},{"line_number":195,"context_line":"    parent: tripleo-build-images-base-centos-8"},{"line_number":196,"context_line":"    branches: master"},{"line_number":197,"context_line":"    vars:"},{"line_number":198,"context_line":"      tripleo_image_type: overcloud-hardened-uefi-full"},{"line_number":199,"context_line":"    irrelevant-files:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff40f177_296266c1","line":196,"range":{"start_line":196,"start_character":14,"end_line":196,"end_character":20},"updated":"2021-06-24 05:51:31.000000000","message":"ack that should stop it running on stable/train \ndo we need this to be more like \n\nbranches: ^(master|stable/wallaby).*\n\n\nso we get this running on e.g. tripleo-common stable/wallaby?","commit_id":"6f0aa238a831941577eba60e2d2f6714c099503a"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5b69bac036db1b3413f2bcdd8692d27050691261","unresolved":true,"context_lines":[{"line_number":193,"context_line":"- job:"},{"line_number":194,"context_line":"    name: tripleo-buildimage-overcloud-hardened-uefi-full-centos-8"},{"line_number":195,"context_line":"    parent: tripleo-build-images-base-centos-8"},{"line_number":196,"context_line":"    branches: master"},{"line_number":197,"context_line":"    vars:"},{"line_number":198,"context_line":"      tripleo_image_type: overcloud-hardened-uefi-full"},{"line_number":199,"context_line":"    irrelevant-files:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7ab4668f_e9499c30","line":196,"range":{"start_line":196,"start_character":14,"end_line":196,"end_character":20},"in_reply_to":"68f30a07_0a18bf8a","updated":"2021-06-28 21:38:29.000000000","message":"OK thanks for the explanation, that makes sense","commit_id":"6f0aa238a831941577eba60e2d2f6714c099503a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2dbc0ac40db87ec696076cb69a9827e3416f5ecb","unresolved":true,"context_lines":[{"line_number":193,"context_line":"- job:"},{"line_number":194,"context_line":"    name: tripleo-buildimage-overcloud-hardened-uefi-full-centos-8"},{"line_number":195,"context_line":"    parent: tripleo-build-images-base-centos-8"},{"line_number":196,"context_line":"    branches: master"},{"line_number":197,"context_line":"    vars:"},{"line_number":198,"context_line":"      tripleo_image_type: overcloud-hardened-uefi-full"},{"line_number":199,"context_line":"    irrelevant-files:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"68f30a07_0a18bf8a","line":196,"range":{"start_line":196,"start_character":14,"end_line":196,"end_character":20},"in_reply_to":"b54bc9db_828a1111","updated":"2021-06-25 08:48:36.000000000","message":"ack yes we still need it here\n\nthe one on line 304 is specifically for the \u0027ci repos\u0027 which are branchless i.e. always master, tripleo-ci tripleo-quickstart and tripleo-quickstart extras. This is why that job definition does not specify \u0027branches: wallaby\u0027 because if we did add that there, it would never run for our branchless (always master branch) repos. You are wiring it up into the tripleo-ci-buildimage-jobs template there [1] and as you can see, that template is only specified for tripleo-ci [2].\n\nThe one here however tripleo-buildimage-overcloud-hardened-uefi-full-centos-8 is wired up into the tripleo-buildimage-jobs template [3] and that is the one which we are wiring up across our \u0027normal\u0027 branchful tripleo repos [4]. \n\nSo if you want this tripleo-buildimage-overcloud-hardened-uefi-full-centos-8 to run on say tripleo-common stable/wallaby patches, then we need to add stable/wallaby into the branches: match here. Otherwise it will only be running for master. \n\n\n\n[1] https://opendev.org/openstack/tripleo-ci/src/commit/7594837480843b153ed105759c8bcff4f8d15b2d/zuul.d/build-image.yaml#L61\n[2] https://codesearch.opendev.org/?q\u003dtripleo-ci-buildimage-jobs\u0026i\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\n[3] https://opendev.org/openstack/tripleo-ci/src/commit/7594837480843b153ed105759c8bcff4f8d15b2d/zuul.d/build-image.yaml#L120\n[4] https://codesearch.opendev.org/?q\u003dtripleo-buildimage-jobs\u0026i\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"6f0aa238a831941577eba60e2d2f6714c099503a"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"3bc35207f33158e6df616f2120549c6b88adf29e","unresolved":true,"context_lines":[{"line_number":193,"context_line":"- job:"},{"line_number":194,"context_line":"    name: tripleo-buildimage-overcloud-hardened-uefi-full-centos-8"},{"line_number":195,"context_line":"    parent: tripleo-build-images-base-centos-8"},{"line_number":196,"context_line":"    branches: master"},{"line_number":197,"context_line":"    vars:"},{"line_number":198,"context_line":"      tripleo_image_type: overcloud-hardened-uefi-full"},{"line_number":199,"context_line":"    irrelevant-files:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b54bc9db_828a1111","line":196,"range":{"start_line":196,"start_character":14,"end_line":196,"end_character":20},"in_reply_to":"ff40f177_296266c1","updated":"2021-06-24 21:00:51.000000000","message":"Marios can you please check tripleo-buildimage-overcloud-hardened-uefi-full-centos-8-wallaby on line #304 that it will run on wallaby as expected","commit_id":"6f0aa238a831941577eba60e2d2f6714c099503a"}]}