)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f6aa6ca8b3550dbb8c41074927c1821baf5415ff","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-09-02 19:38:30 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added pre from centos 9 container builds"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic3923fd02875b02adbc0fdf46dace180685e76ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":35,"id":"0426f7c5_1653f453","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":40},"updated":"2021-09-03 06:39:08.000000000","message":"this does much more than that \n\nplease consider adding a sentence about what \u0026 why\n\nAdds centos9 support for container builds + adds nodepool pre for coming OS major version bump.","commit_id":"a01748ccb8ae43d62e06657f95991be7eb95512d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"da2a5718e880f302590b2ba17cb3cf7823bec3b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"3599f2a4_0dacef91","updated":"2021-10-11 07:41:53.000000000","message":"It is ready to merge!","commit_id":"63996a6292e0bbd69cffce7611d6200b4de1037d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7599d8eb681d1e2fea39889945412fc459484167","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"cd6e473a_4e36f1f1","updated":"2021-10-11 07:20:48.000000000","message":"for inline comment about minimal changes please check ","commit_id":"63996a6292e0bbd69cffce7611d6200b4de1037d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9c91cef630aae7be322b122ad8ed66e829a9bd4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"ff00c1ac_b3a10c40","updated":"2021-10-11 07:20:35.000000000","message":"i think this is close to merge?\n\ni rebased the image build onto this so i could re-use the repo setup from here https://review.opendev.org/c/openstack/tripleo-ci/+/808177/ \n\ni get a green run on the latest at https://review.rdoproject.org/r/c/testproject/+/35465/9#message-53e000a1082a91ae8fb0817712224c4ab8fb2c96","commit_id":"63996a6292e0bbd69cffce7611d6200b4de1037d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5adf5b125ada00d7de8256d988431786f0cd4ad3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"53d912df_ff3f5a5e","updated":"2021-10-11 12:26:17.000000000","message":"LGTM, thanks","commit_id":"23b06386413550a1ede260699b4dbd4fd44d008f"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"4c3ecbc120a54e882efd9442a9c1366d38f13f37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"a4d990b0_0ecd70b3","updated":"2021-10-12 12:12:57.000000000","message":"Looks good","commit_id":"23b06386413550a1ede260699b4dbd4fd44d008f"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f55ed576966f104c7420564051d7b64ab341d55e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"09e6fdf0_58bd12fd","updated":"2021-10-25 12:37:59.000000000","message":"Thanks Sandeep","commit_id":"23b06386413550a1ede260699b4dbd4fd44d008f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"90f24daa1b40368b96460e492c71e332d91fa393","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"95f9939a_fb4f06b4","updated":"2021-10-11 09:39:06.000000000","message":"thanks for update lgtm maybe we can hit merge during scrum today ","commit_id":"23b06386413550a1ede260699b4dbd4fd44d008f"}],"playbooks/tripleo-buildcontainers/pre.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"849c22a7cd75910be80326ba008b30568c74130d","unresolved":true,"context_lines":[{"line_number":20,"context_line":"        - ansible_pkg_mgr \u003d\u003d \"yum\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    - name: disable/enable container tools"},{"line_number":23,"context_line":"      become: true"},{"line_number":24,"context_line":"      shell: |"},{"line_number":25,"context_line":"         sudo dnf module disable container-tools:rhel8 -y;"},{"line_number":26,"context_line":"         sudo dnf module enable container-tools:3.0 -y;"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"b1575a58_677715e7","line":23,"updated":"2021-08-31 09:21:24.000000000","message":"not sure we need the \"sudo\" since we have \"become: true\" ?","commit_id":"9a799d17c66a8a016f89ab1f989707bf88b9eda0"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5dc4af3601a0339f049ee139087c969df22e37f2","unresolved":true,"context_lines":[{"line_number":20,"context_line":"        - ansible_pkg_mgr \u003d\u003d \"yum\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    - name: disable/enable container tools"},{"line_number":23,"context_line":"      become: true"},{"line_number":24,"context_line":"      shell: |"},{"line_number":25,"context_line":"         sudo dnf module disable container-tools:rhel8 -y;"},{"line_number":26,"context_line":"         sudo dnf module enable container-tools:3.0 -y;"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"64c33376_54c517f7","line":23,"in_reply_to":"b1575a58_677715e7","updated":"2021-08-31 12:29:34.000000000","message":"+1, not needed","commit_id":"9a799d17c66a8a016f89ab1f989707bf88b9eda0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f6aa6ca8b3550dbb8c41074927c1821baf5415ff","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      command: setenforce 0"},{"line_number":33,"context_line":"      changed_when: true"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    - name: Container Build for 8 specific distros"},{"line_number":36,"context_line":"      when: ansible_distribution_major_version|int \u003c 9"},{"line_number":37,"context_line":"      block:"},{"line_number":38,"context_line":"        - name: Include tripleo-repos"},{"line_number":39,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"96848217_46ef5fd8","line":36,"range":{"start_line":35,"start_character":32,"end_line":36,"end_character":53},"updated":"2021-09-03 06:39:08.000000000","message":"if you actually mean \u0027only for 8\u0027 then make the conditional explicit \n\nyou can also use \"is version(\u00278\u0027, \u0027\u003d\u003d\u0027)  rather than \u003c \u003d https://docs.ansible.com/ansible/latest/user_guide/playbooks_tests.html#comparing-versions","commit_id":"a01748ccb8ae43d62e06657f95991be7eb95512d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f6aa6ca8b3550dbb8c41074927c1821baf5415ff","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            name: build-containers"},{"line_number":54,"context_line":"            tasks_from: pre"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    - name: Container Build for 9 specific distros"},{"line_number":57,"context_line":"      when: ansible_distribution_major_version|int \u003e\u003d 9"},{"line_number":58,"context_line":"      include: pre9.yaml"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"8d32c359_8f19212d","line":57,"range":{"start_line":56,"start_character":31,"end_line":57,"end_character":53},"updated":"2021-09-03 06:39:08.000000000","message":"same, since this is specifically the pre9.yaml we include lets make the check explicit for 9?","commit_id":"a01748ccb8ae43d62e06657f95991be7eb95512d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"abd05d22d27f93ae6b5c43cd8d64aa53b1bec299","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    - name: Container Build for 8 specific distros"},{"line_number":32,"context_line":"      when:"},{"line_number":33,"context_line":"        - ansible_distribution_major_version is version(9, \u0027\u003c\u0027)"},{"line_number":34,"context_line":"        - ansible_distribution_major_version is version(8, \u0027\u003e\u003d\u0027)"},{"line_number":35,"context_line":"      block:"},{"line_number":36,"context_line":"        - name: Include tripleo-repos"},{"line_number":37,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"62fccff8_429e0932","line":34,"range":{"start_line":33,"start_character":56,"end_line":34,"end_character":63},"updated":"2021-09-06 07:13:46.000000000","message":"unless there is some reason i\u0027m missing please make this \nis version(\u00278\u0027, \u0027\u003d\u003d\u0027)\n\nhttps://docs.ansible.com/ansible/latest/user_guide/playbooks_tests.html#comparing-versions\n(can even use \u0027eq\u0027 if you prefer ;))","commit_id":"10fd0a5ab77d1ecf9f2341c5a9c564f9f396724c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9c91cef630aae7be322b122ad8ed66e829a9bd4c","unresolved":true,"context_lines":[{"line_number":20,"context_line":"        - ansible_pkg_mgr \u003d\u003d \"yum\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    - name: Container Build for 8 specific distros"},{"line_number":23,"context_line":"      when: ansible_distribution_major_version is version(8, \u0027\u003c\u003d\u0027)"},{"line_number":24,"context_line":"      block:"},{"line_number":25,"context_line":"        # TODO: Move this setting to tripleo-repos yum module"},{"line_number":26,"context_line":"        - name: Enable supported container tools version"},{"line_number":27,"context_line":"          become: true"},{"line_number":28,"context_line":"          shell: |"},{"line_number":29,"context_line":"             {{ ansible_pkg_mgr }} module disable container-tools:rhel8 -y;"},{"line_number":30,"context_line":"             {{ ansible_pkg_mgr }} module enable container-tools:3.0 -y;"},{"line_number":31,"context_line":"             {{ ansible_pkg_mgr }} clean metadata"},{"line_number":32,"context_line":"          when: ansible_distribution_major_version is version(8, \u0027\u003d\u003d\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        - name: Include tripleo-repos"},{"line_number":35,"context_line":"          include_role:"},{"line_number":36,"context_line":"            name: tripleo-repos"},{"line_number":37,"context_line":"          vars:"},{"line_number":38,"context_line":"            override_repos: \"{{ buildcontainers_override_repos | default(\u0027\u0027) }}\""},{"line_number":39,"context_line":"            tripleo_repos_repository: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        - name: Include bindep role"},{"line_number":42,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"68b2fff8_0b7d00ba","line":39,"range":{"start_line":23,"start_character":0,"end_line":39,"end_character":125},"updated":"2021-10-11 07:20:35.000000000","message":"lets do this the other way around like it was? i.e. tripleo-repos first then the container tools. i think it makes more sense to setup the repos before setting modules? but generally lets not change something unless there is a reason to this stuff applies to the exisitng 8 build not 9 so lets keep changes minimal","commit_id":"63996a6292e0bbd69cffce7611d6200b4de1037d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"da2a5718e880f302590b2ba17cb3cf7823bec3b8","unresolved":true,"context_lines":[{"line_number":20,"context_line":"        - ansible_pkg_mgr \u003d\u003d \"yum\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    - name: Container Build for 8 specific distros"},{"line_number":23,"context_line":"      when: ansible_distribution_major_version is version(8, \u0027\u003c\u003d\u0027)"},{"line_number":24,"context_line":"      block:"},{"line_number":25,"context_line":"        # TODO: Move this setting to tripleo-repos yum module"},{"line_number":26,"context_line":"        - name: Enable supported container tools version"},{"line_number":27,"context_line":"          become: true"},{"line_number":28,"context_line":"          shell: |"},{"line_number":29,"context_line":"             {{ ansible_pkg_mgr }} module disable container-tools:rhel8 -y;"},{"line_number":30,"context_line":"             {{ ansible_pkg_mgr }} module enable container-tools:3.0 -y;"},{"line_number":31,"context_line":"             {{ ansible_pkg_mgr }} clean metadata"},{"line_number":32,"context_line":"          when: ansible_distribution_major_version is version(8, \u0027\u003d\u003d\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        - name: Include tripleo-repos"},{"line_number":35,"context_line":"          include_role:"},{"line_number":36,"context_line":"            name: tripleo-repos"},{"line_number":37,"context_line":"          vars:"},{"line_number":38,"context_line":"            override_repos: \"{{ buildcontainers_override_repos | default(\u0027\u0027) }}\""},{"line_number":39,"context_line":"            tripleo_repos_repository: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        - name: Include bindep role"},{"line_number":42,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"4594cb54_1b6603b1","line":39,"range":{"start_line":23,"start_character":0,"end_line":39,"end_character":125},"in_reply_to":"68b2fff8_0b7d00ba","updated":"2021-10-11 07:41:53.000000000","message":"Aye sir, Make sense.","commit_id":"63996a6292e0bbd69cffce7611d6200b4de1037d"}],"playbooks/tripleo-buildcontainers/pre9.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2f07375cc1219f86ca1af0a428a1f8d445c4c07c","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    - https://trunk.rdoproject.org/centos9-master/delorean-deps.repo"},{"line_number":11,"context_line":"  changed_when: true"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Add missing /etc/pki/rpm-gpg dir"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  file:"},{"line_number":16,"context_line":"    path: /etc/pki/rpm-gpg"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"9a13a0ac_b223d0c4","line":13,"range":{"start_line":13,"start_character":21,"end_line":13,"end_character":34},"updated":"2021-09-29 07:24:38.000000000","message":"any more context? this just seems like one of those things we\u0027ll be carrying forever without knowing why or if it was fixed.","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"57e28025fe7c1d59942e28ab958382f533c9e63f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    - https://trunk.rdoproject.org/centos9-master/delorean-deps.repo"},{"line_number":11,"context_line":"  changed_when: true"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Add missing /etc/pki/rpm-gpg dir"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  file:"},{"line_number":16,"context_line":"    path: /etc/pki/rpm-gpg"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"d4ef7903_5dc384a1","line":13,"range":{"start_line":13,"start_character":21,"end_line":13,"end_character":34},"in_reply_to":"9a13a0ac_b223d0c4","updated":"2021-09-30 21:46:11.000000000","message":"I added this when we fist started - not sure of it\u0027s still needed. \nThe c9 image was missing that and the code was expecting the dir to be there","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"43f63ca6c93e147ed64b3f314d33ad1e9e1279c1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    - https://trunk.rdoproject.org/centos9-master/delorean-deps.repo"},{"line_number":11,"context_line":"  changed_when: true"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Add missing /etc/pki/rpm-gpg dir"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  file:"},{"line_number":16,"context_line":"    path: /etc/pki/rpm-gpg"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"668dba9c_868b6b71","line":13,"range":{"start_line":13,"start_character":21,"end_line":13,"end_character":34},"in_reply_to":"d4ef7903_5dc384a1","updated":"2021-10-08 08:54:49.000000000","message":"Done","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"}],"roles/build-containers/tasks/post.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2f07375cc1219f86ca1af0a428a1f8d445c4c07c","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    rsync -var --no-links /etc/ansible/ {{ workspace }}/etc/ansible/ || true"},{"line_number":27,"context_line":"    rsync -var --no-links /etc/docker/ {{ workspace }}/etc/docker/ || true"},{"line_number":28,"context_line":"    rsync -var --no-links /etc/httpd/ {{ workspace }}/etc/httpd/ || true"},{"line_number":29,"context_line":"    rsync -var --no-links /etc/cni/ {{ workspace }}/etc/cni/ || true"},{"line_number":30,"context_line":"    rsync -var --no-links /var/www/html/ {{ workspace }}/logs/httpd_data/ || true"},{"line_number":31,"context_line":"    rsync -var --no-links /etc/containers/ {{ workspace }}/etc/containers/ || true"},{"line_number":32,"context_line":"    rsync -var --no-links --include \u0027yum.repos.d/***\u0027 --include \u0027yum.conf\u0027 --include \u0027dnf/***\u0027 --exclude\u003d\u0027*\u0027 /etc/ {{ workspace }}/etc/ || true"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"9c308126_920b2548","line":29,"range":{"start_line":29,"start_character":31,"end_line":29,"end_character":34},"updated":"2021-09-29 07:24:38.000000000","message":"context on this one?","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"43f63ca6c93e147ed64b3f314d33ad1e9e1279c1","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    rsync -var --no-links /etc/ansible/ {{ workspace }}/etc/ansible/ || true"},{"line_number":27,"context_line":"    rsync -var --no-links /etc/docker/ {{ workspace }}/etc/docker/ || true"},{"line_number":28,"context_line":"    rsync -var --no-links /etc/httpd/ {{ workspace }}/etc/httpd/ || true"},{"line_number":29,"context_line":"    rsync -var --no-links /etc/cni/ {{ workspace }}/etc/cni/ || true"},{"line_number":30,"context_line":"    rsync -var --no-links /var/www/html/ {{ workspace }}/logs/httpd_data/ || true"},{"line_number":31,"context_line":"    rsync -var --no-links /etc/containers/ {{ workspace }}/etc/containers/ || true"},{"line_number":32,"context_line":"    rsync -var --no-links --include \u0027yum.repos.d/***\u0027 --include \u0027yum.conf\u0027 --include \u0027dnf/***\u0027 --exclude\u003d\u0027*\u0027 /etc/ {{ workspace }}/etc/ || true"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"6e87ac8c_de49dc9c","line":29,"range":{"start_line":29,"start_character":31,"end_line":29,"end_character":34},"in_reply_to":"9c308126_920b2548","updated":"2021-10-08 08:54:49.000000000","message":"I have added it for debugging.","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"}],"roles/build-containers/tasks/pre.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"849c22a7cd75910be80326ba008b30568c74130d","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        option: registries"},{"line_number":46,"context_line":"        value:"},{"line_number":47,"context_line":"          - \"localhost:{{ push_registry_port | default(\u00275001\u0027) }}\""},{"line_number":48,"context_line":"      when: ansible_distribution_major_version|int \u003d\u003d 8"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    - name: Configure unqualified-search-registries"},{"line_number":51,"context_line":"      lineinfile:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"ca2f4d6f_e61a765e","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":46},"updated":"2021-08-31 09:21:24.000000000","message":"shouldn\u0027t we use the ansible_facts[\u0027distribution_major_version\u0027] instead?","commit_id":"9a799d17c66a8a016f89ab1f989707bf88b9eda0"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5dc4af3601a0339f049ee139087c969df22e37f2","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        option: registries"},{"line_number":46,"context_line":"        value:"},{"line_number":47,"context_line":"          - \"localhost:{{ push_registry_port | default(\u00275001\u0027) }}\""},{"line_number":48,"context_line":"      when: ansible_distribution_major_version|int \u003d\u003d 8"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    - name: Configure unqualified-search-registries"},{"line_number":51,"context_line":"      lineinfile:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"1072d4b1_f7cf24cf","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":46},"in_reply_to":"ca2f4d6f_e61a765e","updated":"2021-08-31 12:29:34.000000000","message":"@Cedric, we use ansible_distribution_major_version everywhere in code.","commit_id":"9a799d17c66a8a016f89ab1f989707bf88b9eda0"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"849c22a7cd75910be80326ba008b30568c74130d","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        path: /etc/containers/registries.conf"},{"line_number":53,"context_line":"        regexp: \u0027^unqualified-search-registries\u0027"},{"line_number":54,"context_line":"        line: \"unqualified-search-registries \u003d [\u0027localhost:{{ push_registry_port | default(\u00275001\u0027) }}\u0027, \u0027registry.access.redhat.com\u0027, \u0027registry.fedoraproject.org\u0027, \u0027registry.centos.org\u0027, \u0027docker.io\u0027]\""},{"line_number":55,"context_line":"      when: ansible_distribution_major_version|int \u003e 8"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- name: Setup repo web service"},{"line_number":58,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"152daae0_ab243f85","line":55,"range":{"start_line":55,"start_character":12,"end_line":55,"end_character":46},"updated":"2021-08-31 09:21:24.000000000","message":"ditto","commit_id":"9a799d17c66a8a016f89ab1f989707bf88b9eda0"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"849c22a7cd75910be80326ba008b30568c74130d","unresolved":true,"context_lines":[{"line_number":85,"context_line":"          set -ex"},{"line_number":86,"context_line":"          find /etc/yum.repos.d/ -name delorean\\* -o -name quickstart-centos\\* | xargs -I {} cp {} /var/www/html/"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    # - name: Add http iptables rules from containers"},{"line_number":89,"context_line":"    #  command: iptables -I openstack-INPUT 1 -p tcp --dport 80 -s 172.17.0.0/16 -j ACCEPT"},{"line_number":90,"context_line":"    #  become: true"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"76d6e9cb_7e23269e","line":88,"updated":"2021-08-31 09:21:24.000000000","message":"really?","commit_id":"9a799d17c66a8a016f89ab1f989707bf88b9eda0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f6aa6ca8b3550dbb8c41074927c1821baf5415ff","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        option: registries"},{"line_number":46,"context_line":"        value:"},{"line_number":47,"context_line":"          - \"localhost:{{ push_registry_port | default(\u00275001\u0027) }}\""},{"line_number":48,"context_line":"      when: ansible_distribution_major_version|int \u003d\u003d 8"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    - name: Configure unqualified-search-registries"},{"line_number":51,"context_line":"      lineinfile:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9d665fb9_68bdba40","line":48,"range":{"start_line":48,"start_character":46,"end_line":48,"end_character":53},"updated":"2021-09-03 06:39:08.000000000","message":"if you use is version( you can remove the |int","commit_id":"a01748ccb8ae43d62e06657f95991be7eb95512d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f6aa6ca8b3550dbb8c41074927c1821baf5415ff","unresolved":true,"context_lines":[{"line_number":85,"context_line":"          set -ex"},{"line_number":86,"context_line":"          find /etc/yum.repos.d/ -name delorean\\* -o -name quickstart-centos\\* | xargs -I {} cp {} /var/www/html/"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    # - name: Add http iptables rules from containers"},{"line_number":89,"context_line":"    #  command: iptables -I openstack-INPUT 1 -p tcp --dport 80 -s 172.17.0.0/16 -j ACCEPT"},{"line_number":90,"context_line":"    #  become: true"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"- name: Setup tripleo registry"},{"line_number":93,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"2da654d8_076151fa","line":90,"range":{"start_line":88,"start_character":4,"end_line":90,"end_character":6},"updated":"2021-09-03 06:39:08.000000000","message":"will we remove this? lets make it conditional if we want to avoid it or tweak it for 9?","commit_id":"a01748ccb8ae43d62e06657f95991be7eb95512d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"abd05d22d27f93ae6b5c43cd8d64aa53b1bec299","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        value:"},{"line_number":47,"context_line":"          - \"localhost:{{ push_registry_port | default(\u00275001\u0027) }}\""},{"line_number":48,"context_line":"      when:"},{"line_number":49,"context_line":"        - ansible_distribution_major_version is version(8, \u0027\u003e\u003d\u0027)"},{"line_number":50,"context_line":"        - ansible_distribution_major_version is version(9, \u0027\u003c\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    - name: Configure unqualified-search-registries"},{"line_number":53,"context_line":"      lineinfile:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"0deeb7ea_1df2fc10","line":50,"range":{"start_line":49,"start_character":59,"end_line":50,"end_character":63},"updated":"2021-09-06 07:13:46.000000000","message":"use \u003d\u003d and have one conditional","commit_id":"10fd0a5ab77d1ecf9f2341c5a9c564f9f396724c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"abd05d22d27f93ae6b5c43cd8d64aa53b1bec299","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    - name: Add http iptables rules from containers"},{"line_number":91,"context_line":"      command: iptables -I openstack-INPUT 1 -p tcp --dport 80 -s 172.17.0.0/16 -j ACCEPT"},{"line_number":92,"context_line":"      become: true"},{"line_number":93,"context_line":"      when: ansible_distribution_major_version is version(\u00279\u0027, \u0027\u003c\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"- name: Setup tripleo registry"},{"line_number":96,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"9ea0cdab_1038694b","line":93,"range":{"start_line":93,"start_character":59,"end_line":93,"end_character":66},"updated":"2021-09-06 07:13:46.000000000","message":"if you mean 8 lets make it \u003d\u003d 8 here?","commit_id":"10fd0a5ab77d1ecf9f2341c5a9c564f9f396724c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2f07375cc1219f86ca1af0a428a1f8d445c4c07c","unresolved":true,"context_lines":[{"line_number":51,"context_line":"      lineinfile:"},{"line_number":52,"context_line":"        path: /etc/containers/registries.conf"},{"line_number":53,"context_line":"        regexp: \u0027^unqualified-search-registries\u0027"},{"line_number":54,"context_line":"        line: \"unqualified-search-registries \u003d [\u0027localhost:{{ push_registry_port | default(\u00275001\u0027) }}\u0027,"},{"line_number":55,"context_line":"                                                \u0027registry.access.redhat.com\u0027,"},{"line_number":56,"context_line":"                                                \u0027registry.fedoraproject.org\u0027,"},{"line_number":57,"context_line":"                                                \u0027registry.centos.org\u0027,"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"fc70963b_280c95c0","line":54,"range":{"start_line":54,"start_character":49,"end_line":54,"end_character":58},"updated":"2021-09-29 07:24:38.000000000","message":"cant we use the var here instead of hard-coded localhost? it defaults to 127.0.0.1","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2f07375cc1219f86ca1af0a428a1f8d445c4c07c","unresolved":true,"context_lines":[{"line_number":51,"context_line":"      lineinfile:"},{"line_number":52,"context_line":"        path: /etc/containers/registries.conf"},{"line_number":53,"context_line":"        regexp: \u0027^unqualified-search-registries\u0027"},{"line_number":54,"context_line":"        line: \"unqualified-search-registries \u003d [\u0027localhost:{{ push_registry_port | default(\u00275001\u0027) }}\u0027,"},{"line_number":55,"context_line":"                                                \u0027registry.access.redhat.com\u0027,"},{"line_number":56,"context_line":"                                                \u0027registry.fedoraproject.org\u0027,"},{"line_number":57,"context_line":"                                                \u0027registry.centos.org\u0027,"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"cd032347_23d96487","line":54,"range":{"start_line":54,"start_character":92,"end_line":54,"end_character":96},"updated":"2021-09-29 07:24:38.000000000","message":"port defaults to 8787 maybe use that? https://opendev.org/openstack/tripleo-ci/src/commit/abbdcfad5b900f4822aa3ada2e1d48dceea14452/roles/build-containers/defaults/main.yaml#L2","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"43f63ca6c93e147ed64b3f314d33ad1e9e1279c1","unresolved":true,"context_lines":[{"line_number":51,"context_line":"      lineinfile:"},{"line_number":52,"context_line":"        path: /etc/containers/registries.conf"},{"line_number":53,"context_line":"        regexp: \u0027^unqualified-search-registries\u0027"},{"line_number":54,"context_line":"        line: \"unqualified-search-registries \u003d [\u0027localhost:{{ push_registry_port | default(\u00275001\u0027) }}\u0027,"},{"line_number":55,"context_line":"                                                \u0027registry.access.redhat.com\u0027,"},{"line_number":56,"context_line":"                                                \u0027registry.fedoraproject.org\u0027,"},{"line_number":57,"context_line":"                                                \u0027registry.centos.org\u0027,"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"7cbd2252_66611bae","line":54,"range":{"start_line":54,"start_character":92,"end_line":54,"end_character":96},"in_reply_to":"cd032347_23d96487","updated":"2021-10-08 08:54:49.000000000","message":"Let me try that.","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2f07375cc1219f86ca1af0a428a1f8d445c4c07c","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    - name: Add http iptables rules from containers"},{"line_number":93,"context_line":"      command: iptables -I openstack-INPUT 1 -p tcp --dport 80 -s 172.17.0.0/16 -j ACCEPT"},{"line_number":94,"context_line":"      become: true"},{"line_number":95,"context_line":"      when: ansible_distribution_major_version is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"- name: Setup tripleo registry"},{"line_number":98,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"beb6ead9_5a67e998","line":95,"range":{"start_line":95,"start_character":6,"end_line":95,"end_character":10},"updated":"2021-09-29 07:24:38.000000000","message":"we will change this eventually? I mean it is something that will be fixed in 9 or never? anything we can point to with a comment here so we don\u0027t forget about it?","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"43f63ca6c93e147ed64b3f314d33ad1e9e1279c1","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    - name: Add http iptables rules from containers"},{"line_number":93,"context_line":"      command: iptables -I openstack-INPUT 1 -p tcp --dport 80 -s 172.17.0.0/16 -j ACCEPT"},{"line_number":94,"context_line":"      become: true"},{"line_number":95,"context_line":"      when: ansible_distribution_major_version is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"- name: Setup tripleo registry"},{"line_number":98,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"1fc72556_381618fc","line":95,"range":{"start_line":95,"start_character":6,"end_line":95,"end_character":10},"in_reply_to":"beb6ead9_5a67e998","updated":"2021-10-08 08:54:49.000000000","message":"Let me remove the conditional and see","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"}],"roles/build-containers/templates/tripleo-build.sh.j2":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"6407982ea55c4df5d20c4eafd18fc23dc8a78980","unresolved":true,"context_lines":[{"line_number":88,"context_line":"     --volume {{ item }} \\"},{"line_number":89,"context_line":"{%   endfor %}"},{"line_number":90,"context_line":"{%   endif %}"},{"line_number":91,"context_line":"{%   if branch not  in [\"train\", \"ussuri\", \"victoria\", \"wallaby\"] %}"},{"line_number":92,"context_line":"     --tcib-extra tcib_release\u003d{{ ansible_distribution_major_version }} \\"},{"line_number":93,"context_line":"     --tcib-extra tcib_python_version\u003d{{ (ansible_distribution_major_version|int \u003c 9) | ternary (\u00273.6\u0027, \u00273.9\u0027) }} \\"},{"line_number":94,"context_line":"{%   endif %}"}],"source_content_type":"text/x-jinja2","patch_set":35,"id":"b5049809_de0d2391","line":91,"updated":"2021-09-03 12:06:56.000000000","message":"wallaby will also centos 8 and 9","commit_id":"a01748ccb8ae43d62e06657f95991be7eb95512d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2f07375cc1219f86ca1af0a428a1f8d445c4c07c","unresolved":true,"context_lines":[{"line_number":90,"context_line":"{%   endif %}"},{"line_number":91,"context_line":"{%   if branch not  in [\"train\", \"ussuri\", \"victoria\", \"wallaby\"] %}"},{"line_number":92,"context_line":"     --tcib-extra tcib_release\u003d{{ ansible_distribution_major_version }} \\"},{"line_number":93,"context_line":"     --tcib-extra tcib_python_version\u003d{{ (ansible_distribution_major_version|int \u003c 9) | ternary (\u00273.6\u0027, \u00273.9\u0027) }} \\"},{"line_number":94,"context_line":"{%   endif %}"},{"line_number":95,"context_line":"     --debug"}],"source_content_type":"text/x-jinja2","patch_set":51,"id":"79d2efab_ace3b098","line":93,"range":{"start_line":93,"start_character":76,"end_line":93,"end_character":82},"updated":"2021-09-29 07:24:38.000000000","message":"can still use is version here instead of |int \u003c\u003e","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"43f63ca6c93e147ed64b3f314d33ad1e9e1279c1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"{%   endif %}"},{"line_number":91,"context_line":"{%   if branch not  in [\"train\", \"ussuri\", \"victoria\", \"wallaby\"] %}"},{"line_number":92,"context_line":"     --tcib-extra tcib_release\u003d{{ ansible_distribution_major_version }} \\"},{"line_number":93,"context_line":"     --tcib-extra tcib_python_version\u003d{{ (ansible_distribution_major_version|int \u003c 9) | ternary (\u00273.6\u0027, \u00273.9\u0027) }} \\"},{"line_number":94,"context_line":"{%   endif %}"},{"line_number":95,"context_line":"     --debug"}],"source_content_type":"text/x-jinja2","patch_set":51,"id":"b2ed86c3_dbb56412","line":93,"range":{"start_line":93,"start_character":76,"end_line":93,"end_character":82},"in_reply_to":"79d2efab_ace3b098","updated":"2021-10-08 08:54:49.000000000","message":"Done","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"}],"roles/build-containers/vars/centos-9.yml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"849c22a7cd75910be80326ba008b30568c74130d","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  - \"file://{{ openstack_git_root }}/tripleo-ansible\""},{"line_number":19,"context_line":"  - decorator"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"volume_mounts:"},{"line_number":22,"context_line":"  - \"/etc/yum.repos.d:/etc/distro.repos.d:z\""},{"line_number":23,"context_line":"  - \"/etc/pki/rpm-gpg:/etc/pki/rpm-gpg:z\""},{"line_number":24,"context_line":"  - \"/etc/dnf/vars:/etc/dnf/vars:z\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3140969d_f2cf8433","line":21,"updated":"2021-08-31 09:21:24.000000000","message":"I think podman won\u0027t relabel those locations for (obvious) security issues. It would more than probably be better to copy the content of those locations to some other place, and there mount with that :z flag if really. Are the container actually editing content in there?","commit_id":"9a799d17c66a8a016f89ab1f989707bf88b9eda0"}],"roles/tripleo-repos/tasks/main.yml":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bb58f23e0f2fc10f8eb00556225b0a3f74c07bdb","unresolved":true,"context_lines":[{"line_number":133,"context_line":"    set -exo pipefail"},{"line_number":134,"context_line":"    source {{ workspace }}/venv/bin/activate"},{"line_number":135,"context_line":"    rm -fr /etc/yum.repos.d/centos9.repo"},{"line_number":136,"context_line":"    tripleo-yum-config enable-compose-repos \\"},{"line_number":137,"context_line":"      --release centos-stream-9 \\"},{"line_number":138,"context_line":"      --compose-url https://composes.stream.centos.org/production/CentOS-Stream-9-20210923.0/compose"},{"line_number":139,"context_line":"  register: result"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"9293e664_ac7f5b8f","line":136,"range":{"start_line":136,"start_character":23,"end_line":136,"end_character":43},"updated":"2021-10-06 21:44:16.000000000","message":"we should add \u0027--disable-all-conflicting\u0027 which will disable all other conflicting variants, i.e will disable the ones that match the default name such as \u0027appstream\u0027, \u0027baseos\u0027, etc. If we have specific repos to be disabled we need to provide the repo name using \u0027--disable-repos\u0027 option, e.g \u0027--disable-repos another-appstream.repo\u0027","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"21af6a07e484b4154d69773ed1f7e836d3476a11","unresolved":true,"context_lines":[{"line_number":135,"context_line":"    rm -fr /etc/yum.repos.d/centos9.repo"},{"line_number":136,"context_line":"    tripleo-yum-config enable-compose-repos \\"},{"line_number":137,"context_line":"      --release centos-stream-9 \\"},{"line_number":138,"context_line":"      --compose-url https://composes.stream.centos.org/production/CentOS-Stream-9-20210923.0/compose"},{"line_number":139,"context_line":"  register: result"},{"line_number":140,"context_line":"  when: ansible_distribution_major_version is version(8, \u0027\u003e\u0027)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":51,"id":"b8965c76_1ced5dea","line":138,"range":{"start_line":138,"start_character":66,"end_line":138,"end_character":92},"updated":"2021-10-04 12:52:42.000000000","message":"don\u0027t you want \u0027latest-CentOS-Stream\u0027? Because repos will be rotated and deleted on centos side, I believe","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"bb58f23e0f2fc10f8eb00556225b0a3f74c07bdb","unresolved":true,"context_lines":[{"line_number":135,"context_line":"    rm -fr /etc/yum.repos.d/centos9.repo"},{"line_number":136,"context_line":"    tripleo-yum-config enable-compose-repos \\"},{"line_number":137,"context_line":"      --release centos-stream-9 \\"},{"line_number":138,"context_line":"      --compose-url https://composes.stream.centos.org/production/CentOS-Stream-9-20210923.0/compose"},{"line_number":139,"context_line":"  register: result"},{"line_number":140,"context_line":"  when: ansible_distribution_major_version is version(8, \u0027\u003e\u0027)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":51,"id":"97c10ca9_9ef11e4a","line":138,"range":{"start_line":138,"start_character":66,"end_line":138,"end_character":92},"in_reply_to":"3b4964da_88c34c6d","updated":"2021-10-06 21:44:16.000000000","message":"+1\nmaybe it would be better to set the whole \u0027compose_url\u0027 as a variable.","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"43f63ca6c93e147ed64b3f314d33ad1e9e1279c1","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    rm -fr /etc/yum.repos.d/centos9.repo"},{"line_number":136,"context_line":"    tripleo-yum-config enable-compose-repos \\"},{"line_number":137,"context_line":"      --release centos-stream-9 \\"},{"line_number":138,"context_line":"      --compose-url https://composes.stream.centos.org/production/CentOS-Stream-9-20210923.0/compose"},{"line_number":139,"context_line":"  register: result"},{"line_number":140,"context_line":"  when: ansible_distribution_major_version is version(8, \u0027\u003e\u0027)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":51,"id":"0b22201e_17f08156","line":138,"range":{"start_line":138,"start_character":66,"end_line":138,"end_character":92},"in_reply_to":"97c10ca9_9ef11e4a","updated":"2021-10-08 08:54:49.000000000","message":"Done","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"eecc6058a21d28c11007f3cb53a10485c39a6c03","unresolved":true,"context_lines":[{"line_number":135,"context_line":"    rm -fr /etc/yum.repos.d/centos9.repo"},{"line_number":136,"context_line":"    tripleo-yum-config enable-compose-repos \\"},{"line_number":137,"context_line":"      --release centos-stream-9 \\"},{"line_number":138,"context_line":"      --compose-url https://composes.stream.centos.org/production/CentOS-Stream-9-20210923.0/compose"},{"line_number":139,"context_line":"  register: result"},{"line_number":140,"context_line":"  when: ansible_distribution_major_version is version(8, \u0027\u003e\u0027)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":51,"id":"3b4964da_88c34c6d","line":138,"range":{"start_line":138,"start_character":66,"end_line":138,"end_character":92},"in_reply_to":"b8965c76_1ced5dea","updated":"2021-10-06 19:11:25.000000000","message":"We should use latest - but latest is often broken. It would probably be best to use a variable that defaults to latest - that lets us override it easily.\nIn fact - keeping stream pinning in mind - we should keep a generalized variable to override compose IDs.","commit_id":"a271885d8dcd25315f9c2191f3e63d16a895e53a"}]}