)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c06c3e0544789198e93ef2086d76af0e56f86f8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a1c3ec9e_fcebd4bf","updated":"2021-10-11 10:24:28.000000000","message":"Looks goods, New things to learn and try out, sane approach and it will avoid duplicating, thanks Marios for working on this :-)","commit_id":"74be796580b45eaf1085003343977178c80ae3df"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"d58c2d5e2b8f1773f0e543ae702d3953ac11acb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8a7b5d8d_6a9698f1","updated":"2021-10-11 14:40:31.000000000","message":"Thank you marios.\n\nleft a comment about parenting but I am fine if we merge this as it.","commit_id":"74be796580b45eaf1085003343977178c80ae3df"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"b5afa9000d8d888dde9af369e18b36bcb29eeb79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7cc2df5b_91197713","updated":"2021-10-11 11:10:20.000000000","message":"we need to fix the syntax error on the RDO side","commit_id":"74be796580b45eaf1085003343977178c80ae3df"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"216f2ba5349290548a275fdfdb1bf40df235d10b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f757efbe_ed76f554","in_reply_to":"022c6fbb_5c08d74b","updated":"2021-10-12 12:04:25.000000000","message":"Yeah, I suspected it looks for such secret in rdo side. Will add it.","commit_id":"74be796580b45eaf1085003343977178c80ae3df"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5f8efc42d650f7b021fcdaf2e3c4ecb30dbd23e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"823737b2_9519d3d5","in_reply_to":"7cc2df5b_91197713","updated":"2021-10-12 11:41:09.000000000","message":"as discussed in yesterday scrum, i believe that is because the secret ansible_galaxy_info_tripleo_ci is being added in this review.\n\nI\u0027ll hit the merge button and if it causes any issues for rdo jobs we will revert immediately and investigate further.","commit_id":"74be796580b45eaf1085003343977178c80ae3df"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"aaf3bce0c96dd7973d3d9462ab30ee394309a2b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"022c6fbb_5c08d74b","in_reply_to":"823737b2_9519d3d5","updated":"2021-10-12 11:59:38.000000000","message":"The issue happened as missing secret, and it\u0027s missing as only jobs are imported not secrets in zuul config:- https://github.com/rdo-infra/review.rdoproject.org-config/blob/master/zuul/rdo.yaml#L995, /me not sure if it will just report config-errors or will cause other issue and then revert and all will take much time, instead can import \"secret\" from tripleo-ci repo also in RDO zuul config or add the required secrets in RDO side(even dummy will work).","commit_id":"74be796580b45eaf1085003343977178c80ae3df"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"39a6ef3065bf13af8da6e657dd51e90c9412eaa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d3a30e1c_b76b5c97","in_reply_to":"8a7b5d8d_6a9698f1","updated":"2021-10-12 11:45:41.000000000","message":"thanks for review as sshnaidm commented i want to test this and get the queue right (\u0027tag\u0027 vs \u0027release\u0027) and then we can tidy up and indeed likely make a base job","commit_id":"74be796580b45eaf1085003343977178c80ae3df"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"11ce06708d75deab7b949338c2f37e6f0bde9fc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"05b69346_6883f0de","in_reply_to":"f757efbe_ed76f554","updated":"2021-10-12 12:38:29.000000000","message":"I don\u0027t think this should affect the currently running job in rdo, and zuul may just report a config-error for this job because of the missing secret once this is merged. Though I asked in #zuul room what is the recommended strategy to deal with that case.","commit_id":"74be796580b45eaf1085003343977178c80ae3df"}],"zuul.d/ansible-galaxy.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"21ad96d26d9f6dcd037d417f513f64cf852fd4f2","unresolved":true,"context_lines":[{"line_number":21,"context_line":"      collection_name_prefix: \"tripleo-repos\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- secret:"},{"line_number":24,"context_line":"    name: ansible_galaxy_info_toa"},{"line_number":25,"context_line":"    data:"},{"line_number":26,"context_line":"      url: https://galaxy.ansible.com"},{"line_number":27,"context_line":"      token: !encrypted/pkcs1-oaep"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9dd644f0_7399ef9e","line":24,"range":{"start_line":24,"start_character":10,"end_line":24,"end_character":33},"updated":"2021-09-23 10:49:21.000000000","message":"i will need to add a new key apparently they are tied to the project\n\nthe pub key used to encrypt the secret is different for each project so cant use the one defined for tripleo-operator-ansible...","commit_id":"9b47676bdc7048ebf2d7b771d10ef050de18785f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"267f8409bf9afd1bd41a100b75ae3d69f8138622","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"119b9f17_f3c2d69b","side":"PARENT","updated":"2021-09-27 07:56:34.000000000","message":"linters failing on missing --- here updating","commit_id":"82f407c5288974428ec8d35e22ae516dc9bf0a96"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"09f9e2d90edd6955febc039fc1709081d95edaeb","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    name: ansible_galaxy_info_tripleo-ci"},{"line_number":25,"context_line":"    data:"},{"line_number":26,"context_line":"      url: https://galaxy.ansible.com"},{"line_number":27,"context_line":"      token: !encrypted/pkcs1-oaep"},{"line_number":28,"context_line":"        - Wj3D5B5XYJkZkOfiITUW4kplITZcTjlXPLhLU4fvjhS/MunE0hnDkUEVBCEmWTszBRUKu"},{"line_number":29,"context_line":"          90RScKHIx9C4jLOsQ/pXgAMq/E8WkdgiKaWE1BgryxhYfAE4ceL97xNqjidacUBbHoeRU"},{"line_number":30,"context_line":"          4RiCOP7POlYzVMTRi1gaILsRu0DfxaGHq1FOTqDOgwwnq95glNHIpj1ShN+xGWnv2hxhH"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d4e12c1f_cb4e2bf9","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":11},"updated":"2021-09-24 11:05:26.000000000","message":"verified our API key today and published v0.0.5 ... then encrypted that and updated here.\n\nhttps://galaxy.ansible.com/tripleo/repos","commit_id":"ccdab2203ce625bfa62010a41caa3debd4b37440"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d7a16f292524c5dd1e48c57255d45009491422bb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- job:"},{"line_number":3,"context_line":"    name: tripleo-operator-ansible-release"},{"line_number":4,"context_line":"    parent: base"},{"line_number":5,"context_line":"    run: playbooks/publish-galaxy-collection/publish_collection.yml"},{"line_number":6,"context_line":"    secrets:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"44417ac4_8b831705","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":35},"updated":"2021-10-07 09:14:25.000000000","message":"lets use a new name here so we can remove the depends-on \nso we can test the approach and then if happy remove the t-o-a definition...","commit_id":"ffb527ae93209ba11133a6bf6cce8d01ce06a76b"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"4d15b975c54018b1ead0ac1c14c04a2812aaf10d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- job:"},{"line_number":3,"context_line":"    name: tripleo-operator-ansible-release"},{"line_number":4,"context_line":"    parent: base"},{"line_number":5,"context_line":"    run: playbooks/publish-galaxy-collection/publish_collection.yml"},{"line_number":6,"context_line":"    secrets:"},{"line_number":7,"context_line":"      - name: ansible_galaxy_info"},{"line_number":8,"context_line":"        secret: ansible_galaxy_info_tripleo_ci"},{"line_number":9,"context_line":"    vars:"},{"line_number":10,"context_line":"      collection_path: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/tripleo-operator-ansible\u0027].src_dir }}\""},{"line_number":11,"context_line":"      collection_name_prefix: \"tripleo-operator\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- job:"},{"line_number":14,"context_line":"    name: tripleo-repos-release"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b421b375_b660e07b","line":11,"range":{"start_line":2,"start_character":1,"end_line":11,"end_character":48},"updated":"2021-10-06 11:28:54.000000000","message":"I don\u0027t think we need to move it here. What is the value?\nIt\u0027s better to have a base release job, and then inherited from it in each repo with each secret.","commit_id":"ffb527ae93209ba11133a6bf6cce8d01ce06a76b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"73a89a75c5c00b0c71ff042334df256550ae5d71","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- job:"},{"line_number":3,"context_line":"    name: tripleo-operator-ansible-release"},{"line_number":4,"context_line":"    parent: base"},{"line_number":5,"context_line":"    run: playbooks/publish-galaxy-collection/publish_collection.yml"},{"line_number":6,"context_line":"    secrets:"},{"line_number":7,"context_line":"      - name: ansible_galaxy_info"},{"line_number":8,"context_line":"        secret: ansible_galaxy_info_tripleo_ci"},{"line_number":9,"context_line":"    vars:"},{"line_number":10,"context_line":"      collection_path: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/tripleo-operator-ansible\u0027].src_dir }}\""},{"line_number":11,"context_line":"      collection_name_prefix: \"tripleo-operator\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- job:"},{"line_number":14,"context_line":"    name: tripleo-repos-release"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7d740170_abe2bf30","line":11,"range":{"start_line":2,"start_character":1,"end_line":11,"end_character":48},"in_reply_to":"b421b375_b660e07b","updated":"2021-10-07 08:03:57.000000000","message":"the value is that they can share the publish_collection playbook.\n\ndo you mean:\n\nbase job in tripleo-ci with the playbook\nrelease job in tripleo-repos with the secret there? \nrelease job in tripleo-operator-ansible with the secret there? \n\nwhat is the advantage of keeping the jobs definitions and a secret in each of those repos? if we do it like that, will the common playbook in the base tripleo-ci job be able to use the secret defined in the tripleo-repos or t-o-a repos I don\u0027t think so?","commit_id":"ffb527ae93209ba11133a6bf6cce8d01ce06a76b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c06c3e0544789198e93ef2086d76af0e56f86f8e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- job:"},{"line_number":3,"context_line":"    name: tripleo-operator-ansible-release-new  # TODO(marios) remove -new"},{"line_number":4,"context_line":"    parent: base"},{"line_number":5,"context_line":"    run: playbooks/publish-galaxy-collection/publish_collection.yml"},{"line_number":6,"context_line":"    secrets:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ee1bdfcf_84fd5e3b","line":3,"range":{"start_line":3,"start_character":70,"end_line":3,"end_character":74},"updated":"2021-10-11 10:24:28.000000000","message":"Ok, Make sense since tripleo-operator-ansible-release is defined here https://review.opendev.org/c/openstack/tripleo-operator-ansible/+/803588/6/zuul.d/layout.yaml .","commit_id":"74be796580b45eaf1085003343977178c80ae3df"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"d58c2d5e2b8f1773f0e543ae702d3953ac11acb0","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    vars:"},{"line_number":10,"context_line":"      collection_path: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/tripleo-operator-ansible\u0027].src_dir }}\""},{"line_number":11,"context_line":"      collection_name_prefix: \"tripleo-operator\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- job:"},{"line_number":14,"context_line":"    name: tripleo-repos-release"},{"line_number":15,"context_line":"    parent: base"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"820fe468_b1980f77","line":12,"updated":"2021-10-11 14:40:31.000000000","message":"This looks great, Just a thought we are sharing a lot of things between tripleo-operator-ansible-release-new and tripleo-repos-release job like parent, secrets, run and some var.\n\nMaybe we could have created an abstract job and then parent off that to created specific job passing collection_name_prefix.","commit_id":"74be796580b45eaf1085003343977178c80ae3df"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e5f4850c5fc673b7a7b74e8d8c80a77d62e75b71","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    vars:"},{"line_number":10,"context_line":"      collection_path: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/tripleo-operator-ansible\u0027].src_dir }}\""},{"line_number":11,"context_line":"      collection_name_prefix: \"tripleo-operator\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- job:"},{"line_number":14,"context_line":"    name: tripleo-repos-release"},{"line_number":15,"context_line":"    parent: base"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"0b64b314_7a710e75","line":12,"in_reply_to":"820fe468_b1980f77","updated":"2021-10-11 14:51:32.000000000","message":"Yes, we talked that it should be a base job if this setup works.","commit_id":"74be796580b45eaf1085003343977178c80ae3df"}]}