)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6b6233e366204a3c0ca78b63652f11bda4a5e61e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9328619d_de588266","updated":"2021-10-14 08:27:14.000000000","message":"Few suggestions, rest looks good.","commit_id":"efa5600ea2d981a61d89aa4c3c3092495110d62a"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"1949cabb849abfe77e5149adeea4c393c9bcba26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c3020e3a_c465ecf2","updated":"2021-10-14 11:12:36.000000000","message":"recheck","commit_id":"2e8474b5f292cc2ffe109fbf4b32225f2b2a5c8b"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"ee6fe78125d630629d4623e6afdf8cd81bd99df3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7b74638c_d6804da7","updated":"2021-10-18 21:16:51.000000000","message":"comment in line","commit_id":"1ece18b545735b891808a6a1b0e54cecbf0bb7bb"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f045f51eb40acea72532cd3b84d51eee08b10847","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"44780161_54f35af3","updated":"2021-10-19 08:21:14.000000000","message":"Promoter changes are here: https://review.rdoproject.org/r/c/rdo-infra/ci-config/+/36300","commit_id":"29ff2ff5d9ebe333f51f5e36565530bd7ed6951a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"77d400ddb73b5b1e40fc35e75720837c08a3cffe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"21e2e325_5640c1c5","updated":"2021-10-19 12:23:43.000000000","message":"ansible_distribution|lower will be \u0027redhat\u0027 not rhel.","commit_id":"29ff2ff5d9ebe333f51f5e36565530bd7ed6951a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"bad2c46be09008e8426c8260c1ed6755a9bec1a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fdea60be_ecc96a9a","updated":"2021-10-19 08:21:19.000000000","message":"recheck","commit_id":"29ff2ff5d9ebe333f51f5e36565530bd7ed6951a"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"8b8a1f0f02bf44f6a5b44f18687bd96c606eeeee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c907dced_39ca2a1c","updated":"2021-10-19 11:28:55.000000000","message":"waiting on downstream confirmation","commit_id":"29ff2ff5d9ebe333f51f5e36565530bd7ed6951a"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"52e28fe9dd8a988a25a492ef2dc11c942bc2aff1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e4e5e28e_15ff3e9c","in_reply_to":"c907dced_39ca2a1c","updated":"2021-10-19 11:54:09.000000000","message":"Testing downstream here: https://code.engineering.redhat.com/gerrit/c/testproject/+/273018","commit_id":"29ff2ff5d9ebe333f51f5e36565530bd7ed6951a"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"211c3fb2060a0c4f7675775fd43496ec519b1241","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"10937b49_163aa052","in_reply_to":"e4e5e28e_15ff3e9c","updated":"2021-10-19 12:20:30.000000000","message":"Downstream failing:-\n\nhttps://sf.hosted.upshift.rdu2.redhat.com/logs/18/273018/9/check/periodic-tripleo-build-containers-ubi-8-internal-rhel-8-build-push-upload-rhos-16.2/179fd20/job-output.txt\n\n~~~\n2021-10-19 12:06:48.754695 | TASK [build-containers : Generate tripleo building script]\n2021-10-19 12:06:59.412884 | primary | ERROR\n2021-10-19 12:06:59.413410 | primary | {\n2021-10-19 12:06:59.413468 | primary |   \"msg\": \"AnsibleUndefinedVariable: \u0027dict object\u0027 has no attribute \u0027redhat8\u0027\"\n2021-10-19 12:06:59.413500 | primary | }\n~~~","commit_id":"29ff2ff5d9ebe333f51f5e36565530bd7ed6951a"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"4e91bf4a6a132ccaba93fa9686bcda5c8483739e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2a3cd993_f93b22d9","updated":"2021-10-19 14:05:32.000000000","message":"Downstream container build is fixed with the latest patchset.","commit_id":"b2f2345d138983426010cee939cf7ddc68504d83"}],"roles/build-containers/defaults/main.yaml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6b6233e366204a3c0ca78b63652f11bda4a5e61e","unresolved":true,"context_lines":[{"line_number":43,"context_line":"container_registry_image: quay.io/tripleoci/registry:2"},{"line_number":44,"context_line":"provider_registry_port: 5001"},{"line_number":45,"context_line":"container_exclude_distro: \u003e-"},{"line_number":46,"context_line":"  {%- if distro is defined -%}"},{"line_number":47,"context_line":"  {{- distro -}}"},{"line_number":48,"context_line":"  {%- else -%}"},{"line_number":49,"context_line":"  centos8"},{"line_number":50,"context_line":"  {%- endif -%}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1cf92bd0_23bc287a","line":47,"range":{"start_line":46,"start_character":2,"end_line":47,"end_character":16},"updated":"2021-10-14 08:27:14.000000000","message":"I would suggest to remove distro as a default. Since https://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/v2/tripleo_container_image.py#L105 It points distro \u003d centos (without version).\nI would set it to {{ ansible_distribution|lower }}{{ ansible_distribution_major_version}} as we are using centos8 in the var file as a distro.\n\nAnd a openstack release can run on multiple distros. It might be c7 and rhel7 or c8 and c9","commit_id":"efa5600ea2d981a61d89aa4c3c3092495110d62a"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"5a91de1027890199bc963a6e0138273e827c3204","unresolved":false,"context_lines":[{"line_number":43,"context_line":"container_registry_image: quay.io/tripleoci/registry:2"},{"line_number":44,"context_line":"provider_registry_port: 5001"},{"line_number":45,"context_line":"container_exclude_distro: \u003e-"},{"line_number":46,"context_line":"  {%- if distro is defined -%}"},{"line_number":47,"context_line":"  {{- distro -}}"},{"line_number":48,"context_line":"  {%- else -%}"},{"line_number":49,"context_line":"  centos8"},{"line_number":50,"context_line":"  {%- endif -%}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9172f82d_ac2f3c44","line":47,"range":{"start_line":46,"start_character":2,"end_line":47,"end_character":16},"in_reply_to":"1cf92bd0_23bc287a","updated":"2021-10-14 08:36:39.000000000","message":"Done","commit_id":"efa5600ea2d981a61d89aa4c3c3092495110d62a"}],"roles/build-containers/vars/main.yaml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6b6233e366204a3c0ca78b63652f11bda4a5e61e","unresolved":true,"context_lines":[{"line_number":34,"context_line":"      - sensu-base"},{"line_number":35,"context_line":"      - influxdb"},{"line_number":36,"context_line":"      - tempest"},{"line_number":37,"context_line":"    centosstream9:"},{"line_number":38,"context_line":"      - fluentd"},{"line_number":39,"context_line":"      - opendaylight"},{"line_number":40,"context_line":"      - neutron-server-opendaylight"},{"line_number":41,"context_line":"      - neutron-mlnx-agent"},{"line_number":42,"context_line":"      - nova-serialproxy"},{"line_number":43,"context_line":"      - sahara-api"},{"line_number":44,"context_line":"      - sahara-engine"},{"line_number":45,"context_line":"      - skydive-agent"},{"line_number":46,"context_line":"      - skydive-analyzer"},{"line_number":47,"context_line":"      - sensu-client"},{"line_number":48,"context_line":"      - sensu-base"},{"line_number":49,"context_line":"      - influxdb"},{"line_number":50,"context_line":"      - tempest"},{"line_number":51,"context_line":"  wallaby:"},{"line_number":52,"context_line":"    centos8: *exclude_master_containers"},{"line_number":53,"context_line":"  victoria:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"362db88d_4140b99a","line":50,"range":{"start_line":37,"start_character":0,"end_line":50,"end_character":15},"updated":"2021-10-14 08:27:14.000000000","message":"can we update this section to \ncentosstream9: *exclude_master_containers","commit_id":"efa5600ea2d981a61d89aa4c3c3092495110d62a"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"5a91de1027890199bc963a6e0138273e827c3204","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      - sensu-base"},{"line_number":35,"context_line":"      - influxdb"},{"line_number":36,"context_line":"      - tempest"},{"line_number":37,"context_line":"    centosstream9:"},{"line_number":38,"context_line":"      - fluentd"},{"line_number":39,"context_line":"      - opendaylight"},{"line_number":40,"context_line":"      - neutron-server-opendaylight"},{"line_number":41,"context_line":"      - neutron-mlnx-agent"},{"line_number":42,"context_line":"      - nova-serialproxy"},{"line_number":43,"context_line":"      - sahara-api"},{"line_number":44,"context_line":"      - sahara-engine"},{"line_number":45,"context_line":"      - skydive-agent"},{"line_number":46,"context_line":"      - skydive-analyzer"},{"line_number":47,"context_line":"      - sensu-client"},{"line_number":48,"context_line":"      - sensu-base"},{"line_number":49,"context_line":"      - influxdb"},{"line_number":50,"context_line":"      - tempest"},{"line_number":51,"context_line":"  wallaby:"},{"line_number":52,"context_line":"    centos8: *exclude_master_containers"},{"line_number":53,"context_line":"  victoria:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"122248f8_ddbf93e6","line":50,"range":{"start_line":37,"start_character":0,"end_line":50,"end_character":15},"in_reply_to":"362db88d_4140b99a","updated":"2021-10-14 08:36:39.000000000","message":"Done","commit_id":"efa5600ea2d981a61d89aa4c3c3092495110d62a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d86ae4b9a7b62162888e3eaaff6bba02f92e3b76","unresolved":true,"context_lines":[{"line_number":34,"context_line":"      - sensu-base"},{"line_number":35,"context_line":"      - influxdb"},{"line_number":36,"context_line":"      - tempest"},{"line_number":37,"context_line":"    centosstream9: *exclude_master_containers"},{"line_number":38,"context_line":"  wallaby:"},{"line_number":39,"context_line":"    centos8: *exclude_master_containers"},{"line_number":40,"context_line":"  victoria:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e4b00165_232b2fe0","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":17},"updated":"2021-10-18 15:34:47.000000000","message":"It should be centos9","commit_id":"1b3a4e3b1683fe74ccb3e717ea5378463880e1bb"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"c2aa1f239eb65708b3fb095ce468f6dee4f17848","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      - sensu-base"},{"line_number":35,"context_line":"      - influxdb"},{"line_number":36,"context_line":"      - tempest"},{"line_number":37,"context_line":"    centosstream9: *exclude_master_containers"},{"line_number":38,"context_line":"  wallaby:"},{"line_number":39,"context_line":"    centos8: *exclude_master_containers"},{"line_number":40,"context_line":"  victoria:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"17805a9a_d670bb00","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":17},"in_reply_to":"e4b00165_232b2fe0","updated":"2021-10-18 16:20:42.000000000","message":"Done","commit_id":"1b3a4e3b1683fe74ccb3e717ea5378463880e1bb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"ee6fe78125d630629d4623e6afdf8cd81bd99df3","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  rhos-17:"},{"line_number":68,"context_line":"    rhel8: *exclude_master_containers"},{"line_number":69,"context_line":"  rhos-16.2:"},{"line_number":70,"context_line":"    rhel7: *exclude_containers"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"timestamper_cmd: \u003e-"},{"line_number":73,"context_line":"    | awk \u0027{ print strftime(\"%Y-%m-%d %H:%M:%S |\"), $0; fflush(); }\u0027"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"09254459_0563e5cf","line":70,"updated":"2021-10-18 21:16:51.000000000","message":"rhel8","commit_id":"1ece18b545735b891808a6a1b0e54cecbf0bb7bb"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"1b1593bb90a4a48734ccb40e0edd6100b7e54820","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  rhos-17:"},{"line_number":68,"context_line":"    rhel8: *exclude_master_containers"},{"line_number":69,"context_line":"  rhos-16.2:"},{"line_number":70,"context_line":"    rhel7: *exclude_containers"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"timestamper_cmd: \u003e-"},{"line_number":73,"context_line":"    | awk \u0027{ print strftime(\"%Y-%m-%d %H:%M:%S |\"), $0; fflush(); }\u0027"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"cb5995cf_4d3eb873","line":70,"in_reply_to":"09254459_0563e5cf","updated":"2021-10-19 05:23:36.000000000","message":"Done","commit_id":"1ece18b545735b891808a6a1b0e54cecbf0bb7bb"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"77d400ddb73b5b1e40fc35e75720837c08a3cffe","unresolved":true,"context_lines":[{"line_number":65,"context_line":"      - opendaylight"},{"line_number":66,"context_line":"      - neutron-server-opendaylight"},{"line_number":67,"context_line":"  rhos-17:"},{"line_number":68,"context_line":"    rhel8: *exclude_master_containers"},{"line_number":69,"context_line":"  rhos-16.2:"},{"line_number":70,"context_line":"    rhel8: *exclude_containers"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"2944fbb5_cf8f10c8","line":68,"range":{"start_line":68,"start_character":4,"end_line":68,"end_character":8},"updated":"2021-10-19 12:23:43.000000000","message":"it should be redhat","commit_id":"29ff2ff5d9ebe333f51f5e36565530bd7ed6951a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"77d400ddb73b5b1e40fc35e75720837c08a3cffe","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  rhos-17:"},{"line_number":68,"context_line":"    rhel8: *exclude_master_containers"},{"line_number":69,"context_line":"  rhos-16.2:"},{"line_number":70,"context_line":"    rhel8: *exclude_containers"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"timestamper_cmd: \u003e-"},{"line_number":73,"context_line":"    | awk \u0027{ print strftime(\"%Y-%m-%d %H:%M:%S |\"), $0; fflush(); }\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bbe0d2ac_7319e390","line":70,"range":{"start_line":70,"start_character":4,"end_line":70,"end_character":8},"updated":"2021-10-19 12:23:43.000000000","message":"it should be redhat","commit_id":"29ff2ff5d9ebe333f51f5e36565530bd7ed6951a"}]}