)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b5fbdf4e5bbc85626e530ff9e91d5d5d7873c4dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ad15a43_25841da3","updated":"2021-10-25 13:25:33.000000000","message":"Once this https://review.opendev.org/c/openstack/project-config/+/811442 merges, nodepool node will be available. I think.","commit_id":"f7340d60e90555b00a362f1a9e4c45b36a2a5528"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c711a8f66bfb7f8ea045d8d92cc7a1d4997c6d4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1b0a8fff_b3b8bbaa","in_reply_to":"3ad15a43_25841da3","updated":"2021-11-05 08:01:14.000000000","message":"yeah and actually we also need to change/uncomment that as well in this review when we are ready:\n\nhttps://opendev.org/openstack/tripleo-ci/src/commit/8eed25613233f7c5960c46b5ec43aa84d180f03e/zuul.d/base.yaml#L791","commit_id":"f7340d60e90555b00a362f1a9e4c45b36a2a5528"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b9a9b0162c112e6b143b64e40c19ea829eca7aed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"706110c3_f011f784","updated":"2021-11-08 05:09:55.000000000","message":"https://7b4711a9448bb4dde5f0-dff9c49794866cbef4153ad433747146.ssl.cf2.rackcdn.com/815108/2/check/tripleo-buildimage-overcloud-full-centos-9/2954b8a/job-output.txt\n```\n2021-11-05 16:24:59.060910 | LOOP [get extra repos delorean and deps]\n2021-11-05 16:25:09.684574 | primary | ERROR\n2021-11-05 16:25:09.685286 | primary | {\n2021-11-05 16:25:09.685393 | primary |   \"msg\": \"\u0027release\u0027 is undefined\"\n2021-11-05 16:25:09.685486 | primary | }\n2021-11-05 16:25:09.704910 | \n\n```\n","commit_id":"e3e49e63e3d1b08b99ecf69a380989331cf7552e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"40c998122ad77cd08c25a1e0baa42f0837612b23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1e011d50_afcaca59","in_reply_to":"706110c3_f011f784","updated":"2021-11-09 07:37:04.000000000","message":"yeah thanks I meant to dig into that yesterday but got distracted by other stuff will dig into it today","commit_id":"e3e49e63e3d1b08b99ecf69a380989331cf7552e"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"43af947dccdb5df8b80b01d1b53d1f997527319e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"742e4f10_c60c6f89","updated":"2021-11-10 17:18:03.000000000","message":"recheck\n","commit_id":"784a58ff32170483fe83110c5f1e0e8f2092116c"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b40b942b10648b32730ffc032d191d8332344cf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fd41edec_e6893e02","updated":"2021-11-11 11:37:09.000000000","message":"ok to merge, there is a follow up change here https://review.opendev.org/c/openstack/tripleo-ci/+/817341/","commit_id":"f3035623bfbeaad0dee8a110e8c581db7d05d7c3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5901a225a03e36096a2b010098e518a17403479a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b1552431_370c4c66","updated":"2021-11-11 14:11:24.000000000","message":"ripleo-buildimage-overcloud-full-centos-9 https://zuul.opendev.org/t/openstack/build/7ee46c0e139c4fc8ab8f2be676fb471d : SUCCESS in 42m 01s\ntripleo-buildimage-ironic-python-agent-centos-9 https://zuul.opendev.org/t/openstack/build/b9ffd5b6d7fd4cd896ac8a189fd806ba : SUCCESS in 34m 14s\ntripleo-buildimage-overcloud-hardened-uefi-full-centos-9 https://zuul.opendev.org/t/openstack/build/47ed986a7ccd4d36b296bea938d2e149 : SUCCESS in 42m 39s\n\nCan we mark these jobs non-voting, till it gets stable?","commit_id":"f3035623bfbeaad0dee8a110e8c581db7d05d7c3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a996ed008858645a1101997983456e9b652137ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bf7ea9a4_f52603bc","updated":"2021-11-12 11:23:18.000000000","message":"thanks for review ysandeep let\u0027s fix that here before merge","commit_id":"f3035623bfbeaad0dee8a110e8c581db7d05d7c3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d3beb823184dca0e11a8f89b0a4e150b98661b40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9e013495_6ca553d7","in_reply_to":"b1552431_370c4c66","updated":"2021-11-12 08:59:20.000000000","message":"maybe? I\u0027d rather we do this and then if they start to break often/alot we can make them non voting","commit_id":"f3035623bfbeaad0dee8a110e8c581db7d05d7c3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2c52d244239c819d5edbdaa91dea1c828723573a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"eaafb9dc_4a739b67","updated":"2021-11-12 11:35:39.000000000","message":"\u003e Patch Set 6: Verified-1\n\u003e \n\u003e Zuul encountered a syntax error while parsing its configuration in the\n\u003e repo openstack/tripleo-ci on branch master.  The error was:\n\u003e \n\u003e   The nodeset \"single-centos-9-node\" was not found.\n\u003e \n\u003e The error appears in the following job stanza:\n\u003e \n\u003e   job:\n\u003e       name: tripleo-build-images-base-centos-9\n\u003e       abstract: true\n\u003e       description: |\n\u003e           Base abstract job for tripleo-buildimage-* centos-9 jobs\n\u003e       parent: tripleo-build-images-base-centos-8\n\u003e       nodeset: single-centos-9-node\n\u003e       vars:\n\u003e         tripleo_image_os: centos9\n\u003e \n\u003e   in \"openstack/tripleo-ci/zuul.d/base.yaml@master\", line 785, column 3\n\n\n13:32 \u003c rlandy|ruck\u003e The nodeset \"single-centos-9-node\" was not found.\n13:33 \u003c marios\u003e rlandy|ruck: that is from rdo/3rd party \n13:33 \u003c marios\u003e rlandy|ruck: these jobs will not run there and we are overridign the nodeset for the periodic image builds\n13:33 \u003c marios\u003e for rdo \n13:34 \u003c marios\u003e rlandy|ruck: rdo cant see that nodeset basically but it is there  \nhttps://opendev.org/openstack/tripleo-ci/src/commit/e6a036545aa0d3dd543562703b0f87f3267dacd2/zuul.d/nodesets.yaml#L69 \n13:34 \u003c marios\u003e rlandy|ruck: at least it is there for upstream zuul \n\n\n\n\n\n\n\n\n","commit_id":"9942c04a5f646066e74787c5a649f18dc0f19f1f"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"96cefde62aca23d1e40e16ddbe00cd3834909913","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"05315f8d_0b81267b","updated":"2021-11-12 12:04:05.000000000","message":"Please merge fake nodeset patch if we see that error again.","commit_id":"9942c04a5f646066e74787c5a649f18dc0f19f1f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"df817d0433c86aa60dfd5eac6edb09350fe5d738","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3b8eb35b_f2c5ecfb","updated":"2021-11-15 07:42:53.000000000","message":"lets see ... if we have any problems with rdo 3rd party (like if that https://review.opendev.org/c/openstack/tripleo-ci/+/815108/6#message-15d0129fe814009a48b65d8e12bcdd50cfab886b persists after we merge this) then we should merge that:\nhttps://review.rdoproject.org/r/c/rdo-jobs/+/36720/1#message-be2b9f33e888fa112c5613c816abac087d2d6ad9","commit_id":"9942c04a5f646066e74787c5a649f18dc0f19f1f"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5851d06bacfec3e5aa23f080792e8d5019596142","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a4c542d3_36b49986","updated":"2021-11-16 13:26:33.000000000","message":"recheck","commit_id":"9942c04a5f646066e74787c5a649f18dc0f19f1f"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ef78cbff008dc92493b32a509a41172d6e6579ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3bd73459_2dff1d83","updated":"2021-11-16 19:19:08.000000000","message":"recheck\n\nmolecule job failure is not reproducible, trying again","commit_id":"9942c04a5f646066e74787c5a649f18dc0f19f1f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d30a4294a2002ea7f815e1246b2a07e3a5815a26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d8dc4bc4_c54340f5","updated":"2021-11-12 15:48:21.000000000","message":"recheck ","commit_id":"9942c04a5f646066e74787c5a649f18dc0f19f1f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1a32bf2ba3c0e3fe1213b3aaab43cd6a8b84aad0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c605af21_3a801e1d","updated":"2021-11-17 07:04:45.000000000","message":"recheck \n\n\njob looks pretty stable https://zuul.opendev.org/t/openstack/builds?job_name\u003dtripleo-ci-centos-8-standalone\u0026project\u003dopenstack/tripleo-ci\n\n\n        * http://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_241/815108/6/gate/tripleo-ci-centos-8-standalone/2415468/logs/undercloud/home/zuul/standalone_deploy.log\n        * 2021-11-17 01:17:17.580862 | fa163e3e-5b42-bb0b-c219-000000002637 |       TASK | Manage Cinder\u0027s default volume type\ne-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\\n  DeprecationWarning\\n/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\\n  DeprecationWarning\\nFailed to delete volume type with name or ID \u0027233a33e5-a01c-4d8c-a326-b3a8e1c02dda\u0027: The request cannot be fulfilled as the default volume type tripleo cannot be found. (HTTP 500) (Request-ID: req-bfc9d2c6-5ba3-4f1c-bf1a-0a868f6ad814)\\n1 of 1 volume types failed to delete.\", \"stderr_lines\": [\"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\", \"  DeprecationWarning\", \"Internal Server Error (HTTP 500)\", \"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\", \"  DeprecationWarning\", \"Internal Server Error (HTTP 500)\", \"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\", \"  DeprecationWarning\", \"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23:2021-11-17 01:17:38.137221 | fa163e3e-5b42-bb0b-c219-000000002637 |      FATAL | Manage Cinder\u0027s default volume type | undercloud | error\u003d{\"changed\": false, \"cmd\": \"if ! openstack volume type show \\\"tripleo\\\"; then\\n    openstack volume type create --public \\\"tripleo\\\"\\nfi\\neval $(openstack volume type show __DEFAULT__ -f shell -c id -c description)\\nif [ -n \\\"$id\\\" ]; then\\n    vols\u003d$(openstack volume list -f value -c ID)\\n    tripleo_descr\u003d\\\"For internal use, \u0027tripleo\u0027 is the default volume type\\\"\\n    if [ -z \\\"$vols\\\" ]; then\\n        openstack volume type delete $id\\n    elif [ \\\"$description\\\" !\u003d \\\"$tripleo_descr\\\" ]; then\\n        openstack volume type set $id --description \\\"$tripleo_descr\\\"\\n    fi\\nfi\\n\", \"delta\": \"0:00:20.239063\", \"end\": \"2021-11-17 01:17:38.093377\", \"msg\": \"non-zero return code\", \"rc\": 1, \"start\": \"2021-11-17 01:17:17.854314\", \"stderr\": \"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\\n  DeprecationWarning\\nInternal Server Error (HTTP 500)\\n/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\\n  DeprecationWarning\\nInternal Server Error (HTTP 500)\\n/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\\n  DeprecationWarning\\n/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\\n  DeprecationWarning\\n/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\\n  DeprecationWarning\\nFailed to delete volume type with name or ID \u0027233a33e5-a01c-4d8c-a326-b3a8e1c02dda\u0027: The request cannot be fulfilled as the default volume type tripleo cannot be found. (HTTP 500) (Request-ID: req-bfc9d2c6-5ba3-4f1c-bf1a-0a868f6ad814)\\n1 of 1 volume types failed to delete.\", \"stderr_lines\": [\"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\", \"  DeprecationWarning\", \"Internal Server Error (HTTP 500)\", \"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\", \"  DeprecationWarning\", \"Internal Server Error (HTTP 500)\", \"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\", \"  DeprecationWarning\", \"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\", \"  DeprecationWarning\", \"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\", \"  DeprecationWarning\", \"Failed to delete volume type with name or ID \u0027233a33e5-a01c-4d8c-a326-b3a8e1c02dda\u0027: The request cannot be fulfilled as the default volume type tripleo cannot be found. (HTTP 500) (Request-ID: req-bfc9d2c6-5ba3-4f1c-bf1a-0a868f6ad814)\", \"1 of 1 volume types failed to delete.\"], \"stdout\": \"\", \"stdout_lines\": []}","commit_id":"9942c04a5f646066e74787c5a649f18dc0f19f1f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6f31d0f4eaf1f4acf14b7ce217f703190dabf9bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"58a6d71c_a562423d","in_reply_to":"05315f8d_0b81267b","updated":"2021-11-12 12:06:17.000000000","message":"ack","commit_id":"9942c04a5f646066e74787c5a649f18dc0f19f1f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5d1842ccb6bbef871f4f4b510a389407be1ca2c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"43a5e140_997eec1e","in_reply_to":"eaafb9dc_4a739b67","updated":"2021-11-12 12:00:19.000000000","message":"k as discussed with rlandy i have posted a \u0027fake\u0027 nodeset at https://review.rdoproject.org/r/c/rdo-jobs/+/36720/1#message-be2b9f33e888fa112c5613c816abac087d2d6ad9 \n\nbut can we wait and see if it is needed before merging? I am hoping that it wont be but i am not sure","commit_id":"9942c04a5f646066e74787c5a649f18dc0f19f1f"}],"playbooks/tripleo-buildimages/pre9.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5759dbde956e081236db01216eb998e4c76ff4fb","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    cmd: |"},{"line_number":11,"context_line":"      dnf config-manager --add-repo {{ item }}"},{"line_number":12,"context_line":"  loop:"},{"line_number":13,"context_line":"    - \"https://trunk.rdoproject.org/centos9-{{ ci_branch }}/{{ promote_source | default(\u0027consistent\u0027) }}/delorean.repo\""},{"line_number":14,"context_line":"    - https://trunk.rdoproject.org/centos9-{{ ci_branch }}/delorean-deps.repo"},{"line_number":15,"context_line":"  changed_when: true"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4296e724_cd711118","line":13,"range":{"start_line":13,"start_character":89,"end_line":13,"end_character":99},"updated":"2021-11-11 09:30:15.000000000","message":"lets change this to default to current-tripleo too... conistent is something we were using for developing\n\nbut there is a wider issue here because we aren\u0027t using release files for these jobs (same for container builds I think? I have to dig to confirm) so we have no \u0027release\u0027 but also no \u0027promote_source\u0027.\n\nWe should instead use tripleo-repos to set these up (tripleo-yum-config module) and stop doing it like this.\n\nfor now however I\u0027ll make the default current-tripleo","commit_id":"784a58ff32170483fe83110c5f1e0e8f2092116c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6fccf1741bbd089096ec838a371788c8a030c65f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    cmd: |"},{"line_number":11,"context_line":"      dnf config-manager --add-repo {{ item }}"},{"line_number":12,"context_line":"  loop:"},{"line_number":13,"context_line":"    - \"https://trunk.rdoproject.org/centos9-{{ ci_branch }}/{{ promote_source | default(\u0027consistent\u0027) }}/delorean.repo\""},{"line_number":14,"context_line":"    - https://trunk.rdoproject.org/centos9-{{ ci_branch }}/delorean-deps.repo"},{"line_number":15,"context_line":"  changed_when: true"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a042b95c_286014db","line":13,"range":{"start_line":13,"start_character":89,"end_line":13,"end_character":99},"in_reply_to":"4296e724_cd711118","updated":"2021-11-11 09:45:37.000000000","message":"Thank you marios for working on this.\n\nin Container and Image build, release file is not used and we use tripleo-repos to lay down the centos and dlrn repos.\n\nTotally agree with the suggestions,\n1. Changing promote_source to current-tripleo as a default\n2. Regarding using tripleo-yum-config: https://review.opendev.org/c/openstack/tripleo-ci/+/817341 (we are already working in that direction.)","commit_id":"784a58ff32170483fe83110c5f1e0e8f2092116c"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b40b942b10648b32730ffc032d191d8332344cf4","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    cmd: |"},{"line_number":11,"context_line":"      dnf config-manager --add-repo {{ item }}"},{"line_number":12,"context_line":"  loop:"},{"line_number":13,"context_line":"    - \"https://trunk.rdoproject.org/centos9-{{ ci_branch }}/{{ promote_source | default(\u0027consistent\u0027) }}/delorean.repo\""},{"line_number":14,"context_line":"    - https://trunk.rdoproject.org/centos9-{{ ci_branch }}/delorean-deps.repo"},{"line_number":15,"context_line":"  changed_when: true"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fd64cb5_9beb4898","line":13,"range":{"start_line":13,"start_character":89,"end_line":13,"end_character":99},"in_reply_to":"a042b95c_286014db","updated":"2021-11-11 11:37:09.000000000","message":"ok, this code is being deleted here[1], but there we are using \u0027tripleo-ci-testing\u0027 as promote_source?\n[1] https://review.opendev.org/c/openstack/tripleo-ci/+/817341/3/roles/tripleo-repos/tasks/main.yml#140","commit_id":"784a58ff32170483fe83110c5f1e0e8f2092116c"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b40b942b10648b32730ffc032d191d8332344cf4","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: Set the ci_branch fact"},{"line_number":3,"context_line":"  include_role:"},{"line_number":4,"context_line":"    name: build-containers"},{"line_number":5,"context_line":"    tasks_from: set_ci_branch.yml"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: get extra repos delorean and deps"},{"line_number":8,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fcb629bf_1ff22f0d","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":33},"updated":"2021-11-11 11:37:09.000000000","message":"+1","commit_id":"f3035623bfbeaad0dee8a110e8c581db7d05d7c3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"8fe5a9824a3f8750e2e1fa9e2138a16761af33d7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    cmd: |"},{"line_number":11,"context_line":"      dnf config-manager --add-repo {{ item }}"},{"line_number":12,"context_line":"  loop:"},{"line_number":13,"context_line":"    - \"https://trunk.rdoproject.org/centos9-{{ ci_branch }}/{{ promote_source | default(\u0027current-tripleo\u0027) }}/delorean.repo\""},{"line_number":14,"context_line":"    - https://trunk.rdoproject.org/centos9-{{ ci_branch }}/delorean-deps.repo"},{"line_number":15,"context_line":"  changed_when: true"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Install vitualenv"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9e3ea1bf_8b29005a","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":77},"updated":"2021-11-11 15:08:10.000000000","message":"just curios, why do we need this and not using a regular tripleo-repos?","commit_id":"f3035623bfbeaad0dee8a110e8c581db7d05d7c3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d3beb823184dca0e11a8f89b0a4e150b98661b40","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    cmd: |"},{"line_number":11,"context_line":"      dnf config-manager --add-repo {{ item }}"},{"line_number":12,"context_line":"  loop:"},{"line_number":13,"context_line":"    - \"https://trunk.rdoproject.org/centos9-{{ ci_branch }}/{{ promote_source | default(\u0027current-tripleo\u0027) }}/delorean.repo\""},{"line_number":14,"context_line":"    - https://trunk.rdoproject.org/centos9-{{ ci_branch }}/delorean-deps.repo"},{"line_number":15,"context_line":"  changed_when: true"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Install vitualenv"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f9a025ba_db0b7d24","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":77},"in_reply_to":"6a1d3fd1_79420e1f","updated":"2021-11-12 08:59:20.000000000","message":"in fact the task will be removed with https://review.opendev.org/c/openstack/tripleo-ci/+/817341/3/playbooks/tripleo-buildcontainers/pre9.yaml which wires up tripleo-repos so we should be OK to merge this (this isn\u0027t the main point of this review. the main point is to wire up the check/gate jobs","commit_id":"f3035623bfbeaad0dee8a110e8c581db7d05d7c3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"86461002e6b7c494d8ef4007033fbe7ee2ebe3d7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    cmd: |"},{"line_number":11,"context_line":"      dnf config-manager --add-repo {{ item }}"},{"line_number":12,"context_line":"  loop:"},{"line_number":13,"context_line":"    - \"https://trunk.rdoproject.org/centos9-{{ ci_branch }}/{{ promote_source | default(\u0027current-tripleo\u0027) }}/delorean.repo\""},{"line_number":14,"context_line":"    - https://trunk.rdoproject.org/centos9-{{ ci_branch }}/delorean-deps.repo"},{"line_number":15,"context_line":"  changed_when: true"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Install vitualenv"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6a1d3fd1_79420e1f","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":77},"in_reply_to":"9e3ea1bf_8b29005a","updated":"2021-11-11 15:28:22.000000000","message":"yes as commented earlier here https://review.opendev.org/c/openstack/tripleo-ci/+/815108/comment/4296e724_cd711118/ we will do that eventually this is just \u0027for now\u0027","commit_id":"f3035623bfbeaad0dee8a110e8c581db7d05d7c3"}],"zuul.d/build-image.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c1adf25e88b7cd642a5ed1205a65fc77d0379346","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            files: *build_images_files"},{"line_number":64,"context_line":"        - tripleo-buildimage-ironic-python-agent-centos-9:"},{"line_number":65,"context_line":"            files: *build_images_files"},{"line_number":66,"context_line":"        - tripleo-buildimage-ironic-python-agent-centos-9-wallaby:"},{"line_number":67,"context_line":"            files: *build_images_files"},{"line_number":68,"context_line":"        - tripleo-buildimage-overcloud-hardened-uefi-full-centos-9:"},{"line_number":69,"context_line":"            files: *build_images_hardened_uefi_files"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9bb6792c_d4054a4c","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":2},"updated":"2021-11-10 10:56:13.000000000","message":"k we cant wire up the -wallaby jobs yet :D","commit_id":"ec7092d9c7d2563783d622ba196c97828088c6a0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c1adf25e88b7cd642a5ed1205a65fc77d0379346","unresolved":true,"context_lines":[{"line_number":190,"context_line":"    name: tripleo-buildimage-overcloud-full-centos-9"},{"line_number":191,"context_line":"    parent: tripleo-build-images-base-centos-9"},{"line_number":192,"context_line":"    branches: ^(?!stable/(train|ussuri|victoria)).*$"},{"line_number":193,"context_line":"    vars:"},{"line_number":194,"context_line":"      tripleo_image_type: overcloud-full"},{"line_number":195,"context_line":"    irrelevant-files: *build_image_irrelevant"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"24b0ca41_13083e24","line":193,"range":{"start_line":193,"start_character":4,"end_line":193,"end_character":8},"updated":"2021-11-10 10:56:13.000000000","message":"and this one needs image_sanity: false for now\n\n(filing a bug for it and will update with note)","commit_id":"ec7092d9c7d2563783d622ba196c97828088c6a0"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"bcad88b9811ff59ecbd928b6e9c790abe6581fcf","unresolved":true,"context_lines":[{"line_number":177,"context_line":"- job:"},{"line_number":178,"context_line":"    name: tripleo-buildimage-overcloud-full-centos-9"},{"line_number":179,"context_line":"    parent: tripleo-build-images-base-centos-9"},{"line_number":180,"context_line":"    branches: ^(?!stable/(train|ussuri|victoria)).*$"},{"line_number":181,"context_line":"    vars:"},{"line_number":182,"context_line":"      tripleo_image_type: overcloud-full"},{"line_number":183,"context_line":"      image_sanity: false  # https://bugs.launchpad.net/tripleo/+bug/1950453"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"82281066_34062c58","line":180,"range":{"start_line":180,"start_character":4,"end_line":180,"end_character":52},"updated":"2021-11-12 10:47:20.000000000","message":"I am wondering why we have not added wallaby here?\n\nTo me looks like this job will now trigger on wallaby branch as well,  is that intended?\n\nI can see template tripleo-buildimage-jobs is also used in wallaby.\n\nhttps://opendev.org/openstack/python-tripleoclient/src/branch/stable/wallaby/zuul.d/layout.yaml\n\n\nI am sorry to ask this question here, I didn\u0027t get a chance to review: https://review.opendev.org/c/openstack/tripleo-ci/+/813618","commit_id":"f3035623bfbeaad0dee8a110e8c581db7d05d7c3"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"0589ac884800b53aae5a45547eee4e3a940618bc","unresolved":false,"context_lines":[{"line_number":177,"context_line":"- job:"},{"line_number":178,"context_line":"    name: tripleo-buildimage-overcloud-full-centos-9"},{"line_number":179,"context_line":"    parent: tripleo-build-images-base-centos-9"},{"line_number":180,"context_line":"    branches: ^(?!stable/(train|ussuri|victoria)).*$"},{"line_number":181,"context_line":"    vars:"},{"line_number":182,"context_line":"      tripleo_image_type: overcloud-full"},{"line_number":183,"context_line":"      image_sanity: false  # https://bugs.launchpad.net/tripleo/+bug/1950453"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"01c1a5c2_775c64b4","line":180,"range":{"start_line":180,"start_character":4,"end_line":180,"end_character":52},"in_reply_to":"640800f5_71327e18","updated":"2021-11-12 11:33:05.000000000","message":"Thanks for fixing that.","commit_id":"f3035623bfbeaad0dee8a110e8c581db7d05d7c3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a996ed008858645a1101997983456e9b652137ae","unresolved":true,"context_lines":[{"line_number":177,"context_line":"- job:"},{"line_number":178,"context_line":"    name: tripleo-buildimage-overcloud-full-centos-9"},{"line_number":179,"context_line":"    parent: tripleo-build-images-base-centos-9"},{"line_number":180,"context_line":"    branches: ^(?!stable/(train|ussuri|victoria)).*$"},{"line_number":181,"context_line":"    vars:"},{"line_number":182,"context_line":"      tripleo_image_type: overcloud-full"},{"line_number":183,"context_line":"      image_sanity: false  # https://bugs.launchpad.net/tripleo/+bug/1950453"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"640800f5_71327e18","line":180,"range":{"start_line":180,"start_character":4,"end_line":180,"end_character":52},"in_reply_to":"82281066_34062c58","updated":"2021-11-12 11:23:18.000000000","message":"yeah right we should fix that... eventually we will have it on wallaby but it isn\u0027t ready yet \n\nthis is why i removed them from the layout here i initially tried to include the wallaby jobs too) (2021-11-09 13:28:43.978830 | primary | Status code: 404 for https://trunk.rdoproject.org/centos9-wallaby/consistent/delorean.repo (IP: 3.87.151.16) https://454a18382356f65f474d-a314ed1e81fb229dd8553fdd3b9ca80f.ssl.cf1.rackcdn.com/815108/3/check/tripleo-buildimage-overcloud-full-centos-9-wallaby/9219e23/job-output.txt","commit_id":"f3035623bfbeaad0dee8a110e8c581db7d05d7c3"}]}