)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"be3eca190c1b014c8ad1712fc76ab380387836cd","unresolved":true,"context_lines":[{"line_number":12,"context_line":"job. Without this, if there is a promotion while the job is being"},{"line_number":13,"context_line":"executed, the upgrade job get this new hash, which isn\u0027t located in the"},{"line_number":14,"context_line":"content provider, and then the job fails."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I9e0162f88cf262957234bf946ad3c013f6213891"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"0be55960_ec2813d1","line":15,"updated":"2021-11-19 08:55:29.000000000","message":"have you tried testing this with e.g. tripleo-heat-templates change in stable/ussuri\n\ne.g. you can post a Do not merge in THT with depends-on this and see the undercloud-upgrade job running there?\n\ni think that should work","commit_id":"3ace56324ca71cc036abd1d13ae15751423d7329"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5bc5503700f75c1ee99c5758693c616c85ddeb05","unresolved":true,"context_lines":[{"line_number":12,"context_line":"job. Without this, if there is a promotion while the job is being"},{"line_number":13,"context_line":"executed, the upgrade job get this new hash, which isn\u0027t located in the"},{"line_number":14,"context_line":"content provider, and then the job fails."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I9e0162f88cf262957234bf946ad3c013f6213891"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"959eb7d3_07c7a01d","line":15,"in_reply_to":"0be55960_ec2813d1","updated":"2021-11-23 08:30:29.000000000","message":"worth a try before we merge? ^^","commit_id":"3ace56324ca71cc036abd1d13ae15751423d7329"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"2bdf4e0947d863130430b7046db6cbe2f04f1208","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Arx Cruz \u003carxcruz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-30 17:25:21 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Properly set the hash for undercloud upgrade jobs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the upgrade-hash-override to the emite releases file"},{"line_number":10,"context_line":"script in order to sync the hash contained in the content provider at"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"d79fab30_a9bc8b76","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":36},"updated":"2021-12-01 06:49:55.000000000","message":"Hello Arx,\n\nWill this patch just solve undercloud upgrade issue or standalone upgrade issues as well.\n\nI noticed standalone upgrade jobs are also facing a similiar issue, Or will we need a separate fix for standalone jobs?\n\n\nUndercloud upgrade:-\n\nhttps://57b5fc1045ae44193df2-2911fe45767baafe5d6c56a19a01c301.ssl.cf5.rackcdn.com/periodic/opendev.org/openstack/tripleo-heat-templates/stable/victoria/tripleo-ci-centos-8-undercloud-upgrade-victoria/414c937/logs/undercloud/home/zuul/undercloud_install.log\n~~~\np(upload_task, self.upload_tasks):\", \"  File \\\"/usr/lib64/python3.6/concurrent/futures/process.py\\\", line 366, in _chain_from_iterable_of_lists\", \"    for element in iterable:\", \"  File \\\"/usr/lib64/python3.6/concurrent/futures/_base.py\\\", line 586, in result_iterator\", \"    yield fs.pop().result()\", \"  File \\\"/usr/lib64/python3.6/concurrent/futures/_base.py\\\", line 432, in result\", \"    return self.__get_result()\", \"  File \\\"/usr/lib64/python3.6/concurrent/futures/_base.py\\\", line 384, in __get_result\", \"    raise self._exception\", \"tripleo_common.image.exception.ImageNotFoundException: Not found image: http://198.72.124.80:5001/v2/tripleou/centos-binary-haproxy/manifests/5351503355170bde37e91df01ce2a669\"], \"stdout\": \"\", \"stdout_lines\": []}\n~~~\n\nStandalone upgrade:-\n\nhttps://8010c4cd9c37fe11158f-99e30c61631357d52e091f75fecb0b32.ssl.cf5.rackcdn.com/periodic/opendev.org/openstack/tripleo-heat-templates/stable/victoria/tripleo-ci-centos-8-standalone-upgrade-victoria/4080cf2/logs/undercloud/home/zuul/standalone_deploy.log\n~~~\n2021-12-01 04:11:52.465740 | fa163e03-9e49-dd39-575d-000000000f8c |      FATAL | Pull 198.72.124.80:5001/tripleou/centos-binary-cinder-volume:5351503355170bde37e91df01ce2a669 image | standalone | error\u003d{\"changed\": true, \"cmd\": \"podman pull 198.72.124.80:5001/tripleou/centos-binary-cinder-volume:5351503355170bde37e91df01ce2a669\", \"delta\": \"0:00:00.570213\", \"end\": \"2021-12-01 04:11:52.426460\", \"msg\": \"non-zero return code\", \"rc\": 125, \"start\": \"2021-12-01 04:11:51.856247\", \"stderr\": \"Trying to pull 198.72.124.80:5001/tripleou/centos-binary-cinder-volume:5351503355170bde37e91df01ce2a669...\\n  manifest unknown: manifest unknown\\nError: Error initializing source docker://198.72.124.80:5001/tripleou/centos-binary-cinder-volume:5351503355170bde37e91df01ce2a669: Error reading manifest 5351503355170bde37e91df01ce2a669 in 198.72.124.80:5001/tripleou/centos-binary-cinder-volume: manifest unknown: manifest unknown\", \"stderr_lines\": [\"Trying to pull 198.72.124.80:5001/tripleou/centos-binary-cinder-volume:5351503355170bde37e91df01ce2a669...\", \"  manifest unknown: manifest unknown\", \"Error: Error initializing source docker://198.72.124.80:5001/tripleou/centos-binary-cinder-volume:5351503355170bde37e91df01ce2a669: Error reading manifest 5351503355170bde37e91df01ce2a669 in 198.72.124.80:5001/tripleou/centos-binary-cinder-volume: manifest unknown: manifest unknown\"], \"stdout\": \"\", \"stdout_lines\": []}\n~~~\n\n\nContent provider had older hash(current-tripleo when it was ran):-\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_78e/periodic/opendev.org/openstack/tripleo-heat-templates/stable/victoria/tripleo-ci-centos-8-content-provider-ussuri/78e79c7/logs/undercloud/home/zuul/workspace/containers-built.log\n~~~\n127.0.0.1:5001/tripleou/centos-binary-haproxy                      1bb1ad8e9ae22b1e79883af13f9b9d16              0f8aa98a7c98   About an hour ago   656 MB\n~~~\n\nUssuri was promotion during that time:-\n~~~\nrr --release ussuri\nHash under test: https://trunk.rdoproject.org/api-centos8-ussuri/api/civotes_agg_detail.html?ref_hash\u003d5351503355170bde37e91df01ce2a669 \nlast_promotion\u003d2021-12-01 03:14:02\n~~~\n\nold hash - https://trunk.rdoproject.org/centos8-ussuri/previous-current-tripleo/delorean.repo.md5 - 1bb1ad8e9ae22b1e79883af13f9b9d16\nnew hash - https://trunk.rdoproject.org/centos8-ussuri/current-tripleo/delorean.repo.md5 - 5351503355170bde37e91df01ce2a669","commit_id":"ed5ae2be3c35ae88a38c4275db9c53cc240812f7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3763d2f1b933d605cc2059e37fa0d5dd674da80e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Arx Cruz \u003carxcruz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-30 17:25:21 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Properly set the hash for undercloud upgrade jobs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the upgrade-hash-override to the emite releases file"},{"line_number":10,"context_line":"script in order to sync the hash contained in the content provider at"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"70068e37_2db5609c","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":36},"in_reply_to":"d79fab30_a9bc8b76","updated":"2021-12-01 08:10:01.000000000","message":"see inline Sandeep\nthe change is specific to the undercloud upgrade you\u0027d need a followup for the standalone","commit_id":"ed5ae2be3c35ae88a38c4275db9c53cc240812f7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"83edcd9072905429d671c3264f5f210e11526a8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e9f5af6e_54d0c0fa","updated":"2021-11-08 17:45:33.000000000","message":"I saw that is still WIP, but adding some comments inline already :P","commit_id":"2032fbb20a593c36dbf74e1581007f6438ab02c1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6408430b7525f7289bb8ad8819b4c4be10b8ea57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98415ced_e6aed232","updated":"2021-11-10 07:55:51.000000000","message":"looks like it is going in the right direction Arx some inline comments for your consideration thanks","commit_id":"2032fbb20a593c36dbf74e1581007f6438ab02c1"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"7c390247d79feee54876f52dae055909fbd0edcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"95552169_d8af3ccc","updated":"2021-11-17 13:36:00.000000000","message":"So, it is being very hard to test it either on testproject or in upstream with a dnm patch.\n\nThe patch is applied on content-provider job as can be noticed here:\n\nhttps://logserver.rdoproject.org/36/36136/7/check/tripleo-ci-centos-8-content-provider/c42fb57/job-output.txt \n\nJust search for \"Print out the change\"\n\nHowever, in content-provider job it doesn\u0027t have the provider_dlrn_hash_branch[release] variable, so it doesn\u0027t have any effect.\n\nOn the upgrade job, this patch doesn\u0027t work, because upgrade doesn\u0027t execute the build-test-package role.\n\nAs it is right now, it\u0027s very hard to test this kind of changes because of this. If we run the build-test-package, the content-provider job isn\u0027t used, and we need to have it in order to test.\n\nI would suggest to merge as it is, and in case this doesn\u0027t work, revert.","commit_id":"0bfb66e08b330f5a7d6864c68ecd0550377f9745"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e453fb3d20ee80ccd7e9c07a31ecbe9b32f7ffbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aa671c48_002d3aa9","updated":"2021-11-19 08:55:55.000000000","message":"obligatory -1 because of the inline nits that zuul pointed out already","commit_id":"3ace56324ca71cc036abd1d13ae15751423d7329"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5bc5503700f75c1ee99c5758693c616c85ddeb05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6b06ffee_e68730e6","updated":"2021-11-23 08:30:29.000000000","message":"arx please see inline comments - can we use env lookup for the bash variables?\nalso see comment about trying to test this with tripleo-heat-templates and depends-on this? it can be master tht we have the undercloud-upgrade job on master ... if the branches is a problem","commit_id":"af29a9deaecff368d5810c8940bb8d09a8bdfd1f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"985dc274cba1075e15c8c09c0a58fe15257b1195","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4622fcaa_652d67d3","updated":"2021-11-24 06:59:05.000000000","message":"looks good arx but I think inline nit you need the other one","commit_id":"bef667b46ca038a6c0f489436f541847509c44df"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3763d2f1b933d605cc2059e37fa0d5dd674da80e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"06cda2bb_5021bf7f","updated":"2021-12-01 08:10:01.000000000","message":"@Arx did you try the depends on from tripleo-heat-templates? ","commit_id":"ed5ae2be3c35ae88a38c4275db9c53cc240812f7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8d39013f264fea8c448faa3c4c7bee5d3827283c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"095f6aa4_11e45384","updated":"2021-12-01 08:10:13.000000000","message":"lgtm but waiting to hear about testing","commit_id":"ed5ae2be3c35ae88a38c4275db9c53cc240812f7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ddd5fd0bd7003e793780774b019d10d190d40007","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8a0f6979_267b82b2","updated":"2021-12-02 08:06:35.000000000","message":"please see previous comments - mainly did you try posting a DNM patch from tripleo-heat-templates to test the undercloud upgrade job?\n\n","commit_id":"91b36d8fe364627bdcbf2e73cd7ed1882e4b2bff"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"c6c4f9089451ffc7d1dda663e065a111aec2e792","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8b003aec_b5470c25","updated":"2021-12-02 10:35:23.000000000","message":"tests on https://review.opendev.org/c/openstack/tripleo-quickstart/+/818078","commit_id":"e78e0bcd0ef004ed35262017e6a950458cd56b7b"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"28444d6a61a74e2b638fbbabcef9d6fa48e22f52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"229ca37e_08556aeb","updated":"2021-12-15 00:56:35.000000000","message":"looks good from test results. ","commit_id":"151e5d72726da505506d4c5d2b315903695c30b3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"199f53afaae2f5a30fe54be0bdf3c57b348e8b54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e62c2897_84e8b610","updated":"2021-12-14 15:13:18.000000000","message":"test looks good there https://review.rdoproject.org/r/c/testproject/+/37144/2#message-a17dedf7719520e6c68697ac973184fc73f1e981\n\n        * https://logserver.rdoproject.org/44/37144/2/check/tripleo-ci-centos-8-undercloud-upgrade/55489ae/logs/quickstart_files/emit_releases_file.log\n\t\tUsing hash override c167f95a3640d3950756d193c0a3dc25 for branch master\n\t\tDoing an undercloud upgrade\n\t\tUsing hash override 4a9f570662f801b4340cb5e257eb6b5f for branch wallaby\n\n        * https://logserver.rdoproject.org/44/37144/2/check/tripleo-ci-centos-8-undercloud-upgrade/55489ae/logs/quickstart_files/releases.sh\n\t\texport UNDERCLOUD_INSTALL_RELEASE\u003d\"wallaby\"\n\t\texport UNDERCLOUD_INSTALL_HASH\u003d\"4a9f570662f801b4340cb5e257eb6b5f\"\n\t\texport UNDERCLOUD_TARGET_RELEASE\u003d\"master\"\n\t\texport UNDERCLOUD_TARGET_HASH\u003d\"c167f95a3640d3950756d193c0a3dc25\"\n\n        * https://logserver.rdoproject.org/44/37144/2/check/tripleo-ci-centos-8-undercloud-upgrade/55489ae/zuul-info/inventory.yaml\n\t\tprovider_dlrn_hash_tag_branch: \u0026id005\n\t\t\tmaster: c167f95a3640d3950756d193c0a3dc25\n\t\t\twallaby: 4a9f570662f801b4340cb5e257eb6b5f\n","commit_id":"151e5d72726da505506d4c5d2b315903695c30b3"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"42a0fa3365543a0ceb90757049ac5bfb9f804c0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"4ee7a63e_e18f69bb","in_reply_to":"e62c2897_84e8b610","updated":"2021-12-15 11:05:41.000000000","message":"thanks!","commit_id":"151e5d72726da505506d4c5d2b315903695c30b3"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"f3e8fe7b20e68fd2c9d36a3b16b94e27dcc07bfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"09d97a85_609670b0","updated":"2021-12-17 00:05:56.000000000","message":"This looks better - thanks!\nwould prefer to merge this on monday so we can watch the damage.","commit_id":"4a6b1f0bcf57816890f36c3a6c385bfae9fd1965"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1cb39ae4e8a03defbd999c361cabfa3d5c22c309","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ee9b19fe_4d73a3a1","updated":"2021-12-17 07:47:52.000000000","message":"Will wait for more people to vote then +w","commit_id":"4a6b1f0bcf57816890f36c3a6c385bfae9fd1965"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"1b80f63653e2bed1f7cce714f0eff37dddbe06e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"70ce8bc4_7ed72f16","updated":"2021-12-16 12:45:38.000000000","message":"recheck","commit_id":"4a6b1f0bcf57816890f36c3a6c385bfae9fd1965"}],"roles/run-test/tasks/main.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ddd5fd0bd7003e793780774b019d10d190d40007","unresolved":true,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"      # Upgrade jobs"},{"line_number":147,"context_line":"      export DLRN_HASH_TAG_ZUUL\u003d{{ zuul.provider_dlrn_hash_tag_branch[release] | default(\u0027Not available\u0027) }}"},{"line_number":148,"context_line":"      export DLRN_HASH_TAG_JOB\u003d{{ job.provider_dlrn_hash_tag_branch[release] | default(\u0027Not available\u0027) }}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"      export BRANCH_OVERRIDE\u003d\"{{ branch_override | default(\u0027default\u0027) }}\""},{"line_number":151,"context_line":"      if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5cddd1e8_74c88e33","line":148,"updated":"2021-12-02 08:06:35.000000000","message":"what are these where are they used ?","commit_id":"91b36d8fe364627bdcbf2e73cd7ed1882e4b2bff"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"c6c4f9089451ffc7d1dda663e065a111aec2e792","unresolved":true,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"      # Upgrade jobs"},{"line_number":147,"context_line":"      export DLRN_HASH_TAG_ZUUL\u003d{{ zuul.provider_dlrn_hash_tag_branch[release] | default(\u0027Not available\u0027) }}"},{"line_number":148,"context_line":"      export DLRN_HASH_TAG_JOB\u003d{{ job.provider_dlrn_hash_tag_branch[release] | default(\u0027Not available\u0027) }}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"      export BRANCH_OVERRIDE\u003d\"{{ branch_override | default(\u0027default\u0027) }}\""},{"line_number":151,"context_line":"      if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"6923edb6_de68a522","line":148,"in_reply_to":"5cddd1e8_74c88e33","updated":"2021-12-02 10:35:23.000000000","message":"Sorry, this was a test that was supposed to be on another patch.\nThe test is being executed at https://review.opendev.org/c/openstack/tripleo-quickstart/+/818078","commit_id":"91b36d8fe364627bdcbf2e73cd7ed1882e4b2bff"}],"roles/run-test/templates/toci_gate_test.sh.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6408430b7525f7289bb8ad8819b4c4be10b8ea57","unresolved":true,"context_lines":[{"line_number":6,"context_line":"export START_JOB_TIME\u003d$(date +%s)"},{"line_number":7,"context_line":"export PS4\u003d\u0027+(${BASH_SOURCE}:${LINENO}): ${FUNCNAME[0]:+${FUNCNAME[0]}(): }\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"source $TRIPLEO_ROOT/tripleo-ci/scripts/oooq_common_functions.sh"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"if [ -f /etc/nodepool/provider ] ; then"},{"line_number":12,"context_line":"    # this sets"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffbad1b7_870cdc03","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":61},"updated":"2021-11-10 07:55:51.000000000","message":"why not try using the function there https://opendev.org/openstack/tripleo-ci/src/commit/e6a036545aa0d3dd543562703b0f87f3267dacd2/roles/run-test/templates/oooq_common_functions.sh.j2#L1\n\nit should be included with this source statement","commit_id":"2032fbb20a593c36dbf74e1581007f6438ab02c1"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"344e2590120fff9661f107336b04953ef1a06e0b","unresolved":true,"context_lines":[{"line_number":6,"context_line":"export START_JOB_TIME\u003d$(date +%s)"},{"line_number":7,"context_line":"export PS4\u003d\u0027+(${BASH_SOURCE}:${LINENO}): ${FUNCNAME[0]:+${FUNCNAME[0]}(): }\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"source $TRIPLEO_ROOT/tripleo-ci/scripts/oooq_common_functions.sh"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"if [ -f /etc/nodepool/provider ] ; then"},{"line_number":12,"context_line":"    # this sets"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"cc25e73f_884b3dc5","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":61},"in_reply_to":"ffbad1b7_870cdc03","updated":"2021-11-10 18:54:13.000000000","message":"Yes, I could, but I can\u0027t parse this information to job.provider_dlrn_hash_tag_branch[release] at least I don\u0027t know how.","commit_id":"2032fbb20a593c36dbf74e1581007f6438ab02c1"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"83edcd9072905429d671c3264f5f210e11526a8c","unresolved":true,"context_lines":[{"line_number":112,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --is-periodic\""},{"line_number":113,"context_line":"{% endif %}"},{"line_number":114,"context_line":"{% if job is defined %}"},{"line_number":115,"context_line":"  {% set list_releases \u003d [\u0027train\u0027, \u0027ussuri\u0027, \u0027victoria\u0027, \u0027wallaby\u0027, \u0027xena\u0027, \u0027master\u0027] %}"},{"line_number":116,"context_line":"  {% if release in list_releases %}"},{"line_number":117,"context_line":"    {% set previous_release \u003d list_releases.index(release)-1 %}"},{"line_number":118,"context_line":"  {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"79723a8d_8cc4c0ad","line":115,"range":{"start_line":115,"start_character":69,"end_line":115,"end_character":73},"updated":"2021-11-08 17:45:33.000000000","message":"we don\u0027t have xena release, right?","commit_id":"2032fbb20a593c36dbf74e1581007f6438ab02c1"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"344e2590120fff9661f107336b04953ef1a06e0b","unresolved":true,"context_lines":[{"line_number":112,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --is-periodic\""},{"line_number":113,"context_line":"{% endif %}"},{"line_number":114,"context_line":"{% if job is defined %}"},{"line_number":115,"context_line":"  {% set list_releases \u003d [\u0027train\u0027, \u0027ussuri\u0027, \u0027victoria\u0027, \u0027wallaby\u0027, \u0027xena\u0027, \u0027master\u0027] %}"},{"line_number":116,"context_line":"  {% if release in list_releases %}"},{"line_number":117,"context_line":"    {% set previous_release \u003d list_releases.index(release)-1 %}"},{"line_number":118,"context_line":"  {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"de873b84_497ec922","line":115,"range":{"start_line":115,"start_character":69,"end_line":115,"end_character":73},"in_reply_to":"61dbd4b9_5c465e28","updated":"2021-11-10 18:54:13.000000000","message":"Removing xena","commit_id":"2032fbb20a593c36dbf74e1581007f6438ab02c1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6408430b7525f7289bb8ad8819b4c4be10b8ea57","unresolved":true,"context_lines":[{"line_number":112,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --is-periodic\""},{"line_number":113,"context_line":"{% endif %}"},{"line_number":114,"context_line":"{% if job is defined %}"},{"line_number":115,"context_line":"  {% set list_releases \u003d [\u0027train\u0027, \u0027ussuri\u0027, \u0027victoria\u0027, \u0027wallaby\u0027, \u0027xena\u0027, \u0027master\u0027] %}"},{"line_number":116,"context_line":"  {% if release in list_releases %}"},{"line_number":117,"context_line":"    {% set previous_release \u003d list_releases.index(release)-1 %}"},{"line_number":118,"context_line":"  {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"61dbd4b9_5c465e28","line":115,"range":{"start_line":115,"start_character":69,"end_line":115,"end_character":73},"in_reply_to":"79723a8d_8cc4c0ad","updated":"2021-11-10 07:55:51.000000000","message":"+1 to this\nbut more generally please see the comment above... can you not re-use the existing function rather than carrying this new list here?","commit_id":"2032fbb20a593c36dbf74e1581007f6438ab02c1"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"83edcd9072905429d671c3264f5f210e11526a8c","unresolved":true,"context_lines":[{"line_number":114,"context_line":"{% if job is defined %}"},{"line_number":115,"context_line":"  {% set list_releases \u003d [\u0027train\u0027, \u0027ussuri\u0027, \u0027victoria\u0027, \u0027wallaby\u0027, \u0027xena\u0027, \u0027master\u0027] %}"},{"line_number":116,"context_line":"  {% if release in list_releases %}"},{"line_number":117,"context_line":"    {% set previous_release \u003d list_releases.index(release)-1 %}"},{"line_number":118,"context_line":"  {% endif %}"},{"line_number":119,"context_line":"  {% if job.provider_dlrn_hash_tag_branch[release] | default(omit) %}"},{"line_number":120,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[release] }}\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5bc2c78b_7409ea75","line":117,"range":{"start_line":117,"start_character":11,"end_line":117,"end_character":27},"updated":"2021-11-08 17:45:33.000000000","message":"this will give you the index number, not the release name, right? which will error in L122?","commit_id":"2032fbb20a593c36dbf74e1581007f6438ab02c1"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"344e2590120fff9661f107336b04953ef1a06e0b","unresolved":true,"context_lines":[{"line_number":114,"context_line":"{% if job is defined %}"},{"line_number":115,"context_line":"  {% set list_releases \u003d [\u0027train\u0027, \u0027ussuri\u0027, \u0027victoria\u0027, \u0027wallaby\u0027, \u0027xena\u0027, \u0027master\u0027] %}"},{"line_number":116,"context_line":"  {% if release in list_releases %}"},{"line_number":117,"context_line":"    {% set previous_release \u003d list_releases.index(release)-1 %}"},{"line_number":118,"context_line":"  {% endif %}"},{"line_number":119,"context_line":"  {% if job.provider_dlrn_hash_tag_branch[release] | default(omit) %}"},{"line_number":120,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[release] }}\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"2f4034da_b7fa0f56","line":117,"range":{"start_line":117,"start_character":11,"end_line":117,"end_character":27},"in_reply_to":"5bc2c78b_7409ea75","updated":"2021-11-10 18:54:13.000000000","message":"You are right, fixing it","commit_id":"2032fbb20a593c36dbf74e1581007f6438ab02c1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9a93067176d0a67e59c4f906fd90d98c5cdd1bfe","unresolved":true,"context_lines":[{"line_number":112,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --is-periodic\""},{"line_number":113,"context_line":"{% endif %}"},{"line_number":114,"context_line":"{% if job is defined %}"},{"line_number":115,"context_line":"  {% set list_releases \u003d [\u0027train\u0027, \u0027ussuri\u0027, \u0027victoria\u0027, \u0027wallaby\u0027, \u0027master\u0027] %}"},{"line_number":116,"context_line":"  {% if release in list_releases %}"},{"line_number":117,"context_line":"    {% set previous_release \u003d list_releases.index(release)-1 %}"},{"line_number":118,"context_line":"  {% endif %}"},{"line_number":119,"context_line":"  {% if job.provider_dlrn_hash_tag_branch[release] | default(omit) %}"},{"line_number":120,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[release] }}\""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"a766f1df_b556b614","line":117,"range":{"start_line":115,"start_character":9,"end_line":117,"end_character":19},"updated":"2021-11-18 09:29:00.000000000","message":"i don\u0027t understand why you can\u0027t use the existing previous_release_from function? It is used on line 105 above. Instead of working out previous_release yourself like here. I made a similar comment earlier https://review.opendev.org/c/openstack/tripleo-ci/+/802616/2#message-be6000c6261fe065e8e223883569a0d1f1095db7","commit_id":"00ec1ee8e77b341e318a15a8e029fee2df40793a"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"680d437356cf4f1bf6ef74009d655a12fb95aa56","unresolved":true,"context_lines":[{"line_number":112,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --is-periodic\""},{"line_number":113,"context_line":"{% endif %}"},{"line_number":114,"context_line":"{% if job is defined %}"},{"line_number":115,"context_line":"  {% set list_releases \u003d [\u0027train\u0027, \u0027ussuri\u0027, \u0027victoria\u0027, \u0027wallaby\u0027, \u0027master\u0027] %}"},{"line_number":116,"context_line":"  {% if release in list_releases %}"},{"line_number":117,"context_line":"    {% set previous_release \u003d list_releases.index(release)-1 %}"},{"line_number":118,"context_line":"  {% endif %}"},{"line_number":119,"context_line":"  {% if job.provider_dlrn_hash_tag_branch[release] | default(omit) %}"},{"line_number":120,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[release] }}\""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"4f8b0cf5_fbe21c08","line":117,"range":{"start_line":115,"start_character":9,"end_line":117,"end_character":19},"in_reply_to":"a766f1df_b556b614","updated":"2021-11-18 09:58:24.000000000","message":"Because you can\u0027t use the shell variable in the jinja template:\n\n$release \u003d $(previous_release_from \"${STABLE_RELEASE}\")\n\nThen, you can\u0027t do this to get the hash:\n\njob.provider_dlrn_hash_tag_branch[$(release)]","commit_id":"00ec1ee8e77b341e318a15a8e029fee2df40793a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"be3eca190c1b014c8ad1712fc76ab380387836cd","unresolved":true,"context_lines":[{"line_number":114,"context_line":"{% if job is defined %}"},{"line_number":115,"context_line":"  {% set list_releases \u003d [\u0027train\u0027, \u0027ussuri\u0027, \u0027victoria\u0027, \u0027wallaby\u0027, \u0027master\u0027] %}"},{"line_number":116,"context_line":"  {% if release in list_releases %}"},{"line_number":117,"context_line":"    {% set previous_release \u003d list_releases.index(release)-1 %}"},{"line_number":118,"context_line":"  {% endif %}"},{"line_number":119,"context_line":"  {% if job.provider_dlrn_hash_tag_branch[release] | default(omit) %}"},{"line_number":120,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --target-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[release] }}\""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ece4549b_01395766","line":117,"updated":"2021-11-19 08:55:29.000000000","message":"so we already have the previous release from lines 99-101 above ie.\n\n    export UPGRADE_RELEASE\u003d$QUICKSTART_RELEASE\n    export QUICKSTART_RELEASE\u003d$(previous_release_mixed_upgrade_case \"${UPGRADE_RELEASE}\")\n\nso the problem we need to solve is:\n\nEMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --target-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[$UPGRADE_RELEASE }}\"\n\u0026\nEMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --install-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[list_releases[$QUICKSTART_RELEASE]] }}\"\n\ni.e. can we pass the bash vars UPGRADE_RELEASE and QUICKSTART_RELEASE into the jinja/python?","commit_id":"3ace56324ca71cc036abd1d13ae15751423d7329"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5bc5503700f75c1ee99c5758693c616c85ddeb05","unresolved":true,"context_lines":[{"line_number":117,"context_line":"    {% set previous_release \u003d list_releases.index(release)-1 %}"},{"line_number":118,"context_line":"  {% endif %}"},{"line_number":119,"context_line":"  {% if job.provider_dlrn_hash_tag_branch[release] | default(omit) %}"},{"line_number":120,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --target-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[release] }}\""},{"line_number":121,"context_line":"  {% endif %}"},{"line_number":122,"context_line":"  {% if previous_release is defined and job.provider_dlrn_hash_tag_branch[list_releases[previous_release]] | default(omit) %}"},{"line_number":123,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --install-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[list_releases[previous_release]] }}\""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"28d0040a_365dff98","line":120,"range":{"start_line":120,"start_character":112,"end_line":120,"end_character":119},"updated":"2021-11-23 08:30:29.000000000","message":"how about something like:\n\n{{ job.provider_dlrn_hash_tag_branch[lookup(\u0027env\u0027, UPGRADE_RELEASE)] }} \n\n?\n\nas commented previously at https://review.opendev.org/c/openstack/tripleo-ci/+/816991/comment/ece4549b_01395766/   we already have those vars in bash on lines 99/101 above it already works out what the previous release is and stores it into QUICKSTART_RELEASE.","commit_id":"af29a9deaecff368d5810c8940bb8d09a8bdfd1f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5bc5503700f75c1ee99c5758693c616c85ddeb05","unresolved":true,"context_lines":[{"line_number":120,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --target-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[release] }}\""},{"line_number":121,"context_line":"  {% endif %}"},{"line_number":122,"context_line":"  {% if previous_release is defined and job.provider_dlrn_hash_tag_branch[list_releases[previous_release]] | default(omit) %}"},{"line_number":123,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --install-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[list_releases[previous_release]] }}\""},{"line_number":124,"context_line":"  {% endif %}"},{"line_number":125,"context_line":"{% endif %}"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"d545732b_0eb84a1d","line":123,"range":{"start_line":123,"start_character":113,"end_line":123,"end_character":143},"updated":"2021-11-23 08:30:29.000000000","message":"{{ job.provider_dlrn_hash_tag_branch[lookup(\u0027env\u0027, $QUICKSTART_RELEASE] }}\n\nI am not sure if you will need to add an \u0027export QUICKSTART_RELEASE\u003d$QUICKSTART_RELEASE\u0027.... the UPGRADE_RELEASE is already \u0027exported\u0027 on line 105 above.","commit_id":"af29a9deaecff368d5810c8940bb8d09a8bdfd1f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"985dc274cba1075e15c8c09c0a58fe15257b1195","unresolved":true,"context_lines":[{"line_number":113,"context_line":"{% endif %}"},{"line_number":114,"context_line":"{% if job is defined %}"},{"line_number":115,"context_line":"  {% if job.provider_dlrn_hash_tag_branch[release] | default(omit) %}"},{"line_number":116,"context_line":"  EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --target-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[release] }}\""},{"line_number":117,"context_line":"  {% endif %}"},{"line_number":118,"context_line":"  {% if job.provider_dlrn_hash_tag_branch[lookup(\u0027env\u0027, \u0027UPGRADE_RELEASE\u0027)] | default(omit) %}"},{"line_number":119,"context_line":"  EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --install-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[lookup(\u0027env\u0027, \u0027UPGRADE_RELEASE\u0027)] }}\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5998b5cf_c47320d2","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":2},"updated":"2021-11-24 06:59:05.000000000","message":"don\u0027t think it should matter since it is bash but the if here is jinja so there should be no indent required here","commit_id":"bef667b46ca038a6c0f489436f541847509c44df"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"985dc274cba1075e15c8c09c0a58fe15257b1195","unresolved":true,"context_lines":[{"line_number":116,"context_line":"  EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --target-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[release] }}\""},{"line_number":117,"context_line":"  {% endif %}"},{"line_number":118,"context_line":"  {% if job.provider_dlrn_hash_tag_branch[lookup(\u0027env\u0027, \u0027UPGRADE_RELEASE\u0027)] | default(omit) %}"},{"line_number":119,"context_line":"  EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --install-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[lookup(\u0027env\u0027, \u0027UPGRADE_RELEASE\u0027)] }}\""},{"line_number":120,"context_line":"  {% endif %}"},{"line_number":121,"context_line":"{% endif %}"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5b411218_7fe49d55","line":119,"range":{"start_line":119,"start_character":130,"end_line":119,"end_character":145},"updated":"2021-11-24 06:59:05.000000000","message":"i think this one should be QUICKSTART_RELEASE? This one is the *install* version right not the *upgrade*/*target* version the one we are going to.\n\nif you check line 101 above it is QUICKSTART_RELEASE which has the result of previous_release_from","commit_id":"bef667b46ca038a6c0f489436f541847509c44df"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ce394cf567970fa1546dcda59c417ed74a6499c1","unresolved":true,"context_lines":[{"line_number":116,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --target-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[release] }}\""},{"line_number":117,"context_line":"  {% endif %}"},{"line_number":118,"context_line":"  {% if job.provider_dlrn_hash_tag_branch[lookup(\u0027env\u0027, \u0027QUICKSTART_RELEASE\u0027)] | default(omit) %}"},{"line_number":119,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --install-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[lookup(\u0027env\u0027, \u0027UPGRADE_RELEASE\u0027)] }}\""},{"line_number":120,"context_line":"  {% endif %}"},{"line_number":121,"context_line":"{% endif %}"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"00e005f9_deb0a32b","line":119,"range":{"start_line":119,"start_character":128,"end_line":119,"end_character":143},"updated":"2021-11-30 08:16:21.000000000","message":"QUICKSTART_RELEASE here too","commit_id":"6b3fb93c78541ea1f38d7a9bc470811e66fde0ac"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"785dae2c5416df14405ed42566a0a12a51b91110","unresolved":false,"context_lines":[{"line_number":116,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --target-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[release] }}\""},{"line_number":117,"context_line":"  {% endif %}"},{"line_number":118,"context_line":"  {% if job.provider_dlrn_hash_tag_branch[lookup(\u0027env\u0027, \u0027QUICKSTART_RELEASE\u0027)] | default(omit) %}"},{"line_number":119,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --install-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[lookup(\u0027env\u0027, \u0027UPGRADE_RELEASE\u0027)] }}\""},{"line_number":120,"context_line":"  {% endif %}"},{"line_number":121,"context_line":"{% endif %}"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"f4f4d49b_0664143a","line":119,"range":{"start_line":119,"start_character":128,"end_line":119,"end_character":143},"in_reply_to":"00e005f9_deb0a32b","updated":"2021-11-30 16:25:39.000000000","message":"Done","commit_id":"6b3fb93c78541ea1f38d7a9bc470811e66fde0ac"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1b027b3b9fa87465d55ffdd4c53982b710090858","unresolved":true,"context_lines":[{"line_number":115,"context_line":"  {% if job.provider_dlrn_hash_tag_branch[release] | default(omit) %}"},{"line_number":116,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --target-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[release] }}\""},{"line_number":117,"context_line":"  {% endif %}"},{"line_number":118,"context_line":"  {% if job.provider_dlrn_hash_tag_branch[lookup(\u0027env\u0027, \u0027QUICKSTART_RELEASE\u0027)] | default(omit) %}"},{"line_number":119,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --install-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[lookup(\u0027env\u0027, \u0027QUICKSTART_RELEASE\u0027)] }}\""},{"line_number":120,"context_line":"  {% endif %}"},{"line_number":121,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ac77b773_a3d27fff","line":118,"range":{"start_line":118,"start_character":42,"end_line":118,"end_character":53},"updated":"2021-12-09 12:38:43.000000000","message":"we can\u0027t use lookup\u0027env\u0027 here \n\nhttps://aceef6c1526cbdb83fa6-ecaf6f24685cfabe89c3e9d8fac0dfc4.ssl.cf5.rackcdn.com/819645/5/check/tripleo-ci-centos-8-content-provider/cfcb4a7/job-output.txt\n\n2021-12-03 12:30:51.895504 | TASK [run-test : run toci_gate_test.sh]\n2021-12-03 12:31:03.265995 | primary | ERROR\n2021-12-03 12:31:03.267231 | primary | {\n2021-12-03 12:31:03.267347 | primary |   \"msg\": \"An unhandled exception occurred while running the lookup plugin \u0027env\u0027. Error was a \u003cclass \u0027ansible.errors.AnsibleError\u0027\u003e, original message: Use of lookup modules that perform local actions on the executor is forbidden.\"\n2021-12-03 12:31:03.267444 | primary | }\n\nwe can try ansible_env as an altervative","commit_id":"e78e0bcd0ef004ed35262017e6a950458cd56b7b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"87af86cea468f07dc58ff174b17fda450d49f1a5","unresolved":true,"context_lines":[{"line_number":115,"context_line":"  {% if job.provider_dlrn_hash_tag_branch[release] | default(omit) %}"},{"line_number":116,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --target-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[release] }}\""},{"line_number":117,"context_line":"  {% endif %}"},{"line_number":118,"context_line":"  {% if job.provider_dlrn_hash_tag_branch[lookup(\u0027env\u0027, \u0027QUICKSTART_RELEASE\u0027)] | default(omit) %}"},{"line_number":119,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --install-hash-override\u003d{{ job.provider_dlrn_hash_tag_branch[lookup(\u0027env\u0027, \u0027QUICKSTART_RELEASE\u0027)] }}\""},{"line_number":120,"context_line":"  {% endif %}"},{"line_number":121,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"4e4c0aa0_8b1c9b2c","line":118,"range":{"start_line":118,"start_character":42,"end_line":118,"end_character":53},"in_reply_to":"ac77b773_a3d27fff","updated":"2021-12-09 15:18:33.000000000","message":"actually... i think this just applied to the task at https://review.opendev.org/c/openstack/tripleo-ci/+/819645 which is run natively... for this stuff we should be OK (nested ansible) to use lookup.","commit_id":"e78e0bcd0ef004ed35262017e6a950458cd56b7b"}],"scripts/emit_releases_file/emit_releases_file.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6408430b7525f7289bb8ad8819b4c4be10b8ea57","unresolved":true,"context_lines":[{"line_number":303,"context_line":"        logger.info(\u0027Doing an undercloud upgrade\u0027)"},{"line_number":304,"context_line":"        install_release \u003d get_relative_release(stable_release, -1)"},{"line_number":305,"context_line":"        install_hash \u003d \u0027\u0027"},{"line_number":306,"context_line":"        if upgrade_hash_override:"},{"line_number":307,"context_line":"            install_hash \u003d upgrade_hash_override"},{"line_number":308,"context_line":"        else:"},{"line_number":309,"context_line":"            install_hash \u003d get_dlrn_hash("}],"source_content_type":"text/x-python","patch_set":1,"id":"6b5e78b8_41ba44be","line":306,"range":{"start_line":306,"start_character":0,"end_line":306,"end_character":1},"updated":"2021-11-10 07:55:51.000000000","message":"this bit looks OK","commit_id":"2032fbb20a593c36dbf74e1581007f6438ab02c1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6408430b7525f7289bb8ad8819b4c4be10b8ea57","unresolved":true,"context_lines":[{"line_number":502,"context_line":"        args.is_periodic,"},{"line_number":503,"context_line":"        args.distro_name,"},{"line_number":504,"context_line":"        args.distro_version,"},{"line_number":505,"context_line":"        args.hash_override,"},{"line_number":506,"context_line":"        args.upgrade_hash_override,"},{"line_number":507,"context_line":"    )"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    releases_dictionary \u003d shim_convert_old_release_names("}],"source_content_type":"text/x-python","patch_set":1,"id":"d71c19e9_f9e761d6","line":506,"range":{"start_line":505,"start_character":13,"end_line":506,"end_character":34},"updated":"2021-11-10 07:55:51.000000000","message":"can you consider using more descriptive names for both of these \n\ne.g. \u0027install_hash_override\u0027 and \u0027target_hash_override\u0027 or something similar","commit_id":"2032fbb20a593c36dbf74e1581007f6438ab02c1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9a93067176d0a67e59c4f906fd90d98c5cdd1bfe","unresolved":true,"context_lines":[{"line_number":485,"context_line":"    )"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    parser.add_argument("},{"line_number":488,"context_line":"        \u0027--upgrade-hash-override\u0027,"},{"line_number":489,"context_line":"        help\u003d\u0027Force an specific hash instead of release - 1\u0027,"},{"line_number":490,"context_line":"    )"},{"line_number":491,"context_line":"    args \u003d parser.parse_args()"}],"source_content_type":"text/x-python","patch_set":3,"id":"63dcee34_9419d7a4","line":488,"range":{"start_line":488,"start_character":8,"end_line":488,"end_character":11},"updated":"2021-11-18 09:29:00.000000000","message":"please lets change the names though as it is now confusing  - the names are doing the opposite of what they suggest. \n\nwe are using --hash-override to specify the *target* hash (i.e. \u0027release\u0027) and --upgrade-hash-override to specify the *install* hash (i.e. release -1 ). for me the upgrade-hash-override should be the target i.e. the version we\u0027re going to, not the one we install first and upgrade from. \n\nlets make them explicit like --install-hash-override and --target-hash-override","commit_id":"00ec1ee8e77b341e318a15a8e029fee2df40793a"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"680d437356cf4f1bf6ef74009d655a12fb95aa56","unresolved":false,"context_lines":[{"line_number":485,"context_line":"    )"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    parser.add_argument("},{"line_number":488,"context_line":"        \u0027--upgrade-hash-override\u0027,"},{"line_number":489,"context_line":"        help\u003d\u0027Force an specific hash instead of release - 1\u0027,"},{"line_number":490,"context_line":"    )"},{"line_number":491,"context_line":"    args \u003d parser.parse_args()"}],"source_content_type":"text/x-python","patch_set":3,"id":"a66ffdd2_072ed6ff","line":488,"range":{"start_line":488,"start_character":8,"end_line":488,"end_character":11},"in_reply_to":"63dcee34_9419d7a4","updated":"2021-11-18 09:58:24.000000000","message":"Done","commit_id":"00ec1ee8e77b341e318a15a8e029fee2df40793a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3763d2f1b933d605cc2059e37fa0d5dd674da80e","unresolved":true,"context_lines":[{"line_number":312,"context_line":"        releases_dictionary[\u0027undercloud_install_release\u0027] \u003d install_release"},{"line_number":313,"context_line":"        releases_dictionary[\u0027undercloud_install_hash\u0027] \u003d install_hash"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    elif featureset.get(\u0027standalone_upgrade\u0027):"},{"line_number":316,"context_line":"        logger.info(\u0027Doing an standalone upgrade\u0027)"},{"line_number":317,"context_line":"        install_release \u003d get_relative_release(stable_release, -1)"},{"line_number":318,"context_line":"        install_hash \u003d get_dlrn_hash("}],"source_content_type":"text/x-python","patch_set":8,"id":"cbedd801_b96ec790","line":315,"range":{"start_line":315,"start_character":9,"end_line":315,"end_character":43},"updated":"2021-12-01 08:10:01.000000000","message":"@Sandeep to answer your question for the standalone upgrade we would have to work in here.\n\nthe changes arx is making are specific to the undercloud upgrade","commit_id":"ed5ae2be3c35ae88a38c4275db9c53cc240812f7"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"52cf8bcd49fcb4a7143f52eb2decf15681df5117","unresolved":true,"context_lines":[{"line_number":498,"context_line":"        help\u003d\u0027Specify if the current running job is periodic\u0027,"},{"line_number":499,"context_line":"    )"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    parser.add_argument("},{"line_number":502,"context_line":"        \u0027--target-branch-override\u0027,"},{"line_number":503,"context_line":"        help\u003d\u0027Override to use this branch for the target version - required\\n\u0027"},{"line_number":504,"context_line":"        \u0027with the --content-provider-hashes argument\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"b7bf22a5_dbf3b48d","line":501,"updated":"2021-12-15 11:11:57.000000000","message":"Thank you for clearly explaining this part in the code, It is much clearer in the code.","commit_id":"151e5d72726da505506d4c5d2b315903695c30b3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3c0405923517a75d8ba9eea90949d815375b93ef","unresolved":true,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    # args.content_provider_hashes \u0027master:1;wallaby:2\u0027"},{"line_number":549,"context_line":"    _content_provider_hashes \u003d {}"},{"line_number":550,"context_line":"    for keyval in args.content_provider_hashes.split(\u0027;\u0027):"},{"line_number":551,"context_line":"        dict_key \u003d keyval.split(\u0027:\u0027)[0]"},{"line_number":552,"context_line":"        dict_val \u003d keyval.split(\u0027:\u0027)[1]"},{"line_number":553,"context_line":"        _content_provider_hashes.update({dict_key: dict_val})"}],"source_content_type":"text/x-python","patch_set":16,"id":"c48bc2ef_7d53d2a4","line":550,"range":{"start_line":550,"start_character":0,"end_line":550,"end_character":7},"updated":"2021-12-16 08:41:30.000000000","message":"thanks @Doug for catching that... problem is here \n\n\ndviroel|rover\u003e https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_874/821597/1/gate/tripleo-ci-centos-8-scenario000-multinode-oooq-container-updates-train/87484a1/job-output.txt\n\n\n2021-12-15 20:07:24.031135 | primary | Traceback (most recent call last):\n2021-12-15 20:07:24.031174 | primary |   File \"/home/zuul/src/opendev.org/openstack/tripleo-ci/scripts/emit_releases_file/emit_releases_file.py\", line 550, in \u003cmodule\u003e\n2021-12-15 20:07:24.031358 | primary |     for keyval in args.content_provider_hashes.split(\u0027;\u0027):\n2021-12-15 20:07:24.031401 | primary | AttributeError: \u0027NoneType\u0027 object has no attribute \u0027split\u0027\n\n\nI will guard this or move it inside the if above it.","commit_id":"151e5d72726da505506d4c5d2b315903695c30b3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9a3cc5ecfd05525df9fe447e88f089a88e3e3d74","unresolved":true,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    # args.content_provider_hashes \u0027master:1;wallaby:2\u0027"},{"line_number":549,"context_line":"    _content_provider_hashes \u003d {}"},{"line_number":550,"context_line":"    for keyval in args.content_provider_hashes.split(\u0027;\u0027):"},{"line_number":551,"context_line":"        dict_key \u003d keyval.split(\u0027:\u0027)[0]"},{"line_number":552,"context_line":"        dict_val \u003d keyval.split(\u0027:\u0027)[1]"},{"line_number":553,"context_line":"        _content_provider_hashes.update({dict_key: dict_val})"}],"source_content_type":"text/x-python","patch_set":16,"id":"57d6c0ac_25c1ae60","line":550,"range":{"start_line":550,"start_character":0,"end_line":550,"end_character":7},"in_reply_to":"0953932a_39b70663","updated":"2021-12-16 12:42:31.000000000","message":"and looks OK - results there:\n\n        * https://review.opendev.org/c/openstack/tripleo-common/+/821951/2#message-17d8437db6dc766aefe45680993f70329abcc796\n\n        * https://review.rdoproject.org/r/c/testproject/+/37144/2#message-9f99db5803011602fc4772370aa4aa2dd1916a8f","commit_id":"151e5d72726da505506d4c5d2b315903695c30b3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ab1da044fb21dbc7d680afc179533ff6b0ae0082","unresolved":true,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    # args.content_provider_hashes \u0027master:1;wallaby:2\u0027"},{"line_number":549,"context_line":"    _content_provider_hashes \u003d {}"},{"line_number":550,"context_line":"    for keyval in args.content_provider_hashes.split(\u0027;\u0027):"},{"line_number":551,"context_line":"        dict_key \u003d keyval.split(\u0027:\u0027)[0]"},{"line_number":552,"context_line":"        dict_val \u003d keyval.split(\u0027:\u0027)[1]"},{"line_number":553,"context_line":"        _content_provider_hashes.update({dict_key: dict_val})"}],"source_content_type":"text/x-python","patch_set":16,"id":"0953932a_39b70663","line":550,"range":{"start_line":550,"start_character":0,"end_line":550,"end_character":7},"in_reply_to":"c48bc2ef_7d53d2a4","updated":"2021-12-16 09:36:11.000000000","message":"posted v17 with that ^^^\n\nsanity recheck on the testproject there https://review.rdoproject.org/r/c/testproject/+/37144/2#message-865e41655688ab981f569d6a2f6617e2ab03f8a0\n(https://review.rdoproject.org/zuul/status#37144)\n\nsanity check on the failing job that Dough saw there https://review.opendev.org/c/openstack/tripleo-common/+/821951/2#message-abe4ce789fe6015e56c72192f2700242af1c4800\n(https://zuul.openstack.org/status#821951)","commit_id":"151e5d72726da505506d4c5d2b315903695c30b3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5d1b20ed633561646f544d09ada9259ed63a4df0","unresolved":true,"context_lines":[{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    featureset \u003d load_featureset_file(args.featureset_file)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    _content_provider_hashes \u003d None"},{"line_number":526,"context_line":"    # when overriding with content-provider-hashes we expect to have"},{"line_number":527,"context_line":"    # --install-branch-override and --target-branch-override in args"},{"line_number":528,"context_line":"    # and that these branches exist in the passed content-provider-hashes"}],"source_content_type":"text/x-python","patch_set":17,"id":"acd7d19f_64113c77","line":525,"range":{"start_line":525,"start_character":4,"end_line":525,"end_character":35},"updated":"2021-12-17 07:47:10.000000000","message":"ok, this one got added to fix Nonetype attribute error Thanks!","commit_id":"4a6b1f0bcf57816890f36c3a6c385bfae9fd1965"}]}