)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"671ce30f6b347af3901e3adc55024f3c74d26fbf","unresolved":true,"context_lines":[{"line_number":16,"context_line":"release files to use the c9 stream repos."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-quickstart/+/817161"},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-quickstart/+/819100"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I39fc32cf1249b4f14bdc35a4af7a1f8784c19801"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":42,"id":"7e9b6861_6498eff1","line":19,"range":{"start_line":19,"start_character":72,"end_line":19,"end_character":78},"updated":"2021-12-01 12:06:04.000000000","message":"that one merged can remove.","commit_id":"d70fd2deef2c192d26ded8f3a94caf93ad1b96f3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bd3df4e1b165ab9e9f1ffbaab1424b213ee0988d","unresolved":true,"context_lines":[{"line_number":16,"context_line":"release files to use the c9 stream repos."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-quickstart/+/817161"},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/opendev/base-jobs/+/820018"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I39fc32cf1249b4f14bdc35a4af7a1f8784c19801"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":44,"id":"0344550e_ab61af0a","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":10},"updated":"2021-12-01 14:26:42.000000000","message":"we need this but depends-on doesn\u0027t work for it - including workaround in https://review.opendev.org/c/openstack/tripleo-quickstart/+/817161/7..8 for now.\ngoing to remove the depends-on so we can get this merged","commit_id":"0781bdec14a6317a05ae07aca34c423b991be762"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"380b10f520f8a6980d3c93218da8c961014c6b36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"8cb6e96d_65a57d5d","updated":"2021-11-26 13:33:14.000000000","message":"recheck ","commit_id":"bfd3939410338a74d6dc58aa170a5273554af276"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"74b84935cbdb6cc6a3bf8d77bace8a1859e56ae8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"bae9aace_d51aeaff","updated":"2021-11-30 19:44:36.000000000","message":"recheck","commit_id":"d70fd2deef2c192d26ded8f3a94caf93ad1b96f3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6c2338414f25135d933b6bc19f5bca46890f135f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"51657529_615a5e79","updated":"2021-12-01 07:47:05.000000000","message":"recheck\n\nhttps://8a01cb64d4435f3fe938-0be6f2faeb5dd053eec85051536d7f3c.ssl.cf5.rackcdn.com/818222/42/check/tripleo-ci-centos-8-standalone/5cc7a52/logs/undercloud/home/zuul/standalone_deploy.log\n\n FATAL | Manage Cinder\u0027s default volume type | undercloud | error\u003d{\"changed\": false, \"cmd\": \"if ! openstack volume type show \\\"tripleo\\\"; then\\n    openstack volume type create --public \\\"tripleo\\\"\\nfi\\neval $(openstack volume type show __DEFAULT__ -f shell -c id -c description)\\nif [ -n \\\"$id\\\" ]; then\\n    vols\u003d$(openstack volume list -f value -c ID)\\n    tripleo_descr\u003d\\\"For internal use, \u0027tripleo\u0027 is the default volume type\\\"\\n    if [ -z \\\"$vols\\\" ]; then\\n        openstack volume type delete $id\\n    elif [ \\\"$description\\\" !\u003d \\\"$tripleo_descr\\\" ]; then\\n        openstack volume type set $id --description \\\"$tripleo_descr\\\"\\n    fi\\nfi\\n\", \"delta\": \"0:00:19.846438\", \"end\": \"2021-11-30 21:30:26.341288\", \"msg\": \"non-zero return code\", \"rc\": 1, \"start\": \"2021-11-30 21:30:06.494850\", \"stderr\": \"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\\n  DeprecationWarning\\nInternal Server Error (HTTP 500)\\n/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\\n  DeprecationWarning\\nInternal Server Error (HTTP 500)\\n/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\\n  DeprecationWarning\\n/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\\n  DeprecationWarning\\n/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\\n  DeprecationWarning\\nFailed to delete volume type with name or ID \u00272bd9c125-05a4-4c2c-9e1f-809cf8a5db0d\u0027: The request cannot be fulfilled as the default volume type tripleo cannot be found. (HTTP 500) (Request-ID: req-9cf519b7-fd33-4100-a33a-cfca3bb15eed)\\n1 of 1 volume types failed to delete.\", \"stderr_lines\": [\"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\", \"  DeprecationWarning\", \"Internal Server Error (HTTP 500)\", \"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\", \"  DeprecationWarning\", \"Internal Server Error (HTTP 500)\", \"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\", \"  DeprecationWarning\", \"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\", \"  DeprecationWarning\", \"/usr/lib64/python3.6/site-packages/_yaml/__init__.py:23: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.\", \"  DeprecationWarning\", \"Failed to delete volume type with name or ID \u00272bd9c125-05a4-4c2c-9e1f-809cf8a5db0d\u0027: The request cannot be fulfilled as the default volume type tripleo cannot be found. (HTTP 500) (Request-ID: req-9cf519b7-fd33-4100-a33a-cfca3bb15eed)\", \"1 of 1 volume types failed to delete.\"], \"stdout\": \"\", \"stdout_lines\": []}\n2021-11-30 21:30:26.362688 | fa163ee0-e4f1-bbd4-8da4-000000002662 |     TIMING | Manage Cinder\u0027s default volume type | undercloud | 0:20:59.261522 | 20.09s\n","commit_id":"d70fd2deef2c192d26ded8f3a94caf93ad1b96f3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"671ce30f6b347af3901e3adc55024f3c74d26fbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"d65c444d_313e1792","updated":"2021-12-01 12:06:04.000000000","message":"recheck\n\nupdated v2 @ https://review.opendev.org/c/opendev/base-jobs/+/820018","commit_id":"0781bdec14a6317a05ae07aca34c423b991be762"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f76196e9fed0f291506ac4dc21644f6694ec3806","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"e3210eb3_8c4f4699","updated":"2021-12-01 12:38:19.000000000","message":"recheck \n\nupdated depends-on  v8 https://review.opendev.org/c/openstack/tripleo-quickstart/+/817161/7..8","commit_id":"0781bdec14a6317a05ae07aca34c423b991be762"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"8603ddd06fd75638ac76beb7eba1c6fca31d54e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"82d4d293_b3734955","updated":"2021-12-01 20:07:43.000000000","message":"some comments line - we should also test downstream to see there is no impact on container/image builds there ","commit_id":"24f75dc63123037fc2a1b23103196920d61bc53c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"aadc27d1304bc95c39ab9035cc4afc559fe90fee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"53d2b475_cad3eea8","in_reply_to":"82d4d293_b3734955","updated":"2021-12-02 11:09:30.000000000","message":"I have posted https://code.engineering.redhat.com/gerrit/c/testproject/+/295749 but for some reason i cant get those jobs to trigger... it appears briefly at https://sf.hosted.upshift.rdu2.redhat.com/zuul/t/tripleo-ci-internal/status but the disappears with nothing run.\n\nI have ping rhos-ops but didn\u0027t get any replies yet will try again later. maybe you can see what\u0027s missing there?","commit_id":"24f75dc63123037fc2a1b23103196920d61bc53c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a616446c90e0aff70e7c7a1276efd6330392e4c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"4533c578_e9efd36d","updated":"2021-12-03 07:21:01.000000000","message":"I am going to split this patch - in particular we need to split out changes to base.yaml and merge those before we can test the d/stream build jobs with it. Thanks to rlandy it seems that because we are shadowing tripleo-ci-internal-jobs for the tripleo-ci project definition we cannot test changes to base speculatively so we have to merge that part first.\n\n  92         - openstack/tripleo-ci:\n  93             connection: opendev.org\n  94             zuul/include: [job]\n  95             zuul/shadow: openstack/tripleo-ci-internal-jobs\n  96             repoxplorer/skip: true\n  97             hound/skip: true\n","commit_id":"4bc91c7fa94594046e5781d75894a58e3f654c71"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"fe9b595b7ce03e821d1a6dd266eb613d37a712c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"20a80d45_c69cb87a","updated":"2021-12-02 14:48:31.000000000","message":"Waiting for container build testproject to finish https://review.rdoproject.org/r/c/testproject/+/36997","commit_id":"4bc91c7fa94594046e5781d75894a58e3f654c71"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"11d4d115b4779b697920caa60bf959c8756c8714","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"3ad79ffb_fbc7380d","updated":"2021-12-02 15:39:00.000000000","message":"setting workflow until we get d/stream environment sorted - currently cant trigger the jobs https://code.engineering.redhat.com/gerrit/c/testproject/+/295749\n","commit_id":"4bc91c7fa94594046e5781d75894a58e3f654c71"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"92dde9a5c563e854444805311b2230858d8a0d06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":49,"id":"9078bef0_f47a286c","updated":"2021-12-03 17:03:14.000000000","message":"19:00 \u003c marios\u003e rlandy|ruck: yeah some green there looks promising \n                https://sf.hosted.upshift.rdu2.redhat.com/zuul/t/tripleo-ci-internal/status#295749 \n19:01 \u003c rlandy|ruck\u003e marios: https://code.engineering.redhat.com/gerrit/c/testproject/+/190672\n","commit_id":"bc278516174cd1133ca910bb4978397499645a34"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1774e43ef012ba01b83d6c778c4079c495501606","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":49,"id":"f6e36a90_0e9bff96","updated":"2021-12-03 14:16:38.000000000","message":"Based on my testing here https://review.rdoproject.org/r/c/testproject/+/36997:\nhttps://review.opendev.org/c/openstack/tripleo-ci/+/820172 uses this patch as a parent and based on results:\n\nperiodic-tripleo-ci-build-containers-centos-9-push-master\tSUCCESS 38m 36s\n\nand https://logserver.rdoproject.org/97/36997/7/check/periodic-tripleo-ci-build-containers-centos-9-push-master/1bc64eb/etc/yum.repos.d/\n\n[   ]\tquickstart-centos-appstreams.repo\t2021-12-03 13:39\t177\n[   ]\tquickstart-centos-base.repo\t2021-12-03 13:39\t141\n[   ]\tquickstart-centos-crb.repo\t2021-12-03 13:39\t136\n[   ]\tquickstart-centos-highavailability.repo\t2\n\nUsing repos from release file. \\o/\nMarios nice work:-) Thank you Thank you. ","commit_id":"bc278516174cd1133ca910bb4978397499645a34"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"ae812e9980bdbd0e26e7267a929e47003dca3b19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":49,"id":"28839f7a_971ddc09","updated":"2021-12-03 20:42:30.000000000","message":"recheck","commit_id":"bc278516174cd1133ca910bb4978397499645a34"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"fab59475dbf41e229b6ee20e69ac4f683ac3a1ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":49,"id":"71039d25_c80a3765","updated":"2021-12-04 15:19:30.000000000","message":"recheck","commit_id":"bc278516174cd1133ca910bb4978397499645a34"}],"playbooks/tripleo-buildcontainers/pre.yaml":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"8603ddd06fd75638ac76beb7eba1c6fca31d54e2","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            bindep_dir: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/python-tripleoclient\u0027].src_dir }}\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    - name: Setup repos using repo-setup role and release file"},{"line_number":63,"context_line":"      when: ansible_distribution_major_version is version(9, \u0027\u003d\u003d\u0027)"},{"line_number":64,"context_line":"      include_role:"},{"line_number":65,"context_line":"        name: tripleo-build-jobs-repos"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":45,"id":"ab5d42b6_2adb7227","line":63,"updated":"2021-12-01 20:07:43.000000000","message":"\u003e\u003d9?","commit_id":"24f75dc63123037fc2a1b23103196920d61bc53c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c44a9bc9e649a68fe73571a42d03ea1eaa802264","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            bindep_dir: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/python-tripleoclient\u0027].src_dir }}\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    - name: Setup repos using repo-setup role and release file"},{"line_number":63,"context_line":"      when: ansible_distribution_major_version is version(9, \u0027\u003d\u003d\u0027)"},{"line_number":64,"context_line":"      include_role:"},{"line_number":65,"context_line":"        name: tripleo-build-jobs-repos"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":45,"id":"c34deb8d_bd79392d","line":63,"in_reply_to":"ab5d42b6_2adb7227","updated":"2021-12-02 09:14:49.000000000","message":"sure i mean we can only hope it will \u0027just work\u0027 for 10 right ;)\ndoesn\u0027t cost us anything to hope i guess :D","commit_id":"24f75dc63123037fc2a1b23103196920d61bc53c"}],"playbooks/tripleo-buildimages/pre.yaml":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"8603ddd06fd75638ac76beb7eba1c6fca31d54e2","unresolved":true,"context_lines":[{"line_number":20,"context_line":"        - ansible_pkg_mgr \u003d\u003d \"yum\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    - name: Setup repos using repo-setup role and release file"},{"line_number":23,"context_line":"      when: ansible_distribution_major_version is version(9, \u0027\u003d\u003d\u0027)"},{"line_number":24,"context_line":"      include_role:"},{"line_number":25,"context_line":"        name: tripleo-build-jobs-repos"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":45,"id":"6c3bb0a3_365b7b84","line":23,"updated":"2021-12-01 20:07:43.000000000","message":"forward looking \u003e\u003d9?","commit_id":"24f75dc63123037fc2a1b23103196920d61bc53c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c44a9bc9e649a68fe73571a42d03ea1eaa802264","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        - ansible_pkg_mgr \u003d\u003d \"yum\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    - name: Setup repos using repo-setup role and release file"},{"line_number":23,"context_line":"      when: ansible_distribution_major_version is version(9, \u0027\u003d\u003d\u0027)"},{"line_number":24,"context_line":"      include_role:"},{"line_number":25,"context_line":"        name: tripleo-build-jobs-repos"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":45,"id":"d8daa60f_975b5a6d","line":23,"in_reply_to":"6c3bb0a3_365b7b84","updated":"2021-12-02 09:14:49.000000000","message":"Ack","commit_id":"24f75dc63123037fc2a1b23103196920d61bc53c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d390570fbb491f0282a5a10b972fbf6deaffaf1c","unresolved":true,"context_lines":[{"line_number":25,"context_line":"        name: tripleo-build-jobs-repos"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    - name: Include tripleo-repos"},{"line_number":28,"context_line":"      when: ansible_distribution_major_version is version(8, \u0027\u003c\u003d\u0027)"},{"line_number":29,"context_line":"      include_role:"},{"line_number":30,"context_line":"        name: tripleo-repos"},{"line_number":31,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7e9276a0_46b3d8b4","line":28,"updated":"2021-12-02 15:04:59.000000000","message":"Since we are not going to use tripleo-repos for EL9, Can we remove the code which enables the compose repo for EL9\nhttps://opendev.org/openstack/tripleo-ci/src/branch/master/roles/tripleo-repos/tasks/main.yml#L130 ?","commit_id":"4bc91c7fa94594046e5781d75894a58e3f654c71"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9ee469a190d6c29c3b3ede3fb476097f79dedaac","unresolved":true,"context_lines":[{"line_number":25,"context_line":"        name: tripleo-build-jobs-repos"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    - name: Include tripleo-repos"},{"line_number":28,"context_line":"      when: ansible_distribution_major_version is version(8, \u0027\u003c\u003d\u0027)"},{"line_number":29,"context_line":"      include_role:"},{"line_number":30,"context_line":"        name: tripleo-repos"},{"line_number":31,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"affa6ebc_abbd3243","line":28,"in_reply_to":"7e9276a0_46b3d8b4","updated":"2021-12-02 15:44:25.000000000","message":"ack but i think it can be a separate patch since here we are no longer using tripleo-repos as you said... posted it to https://review.opendev.org/c/openstack/tripleo-ci/+/820188","commit_id":"4bc91c7fa94594046e5781d75894a58e3f654c71"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ca954f2c2e26976fb467fe2a370ff021c9e263cb","unresolved":true,"context_lines":[{"line_number":25,"context_line":"        name: tripleo-build-jobs-repos"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    - name: Include tripleo-repos"},{"line_number":28,"context_line":"      when: ansible_distribution_major_version is version(8, \u0027\u003c\u003d\u0027)"},{"line_number":29,"context_line":"      include_role:"},{"line_number":30,"context_line":"        name: tripleo-repos"},{"line_number":31,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"d79182fe_cb4b7f8b","line":28,"in_reply_to":"affa6ebc_abbd3243","updated":"2021-12-03 07:05:02.000000000","message":"Thanks!","commit_id":"4bc91c7fa94594046e5781d75894a58e3f654c71"}],"roles/tripleo-build-jobs-repos/tasks/main.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c348a3989d18bc1fe365a05157bf3a7d512126a7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":23,"id":"3dba2ec8_7413160c","updated":"2021-11-19 14:24:17.000000000","message":"with this it manages to include the vars but still cant find the tripleo repos collection\n\n* https://logserver.rdoproject.org/17/36817/3/check/tripleo-stream9-development-buildimage-overcloud-hardened-uefi-full-master/b93c4ef/job-output.txt","commit_id":"eb56a6169483336756a9ebb060041a2973934290"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c348a3989d18bc1fe365a05157bf3a7d512126a7","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Load vars from release file"},{"line_number":25,"context_line":"  include_vars:"},{"line_number":26,"context_line":"    file: \"{{ zuul.executor.work_root }}/{{ release_file_name }}\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- debug:"},{"line_number":29,"context_line":"    var: overcloud_image_url|default(\u0027\u0027)"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"b0a33ce0_cc2bd945","line":26,"updated":"2021-11-19 14:24:17.000000000","message":"2021-11-19 13:29:21.498170 | TASK [tripleo-build-jobs-repos : fetch promotion-testing-hash-master.yml into ansible executor work_root]\n2021-11-19 13:29:26.479518 | primary | changed\n2021-11-19 13:29:26.528724 | \n2021-11-19 13:29:26.528854 | TASK [tripleo-build-jobs-repos : Load vars from release file]\n2021-11-19 13:29:26.688921 | primary | ok","commit_id":"eb56a6169483336756a9ebb060041a2973934290"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c348a3989d18bc1fe365a05157bf3a7d512126a7","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    file: \"{{ zuul.executor.work_root }}/{{ release_file_name }}\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- debug:"},{"line_number":29,"context_line":"    var: overcloud_image_url|default(\u0027\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Include role for pip"},{"line_number":32,"context_line":"  include_role:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"06c1ae9a_5b16d3d4","line":29,"updated":"2021-11-19 14:24:17.000000000","message":"2021-11-19 13:29:26.747343 | TASK [tripleo-build-jobs-repos : debug]\n2021-11-19 13:29:26.828994 | primary | ok:\n2021-11-19 13:29:26.829218 | primary | {\n2021-11-19 13:29:26.830830 | primary |   \"overcloud_image_url|default(\u0027\u0027)\": \"https://images.rdoproject.org/centos9/master/rdo_trunk/tripleo-ci-testing/overcloud-hardened-uefi-full.qcow2\"\n2021-11-19 13:29:26.830883 | primary | }","commit_id":"eb56a6169483336756a9ebb060041a2973934290"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c348a3989d18bc1fe365a05157bf3a7d512126a7","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  include_role:"},{"line_number":50,"context_line":"    name: repo-setup"},{"line_number":51,"context_line":"  vars:"},{"line_number":52,"context_line":"    tripleo_ci_job_include_vars: true"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"819c226b_f32035c6","line":52,"updated":"2021-11-19 14:24:17.000000000","message":"2021-11-19 13:29:55.189654 | primary | ERROR\n2021-11-19 13:29:55.189870 | primary | {\n2021-11-19 13:29:55.189927 | primary |   \"reason\": \"couldn\u0027t resolve module/action \u0027tripleo.repos.get_hash\u0027. This often indicates a misspelling, missing collection, or incorrect module path.\\n\\nThe error appears to be in \u0027/var/lib/zuul/builds/b93c4ef6b38f486e955dd7b60a3fa4c1/untrusted/project_5/opendev.org/openstack/tripleo-quickstart/roles/repo-setup/tasks/tripleo-get-hash-set-fact.yml\u0027: line 9, column 7, but may\\nbe elsewhere in the file depending on the exact syntax problem.\\n\\nThe offending line appears to be:\\n\\n        tgh_dlrn_url: \\\"{{ dlrn_baseurl|urlsplit(\u0027scheme\u0027) }}://{{ dlrn_baseurl|urlsplit(\u0027hostname\u0027) }}\\\"\\n    - name: \u0027tripleo-get-hash {{ search_tag }} for {{ tgh_release }} on {{ tgh_os_version }} from {{ tgh_dlrn_url }}\u0027\\n      ^ here\\nWe could be wrong, but this one looks like it might be an issue with\\nmissing quotes. Always quote template expression brackets when they\\nstart a value. For instance:\\n\\n    with_items:\\n      - {{ foo }}\\n\\nShould be written as:\\n\\n    with_items:\\n      - \\\"{{ foo }}\\\"\\n\"\n2021-11-19 13:29:55.189973 | primary | }","commit_id":"eb56a6169483336756a9ebb060041a2973934290"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"da41a05110f10991c67d51049de8c061c6c1f59b","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        export ANSIBLE_COLLECTIONS_PATHS\u003d\"$ANSIBLE_COLLECTIONS_PATHS:/home/zuul/.ansible/collections:/usr/share/ansible/collections\""},{"line_number":55,"context_line":"        tripleo-get-hash # is it there?"},{"line_number":56,"context_line":"        ansible localhost -m tripleo.repos.get_hash"},{"line_number":57,"context_line":"      register: collection_install_res"},{"line_number":58,"context_line":"      failed_when: false"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    - debug:"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"a7434e8c_d1ca3532","line":57,"updated":"2021-11-23 16:41:04.000000000","message":"debug there https://logserver.rdoproject.org/17/36817/3/check/tripleo-stream9-development-buildimage-overcloud-hardened-uefi-full-master/5c1daf9/job-output.txt","commit_id":"e145eb1a2ae54f91bf8d5f7e7fe895515d1b911b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"756c92450fd3af7735281d115691deb8e436abd5","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    release_file_name: \"{{ \u0027promotion-testing-hash-\u0027 + ci_branch + \u0027.yml\u0027 if \u0027periodic\u0027 in zuul.job else ci_branch + \u0027.yml\u0027 }}\""},{"line_number":14,"context_line":"    t_q_release_dir: \"{{ tripleo_quickstart_dir }}/config/release/tripleo-ci/{{ ansible_distribution }}-{{ ansible_distribution_major_version }}\""},{"line_number":15,"context_line":"    whole_disk_images: true"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: \"fetch {{ release_file_name }} into ansible executor work_root\""},{"line_number":18,"context_line":"  fetch:"},{"line_number":19,"context_line":"    src: \"{{ t_q_release_dir }}/{{ release_file_name }}\""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"d6370054_ad6d951f","line":16,"updated":"2021-11-30 11:43:30.000000000","message":"let\u0027s also set enable_opstools_repo here too for https://opendev.org/openstack/tripleo-quickstart/src/commit/00a2efa27d64a299d892ecee21a3c53477a5f332/config/release/tripleo-ci/CentOS-9/master.yml#L183","commit_id":"69bb3ac64dad2904bde677571390291947d8c1a9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"fe9b595b7ce03e821d1a6dd266eb613d37a712c4","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    release_file_name: \"{{ \u0027promotion-testing-hash-\u0027 + ci_branch + \u0027.yml\u0027 if \u0027periodic\u0027 in zuul.job else ci_branch + \u0027.yml\u0027 }}\""},{"line_number":14,"context_line":"    t_q_release_dir: \"{{ tripleo_quickstart_dir }}/config/release/tripleo-ci/{{ ansible_distribution }}-{{ ansible_distribution_major_version }}\""},{"line_number":15,"context_line":"    whole_disk_images: true"},{"line_number":16,"context_line":"    enable_opstools_repo: true  # for collectd container build"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: \"fetch {{ release_file_name }} into ansible executor work_root\""},{"line_number":19,"context_line":"  fetch:"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"3145107e_6f1eae60","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":24},"updated":"2021-12-02 14:48:31.000000000","message":"Regarding this var, it is used in current-tripleo release file https://opendev.org/openstack/tripleo-quickstart/src/branch/master/config/release/tripleo-ci/CentOS-9/master.yml#L183\n\nand \n\nhttps://trunk.rdoproject.org/centos9-master/delorean-deps.repo\n\n```\n[centos9-opstools]\nname\u003dcentos9-opstools\nbaseurl\u003dhttps://buildlogs.centos.org/centos/9-stream/opstools/x86_64/collectd-5/\nenabled\u003d1\ngpgcheck\u003d0\nmodule_hotfixes\u003d1\n```\n\nIt is enabled by default as it is used in periodic line as per the release file https://opendev.org/openstack/tripleo-quickstart/src/branch/master/config/release/tripleo-ci/CentOS-9/promotion-testing-hash-master.yml#L124\n\nMy query is do we want to keep the above var as it is enabled by default in promotion line and re-enabling it in current-tripleo line?\n\nThe changes looks good, May be we can tackle it in a new review if needed? As it is not related to this patch.","commit_id":"4bc91c7fa94594046e5781d75894a58e3f654c71"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3eab7f43102d25fdf86e7f2833c7dd2db97289a5","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    release_file_name: \"{{ \u0027promotion-testing-hash-\u0027 + ci_branch + \u0027.yml\u0027 if \u0027periodic\u0027 in zuul.job else ci_branch + \u0027.yml\u0027 }}\""},{"line_number":14,"context_line":"    t_q_release_dir: \"{{ tripleo_quickstart_dir }}/config/release/tripleo-ci/{{ ansible_distribution }}-{{ ansible_distribution_major_version }}\""},{"line_number":15,"context_line":"    whole_disk_images: true"},{"line_number":16,"context_line":"    enable_opstools_repo: true  # for collectd container build"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: \"fetch {{ release_file_name }} into ansible executor work_root\""},{"line_number":19,"context_line":"  fetch:"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"a511f6da_e5b72cb8","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":24},"in_reply_to":"3145107e_6f1eae60","updated":"2021-12-03 06:56:56.000000000","message":"we need this var because without it the container build fails for the check/gate case. At https://opendev.org/openstack/tripleo-quickstart/src/branch/master/config/release/tripleo-ci/CentOS-9/master.yml#L186\n\n   {% if not enable_opstools_repo|default(false)|bool %}sudo dnf config-manager --save --setopt centos9-opstools.enabled\u003d0; \n\nit gets disabled.\n\nCan you please rephrase the question i don\u0027t follow what you are suggesting we should do.","commit_id":"4bc91c7fa94594046e5781d75894a58e3f654c71"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6560e5b54fbb8da680d209d54f1938a25c8030b5","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    release_file_name: \"{{ \u0027promotion-testing-hash-\u0027 + ci_branch + \u0027.yml\u0027 if \u0027periodic\u0027 in zuul.job else ci_branch + \u0027.yml\u0027 }}\""},{"line_number":14,"context_line":"    t_q_release_dir: \"{{ tripleo_quickstart_dir }}/config/release/tripleo-ci/{{ ansible_distribution }}-{{ ansible_distribution_major_version }}\""},{"line_number":15,"context_line":"    whole_disk_images: true"},{"line_number":16,"context_line":"    enable_opstools_repo: true  # for collectd container build"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: \"fetch {{ release_file_name }} into ansible executor work_root\""},{"line_number":19,"context_line":"  fetch:"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"e1304529_30e892ea","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":24},"in_reply_to":"3a85c02f_732b17f5","updated":"2021-12-03 07:06:42.000000000","message":"i see, sure, once we remove it from the release file then we can remove it from here too.","commit_id":"4bc91c7fa94594046e5781d75894a58e3f654c71"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ca954f2c2e26976fb467fe2a370ff021c9e263cb","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    release_file_name: \"{{ \u0027promotion-testing-hash-\u0027 + ci_branch + \u0027.yml\u0027 if \u0027periodic\u0027 in zuul.job else ci_branch + \u0027.yml\u0027 }}\""},{"line_number":14,"context_line":"    t_q_release_dir: \"{{ tripleo_quickstart_dir }}/config/release/tripleo-ci/{{ ansible_distribution }}-{{ ansible_distribution_major_version }}\""},{"line_number":15,"context_line":"    whole_disk_images: true"},{"line_number":16,"context_line":"    enable_opstools_repo: true  # for collectd container build"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: \"fetch {{ release_file_name }} into ansible executor work_root\""},{"line_number":19,"context_line":"  fetch:"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"3a85c02f_732b17f5","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":24},"in_reply_to":"a511f6da_e5b72cb8","updated":"2021-12-03 07:05:02.000000000","message":"Sorry for the confusion, Let me rephrase that.\n\nhttps://opendev.org/openstack/tripleo-quickstart/src/branch/master/config/release/tripleo-ci/CentOS-9/master.yml#L147 \ndelorean-master-deps.repo repo (getting fetched from https://trunk.rdoproject.org/centos9-master/delorean-deps.repo) is created.\n\nif we open the content of the delorean-master-deps.repo, we can find centos9-opstools is already enabled.\n\n++++++++++++++\n[centos9-opstools]\nname\u003dcentos9-opstools\nbaseurl\u003dhttps://buildlogs.centos.org/centos/9-stream/opstools/x86_64/collectd-5/\nenabled\u003d1\ngpgcheck\u003d0\nmodule_hotfixes\u003d1\n+++++++++++++++\nSo I was saying can we get rid of enable_opstools_repo var from here and the above conditional from release file ?","commit_id":"4bc91c7fa94594046e5781d75894a58e3f654c71"}]}