)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d43be06f59bcf32c986085235ff9af18a0714e9b","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch ensures that specific vars are loaded when dependency"},{"line_number":10,"context_line":"jobs are triggered, before they start setting up repos."},{"line_number":11,"context_line":"Also changes tripleo-repos installation to install as root,"},{"line_number":12,"context_line":"avoiding other hacks in tasks that need to be executed with"},{"line_number":13,"context_line":"root user."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"7575a649_33e976fc","line":11,"range":{"start_line":11,"start_character":5,"end_line":11,"end_character":12},"updated":"2022-02-17 07:47:16.000000000","message":"adds","commit_id":"2f5967457a59ecc5287ee65754bfedcc02f9597f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1480cb06259dfbc4157ed05141f698679382697d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch ensures that specific vars are loaded when dependency"},{"line_number":10,"context_line":"jobs are triggered, before they start setting up repos."},{"line_number":11,"context_line":"Also changes tripleo-repos installation to install as root,"},{"line_number":12,"context_line":"avoiding other hacks in tasks that need to be executed with"},{"line_number":13,"context_line":"root user."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"70aff624_155d98c2","line":11,"range":{"start_line":11,"start_character":5,"end_line":11,"end_character":12},"in_reply_to":"7575a649_33e976fc","updated":"2022-02-18 08:10:02.000000000","message":"Done","commit_id":"2f5967457a59ecc5287ee65754bfedcc02f9597f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8489f550e665ebf0809e3c1bab6093963ecdd737","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b95439b7_8e320bcf","updated":"2022-01-25 17:45:05.000000000","message":"recheck","commit_id":"ef11fbe365a8387d63259f72531fff268ba214aa"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"227aaaea143cda5e270fe91f9b91f294e7b23f64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"acd074eb_6c42f493","updated":"2022-02-16 12:25:27.000000000","message":"Thanks for your review Marios.\n\nWill update with small fixes soon","commit_id":"41d5e7b96a67c7360ce259f5c4f9079a21aff0fd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"41fcf9b234371b109ab92576d6161503803bb1ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"42f46a9c_ff76d3cf","updated":"2022-02-16 07:16:37.000000000","message":"cant spot a nit","commit_id":"41d5e7b96a67c7360ce259f5c4f9079a21aff0fd"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2ea0b5c0a101353cf1ff10ea24e08ed6fed8c018","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"0ca43933_b30df228","updated":"2022-02-17 13:52:19.000000000","message":"PS16 results here:\nhttps://review.rdoproject.org/r/c/testproject/+/35174/56#message-487ac689ea7c72b562443bd5615a35c073b6b5e7\n\nyum repos:\nhttps://logserver.rdoproject.org/74/35174/56/check/periodic-tripleo-ci-build-containers-centos-9-push-compose-master-test/268d1b0/etc/yum.repos.d/\nhttps://logserver.rdoproject.org/74/35174/56/check/periodic-tripleo-centos-9-buildimage-overcloud-hardened-uefi-full-compose-master-test/1c9d0a1/yum.repos.d/","commit_id":"1e37568b65522e4af574bb16a531cd821586d872"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"118243afbd605eedd5e9be5b44ea60d0f04a7358","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ef879814_8f17c425","updated":"2022-02-17 12:18:43.000000000","message":"Testing PS16","commit_id":"1e37568b65522e4af574bb16a531cd821586d872"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"19249130a264f7372468a3851b8931ed55f2060c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"f5c1a0a8_51375e20","updated":"2022-02-18 11:08:24.000000000","message":"Thanks Marios!","commit_id":"1e37568b65522e4af574bb16a531cd821586d872"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7643d3953337b2078072c863c4e54f0f1eb6d24c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"8a2ab603_73b3d976","updated":"2022-02-21 12:10:25.000000000","message":"Thansk Marios o/","commit_id":"1e37568b65522e4af574bb16a531cd821586d872"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"1703d5ba50c0c67de6b3eb22b29edd6b99115a0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"4f2791da_acf4a2c6","updated":"2022-02-22 11:23:55.000000000","message":"recheck","commit_id":"1e37568b65522e4af574bb16a531cd821586d872"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"9002f397c80c24d4fd5d7229bc2a9e92f37597b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"b987cca8_86b22f57","updated":"2022-02-18 19:28:03.000000000","message":"recheck\n\n\ntox-molecule is not failing in local env tests","commit_id":"1e37568b65522e4af574bb16a531cd821586d872"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1cdc577d87746af4266a94141694ae6b89d6487c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"787938f6_84c5d6a0","updated":"2022-02-18 08:10:18.000000000","message":"recheck ","commit_id":"1e37568b65522e4af574bb16a531cd821586d872"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1480cb06259dfbc4157ed05141f698679382697d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"096991b2_c4956673","updated":"2022-02-18 08:10:02.000000000","message":"thanks lgtm - just one last question/doubt inline otherwise ready to add +2","commit_id":"1e37568b65522e4af574bb16a531cd821586d872"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4cc19a33c694370c9ff815ba3f09ff6ee2a52ca8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"25560ee0_dd42fbf2","in_reply_to":"0ca43933_b30df228","updated":"2022-02-22 07:15:57.000000000","message":"Thanks for the testproject results","commit_id":"1e37568b65522e4af574bb16a531cd821586d872"}],"roles/oooci-build-images/vars/centos-9.yaml":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"227aaaea143cda5e270fe91f9b91f294e7b23f64","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"tripleo_image_source: https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-20220121.1.x86_64.qcow2"},{"line_number":3,"context_line":"centos_compose_dib_yum_repos: \u003e-"},{"line_number":4,"context_line":"  {% if job is defined and"},{"line_number":5,"context_line":"  job.dependency is defined and"},{"line_number":6,"context_line":"  job.dependency \u003d\u003d \"centos-compose\" or"},{"line_number":7,"context_line":"  dependency|default(\"\") \u003d\u003d \"centos-compose\" -%}"},{"line_number":8,"context_line":"  {{ true|bool }}"},{"line_number":9,"context_line":"  {%- else -%}"},{"line_number":10,"context_line":"  {{ false|bool }}"},{"line_number":11,"context_line":"  {%- endif -%}"},{"line_number":12,"context_line":"dib_yum_repo_conf:"},{"line_number":13,"context_line":"  - /etc/yum.repos.d/quickstart-centos*"},{"line_number":14,"context_line":"  - /etc/yum.repos.d/delorean*"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"f245d40b_327f0a7f","line":11,"range":{"start_line":3,"start_character":0,"end_line":11,"end_character":15},"updated":"2022-02-16 12:25:27.000000000","message":"will move this to defauls, will be needed to CentOS-8 too","commit_id":"41d5e7b96a67c7360ce259f5c4f9079a21aff0fd"}],"roles/tripleo-build-jobs-repos/tasks/load-vars.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"41fcf9b234371b109ab92576d6161503803bb1ce","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    - name: Load vars from dependency file"},{"line_number":42,"context_line":"      include_vars:"},{"line_number":43,"context_line":"        file: \"{{ zuul.executor.work_root }}/repo_config.yaml\""},{"line_number":44,"context_line":"  when: job.dependency is defined or dependency is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"cd92afea_397ba044","line":44,"range":{"start_line":44,"start_character":7,"end_line":44,"end_character":15},"updated":"2022-02-16 07:16:37.000000000","message":"do we need to do (job is defined and job.dependency) or dependency is defined","commit_id":"41d5e7b96a67c7360ce259f5c4f9079a21aff0fd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1480cb06259dfbc4157ed05141f698679382697d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    - name: Load vars from dependency file"},{"line_number":42,"context_line":"      include_vars:"},{"line_number":43,"context_line":"        file: \"{{ zuul.executor.work_root }}/repo_config.yaml\""},{"line_number":44,"context_line":"  when: job.dependency is defined or dependency is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"55fd2302_2fba8b42","line":44,"range":{"start_line":44,"start_character":7,"end_line":44,"end_character":15},"in_reply_to":"2e267996_ac17e563","updated":"2022-02-18 08:10:02.000000000","message":"thanks for checking","commit_id":"41d5e7b96a67c7360ce259f5c4f9079a21aff0fd"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"187268e2eb5ca546d04bd755549153eeaee6ce9e","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    - name: Load vars from dependency file"},{"line_number":42,"context_line":"      include_vars:"},{"line_number":43,"context_line":"        file: \"{{ zuul.executor.work_root }}/repo_config.yaml\""},{"line_number":44,"context_line":"  when: job.dependency is defined or dependency is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"2e267996_ac17e563","line":44,"range":{"start_line":44,"start_character":7,"end_line":44,"end_character":15},"in_reply_to":"9fbcdcd5_0c060732","updated":"2022-02-17 12:08:30.000000000","message":"https://paste.opendev.org/show/bmo8ORXvMhQ6cqhSjBAy/\n\nOK, it seems that we don\u0027t need to test \"job\" before testing \"job.dependency\".","commit_id":"41d5e7b96a67c7360ce259f5c4f9079a21aff0fd"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"227aaaea143cda5e270fe91f9b91f294e7b23f64","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    - name: Load vars from dependency file"},{"line_number":42,"context_line":"      include_vars:"},{"line_number":43,"context_line":"        file: \"{{ zuul.executor.work_root }}/repo_config.yaml\""},{"line_number":44,"context_line":"  when: job.dependency is defined or dependency is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fbcdcd5_0c060732","line":44,"range":{"start_line":44,"start_character":7,"end_line":44,"end_character":15},"in_reply_to":"cd92afea_397ba044","updated":"2022-02-16 12:25:27.000000000","message":"good point, will do a quick test here, tks","commit_id":"41d5e7b96a67c7360ce259f5c4f9079a21aff0fd"}],"roles/tripleo-build-jobs-repos/tasks/main.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"41fcf9b234371b109ab92576d6161503803bb1ce","unresolved":true,"context_lines":[{"line_number":31,"context_line":"  changed_when: true"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: install tripleo-repos as superuser to be available for yum-config module"},{"line_number":34,"context_line":"  become: true"},{"line_number":35,"context_line":"  shell: |"},{"line_number":36,"context_line":"    pushd \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}\""},{"line_number":37,"context_line":"    python3 setup.py install"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"03a550d1_3ad33151","line":34,"range":{"start_line":34,"start_character":2,"end_line":34,"end_character":14},"updated":"2022-02-16 07:16:37.000000000","message":"k but please lets check this doesn\u0027t break the tripleo-get-hash case and if needed we can have duplicate tasks one with/out become","commit_id":"41d5e7b96a67c7360ce259f5c4f9079a21aff0fd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7d326815a1b39f1c6ed6fe2d257eda46c5da4f0c","unresolved":true,"context_lines":[{"line_number":31,"context_line":"  changed_when: true"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: install tripleo-repos as superuser to be available for yum-config module"},{"line_number":34,"context_line":"  become: true"},{"line_number":35,"context_line":"  shell: |"},{"line_number":36,"context_line":"    pushd \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}\""},{"line_number":37,"context_line":"    python3 setup.py install"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"f6729dfa_46ea1816","line":34,"range":{"start_line":34,"start_character":2,"end_line":34,"end_character":14},"in_reply_to":"03a550d1_3ad33151","updated":"2022-02-16 07:17:10.000000000","message":"(especially RDO env since the upstream looks OK according to jobs here)","commit_id":"41d5e7b96a67c7360ce259f5c4f9079a21aff0fd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d43be06f59bcf32c986085235ff9af18a0714e9b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  changed_when: true"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: install tripleo-repos as superuser to be available for yum-config module"},{"line_number":34,"context_line":"  become: true"},{"line_number":35,"context_line":"  shell: |"},{"line_number":36,"context_line":"    pushd \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}\""},{"line_number":37,"context_line":"    python3 setup.py install"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1b903e7c_610d727f","line":34,"range":{"start_line":34,"start_character":2,"end_line":34,"end_character":14},"in_reply_to":"41e3ff81_267d439b","updated":"2022-02-17 07:47:16.000000000","message":"ack thanks the commit message still says \u0027changes\u0027","commit_id":"41d5e7b96a67c7360ce259f5c4f9079a21aff0fd"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"227aaaea143cda5e270fe91f9b91f294e7b23f64","unresolved":true,"context_lines":[{"line_number":31,"context_line":"  changed_when: true"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: install tripleo-repos as superuser to be available for yum-config module"},{"line_number":34,"context_line":"  become: true"},{"line_number":35,"context_line":"  shell: |"},{"line_number":36,"context_line":"    pushd \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}\""},{"line_number":37,"context_line":"    python3 setup.py install"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"41e3ff81_267d439b","line":34,"range":{"start_line":34,"start_character":2,"end_line":34,"end_character":14},"in_reply_to":"f6729dfa_46ea1816","updated":"2022-02-16 12:25:27.000000000","message":"yes, it does break, thats why I duplicated - see task in L25-31","commit_id":"41d5e7b96a67c7360ce259f5c4f9079a21aff0fd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d43be06f59bcf32c986085235ff9af18a0714e9b","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    python3 setup.py install"},{"line_number":38,"context_line":"    popd"},{"line_number":39,"context_line":"  failed_when: false"},{"line_number":40,"context_line":"  changed_when: true"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Include repo-setup role"},{"line_number":43,"context_line":"  include_role:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"48c52757_24894022","line":40,"updated":"2022-02-17 07:47:16.000000000","message":"but do we need a conditional here please? is this needed only for the dependency repos? e.g. when: job is defined and job.dependency) or dependency is defined \n? or is a more general thing","commit_id":"2f5967457a59ecc5287ee65754bfedcc02f9597f"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"187268e2eb5ca546d04bd755549153eeaee6ce9e","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    python3 setup.py install"},{"line_number":38,"context_line":"    popd"},{"line_number":39,"context_line":"  failed_when: false"},{"line_number":40,"context_line":"  changed_when: true"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Include repo-setup role"},{"line_number":43,"context_line":"  include_role:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7160ce06_44f155f2","line":40,"in_reply_to":"48c52757_24894022","updated":"2022-02-17 12:08:30.000000000","message":"Good question. I need for the entire yum-config, so even when dependency is not set, if \"use_yum_config_module\" is enabled [1], will be needed. So yes, I think that I can add a \"when\" condition here.\n\n[1] https://github.com/openstack/tripleo-quickstart/blob/master/config/release/tripleo-ci/CentOS-8/wallaby.yml#L119","commit_id":"2f5967457a59ecc5287ee65754bfedcc02f9597f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1480cb06259dfbc4157ed05141f698679382697d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    python3 setup.py install"},{"line_number":38,"context_line":"    popd"},{"line_number":39,"context_line":"  failed_when: false"},{"line_number":40,"context_line":"  changed_when: true"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Include repo-setup role"},{"line_number":43,"context_line":"  include_role:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"353c2ce3_6d1a3bec","line":40,"in_reply_to":"7160ce06_44f155f2","updated":"2022-02-18 08:10:02.000000000","message":"thanks","commit_id":"2f5967457a59ecc5287ee65754bfedcc02f9597f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1480cb06259dfbc4157ed05141f698679382697d","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  vars:"},{"line_number":37,"context_line":"    repo_setup_dir: \"{{ workspace }}\""},{"line_number":38,"context_line":"    repo_setup_use_collections: false"},{"line_number":39,"context_line":"    use_yum_config_module: false"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Install python3-tripleoclient python3-virtualenv"},{"line_number":42,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"20c89cf2_d3f51ebc","side":"PARENT","line":39,"range":{"start_line":39,"start_character":27,"end_line":39,"end_character":32},"updated":"2022-02-18 08:10:02.000000000","message":"do we need to make that use_yum_config_module: \"{{ use_yum_config_module }} if use_yum_config_module is defined else false\"\n\nnot even sure that will work like that in vars, but my point is do we need to still pass this in? Does it default to true in the repo-setup role? if we don\u0027t set it will it be true?","commit_id":"e8c062a241d3c09d899ee9038b3f15b380a770d2"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"19249130a264f7372468a3851b8931ed55f2060c","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  vars:"},{"line_number":37,"context_line":"    repo_setup_dir: \"{{ workspace }}\""},{"line_number":38,"context_line":"    repo_setup_use_collections: false"},{"line_number":39,"context_line":"    use_yum_config_module: false"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Install python3-tripleoclient python3-virtualenv"},{"line_number":42,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"316fbfd0_8153bfee","side":"PARENT","line":39,"range":{"start_line":39,"start_character":27,"end_line":39,"end_character":32},"in_reply_to":"20c89cf2_d3f51ebc","updated":"2022-02-18 11:08:24.000000000","message":"Thanks for asking, some background on this:\n\nThis var was added to force disabling the use of yum_config_module since it still doesn\u0027t support \"repo_setup_use_collections: false\"(when enabling use of release files for C8). The proper fix was to disable it in the release file (only wallaby was enabling it)[1]. It defaults to false [2].\n\n[1] https://review.opendev.org/c/openstack/tripleo-quickstart/+/827544\n[2] https://github.com/openstack/tripleo-quickstart/blob/95f2952e7ae9ed8f70479471f8da15dee1a4d89c/roles/repo-setup/tasks/main.yml#L19","commit_id":"e8c062a241d3c09d899ee9038b3f15b380a770d2"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"11e8a9e464e0edd3eb09b47692463154dfdb9882","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  vars:"},{"line_number":37,"context_line":"    repo_setup_dir: \"{{ workspace }}\""},{"line_number":38,"context_line":"    repo_setup_use_collections: false"},{"line_number":39,"context_line":"    use_yum_config_module: false"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Install python3-tripleoclient python3-virtualenv"},{"line_number":42,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"da66090c_6967b758","side":"PARENT","line":39,"range":{"start_line":39,"start_character":27,"end_line":39,"end_character":32},"in_reply_to":"316fbfd0_8153bfee","updated":"2022-02-18 19:18:23.000000000","message":"There is another change, needed for compose pinning that adds no-collection repo setup [1]. Next step is to enabled it for all setup-repos.\n\n[1] https://review.opendev.org/c/openstack/tripleo-quickstart/+/825307","commit_id":"e8c062a241d3c09d899ee9038b3f15b380a770d2"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7643d3953337b2078072c863c4e54f0f1eb6d24c","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  vars:"},{"line_number":37,"context_line":"    repo_setup_dir: \"{{ workspace }}\""},{"line_number":38,"context_line":"    repo_setup_use_collections: false"},{"line_number":39,"context_line":"    use_yum_config_module: false"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Install python3-tripleoclient python3-virtualenv"},{"line_number":42,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"f99ee8be_07dc306b","side":"PARENT","line":39,"range":{"start_line":39,"start_character":27,"end_line":39,"end_character":32},"in_reply_to":"8884e07b_abd415c4","updated":"2022-02-21 12:10:25.000000000","message":"tks marios. I don´t think that will be needed in fact - if we enable it in release it will work. If we don\u0027t enabled it or not define it - the defaults of repo-setup role will deal it as disabled by default.\nimho, it will work here just as informative that we have that flag in repo-setup.","commit_id":"e8c062a241d3c09d899ee9038b3f15b380a770d2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f6a2ed8cb7aebf3973b88c6f284193be52d7065e","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  vars:"},{"line_number":37,"context_line":"    repo_setup_dir: \"{{ workspace }}\""},{"line_number":38,"context_line":"    repo_setup_use_collections: false"},{"line_number":39,"context_line":"    use_yum_config_module: false"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Install python3-tripleoclient python3-virtualenv"},{"line_number":42,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"8884e07b_abd415c4","side":"PARENT","line":39,"range":{"start_line":39,"start_character":27,"end_line":39,"end_character":32},"in_reply_to":"da66090c_6967b758","updated":"2022-02-21 08:37:42.000000000","message":"ok thanks... so it defaults false. \nwe can\u0027t enable it until we get https://review.opendev.org/c/openstack/tripleo-quickstart/+/825307\nafter that happens then here we can make it like use_yum_config_module: \"{{ use_yum_config_module }} if use_yum_config_module is defined else false\"\n\n\nmaybe add TODO(dviroel) here?","commit_id":"e8c062a241d3c09d899ee9038b3f15b380a770d2"}]}