)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d5cb5cff8e74abae2e773cef4890d224d102d9eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6b050632_e9843ab5","updated":"2022-01-05 07:39:14.000000000","message":"Abandoning it.","commit_id":"7de4655888f98976fcad39828ab9b5e8bb26f4bb"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"164970b258813dbd9b1bb5a36acea6374fadf888","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"05ddada8_7daeaca7","updated":"2021-12-21 21:51:17.000000000","message":"recheck","commit_id":"7de4655888f98976fcad39828ab9b5e8bb26f4bb"}],"roles/oooci-build-images/vars/centos-9.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"069067745793c40804dbe91a423386303e13df7f","unresolved":true,"context_lines":[{"line_number":3,"context_line":"dib_yum_repo_conf:"},{"line_number":4,"context_line":"  - /etc/yum.repos.d/quickstart-centos*"},{"line_number":5,"context_line":"  - /etc/yum.repos.d/delorean*"},{"line_number":6,"context_line":"dib_release: \"9-stream\""},{"line_number":7,"context_line":"dib_dnf_module_streams: \"\""},{"line_number":8,"context_line":"tripleo_image_os: centos9"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"db8bc8f6_7c4b3678","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":5},"updated":"2021-12-17 07:19:39.000000000","message":"not sure about that - unless Ian is also addressing it in dib/elements\n\nwhen i worked on this i originally tried setting that to 9-stream but it failed as some places in dib are using/expecting \u00279\u0027 without -stream \n\nfor example there https://opendev.org/openstack/diskimage-builder/src/commit/6ae099f464a76dab03842612bb548c3b1475953e/diskimage_builder/elements/centos/root.d/10-centos-cloud-image#L59-L60","commit_id":"7de4655888f98976fcad39828ab9b5e8bb26f4bb"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b49f62de4c7092ac66bde585bbddd386eb0f0272","unresolved":true,"context_lines":[{"line_number":3,"context_line":"dib_yum_repo_conf:"},{"line_number":4,"context_line":"  - /etc/yum.repos.d/quickstart-centos*"},{"line_number":5,"context_line":"  - /etc/yum.repos.d/delorean*"},{"line_number":6,"context_line":"dib_release: \"9-stream\""},{"line_number":7,"context_line":"dib_dnf_module_streams: \"\""},{"line_number":8,"context_line":"tripleo_image_os: centos9"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8542fd5d_f71aca3c","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":5},"in_reply_to":"541f8f82_9690676c","updated":"2021-12-17 08:25:46.000000000","message":"Thank you Marios for the insight, It is definitly breaking. Added my notes here: https://bugs.launchpad.net/tripleo/+bug/1954456/comments/17","commit_id":"7de4655888f98976fcad39828ab9b5e8bb26f4bb"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"950f8fb52c0d1a55a813af751d9eb01ccb4232ad","unresolved":true,"context_lines":[{"line_number":3,"context_line":"dib_yum_repo_conf:"},{"line_number":4,"context_line":"  - /etc/yum.repos.d/quickstart-centos*"},{"line_number":5,"context_line":"  - /etc/yum.repos.d/delorean*"},{"line_number":6,"context_line":"dib_release: \"9-stream\""},{"line_number":7,"context_line":"dib_dnf_module_streams: \"\""},{"line_number":8,"context_line":"tripleo_image_os: centos9"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b7eaf242_79dcf2f3","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":5},"in_reply_to":"8542fd5d_f71aca3c","updated":"2021-12-20 04:58:58.000000000","message":"Sigh, another place that centos-minimal has diverged from the centos element\n\nI think it makes sense to call this \"9-stream\"?  I think it\u0027s better to just be explicit.\n\nIf you\u0027re OK working around it, I can propose a change to dib to change it to 9-stream and additionally put something in environment.d or similar to make it fail if we don\u0027t have an explicitly matched DIB_RELEASE.  That should avoid us going over this ground again in the future.  Better to sort it out now before it becomes (more) widely used.","commit_id":"7de4655888f98976fcad39828ab9b5e8bb26f4bb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bed5d2a8afeeffe16c02356c29b3a73d0a9f11a2","unresolved":true,"context_lines":[{"line_number":3,"context_line":"dib_yum_repo_conf:"},{"line_number":4,"context_line":"  - /etc/yum.repos.d/quickstart-centos*"},{"line_number":5,"context_line":"  - /etc/yum.repos.d/delorean*"},{"line_number":6,"context_line":"dib_release: \"9-stream\""},{"line_number":7,"context_line":"dib_dnf_module_streams: \"\""},{"line_number":8,"context_line":"tripleo_image_os: centos9"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ef7d0286_eaaebc0c","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":5},"in_reply_to":"86acc799_34af8009","updated":"2022-01-03 07:29:32.000000000","message":"are we still waiting for other changes here or is this OK now?\ni think we had 2 dependent changes in dib \u0026 tripleo-puppet-elements","commit_id":"7de4655888f98976fcad39828ab9b5e8bb26f4bb"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"5a38d25263999b351d46666edd1c689e0b006455","unresolved":true,"context_lines":[{"line_number":3,"context_line":"dib_yum_repo_conf:"},{"line_number":4,"context_line":"  - /etc/yum.repos.d/quickstart-centos*"},{"line_number":5,"context_line":"  - /etc/yum.repos.d/delorean*"},{"line_number":6,"context_line":"dib_release: \"9-stream\""},{"line_number":7,"context_line":"dib_dnf_module_streams: \"\""},{"line_number":8,"context_line":"tripleo_image_os: centos9"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"86acc799_34af8009","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":5},"in_reply_to":"b7eaf242_79dcf2f3","updated":"2021-12-20 06:00:54.000000000","message":"Thank you Ian for looking into it, Please go ahead and propose the change. Thanks!","commit_id":"7de4655888f98976fcad39828ab9b5e8bb26f4bb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"11c34623ccd18e59cc0260167bf784894edb6ce7","unresolved":true,"context_lines":[{"line_number":3,"context_line":"dib_yum_repo_conf:"},{"line_number":4,"context_line":"  - /etc/yum.repos.d/quickstart-centos*"},{"line_number":5,"context_line":"  - /etc/yum.repos.d/delorean*"},{"line_number":6,"context_line":"dib_release: \"9-stream\""},{"line_number":7,"context_line":"dib_dnf_module_streams: \"\""},{"line_number":8,"context_line":"tripleo_image_os: centos9"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"541f8f82_9690676c","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":5},"in_reply_to":"db8bc8f6_7c4b3678","updated":"2021-12-17 07:29:51.000000000","message":"and places like that https://opendev.org/openstack/tripleo-puppet-elements/src/commit/9753de458a3922ad765ceb8d41db6d76dbbad0b0/elements/overcloud-base/pkg-map#L14\n\ni think we probably should use 9-stream here but i think we will need some further patches to deal with things like ^^^","commit_id":"7de4655888f98976fcad39828ab9b5e8bb26f4bb"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d5cb5cff8e74abae2e773cef4890d224d102d9eb","unresolved":true,"context_lines":[{"line_number":3,"context_line":"dib_yum_repo_conf:"},{"line_number":4,"context_line":"  - /etc/yum.repos.d/quickstart-centos*"},{"line_number":5,"context_line":"  - /etc/yum.repos.d/delorean*"},{"line_number":6,"context_line":"dib_release: \"9-stream\""},{"line_number":7,"context_line":"dib_dnf_module_streams: \"\""},{"line_number":8,"context_line":"tripleo_image_os: centos9"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"542e4530_5c389cae","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":5},"in_reply_to":"ef7d0286_eaaebc0c","updated":"2022-01-05 07:39:14.000000000","message":"Thank you for the reviews and comments based on my testing here: https://review.rdoproject.org/r/c/testproject/+/36713/22#message-6eee33e98f991eadc0c3b46ff40293786d12e4cc\n\nIt is no longer needed.","commit_id":"7de4655888f98976fcad39828ab9b5e8bb26f4bb"}]}