)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"06cf4dc50e18e96b7689b6573a0599e664c56421","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a3f8cee9_2d8c14a0","updated":"2022-01-21 10:08:49.000000000","message":"We can more than probably remove a ton of packages as well. Lemme investigate.","commit_id":"f408dbb14c973468c90e7f17b204e64e83483fc8"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"ffc901ef1496697a00007bfe94db3ccfc575a3d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"70b4e54f_744bc086","updated":"2022-01-21 12:10:00.000000000","message":"Note:\n- virt-customize comes from libguestfs-tools-c\n- virt-sysprep (and friends) come from libguestfs-tools\n\n*scratching my head*","commit_id":"28827b66de3e720dd18a302536e218bf55095cc1"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3477e037f4203d0f10de43fd38e459a4d0afd34d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"532a992e_86de9148","updated":"2022-01-24 06:30:04.000000000","message":"Moved the install to a self-contained task file, and included it in the right places.","commit_id":"fd64a19a70c5c36cce32071d64ae0735cfa9e4ed"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"871c4542c278c3e3d4de2ca696b22b3e0dc51372","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9686fedd_114eb4d5","updated":"2022-01-24 07:54:23.000000000","message":"ok lets make sure we sanity check this though ... current run is pretty red @ https://zuul.openstack.org/status#825728 but i don\u0027t know if the cause is related to the patch didn\u0027t dig at all\n\nalso please lets get rdo testproject going to run the periodic 9 jobs too \n\n","commit_id":"fd64a19a70c5c36cce32071d64ae0735cfa9e4ed"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"38506056a25022e6bb902af1c9ce1caff5c8f86f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3ca3d83f_4063a4ab","updated":"2022-01-26 06:20:33.000000000","message":"recheck","commit_id":"fd64a19a70c5c36cce32071d64ae0735cfa9e4ed"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"027d8398c57af30a3bdf613bbd07264ebcba8602","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ab5dd4e1_a668a918","updated":"2022-01-26 09:27:51.000000000","message":"recheck\n\nerrr... I don\u0027t see any issue in the logs... ??","commit_id":"fd64a19a70c5c36cce32071d64ae0735cfa9e4ed"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d0358eb89e1801b7e0273610da5a063b8543d266","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"99b85827_d51687c0","updated":"2022-01-26 14:32:47.000000000","message":"would love to understand what\u0027s failing in the red jobs.... I don\u0027t see anything - I\u0027m more than probably looking at the wrong place... ?","commit_id":"298687fea692e18f1e45fde62afd54ba789f60c6"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"daecae2dbee000b980de42f5e93f2a838c18a994","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"35049fe0_40cdca39","updated":"2022-01-27 15:14:38.000000000","message":"@Marios: the red was indeed linked to the change, I made some really, really stupid mistakes at different stages of the patch stack...\n\nNow, it\u0027s all good, and it\u0027s all green - at least on Zuul side, and seeing the jobs, it\u0027s able to build images for all the releases.\n\nDo you still think a testproject job is needed? If so, I\u0027d need some help in order to know what actual test is needed :).","commit_id":"db204456520f7fa3917ee0a807970e3b10b4a1ea"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4c67e3269995fbca5d6334d5bed0b8feea4558bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a2bae86a_ff183ecf","updated":"2022-02-01 06:42:10.000000000","message":"minor inline nit please? ","commit_id":"db204456520f7fa3917ee0a807970e3b10b4a1ea"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"6ff89494de9be029483603744f132dc1ce6ab169","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"65164d25_283ade90","updated":"2022-02-01 07:38:36.000000000","message":"Looks good","commit_id":"6cd8303618ff546299d9316c5743f54b5cbbad8e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"79da28f5ce70e42a237c636d5c2bd48b1765f954","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"65096178_f2b267e1","updated":"2022-02-03 07:40:34.000000000","message":"k let\u0027s goooo","commit_id":"6cd8303618ff546299d9316c5743f54b5cbbad8e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c2fa501cab23c3f7004def5d25af3bb966364d82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"34b7e06b_c741d306","updated":"2022-02-02 06:11:46.000000000","message":"recheck","commit_id":"6cd8303618ff546299d9316c5743f54b5cbbad8e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"928d03231871c15e69624dd021b66c17945d8039","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"db769429_8a31a928","updated":"2022-02-01 11:51:57.000000000","message":"recheck\n\nError: Facter: error while resolving custom facts in /usr/share/openstack-puppet/modules/kmod/lib/facter/kmod.rb: expected argument to be a String, Symbol, or Hash","commit_id":"6cd8303618ff546299d9316c5743f54b5cbbad8e"}],"roles/oooci-build-images/tasks/image_sanity.yaml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"60684574ef2364d2b5056997e8e972ea3e93d66a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"718a72fd_1ea4c577","side":"PARENT","updated":"2022-01-24 04:47:35.000000000","message":"Just a nit since these two tasks are common and called in both the playbook, Can we move it to a seperate common playbook and re-use it here?","commit_id":"07cc6a850f28a010c444c47955032f3a2ab0bbb6"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3477e037f4203d0f10de43fd38e459a4d0afd34d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e24491ea_96220d3f","side":"PARENT","in_reply_to":"718a72fd_1ea4c577","updated":"2022-01-24 06:30:04.000000000","message":"Done","commit_id":"07cc6a850f28a010c444c47955032f3a2ab0bbb6"}],"roles/oooci-build-images/tasks/remove_redfish.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4c67e3269995fbca5d6334d5bed0b8feea4558bc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO akahat Remove once lp https://bugs.launchpad.net/tripleo/+bug/1956441 fixed."},{"line_number":3,"context_line":"- name: Install guestfs"},{"line_number":4,"context_line":"  include_tasks: guestfs.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"4ce3e2b3_01ad1f19","line":2,"range":{"start_line":2,"start_character":29,"end_line":2,"end_character":68},"updated":"2022-02-01 06:42:10.000000000","message":"this applies to the fwup-redfish.conf task below can you please move your addition above it otherwise it will be confusing for maintenance","commit_id":"db204456520f7fa3917ee0a807970e3b10b4a1ea"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"1ff508335958323b9503d40f8b83709ebdf2a223","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO akahat Remove once lp https://bugs.launchpad.net/tripleo/+bug/1956441 fixed."},{"line_number":3,"context_line":"- name: Install guestfs"},{"line_number":4,"context_line":"  include_tasks: guestfs.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"72156cb8_dc2411b5","line":2,"range":{"start_line":2,"start_character":29,"end_line":2,"end_character":68},"in_reply_to":"4ce3e2b3_01ad1f19","updated":"2022-02-01 06:58:19.000000000","message":"hm, there\u0027s no other task than that one actually. We wouldn\u0027t need to include that guestfs thing if not for that removal.\n\nMaybe reformulating it would make it better. Lemme propose something.","commit_id":"db204456520f7fa3917ee0a807970e3b10b4a1ea"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"96416b2b86233951b9a8eaf7fb1a7240279a8414","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO akahat Remove once lp https://bugs.launchpad.net/tripleo/+bug/1956441 fixed."},{"line_number":3,"context_line":"- name: Install guestfs"},{"line_number":4,"context_line":"  include_tasks: guestfs.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"eacb9da6_8b08d2b9","line":2,"range":{"start_line":2,"start_character":29,"end_line":2,"end_character":68},"in_reply_to":"72156cb8_dc2411b5","updated":"2022-02-01 07:01:24.000000000","message":"Updated message to point the whole file.","commit_id":"db204456520f7fa3917ee0a807970e3b10b4a1ea"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"946dd45644c8615dc0a880b8c5bd9ebe4d6a087a","unresolved":true,"context_lines":[{"line_number":3,"context_line":"- name: Install guestfs"},{"line_number":4,"context_line":"  include_tasks: guestfs.yaml"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Remove fwupd-redfish.conf file from {{ overcloud_image_customize }}"},{"line_number":7,"context_line":"  shell: |"},{"line_number":8,"context_line":"    virt-customize -a {{ overcloud_image_customize }} --run-command \u0027rm -f /usr/lib/modules-load.d/fwupd-redfish.conf\u0027"},{"line_number":9,"context_line":"  args:"},{"line_number":10,"context_line":"    chdir: \"{{ workspace }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"35c84090_b1ed0348","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":4},"updated":"2022-02-01 07:02:19.000000000","message":"the comment about the launchpad bug applies to this task why cant we have it here ?","commit_id":"a88c0ee68dc0c20acdec5d5dafb4c842c7068bda"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"5efa63ce8239f3864b3e1a3d47f8a2b935482841","unresolved":false,"context_lines":[{"line_number":3,"context_line":"- name: Install guestfs"},{"line_number":4,"context_line":"  include_tasks: guestfs.yaml"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Remove fwupd-redfish.conf file from {{ overcloud_image_customize }}"},{"line_number":7,"context_line":"  shell: |"},{"line_number":8,"context_line":"    virt-customize -a {{ overcloud_image_customize }} --run-command \u0027rm -f /usr/lib/modules-load.d/fwupd-redfish.conf\u0027"},{"line_number":9,"context_line":"  args:"},{"line_number":10,"context_line":"    chdir: \"{{ workspace }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"238bd06b_b0185296","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":4},"in_reply_to":"35c84090_b1ed0348","updated":"2022-02-01 08:41:52.000000000","message":"Done","commit_id":"a88c0ee68dc0c20acdec5d5dafb4c842c7068bda"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"daf8e7b9cebcb2b9bb4d95b1a62d72cc7207e24c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO akahat Delete file once lp https://bugs.launchpad.net/tripleo/+bug/1956441 fixed."},{"line_number":3,"context_line":"- name: Install guestfs"},{"line_number":4,"context_line":"  include_tasks: guestfs.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"b7e7f59e_94a5eaae","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":13},"updated":"2022-02-01 07:39:44.000000000","message":"this one is not needed but fine :)","commit_id":"6cd8303618ff546299d9316c5743f54b5cbbad8e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"5efa63ce8239f3864b3e1a3d47f8a2b935482841","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO akahat Delete file once lp https://bugs.launchpad.net/tripleo/+bug/1956441 fixed."},{"line_number":3,"context_line":"- name: Install guestfs"},{"line_number":4,"context_line":"  include_tasks: guestfs.yaml"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"6103fcfe_ebc3c73b","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":13},"in_reply_to":"b7e7f59e_94a5eaae","updated":"2022-02-01 08:41:52.000000000","message":"Ack","commit_id":"6cd8303618ff546299d9316c5743f54b5cbbad8e"}]}
