)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b5803b859624919efac326f83d34a43042eba622","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b825b9e3_6daf9ede","updated":"2022-03-01 07:10:04.000000000","message":"-1 for missing nodeset (https://review.opendev.org/c/openstack/tripleo-ci/+/831201/2/zuul.d/base.yaml#138) and some other minor comments inline","commit_id":"202de0b0be86db13f4e779420fa58d3d70ec909f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6591b232f0da85fc8303d637e3a90b40de6bd983","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bd332a59_0dbe3dc1","updated":"2022-03-01 03:57:36.000000000","message":"recheck","commit_id":"202de0b0be86db13f4e779420fa58d3d70ec909f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"7c3c7c014d95440f2c48a28d6f02a6a1ed92d891","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"297296a0_57c7a97e","updated":"2022-03-01 07:03:45.000000000","message":"recheck tox job mirror issue","commit_id":"202de0b0be86db13f4e779420fa58d3d70ec909f"}],"zuul.d/base-upstream.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2fc18149c0185f1f038b7645b2110d712569276e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0734a01f_16e4c6ea","side":"PARENT","updated":"2022-03-02 07:41:24.000000000","message":"I think we can remove this file. Let\u0027s keep it all in base? just an opinion though perhaps you/others disagree.","commit_id":"1662814677834b1e4761c2d1f1a89c12938c73ec"}],"zuul.d/base.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b5803b859624919efac326f83d34a43042eba622","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    abstract: true"},{"line_number":57,"context_line":"    description: |"},{"line_number":58,"context_line":"        Base abstract job for all TripleO CI zuulv3 jobs"},{"line_number":59,"context_line":"    parent: tripleo-ci-base-required-projects"},{"line_number":60,"context_line":"    timeout: 10800"},{"line_number":61,"context_line":"    post-timeout: 3600"},{"line_number":62,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2718cde8_6e8b25b5","side":"PARENT","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":45},"updated":"2022-03-01 07:10:04.000000000","message":"afaics (hound [1]) this is the only place using it as parent... so lets also remove the definition of it? i.e. lines 10-50 above should be removed here too?\n\n\n[1] https://codesearch.opendev.org/?q\u003dtripleo-ci-base-required-projects\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\n\n\n\n[EDIT]: ah... we are shadowing it so we\u0027ll need to change downstream too before we remove it https://code.engineering.redhat.com/gerrit/gitweb?p\u003dopenstack/tripleo-ci-internal-jobs.git;a\u003dblob;f\u003dzuul.d/required-projects-overrides.yaml","commit_id":"1662814677834b1e4761c2d1f1a89c12938c73ec"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a6e4fce43b17c97a06c7f679649513b7c2a09067","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    abstract: true"},{"line_number":57,"context_line":"    description: |"},{"line_number":58,"context_line":"        Base abstract job for all TripleO CI zuulv3 jobs"},{"line_number":59,"context_line":"    parent: tripleo-ci-base-required-projects"},{"line_number":60,"context_line":"    timeout: 10800"},{"line_number":61,"context_line":"    post-timeout: 3600"},{"line_number":62,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"67f831b8_7eb00cb8","side":"PARENT","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":45},"in_reply_to":"2718cde8_6e8b25b5","updated":"2022-03-01 12:47:34.000000000","message":"Yes correct, we need to follow the same pattern downstream also.","commit_id":"1662814677834b1e4761c2d1f1a89c12938c73ec"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2fc18149c0185f1f038b7645b2110d712569276e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    abstract: true"},{"line_number":57,"context_line":"    description: |"},{"line_number":58,"context_line":"        Base abstract job for all TripleO CI zuulv3 jobs"},{"line_number":59,"context_line":"    parent: tripleo-ci-base-required-projects"},{"line_number":60,"context_line":"    timeout: 10800"},{"line_number":61,"context_line":"    post-timeout: 3600"},{"line_number":62,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7ad9a833_19412c6b","side":"PARENT","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":45},"in_reply_to":"67f831b8_7eb00cb8","updated":"2022-03-02 07:41:24.000000000","message":"Done","commit_id":"1662814677834b1e4761c2d1f1a89c12938c73ec"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b5803b859624919efac326f83d34a43042eba622","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    abstract: true"},{"line_number":57,"context_line":"    description: |"},{"line_number":58,"context_line":"        Base abstract job for all TripleO CI zuulv3 jobs"},{"line_number":59,"context_line":"    parent: tripleo-ci-base-required-projects-upstream"},{"line_number":60,"context_line":"    timeout: 10800"},{"line_number":61,"context_line":"    post-timeout: 3600"},{"line_number":62,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"53f5fbd1_f418f965","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":54},"updated":"2022-03-01 07:10:04.000000000","message":"i think we should also move the definition of this into this file \n\nie. lets not end up with both zuuld/base.yaml and base-upstream.yaml\n\nif you agree it can also be later in the series if you prefer","commit_id":"202de0b0be86db13f4e779420fa58d3d70ec909f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a6e4fce43b17c97a06c7f679649513b7c2a09067","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    abstract: true"},{"line_number":57,"context_line":"    description: |"},{"line_number":58,"context_line":"        Base abstract job for all TripleO CI zuulv3 jobs"},{"line_number":59,"context_line":"    parent: tripleo-ci-base-required-projects-upstream"},{"line_number":60,"context_line":"    timeout: 10800"},{"line_number":61,"context_line":"    post-timeout: 3600"},{"line_number":62,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"47640633_733371ea","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":54},"in_reply_to":"53f5fbd1_f418f965","updated":"2022-03-01 12:47:34.000000000","message":"Done","commit_id":"202de0b0be86db13f4e779420fa58d3d70ec909f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b5803b859624919efac326f83d34a43042eba622","unresolved":true,"context_lines":[{"line_number":135,"context_line":"    abstract: true"},{"line_number":136,"context_line":"    description: |"},{"line_number":137,"context_line":"        Base abstract job for multinode TripleO CI centos-8 zuulv3 jobs"},{"line_number":138,"context_line":"    parent: tripleo-ci-base"},{"line_number":139,"context_line":"    pre-run: playbooks/tripleo-ci/install-built-repo.yml"},{"line_number":140,"context_line":"    post-run: playbooks/tripleo-ci/post-artifact-mult.yml"},{"line_number":141,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f0825e9f_982a0579","line":138,"range":{"start_line":138,"start_character":4,"end_line":138,"end_character":10},"updated":"2022-03-01 07:10:04.000000000","message":"ok but now we need to add         nodeset: two-centos-8-nodes \nhere?","commit_id":"202de0b0be86db13f4e779420fa58d3d70ec909f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a6e4fce43b17c97a06c7f679649513b7c2a09067","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    abstract: true"},{"line_number":136,"context_line":"    description: |"},{"line_number":137,"context_line":"        Base abstract job for multinode TripleO CI centos-8 zuulv3 jobs"},{"line_number":138,"context_line":"    parent: tripleo-ci-base"},{"line_number":139,"context_line":"    pre-run: playbooks/tripleo-ci/install-built-repo.yml"},{"line_number":140,"context_line":"    post-run: playbooks/tripleo-ci/post-artifact-mult.yml"},{"line_number":141,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"18747233_6743f2dc","line":138,"range":{"start_line":138,"start_character":4,"end_line":138,"end_character":10},"in_reply_to":"f0825e9f_982a0579","updated":"2022-03-01 12:47:34.000000000","message":"Done","commit_id":"202de0b0be86db13f4e779420fa58d3d70ec909f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2fc18149c0185f1f038b7645b2110d712569276e","unresolved":true,"context_lines":[{"line_number":8,"context_line":"# out to allow for this job to be shadowed in another repo"},{"line_number":9,"context_line":"# and the required projects overwritten for other environments."},{"line_number":10,"context_line":"- job:"},{"line_number":11,"context_line":"    name: tripleo-ci-base-required-projects"},{"line_number":12,"context_line":"    description: |"},{"line_number":13,"context_line":"        Base abstract job to add required-projects for tripleo-ci-base"},{"line_number":14,"context_line":"    abstract: true"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8e82cceb_045e2651","side":"PARENT","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":8},"updated":"2022-03-02 07:41:24.000000000","message":"can add #TODO(chkumar): remove this once we switch d/stream too","commit_id":"1662814677834b1e4761c2d1f1a89c12938c73ec"}]}