)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"220a51b780f14ebe9373e3848c0b732ce503e656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0a4dba41_0fbd834f","updated":"2022-03-29 05:57:22.000000000","message":"Thanks Cedric,\n\n\nWe need this patch, virt-customize leads to machine-id generation during the image modification. This would then lead to all the OC nodes having the same machine-id, therefore\nleading to some funky situation. Among them, at least for el9, ovs will generate identical MAC addresses for the vlan ports, therefore breaking all the thing and preventing OSP\ninternal networks (such as interal-api) to work, leading to deploy issues.\n\nTried locally, lgtm:-\n\n~~~\n(undercloud) [zuul@undercloud centos9]$ virt-customize -a overcloud-hardened-uefi-full.qcow2  --delete /usr/lib/modules-load.d/fwupd-redfish.conf --truncate /etc/machine-id\n[   0.0] Examining the guest ...\n[  10.7] Setting a random seed\n[  10.7] Deleting: /usr/lib/modules-load.d/fwupd-redfish.conf\n[  10.7] Truncating: /etc/machine-id\n[  10.8] Finishing off\n\ntrying rerun to confirm it won\u0027t fail in case the file isn\u0027t existing.\n\n(undercloud) [zuul@undercloud centos9]$ virt-customize -a overcloud-hardened-uefi-full.qcow2  --delete /usr/lib/modules-load.d/fwupd-redfish.conf --truncate /etc/machine-id\n[   0.0] Examining the guest ...\n[   9.5] Setting a random seed\n[   9.6] Setting the machine ID in /etc/machine-id\n[   9.6] Deleting: /usr/lib/modules-load.d/fwupd-redfish.conf\n[   9.6] Truncating: /etc/machine-id\n[   9.7] Finishing off\n(undercloud) [zuul@undercloud centos9]$ guestfish -a overcloud-hardened-uefi-full.qcow2\n\nWelcome to guestfish, the guest filesystem shell for\nediting virtual machine filesystems and disk images.\n\nType: ‘help’ for help on commands\n      ‘man’ to read the manual\n      ‘quit’ to quit the shell\n\n\u003e\u003cfs\u003e run\n\u003e\u003cfs\u003e mount /dev/vg/lv_root /\n\u003e\u003cfs\u003e cat /etc/machine-id \n\n\u003e\u003cfs\u003e cat /usr/lib/modules-load.d/fwupd-redfish.conf\nlibguestfs: error: download: /usr/lib/modules-load.d/fwupd-redfish.conf: No such file or directory\n\u003e\u003cfs\u003e \n~~~\n\n","commit_id":"c13188b92a4397ed29431843a2ac1f7cb81d68f8"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"1a9ed07c335cc7b383304ed49a573504c22edf35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"543c5aa4_a0971247","updated":"2022-03-29 08:12:47.000000000","message":"recheck","commit_id":"c13188b92a4397ed29431843a2ac1f7cb81d68f8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"190f843988194c2403dfd8b406b49e19e30b5e47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3e0d4645_e04b5309","updated":"2022-03-29 11:51:13.000000000","message":"14:50 \u003c marios|ruck\u003e ysandeep: hmmm Tengu patch is now blocked on another issue\n14:50 \u003c marios|ruck\u003e centos8 stream \n14:50 \u003c marios|ruck\u003e https://bugs.launchpad.net/tripleo/+bug/1966914/comments/3 \n","commit_id":"0fa525bf8545282c30594d07becdd2b5b5a129a7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"de41d7cf9127e95814384a0c3ee24a55d48a7cf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ff74be7a_c20f54e3","updated":"2022-03-30 06:30:58.000000000","message":"apologies Cedric\n\nThe parent patch from yesterday (black https://review.opendev.org/c/openstack/tripleo-ci/+/835547/9 ) merged\n\nHowever I have to fix the job freeze issue for another patch which is a gate blocker (https://review.opendev.org/c/openstack/tripleo-heat-templates/+/835678/1#message-06c9508fe770fc8890676a41cd065cbc5b16f593 ) so i had to post https://review.opendev.org/c/openstack/tripleo-ci/+/835776\n\non that 835776 i saw the same freeze issue we were fixing here.. so I moved the fix into that 835776 and have rebased this onto it.\n\nsorry for the messing around hope we can get this in today .","commit_id":"d8cdaff0d46ac7e85edaa67856824640d389adf6"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d9939d0d7860fb4e395b8456b14cfd18b004e769","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"91be7dd3_455ac19a","in_reply_to":"ff74be7a_c20f54e3","updated":"2022-03-30 08:03:46.000000000","message":"no problem at all - thanks for keeping that one rolling :)","commit_id":"d8cdaff0d46ac7e85edaa67856824640d389adf6"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"6319c502082d46b63a5385cabd79c967246ece5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8db6221d_43409894","updated":"2022-04-01 05:24:08.000000000","message":"recheck\n\npfrttt. NODE_FAILURE","commit_id":"dc69c653f71904bf96e12dc220258fcfa9c35119"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"59a36f8fa870cae947ade5a97f989ae2845a5449","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4e705c61_82b3ee84","updated":"2022-04-04 05:38:31.000000000","message":"re-adding the +W - we have enough votes anyway :).","commit_id":"dcc54a89ee68ca9f6732875fe3032d903302cb15"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"61d9ed9965c80b1d88d91c2bffe887af07d9a45e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fcac624f_caafa1c6","updated":"2022-04-04 20:10:18.000000000","message":"recheck","commit_id":"dcc54a89ee68ca9f6732875fe3032d903302cb15"}],"zuul.d/standalone-jobs.yaml":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"05e0ef2a33ee41668ffaa7320f09ac06ac10536d","unresolved":true,"context_lines":[{"line_number":67,"context_line":"      - ^test-requirements.txt$"},{"line_number":68,"context_line":"      - ^vars/sova-patterns.yml$"},{"line_number":69,"context_line":"      - tox.ini"},{"line_number":70,"context_line":"      - ^setup.*$"},{"line_number":71,"context_line":"      - ^scripts/.*"},{"line_number":72,"context_line":"      # like parent but with requirements.txt and setup.py removed"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9b4b9158_1e8f4dcb","line":70,"updated":"2022-03-29 11:44:15.000000000","message":"content-provider have tripleo-ci-base-standard as its parent in its parent-child heirarchy. Which have ^.pre-commit-config.yaml$ in irrelevant-files.\n\nhttps://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/base-upstream.yaml#L95\n~~~\n^.pre-commit-config.yaml$\n~~~\n\n\n\nInstead of overriding content-provider irrelevant-files var in project-template, I wonder adding ^.pre-commit-config.yaml$ under tripleo-ci-centos-7-standalone anchor (here) would be a better idea.","commit_id":"0fa525bf8545282c30594d07becdd2b5b5a129a7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"58fdab284a38751648f7d71af90e254be8c72b94","unresolved":false,"context_lines":[{"line_number":67,"context_line":"      - ^test-requirements.txt$"},{"line_number":68,"context_line":"      - ^vars/sova-patterns.yml$"},{"line_number":69,"context_line":"      - tox.ini"},{"line_number":70,"context_line":"      - ^setup.*$"},{"line_number":71,"context_line":"      - ^scripts/.*"},{"line_number":72,"context_line":"      # like parent but with requirements.txt and setup.py removed"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d7660fcf_5e3dcd4f","line":70,"in_reply_to":"9b4b9158_1e8f4dcb","updated":"2022-03-29 11:46:28.000000000","message":"please go ahead sandeep I have to focus on other stuff for ruck duty \nif it works would be cleaner but assuming tengu isn\u0027t in a rush\n\ncould go with this to get his patch merged and try fix that as a new patch? up to you thanks","commit_id":"0fa525bf8545282c30594d07becdd2b5b5a129a7"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"5aab41a6637ef1954ec0ede77da2ea07906e9007","unresolved":false,"context_lines":[{"line_number":67,"context_line":"      - ^test-requirements.txt$"},{"line_number":68,"context_line":"      - ^vars/sova-patterns.yml$"},{"line_number":69,"context_line":"      - tox.ini"},{"line_number":70,"context_line":"      - ^setup.*$"},{"line_number":71,"context_line":"      - ^scripts/.*"},{"line_number":72,"context_line":"      # like parent but with requirements.txt and setup.py removed"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"64af87cc_9537ad4e","line":70,"in_reply_to":"d7660fcf_5e3dcd4f","updated":"2022-03-29 14:05:02.000000000","message":"Okay, so my suggestion didn\u0027t work.\n\nI have reverted to the patchset which Marios uploaded to get this through.","commit_id":"0fa525bf8545282c30594d07becdd2b5b5a129a7"}]}
