)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"be5f412b3edbb6c533abe54b052ac2cfb76ac07a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a9b7ad9d_8880f223","updated":"2022-04-20 06:41:43.000000000","message":"Looks good,\n\ntripleo.sh have some leftovers as well for older branches but can be cleaned up in follow up patches.\n\nhttps://github.com/openstack/tripleo-ci/blob/d492451c1311e6d83cc7816ca93a5381948dea50/scripts/tripleo.sh#L486\n","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"84f52c0174690866614e8c51710eb0bb9185deae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8546083b_62264d09","updated":"2022-04-20 10:19:09.000000000","message":"There are few reference of Newton release, Since Newton is also EOL. Can we include that also. Since we already touched newton part.","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d9945f20831ab98da47873189c8abd28b377b942","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"302997ca_119c078b","updated":"2022-04-20 10:31:42.000000000","message":"ack lets include some more stuff good call thanks for reviews folks","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c956bd8fd03cc2764cce76d51a75f9057984c0c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c84de45d_1e618f8b","updated":"2022-04-20 07:49:25.000000000","message":"thanks for reviewing @Sandeep","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"bdd4d25e73222c80e79ece6ff2e4242a42aeeac8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a32a5cf4_ca73f373","in_reply_to":"919895c3_7ade5399","updated":"2022-04-20 08:59:03.000000000","message":"Thanks marios, +1 to be removed as a follow up.","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c956bd8fd03cc2764cce76d51a75f9057984c0c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"919895c3_7ade5399","in_reply_to":"a9b7ad9d_8880f223","updated":"2022-04-20 07:49:25.000000000","message":"yeah i saw those but hesitated... really we should just remove that entire script i don\u0027t think anything is using it \n\nit used to live somewhere else (tripleo heat templates maybe?) and was meant for devs but nowadays... i wonder if people even know it is in this repo...\n\ni think it can just be removed perhaps as a followup WDYT?","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"527a06f8251a3ef74017214e796725c720dd3d0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"109b42c7_587cae61","updated":"2022-04-20 11:36:11.000000000","message":"Thanks!","commit_id":"800d36d83f1419e4ff9cc403b5a49ea9f9ae9185"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"70a794a8112471572bf7ea7640c7747fc48221bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1b776a93_94c7197e","updated":"2022-04-21 06:32:07.000000000","message":"recheck\n\nhttps://zuul.opendev.org/t/openstack/build/41b627d058de4d36b1841de76f3eccf1\n\n  - cannot install the best update candidate for package python36-devel-3.6.8-2.module_el8.5.0+751+b79b40be.x86_64\n  - cannot install the best update candidate for package platform-python-3.6.8-37.el8.x86_64","commit_id":"800d36d83f1419e4ff9cc403b5a49ea9f9ae9185"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5af7d37f649325815dc12b7b858375909d74661a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e913c1d4_f3179d31","updated":"2022-04-20 14:14:58.000000000","message":"recheck ","commit_id":"800d36d83f1419e4ff9cc403b5a49ea9f9ae9185"}],"roles/build-containers/templates/kolla-build.sh.j2":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"be5f412b3edbb6c533abe54b052ac2cfb76ac07a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -eux"},{"line_number":2,"context_line":"{% if buildcontainers_venv is defined and buildcontainers_venv %}"},{"line_number":3,"context_line":"source {{ workspace }}/venv_build/bin/activate"},{"line_number":4,"context_line":"pip install -U decorator"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"a2c558a3_46d4925e","side":"PARENT","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":16},"updated":"2022-04-20 06:41:43.000000000","message":"Haven\u0027t we moved everything to tcib, I wonder if we still use this file anywhere? need to check c7 train.","commit_id":"00df6fcb4e2e568af720ef404e62c0fb8bee3c3e"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"9e8e46327f0d8f0d5d4d079f66e1075df8a5c353","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -eux"},{"line_number":2,"context_line":"{% if buildcontainers_venv is defined and buildcontainers_venv %}"},{"line_number":3,"context_line":"source {{ workspace }}/venv_build/bin/activate"},{"line_number":4,"context_line":"pip install -U decorator"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9e92b976_535ca2a0","side":"PARENT","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":16},"in_reply_to":"928be2f8_64ac647c","updated":"2022-04-20 08:59:31.000000000","message":"ack, thanks!","commit_id":"00df6fcb4e2e568af720ef404e62c0fb8bee3c3e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c956bd8fd03cc2764cce76d51a75f9057984c0c4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -eux"},{"line_number":2,"context_line":"{% if buildcontainers_venv is defined and buildcontainers_venv %}"},{"line_number":3,"context_line":"source {{ workspace }}/venv_build/bin/activate"},{"line_number":4,"context_line":"pip install -U decorator"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"928be2f8_64ac647c","side":"PARENT","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":16},"in_reply_to":"a2c558a3_46d4925e","updated":"2022-04-20 07:49:25.000000000","message":"yeah same as the tripleo.sh ... i was wondering if i should update this or remove... i\u0027ll leave this in here for now but we could remove with tripleo.sh as a separate patch if there is nothing using it any more","commit_id":"00df6fcb4e2e568af720ef404e62c0fb8bee3c3e"}],"roles/run-test/templates/oooq_common_functions.sh.j2":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"84f52c0174690866614e8c51710eb0bb9185deae","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    case \"${release}\" in"},{"line_number":44,"context_line":"        \u0027\u0027|master)"},{"line_number":45,"context_line":"            # NOTE: we need to update this when we cut a stable branch"},{"line_number":46,"context_line":"            echo \"newton\""},{"line_number":47,"context_line":"            ;;"},{"line_number":48,"context_line":"        wallaby)"},{"line_number":49,"context_line":"            echo \"train\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"0ed1eafe_348ee69d","line":46,"range":{"start_line":46,"start_character":18,"end_line":46,"end_character":24},"updated":"2022-04-20 10:19:09.000000000","message":"Can we update this also?","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8b1c571a20344c88479b5e17421d51ee24479652","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    case \"${release}\" in"},{"line_number":44,"context_line":"        \u0027\u0027|master)"},{"line_number":45,"context_line":"            # NOTE: we need to update this when we cut a stable branch"},{"line_number":46,"context_line":"            echo \"newton\""},{"line_number":47,"context_line":"            ;;"},{"line_number":48,"context_line":"        wallaby)"},{"line_number":49,"context_line":"            echo \"train\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"b48cada8_2a08254f","line":46,"range":{"start_line":46,"start_character":18,"end_line":46,"end_character":24},"in_reply_to":"0ed1eafe_348ee69d","updated":"2022-04-20 10:56:32.000000000","message":"Done","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"}],"scripts/emit_releases_file/emit_releases_file.py":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"84f52c0174690866614e8c51710eb0bb9185deae","unresolved":true,"context_lines":[{"line_number":43,"context_line":"LONG_TERM_SUPPORT_RELEASES \u003d [\u0027train\u0027, \u0027wallaby\u0027]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# NAMED DLRN HASHES"},{"line_number":46,"context_line":"NEWTON_HASH_NAME \u003d \u0027current-passed-ci\u0027"},{"line_number":47,"context_line":"CURRENT_HASH_NAME \u003d \u0027current-tripleo\u0027"},{"line_number":48,"context_line":"NEWEST_HASH_NAME \u003d \u0027current\u0027"},{"line_number":49,"context_line":"PROMOTION_HASH_NAME \u003d \u0027tripleo-ci-testing\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"82b17833_535696bb","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":38},"updated":"2022-04-20 10:19:09.000000000","message":"ditto","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8b1c571a20344c88479b5e17421d51ee24479652","unresolved":false,"context_lines":[{"line_number":43,"context_line":"LONG_TERM_SUPPORT_RELEASES \u003d [\u0027train\u0027, \u0027wallaby\u0027]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# NAMED DLRN HASHES"},{"line_number":46,"context_line":"NEWTON_HASH_NAME \u003d \u0027current-passed-ci\u0027"},{"line_number":47,"context_line":"CURRENT_HASH_NAME \u003d \u0027current-tripleo\u0027"},{"line_number":48,"context_line":"NEWEST_HASH_NAME \u003d \u0027current\u0027"},{"line_number":49,"context_line":"PROMOTION_HASH_NAME \u003d \u0027tripleo-ci-testing\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"04af8529_6a7929bd","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":38},"in_reply_to":"82b17833_535696bb","updated":"2022-04-20 10:56:32.000000000","message":"Done","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"84f52c0174690866614e8c51710eb0bb9185deae","unresolved":true,"context_lines":[{"line_number":192,"context_line":"    ) and stable_release \u003d\u003d RELEASES[0]:"},{"line_number":193,"context_line":"        raise RuntimeError(\"Cannot upgrade to {}\".format(RELEASES[0]))"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    if featureset.get(\u0027undercloud_upgrade\u0027) and stable_release \u003d\u003d \u0027ocata\u0027:"},{"line_number":196,"context_line":"        raise RuntimeError("},{"line_number":197,"context_line":"            \"Undercloud upgrades are not supported from \" \"newton to ocata\""},{"line_number":198,"context_line":"        )"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    if featureset.get(\u0027overcloud_upgrade\u0027) and featureset.get(\u0027undercloud_upgrade\u0027):"},{"line_number":201,"context_line":"        raise RuntimeError("}],"source_content_type":"text/x-python","patch_set":2,"id":"16d7204b_4153fed9","line":198,"range":{"start_line":195,"start_character":4,"end_line":198,"end_character":9},"updated":"2022-04-20 10:19:09.000000000","message":"We can get rid of this also.","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fe48077466ccd5b97bcb6c23c182adb2c0d8a9db","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    ) and stable_release \u003d\u003d RELEASES[0]:"},{"line_number":193,"context_line":"        raise RuntimeError(\"Cannot upgrade to {}\".format(RELEASES[0]))"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    if featureset.get(\u0027undercloud_upgrade\u0027) and stable_release \u003d\u003d \u0027ocata\u0027:"},{"line_number":196,"context_line":"        raise RuntimeError("},{"line_number":197,"context_line":"            \"Undercloud upgrades are not supported from \" \"newton to ocata\""},{"line_number":198,"context_line":"        )"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    if featureset.get(\u0027overcloud_upgrade\u0027) and featureset.get(\u0027undercloud_upgrade\u0027):"},{"line_number":201,"context_line":"        raise RuntimeError("}],"source_content_type":"text/x-python","patch_set":2,"id":"dc95dac2_482b86c5","line":198,"range":{"start_line":195,"start_character":4,"end_line":198,"end_character":9},"in_reply_to":"0cd77614_c2e250e6","updated":"2022-04-20 10:56:41.000000000","message":"Done","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d9945f20831ab98da47873189c8abd28b377b942","unresolved":true,"context_lines":[{"line_number":192,"context_line":"    ) and stable_release \u003d\u003d RELEASES[0]:"},{"line_number":193,"context_line":"        raise RuntimeError(\"Cannot upgrade to {}\".format(RELEASES[0]))"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    if featureset.get(\u0027undercloud_upgrade\u0027) and stable_release \u003d\u003d \u0027ocata\u0027:"},{"line_number":196,"context_line":"        raise RuntimeError("},{"line_number":197,"context_line":"            \"Undercloud upgrades are not supported from \" \"newton to ocata\""},{"line_number":198,"context_line":"        )"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    if featureset.get(\u0027overcloud_upgrade\u0027) and featureset.get(\u0027undercloud_upgrade\u0027):"},{"line_number":201,"context_line":"        raise RuntimeError("}],"source_content_type":"text/x-python","patch_set":2,"id":"0cd77614_c2e250e6","line":198,"range":{"start_line":195,"start_character":4,"end_line":198,"end_character":9},"in_reply_to":"16d7204b_4153fed9","updated":"2022-04-20 10:31:42.000000000","message":"yes good call 😄","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"84f52c0174690866614e8c51710eb0bb9185deae","unresolved":true,"context_lines":[{"line_number":229,"context_line":"    newest_hash \u003d get_dlrn_hash("},{"line_number":230,"context_line":"        stable_release, NEWEST_HASH_NAME, distro_name, distro_version"},{"line_number":231,"context_line":"    )"},{"line_number":232,"context_line":"    if stable_release \u003d\u003d \u0027newton\u0027:"},{"line_number":233,"context_line":"        current_hash \u003d get_dlrn_hash("},{"line_number":234,"context_line":"            stable_release, NEWTON_HASH_NAME, distro_name, distro_version"},{"line_number":235,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"bb470d16_3ce854f2","line":232,"range":{"start_line":232,"start_character":26,"end_line":232,"end_character":34},"updated":"2022-04-20 10:19:09.000000000","message":"This one also.","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d9945f20831ab98da47873189c8abd28b377b942","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    newest_hash \u003d get_dlrn_hash("},{"line_number":230,"context_line":"        stable_release, NEWEST_HASH_NAME, distro_name, distro_version"},{"line_number":231,"context_line":"    )"},{"line_number":232,"context_line":"    if stable_release \u003d\u003d \u0027newton\u0027:"},{"line_number":233,"context_line":"        current_hash \u003d get_dlrn_hash("},{"line_number":234,"context_line":"            stable_release, NEWTON_HASH_NAME, distro_name, distro_version"},{"line_number":235,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"e6ba34ee_e3036f68","line":232,"range":{"start_line":232,"start_character":26,"end_line":232,"end_character":34},"in_reply_to":"bb470d16_3ce854f2","updated":"2022-04-20 10:31:42.000000000","message":"Ack","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"84f52c0174690866614e8c51710eb0bb9185deae","unresolved":true,"context_lines":[{"line_number":272,"context_line":"        if featureset.get(\u0027overcloud_upgrade\u0027):"},{"line_number":273,"context_line":"            logger.info(\u0027Doing an overcloud upgrade\u0027)"},{"line_number":274,"context_line":"            deploy_release \u003d get_relative_release(stable_release, -1)"},{"line_number":275,"context_line":"            if deploy_release \u003d\u003d \u0027newton\u0027:"},{"line_number":276,"context_line":"                deploy_hash \u003d get_dlrn_hash("},{"line_number":277,"context_line":"                    deploy_release, NEWTON_HASH_NAME, distro_name, distro_version"},{"line_number":278,"context_line":"                )"},{"line_number":279,"context_line":"            else:"},{"line_number":280,"context_line":"                deploy_hash \u003d get_dlrn_hash("},{"line_number":281,"context_line":"                    deploy_release, CURRENT_HASH_NAME, distro_name, distro_version"}],"source_content_type":"text/x-python","patch_set":2,"id":"37557b4d_d6e12611","line":278,"range":{"start_line":275,"start_character":12,"end_line":278,"end_character":17},"updated":"2022-04-20 10:19:09.000000000","message":"more reference to newton","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8b1c571a20344c88479b5e17421d51ee24479652","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        if featureset.get(\u0027overcloud_upgrade\u0027):"},{"line_number":273,"context_line":"            logger.info(\u0027Doing an overcloud upgrade\u0027)"},{"line_number":274,"context_line":"            deploy_release \u003d get_relative_release(stable_release, -1)"},{"line_number":275,"context_line":"            if deploy_release \u003d\u003d \u0027newton\u0027:"},{"line_number":276,"context_line":"                deploy_hash \u003d get_dlrn_hash("},{"line_number":277,"context_line":"                    deploy_release, NEWTON_HASH_NAME, distro_name, distro_version"},{"line_number":278,"context_line":"                )"},{"line_number":279,"context_line":"            else:"},{"line_number":280,"context_line":"                deploy_hash \u003d get_dlrn_hash("},{"line_number":281,"context_line":"                    deploy_release, CURRENT_HASH_NAME, distro_name, distro_version"}],"source_content_type":"text/x-python","patch_set":2,"id":"988db2e3_140de6fe","line":278,"range":{"start_line":275,"start_character":12,"end_line":278,"end_character":17},"in_reply_to":"37557b4d_d6e12611","updated":"2022-04-20 10:56:32.000000000","message":"Done","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"84f52c0174690866614e8c51710eb0bb9185deae","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        elif featureset.get(\u0027ffu_overcloud_upgrade\u0027):"},{"line_number":287,"context_line":"            logger.info(\u0027Doing an overcloud fast forward upgrade\u0027)"},{"line_number":288,"context_line":"            deploy_release \u003d get_relative_release(stable_release, -3)"},{"line_number":289,"context_line":"            if deploy_release \u003d\u003d \u0027newton\u0027:"},{"line_number":290,"context_line":"                deploy_hash \u003d get_dlrn_hash("},{"line_number":291,"context_line":"                    deploy_release, NEWTON_HASH_NAME, distro_name, distro_version"},{"line_number":292,"context_line":"                )"},{"line_number":293,"context_line":"            else:"},{"line_number":294,"context_line":"                deploy_hash \u003d get_dlrn_hash("},{"line_number":295,"context_line":"                    deploy_release, CURRENT_HASH_NAME, distro_name, distro_version"}],"source_content_type":"text/x-python","patch_set":2,"id":"ea9f8dfa_09ada1a8","line":292,"range":{"start_line":289,"start_character":0,"end_line":292,"end_character":17},"updated":"2022-04-20 10:19:09.000000000","message":"ditto","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8b1c571a20344c88479b5e17421d51ee24479652","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        elif featureset.get(\u0027ffu_overcloud_upgrade\u0027):"},{"line_number":287,"context_line":"            logger.info(\u0027Doing an overcloud fast forward upgrade\u0027)"},{"line_number":288,"context_line":"            deploy_release \u003d get_relative_release(stable_release, -3)"},{"line_number":289,"context_line":"            if deploy_release \u003d\u003d \u0027newton\u0027:"},{"line_number":290,"context_line":"                deploy_hash \u003d get_dlrn_hash("},{"line_number":291,"context_line":"                    deploy_release, NEWTON_HASH_NAME, distro_name, distro_version"},{"line_number":292,"context_line":"                )"},{"line_number":293,"context_line":"            else:"},{"line_number":294,"context_line":"                deploy_hash \u003d get_dlrn_hash("},{"line_number":295,"context_line":"                    deploy_release, CURRENT_HASH_NAME, distro_name, distro_version"}],"source_content_type":"text/x-python","patch_set":2,"id":"aec7f3fa_a6256503","line":292,"range":{"start_line":289,"start_character":0,"end_line":292,"end_character":17},"in_reply_to":"ea9f8dfa_09ada1a8","updated":"2022-04-20 10:56:32.000000000","message":"Done","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"84f52c0174690866614e8c51710eb0bb9185deae","unresolved":true,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    For overcloud upgrade jobs we start with already upgraded undercloud"},{"line_number":358,"context_line":"    and use config files named \"{{target}}-undercloud-{{deploy}}-overcloud\""},{"line_number":359,"context_line":"    like ocata-undercloud-newton-overcloud so we need to set both deploy and"},{"line_number":360,"context_line":"    target names to point this release config."},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    For periodic jobs the deploy and target config files are in files named"}],"source_content_type":"text/x-python","patch_set":2,"id":"0c794913_4ac7f5e6","line":359,"range":{"start_line":359,"start_character":9,"end_line":359,"end_character":42},"updated":"2022-04-20 10:19:09.000000000","message":"ditto","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8b1c571a20344c88479b5e17421d51ee24479652","unresolved":false,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    For overcloud upgrade jobs we start with already upgraded undercloud"},{"line_number":358,"context_line":"    and use config files named \"{{target}}-undercloud-{{deploy}}-overcloud\""},{"line_number":359,"context_line":"    like ocata-undercloud-newton-overcloud so we need to set both deploy and"},{"line_number":360,"context_line":"    target names to point this release config."},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    For periodic jobs the deploy and target config files are in files named"}],"source_content_type":"text/x-python","patch_set":2,"id":"7063fb54_d8ac33dc","line":359,"range":{"start_line":359,"start_character":9,"end_line":359,"end_character":42},"in_reply_to":"0c794913_4ac7f5e6","updated":"2022-04-20 10:56:32.000000000","message":"left this as it is just a comment and we don\u0027t have a \u0027new\u0027 alternative to use instead (it is only for old stuff... probably we can remove this function but i am not brave enough in this review ;) I think the broom has collected enough on this pass)","commit_id":"4c03bb70fa3b85a540e687981491457519826f51"}]}