)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"08d1ab41a4fdecdb81e6edd491ae300987d70c02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a12f74d_a06b7e30","updated":"2022-07-04 13:03:07.000000000","message":"Thanks for reviewing Sandeep","commit_id":"eee6a2a18bf7debef1c636720100551b19db822a"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"5d840a52e7620f79643b7fbf20f09e7d3504c9bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a50a0271_e3cb498f","updated":"2022-07-04 11:25:56.000000000","message":"fips job is green:-\n\ntripleo-ci-centos-9-standalone-fips https://zuul.opendev.org/t/openstack/build/e0affc696c2045dcbd8ab743a52c39c7 : SUCCESS in 1h 37m 56s (non-voting)\n\n\nWhat checks one can do to ensure fips is correctly enabled in a job?","commit_id":"eee6a2a18bf7debef1c636720100551b19db822a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"095f8adfb663831e46b4eced412a2c12c5e0b26a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"310538e2_4b3eb41e","updated":"2022-06-29 18:25:28.000000000","message":"recheck","commit_id":"eee6a2a18bf7debef1c636720100551b19db822a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6d3cddb8e7fc9cb74a6732e817a4de7b43ee405b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"544532fa_a15d53e4","updated":"2022-06-29 12:06:18.000000000","message":"recheck","commit_id":"eee6a2a18bf7debef1c636720100551b19db822a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"06d7e9bdd802a72f77c26b2828ef352f31375551","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"31aafcc9_5ed8c797","updated":"2022-06-30 11:30:11.000000000","message":"recheck\n\nstandalon012 fix merged: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/848136/\n","commit_id":"eee6a2a18bf7debef1c636720100551b19db822a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"46701d5459f99c0baf30bd04600dbb2306737c25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"32bd1605_501d1752","updated":"2022-07-01 12:21:18.000000000","message":"recheck\n\nstandalone failures seems to be fixed:\nhttps://zuul.opendev.org/t/openstack/builds?job_name\u003dtripleo-ci-centos-9-scenario001-standalone\u0026skip\u003d0","commit_id":"eee6a2a18bf7debef1c636720100551b19db822a"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"d48233a7493a8cb86d958cfa023a8d0f3c35a2c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b7d6ac2f_ebdb1636","in_reply_to":"0facaa0b_db229325","updated":"2022-07-05 06:08:10.000000000","message":"Thanks for these details, Douglas.","commit_id":"eee6a2a18bf7debef1c636720100551b19db822a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"08d1ab41a4fdecdb81e6edd491ae300987d70c02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0facaa0b_db229325","in_reply_to":"a50a0271_e3cb498f","updated":"2022-07-04 13:03:07.000000000","message":"Thanks for asking Sandeep, there are some places that we can check:\n\n1) sysctl shows: crypto.fips_enabled \u003d 1\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_e0a/847858/2/check/tripleo-ci-centos-9-standalone-fips/e0affc6/logs/undercloud/var/log/extra/sysctl.txt\n\n2) kernel boot command line:\nBOOT_IMAGE\u003d(hd0,msdos1)/boot/vmlinuz-5.14.0-119.el9.x86_64 root\u003dLABEL\u003dcloudimg-rootfs ro console\u003dtty0 console\u003dttyS0,115200 no_timer_check nofb nomodeset gfxpayload\u003dtext fips\u003d1\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_e0a/847858/2/check/tripleo-ci-centos-9-standalone-fips/e0affc6/logs/undercloud/var/log/extra/dmesg.txt\n\n3) The role execution itself, which enables fips and reboot the node:\nTASK [enable-fips : Reboot server for FIPS mode]\nprimary | changed\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_e0a/847858/2/check/tripleo-ci-centos-9-standalone-fips/e0affc6/job-output.txt","commit_id":"eee6a2a18bf7debef1c636720100551b19db822a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"d5bb4c269ca88959475757b9a651852a30314c52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7e9788db_0c7ffe9c","updated":"2022-07-06 12:19:43.000000000","message":"Good to go","commit_id":"20f403117981bccbe1e851135094cd8c96afbafd"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"d48233a7493a8cb86d958cfa023a8d0f3c35a2c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e715b486_f76d0d02","updated":"2022-07-05 06:08:10.000000000","message":"this looks good to me, Couldn\u0027t spot any further error.","commit_id":"20f403117981bccbe1e851135094cd8c96afbafd"}],"roles/run-test/tasks/main.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a52746695b89ce6c4962eeb7cde01997066516e8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"          - \u0027dlrn_hash_tag\u0027"},{"line_number":15,"context_line":"          - \u0027dlrn_hash_tag_newest\u0027"},{"line_number":16,"context_line":"          - \u0027extra_args\u0027"},{"line_number":17,"context_line":"          - \u0027enable_fips\u0027"},{"line_number":18,"context_line":"          - \u0027run_tempest\u0027"},{"line_number":19,"context_line":"          - \u0027standalone_container_cli\u0027"},{"line_number":20,"context_line":"          - \u0027standalone_environment_files\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"60baf3c9_faaef39c","line":17,"range":{"start_line":17,"start_character":13,"end_line":17,"end_character":24},"updated":"2022-07-05 06:54:12.000000000","message":"so i guess we need this because we don\u0027t have a dedicated \u0027fips\u0027 featureset? \n\n[EDIT]: yeah looks like it uses the standalone as parent so fs 52 shared. fine","commit_id":"20f403117981bccbe1e851135094cd8c96afbafd"}],"zuul.d/base-upstream.yaml":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"5d840a52e7620f79643b7fbf20f09e7d3504c9bd","unresolved":true,"context_lines":[{"line_number":67,"context_line":"      bridge_address_subnet: 24"},{"line_number":68,"context_line":"      bridge_address_offset: 2"},{"line_number":69,"context_line":"      bridge_mtu: 1350"},{"line_number":70,"context_line":"    roles:"},{"line_number":71,"context_line":"      - zuul: opendev.org/zuul/zuul-jobs"},{"line_number":72,"context_line":"      - zuul: opendev.org/openstack/openstack-zuul-jobs"},{"line_number":73,"context_line":"    pre-run:"},{"line_number":74,"context_line":"      - playbooks/nodepool-provider/pre.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2ffe8ac1_8b9af135","side":"PARENT","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":40},"updated":"2022-07-04 11:25:56.000000000","message":"What is the context behind removing inclusion of this role?","commit_id":"3866735c4e091cff8a40377409e3fcc0572b4542"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"08d1ab41a4fdecdb81e6edd491ae300987d70c02","unresolved":true,"context_lines":[{"line_number":67,"context_line":"      bridge_address_subnet: 24"},{"line_number":68,"context_line":"      bridge_address_offset: 2"},{"line_number":69,"context_line":"      bridge_mtu: 1350"},{"line_number":70,"context_line":"    roles:"},{"line_number":71,"context_line":"      - zuul: opendev.org/zuul/zuul-jobs"},{"line_number":72,"context_line":"      - zuul: opendev.org/openstack/openstack-zuul-jobs"},{"line_number":73,"context_line":"    pre-run:"},{"line_number":74,"context_line":"      - playbooks/nodepool-provider/pre.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ee02ead9_d72adb01","side":"PARENT","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":40},"in_reply_to":"2ffe8ac1_8b9af135","updated":"2022-07-04 13:03:07.000000000","message":"I think that I removed by mistake, there is no need for that. I will add it back","commit_id":"3866735c4e091cff8a40377409e3fcc0572b4542"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b0914d160037834b8be05f037b8fd56fff9c3e5c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"      bridge_address_subnet: 24"},{"line_number":68,"context_line":"      bridge_address_offset: 2"},{"line_number":69,"context_line":"      bridge_mtu: 1350"},{"line_number":70,"context_line":"    roles:"},{"line_number":71,"context_line":"      - zuul: opendev.org/zuul/zuul-jobs"},{"line_number":72,"context_line":"      - zuul: opendev.org/openstack/openstack-zuul-jobs"},{"line_number":73,"context_line":"    pre-run:"},{"line_number":74,"context_line":"      - playbooks/nodepool-provider/pre.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ae7650af_9322e14e","side":"PARENT","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":40},"in_reply_to":"ee02ead9_d72adb01","updated":"2022-07-04 13:08:22.000000000","message":"Done","commit_id":"3866735c4e091cff8a40377409e3fcc0572b4542"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a52746695b89ce6c4962eeb7cde01997066516e8","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    description: |"},{"line_number":12,"context_line":"        Base abstract job to add common required-projects for tripleo-ci-base"},{"line_number":13,"context_line":"    abstract: true"},{"line_number":14,"context_line":"    parent: multinode-fips"},{"line_number":15,"context_line":"    required-projects:"},{"line_number":16,"context_line":"      - opendev.org/openstack/tripleo-ci"},{"line_number":17,"context_line":"      - opendev.org/openstack/tripleo-quickstart"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f7c867a4_f3e400da","line":14,"range":{"start_line":14,"start_character":9,"end_line":14,"end_character":14},"updated":"2022-07-05 06:54:12.000000000","message":"should be OK.. it is governed by the enable_fips parameter https://opendev.org/zuul/zuul-jobs/src/commit/812e063513044e86bd1570d8b3f9baa3276763a4/playbooks/enable-fips/pre.yaml#L9\n\nwould have been safer if that ^^ defaulted to false ;) but we are defaulting false here so fine.","commit_id":"20f403117981bccbe1e851135094cd8c96afbafd"}]}