)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2fdd14724b1c7fb8ff74b2959d25015480793a34","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Removal of tempest_whitelist variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch removes tempest_whitelist variable used"},{"line_number":10,"context_line":"in fs52 standalone job definitions as tempest allowed group"},{"line_number":11,"context_line":"is in place now."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Ref :"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"59a2f6a4_7ea147a8","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":7},"updated":"2022-06-30 06:25:27.000000000","message":"actually, this is not just fs52 wider affecting all the jobs. it removes the tempest_whitelist completely","commit_id":"1568a634906fd17299c284ee990b9d5a5dd323f1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e4bb4575e79ca157fc032bd886613599bd66649e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Removal of tempest_whitelist variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch removes tempest_whitelist variable used"},{"line_number":10,"context_line":"in fs52 standalone job definitions as tempest allowed group"},{"line_number":11,"context_line":"is in place now."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Ref :"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"779ce977_f9ddfe5d","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":7},"in_reply_to":"0caf9e40_bc077bc6","updated":"2022-07-01 07:49:55.000000000","message":"as per the other comment you should workflow -1 as this will affect all jobs we need this one last","commit_id":"1568a634906fd17299c284ee990b9d5a5dd323f1"},{"author":{"_account_id":31075,"name":"Pooja Jadhav","email":"pojadhav@redhat.com","username":"pojadhav"},"change_message_id":"71da57ab9993203eda6a2bc0de0cb9d61d8d5540","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Removal of tempest_whitelist variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch removes tempest_whitelist variable used"},{"line_number":10,"context_line":"in fs52 standalone job definitions as tempest allowed group"},{"line_number":11,"context_line":"is in place now."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Ref :"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0caf9e40_bc077bc6","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":7},"in_reply_to":"59a2f6a4_7ea147a8","updated":"2022-06-30 06:41:30.000000000","message":"nope, right now I only removed the occurrences of whitelist variable for fs52 jobs only because fs52 allow list is in place. will propose more patches in future after merging remaining fs allow list reviews.","commit_id":"1568a634906fd17299c284ee990b9d5a5dd323f1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"58f4261b852375d9040196a3d3f556ed98d9f247","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Removal of tempest_whitelist variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch removes tempest_whitelist variable used"},{"line_number":10,"context_line":"in fs52 standalone job definitions as tempest allowed group"},{"line_number":11,"context_line":"is in place now."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Ref :"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ad747a49_8703bd77","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":7},"in_reply_to":"779ce977_f9ddfe5d","updated":"2022-07-07 06:26:11.000000000","message":"Done (patch was updated to be fs52 only)","commit_id":"1568a634906fd17299c284ee990b9d5a5dd323f1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2fdd14724b1c7fb8ff74b2959d25015480793a34","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Ref :"},{"line_number":14,"context_line":"[1]https://opendev.org/openstack/openstack-tempest-skiplist/src/branch/master/roles/validate-tempest/vars/tempest_allow.yml#L52-L69"},{"line_number":15,"context_line":"[2]https://github.com/openstack/tripleo-quickstart/blob/master/config/general_config/featureset052.yml#L33-L34"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1f9d7134e76d1a828bf45d2fd53043337f314f08"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ac61e085_01c7fe72","line":15,"updated":"2022-06-30 06:25:27.000000000","message":"thanks for references ... just a thought for the future - since you went to the trouble to add them may as well make them \u0027permalink\u0027 so this reference will continue to make sense even if that file changes.\n\ni.e. instaed of\n\nhttps://opendev.org/openstack/openstack-tempest-skiplist/src/branch/master/roles/validate-tempest/vars/tempest_allow.yml#L52-L69\n\nuse\n\nhttps://opendev.org/openstack/openstack-tempest-skiplist/src/commit/cbc43e13219ad09ee27b4498478606f9bd7d0b9e/roles/validate-tempest/vars/tempest_allow.yml#L52-L69\n\n(no need to change here just fyi/for future reference)","commit_id":"1568a634906fd17299c284ee990b9d5a5dd323f1"},{"author":{"_account_id":31075,"name":"Pooja Jadhav","email":"pojadhav@redhat.com","username":"pojadhav"},"change_message_id":"71da57ab9993203eda6a2bc0de0cb9d61d8d5540","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Ref :"},{"line_number":14,"context_line":"[1]https://opendev.org/openstack/openstack-tempest-skiplist/src/branch/master/roles/validate-tempest/vars/tempest_allow.yml#L52-L69"},{"line_number":15,"context_line":"[2]https://github.com/openstack/tripleo-quickstart/blob/master/config/general_config/featureset052.yml#L33-L34"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1f9d7134e76d1a828bf45d2fd53043337f314f08"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"63efc71e_1964153c","line":15,"in_reply_to":"ac61e085_01c7fe72","updated":"2022-06-30 06:41:30.000000000","message":"ack thank you.","commit_id":"1568a634906fd17299c284ee990b9d5a5dd323f1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"10c3226db4561348e4c36c0bc34adcbce7b91e3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4d0c7ee6_16153e20","updated":"2022-07-05 07:15:47.000000000","message":"thanks for update\ncant spot any that you missed here","commit_id":"c6fe1ad28c3760663009400db93976d742bd565c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f38d865720ec5b53fc1a8f8d0d19ee11cc2e57d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"92741440_07d51f6a","updated":"2022-07-07 07:04:51.000000000","message":"No sign of tempest_test_whitelist var in fs052 based jobs","commit_id":"aa2924a3fca31b90e24dd1623f549538da2910f5"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"58f4261b852375d9040196a3d3f556ed98d9f247","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"084e5b97_6e0f551e","updated":"2022-07-07 06:26:11.000000000","message":"re-adding vote... i think v3 is just a rebase? ","commit_id":"aa2924a3fca31b90e24dd1623f549538da2910f5"},{"author":{"_account_id":31075,"name":"Pooja Jadhav","email":"pojadhav@redhat.com","username":"pojadhav"},"change_message_id":"10cb13848756cdbea5c1be7f72f309f3e9eeac82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0cf30f75_9efe19b6","in_reply_to":"084e5b97_6e0f551e","updated":"2022-07-07 06:28:49.000000000","message":"yes due to merge conflict, only rebased the patch.","commit_id":"aa2924a3fca31b90e24dd1623f549538da2910f5"}],"roles/run-test/tasks/main.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2fdd14724b1c7fb8ff74b2959d25015480793a34","unresolved":true,"context_lines":[{"line_number":31,"context_line":"          - \u0027tempest_tempest_conf_overrides\u0027"},{"line_number":32,"context_line":"          - \u0027tempest_test_image_path\u0027"},{"line_number":33,"context_line":"          - \u0027tempest_test_includelist\u0027"},{"line_number":34,"context_line":"          - \u0027tempest_test_whitelist\u0027"},{"line_number":35,"context_line":"          - \u0027tempest_use_skiplist\u0027"},{"line_number":36,"context_line":"          - \u0027tempest_whitelist\u0027"},{"line_number":37,"context_line":"          - \u0027tempest_workers\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5793b462_f6923ee5","side":"PARENT","line":34,"updated":"2022-06-30 06:25:27.000000000","message":"this will affect all jobs not just fs52.\nare we ready to make this change? have we moved everything to skiplist now?","commit_id":"8f527522f7e0d766cb59bb399561b49f3df1bee3"},{"author":{"_account_id":31075,"name":"Pooja Jadhav","email":"pojadhav@redhat.com","username":"pojadhav"},"change_message_id":"71da57ab9993203eda6a2bc0de0cb9d61d8d5540","unresolved":true,"context_lines":[{"line_number":31,"context_line":"          - \u0027tempest_tempest_conf_overrides\u0027"},{"line_number":32,"context_line":"          - \u0027tempest_test_image_path\u0027"},{"line_number":33,"context_line":"          - \u0027tempest_test_includelist\u0027"},{"line_number":34,"context_line":"          - \u0027tempest_test_whitelist\u0027"},{"line_number":35,"context_line":"          - \u0027tempest_use_skiplist\u0027"},{"line_number":36,"context_line":"          - \u0027tempest_whitelist\u0027"},{"line_number":37,"context_line":"          - \u0027tempest_workers\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ab44b2a4_2bde84aa","side":"PARENT","line":34,"in_reply_to":"5793b462_f6923ee5","updated":"2022-06-30 06:41:30.000000000","message":"yes you are right, It will affect for all jobs. as we have not merged all the patches for tempest allowed group list, IMO I should hold this change for now. lets only merge the removal of whitelist variable for fs52 only because fs52 allowed group is in place. is that ok ?","commit_id":"8f527522f7e0d766cb59bb399561b49f3df1bee3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e4bb4575e79ca157fc032bd886613599bd66649e","unresolved":true,"context_lines":[{"line_number":31,"context_line":"          - \u0027tempest_tempest_conf_overrides\u0027"},{"line_number":32,"context_line":"          - \u0027tempest_test_image_path\u0027"},{"line_number":33,"context_line":"          - \u0027tempest_test_includelist\u0027"},{"line_number":34,"context_line":"          - \u0027tempest_test_whitelist\u0027"},{"line_number":35,"context_line":"          - \u0027tempest_use_skiplist\u0027"},{"line_number":36,"context_line":"          - \u0027tempest_whitelist\u0027"},{"line_number":37,"context_line":"          - \u0027tempest_workers\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c9708321_80168e27","side":"PARENT","line":34,"in_reply_to":"ab44b2a4_2bde84aa","updated":"2022-07-01 07:49:55.000000000","message":"ok thanks for checking. in this case you should workflow -1 this until the others are ready","commit_id":"8f527522f7e0d766cb59bb399561b49f3df1bee3"}]}