)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"a965ecb68f2e2e4fd56384fef4b9410939af44c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b6f2da9_77ba4ecd","updated":"2022-07-12 19:12:09.000000000","message":"Testproject:\n\n  https://review.rdoproject.org/r/c/testproject/+/43963/2\n\nZuul CI\u0027s log zuul-info/inventory.yaml [1] shows that ansible-collections-openstack is not being installed from git. TripleO CI jobs such as periodic-tripleo-ci-centos-9-standalone-master still work because ansible-collections-openstack is installed as an rpm package later.\n\n\n[1] https://logserver.rdoproject.org/63/43963/2/check/periodic-tripleo-ci-centos-9-standalone-master/de5137b/zuul-info/inventory.yaml\n","commit_id":"191aa3a94c213957ae5baeec8b6950b039483a6f"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"879c1e5e51cf1fbe63be2eb58b537168ecc7f973","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"21e9e0ad_3ce59fd2","updated":"2022-07-12 19:45:35.000000000","message":"We actually do need the collections for quickstart, as it\u0027s a dependency of the tempest role. This patch is ok because quickstart.sh will install the right collections.","commit_id":"191aa3a94c213957ae5baeec8b6950b039483a6f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"573319c188ddf7637cfe37f488eac3b895e79276","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"003baaec_d427e23f","updated":"2022-07-14 07:08:45.000000000","message":"i take the green zuul run as a positive sign that removing this from requirements wont break our gate ;) (as discussed inline we are installing already via quickstart)","commit_id":"191aa3a94c213957ae5baeec8b6950b039483a6f"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"f8cea7b9f5badf64eaed8777606d0c241f697255","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"50b5b768_0c26a555","updated":"2022-07-12 19:39:17.000000000","message":"pls submit similar patch in downstream overrides","commit_id":"191aa3a94c213957ae5baeec8b6950b039483a6f"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"415e4bd2f0e71f7003c9bd8fb581d726312951c2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cacc7d7a_01deaeb5","in_reply_to":"21e9e0ad_3ce59fd2","updated":"2022-07-13 09:20:24.000000000","message":"Oh right😱 Role os_tempest uses openstack.cloud.* modules although it does not list AOC in its requirements [1] 🙄 \n\nA second patch [2] is required to prevent quickstart.sh from installing AOC at all. But then role os_tempest fails [3] because it does NOT use the AOC release that got installed from RDO RPMs even though the path to the RPM installed collection is in ansible.cfg [5] which is used in quickstart.sh [6].\n\n[1] https://opendev.org/openstack/openstack-ansible-os_tempest/src/branch/master/requirements.yml\n[2] https://review.opendev.org/c/openstack/tripleo-quickstart/+/849620\n[3] https://review.rdoproject.org/r/c/testproject/+/43963/3\n[4] https://logserver.rdoproject.org/63/43963/3/check/periodic-tripleo-ci-centos-9-standalone-master/4da503f/job-output.txt\n[5] https://opendev.org/openstack/tripleo-quickstart/src/branch/master/ansible.cfg#L19\n[6] https://opendev.org/openstack/tripleo-quickstart/src/commit/b48d869e14de40444d69a107a0b718b5f721e912/quickstart.sh#L595","commit_id":"191aa3a94c213957ae5baeec8b6950b039483a6f"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"f47f3672d12769eca79c76f2cecec6684752941d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d8301835_72ba9fb9","in_reply_to":"57d3844d_ed921b08","updated":"2022-07-13 13:34:35.000000000","message":"We need this patch and it works as expected [1]. When Ansible OpenStack collection (aoc) is in required-projects, then quickstart will install it from git (master branch) [2]. This is not what we want in TripleO jobs (only in tripleo jobs we use in aoc itself), there we want to use a known working release of aoc which is 1.8.0 atm. When aoc is not in required-projects, then it will be installed via ansible-collection-requirements.yml [3]. My other patch [4] changes this ansible-collection-requirements.yml to use aoc 1.8.0 in TripleO jobs.\n\nBoth changes, this one and [4] are required. Once we merge both, changes in master branch of aoc will not break TripleO.\n\n[1] https://review.rdoproject.org/r/c/testproject/+/43963/3\n[2] https://opendev.org/openstack/tripleo-quickstart/src/commit/b48d869e14de40444d69a107a0b718b5f721e912/quickstart.sh#L123\n[3] https://opendev.org/openstack/tripleo-quickstart/src/commit/b48d869e14de40444d69a107a0b718b5f721e912/quickstart.sh#L118\n[4] https://review.opendev.org/c/openstack/tripleo-quickstart/+/849620","commit_id":"191aa3a94c213957ae5baeec8b6950b039483a6f"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"f8546b69a8e7e1d4dd72326ce995f94cb09b75e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e4b81b0_89f18c5e","in_reply_to":"a16a49a1_6c52108e","updated":"2022-07-14 08:07:20.000000000","message":"\u0027version: stable/1.0.0\u0027 actually is a branch which atm has aoc 1.8.0. That is confusing, yes, sorry 🙈\n\nBut trust me, we already suffered a lot for using a unusual branch name like \"stable/1.0.0\" 😬 I would definitely never do this in a Zuul CI based system..","commit_id":"191aa3a94c213957ae5baeec8b6950b039483a6f"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"0433f457ae4b78b8bca3ad60ba423494bccc58b4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb7ec02d_f1edb99e","in_reply_to":"cacc7d7a_01deaeb5","updated":"2022-07-13 09:34:14.000000000","message":"I have updated the second patch [2] to install latest stable release of AOC from Ansible Galaxy instead of dropping it completely from the requirements. Testproject [3] has been triggered.\n\n[2] https://review.opendev.org/c/openstack/tripleo-quickstart/+/849620\n[3] https://review.rdoproject.org/r/c/testproject/+/43963","commit_id":"191aa3a94c213957ae5baeec8b6950b039483a6f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"513934448c9d3148ab0da1e7c8b2367ee587bc48","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f147eee0_f31e3524","in_reply_to":"cb7ec02d_f1edb99e","updated":"2022-07-13 11:42:05.000000000","message":"does this mean you no longer want this patch (not dropping from requirements?) please abandon if so \n\n(came here via review list during reviews call)","commit_id":"191aa3a94c213957ae5baeec8b6950b039483a6f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"573319c188ddf7637cfe37f488eac3b895e79276","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a16a49a1_6c52108e","in_reply_to":"d8301835_72ba9fb9","updated":"2022-07-14 07:08:45.000000000","message":"ok thanks for info makes sense. we could control the version that zuul installs via required-projects but fine to make sure we are installing the right versions via our own quickstart mechanisms.\n\n\nbut i think you meant aoc v 1.0.0 at least that\u0027s what you\u0027re doing in https://review.opendev.org/c/openstack/tripleo-quickstart/+/849620/3/ansible-collection-requirements.yml","commit_id":"191aa3a94c213957ae5baeec8b6950b039483a6f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"623b27aded5591df34659579066c5829c08919a4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"57d3844d_ed921b08","in_reply_to":"f147eee0_f31e3524","updated":"2022-07-13 11:44:48.000000000","message":"also, seems wrong to remove this from required-projects if we are saying we *do* need it for tempest which we are running almost everywhere","commit_id":"191aa3a94c213957ae5baeec8b6950b039483a6f"}]}