)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"8077defb125f49d2948d4c1eb2b980288921e252","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add more scenario jobs with fips enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds scenario001 and scenario012 with fips"},{"line_number":10,"context_line":"enabled in check pipeline. These jobs will remain as non-voting"},{"line_number":11,"context_line":"until we make sure that they are stable."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I839830a5efb257c2c4407e6f43c8c47ab68aec0a"},{"line_number":14,"context_line":"Signed-off-by: Douglas Viroel \u003cdviroel@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1650d8f2_b6eab3d7","line":11,"range":{"start_line":10,"start_character":27,"end_line":11,"end_character":40},"updated":"2022-07-27 11:57:34.000000000","message":"Hello Doug,\n\nCurrently, We want to run more scenarios with fips to make sure these jobs are stable. \n\nIMHO.. instead of adding duplicate jobs (with fips enabled)in check/gate which trigger against each patch. We can add these scenarios(duplicate jobs with fips enabled) in periodic integration line and once we are confident that jobs with fips are passing. We can modify the existing scenarios(in check/gate) to be fips enabled instead of adding duplicate jobs.\n\nWhat do you think?","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ba9191f6876adc86e802c230f5cec86f5df77471","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add more scenario jobs with fips enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds scenario001 and scenario012 with fips"},{"line_number":10,"context_line":"enabled in check pipeline. These jobs will remain as non-voting"},{"line_number":11,"context_line":"until we make sure that they are stable."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I839830a5efb257c2c4407e6f43c8c47ab68aec0a"},{"line_number":14,"context_line":"Signed-off-by: Douglas Viroel \u003cdviroel@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6b527d5c_1db17790","line":11,"range":{"start_line":10,"start_character":27,"end_line":11,"end_character":40},"in_reply_to":"1650d8f2_b6eab3d7","updated":"2022-07-28 12:00:42.000000000","message":"Yes, I was expecting to replace non-fips jobs by fips jobs, but looks like it won\u0027t happen soon because standalone-fips job is reporting more failures than non-fips job, and needs to be investigated. So we need to move to another approach, and consider a periodic pipeline for fips jobs. Thanks for sharing the idea.","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ba9191f6876adc86e802c230f5cec86f5df77471","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"721c6138_15d2c507","updated":"2022-07-28 12:00:42.000000000","message":"Thanks for your reviews/feedbacks, I will rework this today and propose a different approach, with periodic jobs instead of check jobs. Thanks","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"74028287774b947026421c8c5289261a14254945","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0b327c4d_e1e2726a","updated":"2022-07-26 19:40:45.000000000","message":"how do we confirm fips is in fact enabled here? There are multiple enable_fips settings - some are marked true and some false","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ba9191f6876adc86e802c230f5cec86f5df77471","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d26e1452_b63f0863","in_reply_to":"0b327c4d_e1e2726a","updated":"2022-07-28 12:00:42.000000000","message":"The easiest way that I found is to look on node\u0027s var/log/extra/sysctl.txt\nAnd look for \"crypto.fips_enabled\"\nAs we can see, those jobs were not running with fips enabled, most probably because of the multiparenting order. I will fix in the next PS. Thanks","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"d8f9e344c90d7d4818e15bdb6000b558380e4ebf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"03164847_55b804e9","updated":"2022-08-02 00:47:15.000000000","message":"recheck - no logs on content providers","commit_id":"12d27188d58e0a23222007bee704554208bcbbae"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"b38352e7cf420eed858bbd5ff5f5f22214c672c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5c594ee8_17a5d99b","updated":"2022-08-04 09:00:44.000000000","message":"Definitions looks good - merging\n\n@doug, one job failed in testproject - Is that a known issue/random failure?\n\nhttps://review.opendev.org/c/openstack/tripleo-ci/+/851777/2#message-f93864492334367854d30923536dff024c5a9cef\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_750/851777/2/check/tripleo-ci-centos-9-scenario002-standalone-fips-wallaby/75001a9/logs/undercloud/home/zuul/standalone_deploy.log","commit_id":"b2ecca12a130eec934a1052380592d227be4e2ce"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"aad0ee55df372b97037b7c5d82e691b921fdf14a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"abd73f0b_b7b90d94","updated":"2022-08-02 20:46:47.000000000","message":"Test results are here:\nhttps://review.opendev.org/c/openstack/tripleo-ci/+/851777/2#message-f93864492334367854d30923536dff024c5a9cef\n\nis fips enabled? check \"crypto.fips_enabled \u003d 1\" on \"logs/undercloud/var/log/extra/sysctl.txt\"","commit_id":"b2ecca12a130eec934a1052380592d227be4e2ce"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8adb5921923075335dc8774bdec7e1a89f7892e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"76576648_b1a200cf","updated":"2022-08-04 11:44:51.000000000","message":"Thanks all","commit_id":"b2ecca12a130eec934a1052380592d227be4e2ce"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"82ff69026ed489a0dee5af519970bbd1a8cec010","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"907feca4_13da136b","updated":"2022-08-04 06:45:54.000000000","message":"another round of staring\n\nlooks good/cant spot the nits ;)","commit_id":"b2ecca12a130eec934a1052380592d227be4e2ce"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"567bbabcb7e884b9dacf42cd24f6cd7df859e7f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"315ba510_69c1c18a","updated":"2022-08-03 06:49:58.000000000","message":"lgtm - since last visit and per discussions this is moved to the upstream periodic line for now\n\nI\u0027ll revisit and we can discuss in todays call","commit_id":"b2ecca12a130eec934a1052380592d227be4e2ce"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5cb1c7caed4a2bdc88e9f673a1c1a6485ad828bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8991d920_546bb5c8","updated":"2022-08-02 20:45:40.000000000","message":"recheck\n\nfailed to download ansible collections","commit_id":"b2ecca12a130eec934a1052380592d227be4e2ce"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fc88922d81902b0a53efe61ff44cc4f05ebb9e3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"233152f1_d256b6b5","updated":"2022-08-04 12:34:48.000000000","message":"recheck\n\nstandalone failed in a random mysql failure [1]\n\n[1] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_8f2/850689/3/gate/tripleo-ci-centos-9-standalone/8f2e195/logs/undercloud/home/zuul/standalone_deploy.log","commit_id":"b2ecca12a130eec934a1052380592d227be4e2ce"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e66e980db2d156e6f30b420a4dfd669781a05cea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1eb86a2f_255d9760","updated":"2022-08-05 11:26:15.000000000","message":"recheck \n\ntripleo-ci-centos-9-content-provider-wallaby gate blocker issue os solved now","commit_id":"b2ecca12a130eec934a1052380592d227be4e2ce"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8adb5921923075335dc8774bdec7e1a89f7892e1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"61fadd65_885d3365","in_reply_to":"5c594ee8_17a5d99b","updated":"2022-08-04 11:44:51.000000000","message":"This is one of the random failures that happens more often when we enabled fips.","commit_id":"b2ecca12a130eec934a1052380592d227be4e2ce"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"f56ea48fbee9a66622381cb30fb324131dc14ddc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5366eb18_bfcb0fc4","in_reply_to":"61fadd65_885d3365","updated":"2022-08-04 12:36:01.000000000","message":"@Sandeep, fyi, standalone non-fips job just failed on gate with the same error [1] \n\n[1] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_8f2/850689/3/gate/tripleo-ci-centos-9-standalone/8f2e195/logs/undercloud/home/zuul/standalone_deploy.log","commit_id":"b2ecca12a130eec934a1052380592d227be4e2ce"}],"zuul.d/standalone-jobs.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"75d5b5c0e29c3115f5270b64c7230b4855833a8c","unresolved":true,"context_lines":[{"line_number":359,"context_line":"            files: *scen12_files"},{"line_number":360,"context_line":"        - tripleo-ci-centos-9-standalone-fips: *cs9_vars"},{"line_number":361,"context_line":"        - tripleo-ci-centos-9-scenario001-standalone-fips: *c9_scen1"},{"line_number":362,"context_line":"        - tripleo-ci-centos-9-scenario012-standalone-fips: *c9_scen12"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    gate:"},{"line_number":365,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"99a03c3a_07f197f4","line":362,"updated":"2022-07-27 07:26:42.000000000","message":"as is, these are \"inheriting\" the files: matches from the definitions above i.e. https://opendev.org/openstack/tripleo-ci/src/commit/77d9ebffe63e74d9052f2dcfe87ea29b52e3d983/zuul.d/standalone-jobs.yaml#L107-L171\n\ncan/should we constrain these a bit for fips? i think it might be too much to always have both scen1 and scen1_fips running for all the reviews WDYT?","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"567bbabcb7e884b9dacf42cd24f6cd7df859e7f7","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            files: *scen12_files"},{"line_number":360,"context_line":"        - tripleo-ci-centos-9-standalone-fips: *cs9_vars"},{"line_number":361,"context_line":"        - tripleo-ci-centos-9-scenario001-standalone-fips: *c9_scen1"},{"line_number":362,"context_line":"        - tripleo-ci-centos-9-scenario012-standalone-fips: *c9_scen12"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    gate:"},{"line_number":365,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"70bcfb22_65e110d6","line":362,"in_reply_to":"42c66d30_003a393b","updated":"2022-08-03 06:49:58.000000000","message":"Ack","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ba9191f6876adc86e802c230f5cec86f5df77471","unresolved":true,"context_lines":[{"line_number":359,"context_line":"            files: *scen12_files"},{"line_number":360,"context_line":"        - tripleo-ci-centos-9-standalone-fips: *cs9_vars"},{"line_number":361,"context_line":"        - tripleo-ci-centos-9-scenario001-standalone-fips: *c9_scen1"},{"line_number":362,"context_line":"        - tripleo-ci-centos-9-scenario012-standalone-fips: *c9_scen12"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    gate:"},{"line_number":365,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"42c66d30_003a393b","line":362,"in_reply_to":"99a03c3a_07f197f4","updated":"2022-07-28 12:00:42.000000000","message":"In a first moment, the idea was to have 1:1, so we can have enough results to compare success rates, and in a near futute, replace the non-fips with the fips one. But now, i have the problem that \"tripleo-ci-centos-9-standalone-fips\" doesn\u0027t have a good success rate compared to the non-fips job, so it seems that we need to move to a new approach here, like having a periodic line to run all fips jobs at least, once a day. And work with those results.","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"75d5b5c0e29c3115f5270b64c7230b4855833a8c","unresolved":true,"context_lines":[{"line_number":972,"context_line":"- job:"},{"line_number":973,"context_line":"    name: tripleo-ci-centos-9-fips-options"},{"line_number":974,"context_line":"    vars:"},{"line_number":975,"context_line":"      enable_fips: true"},{"line_number":976,"context_line":"      nslookup_target: \u0027opendev.org\u0027"},{"line_number":977,"context_line":"      featureset_override:"},{"line_number":978,"context_line":"        enable_fips: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ee49e1a0_9aef65fe","line":975,"range":{"start_line":975,"start_character":6,"end_line":975,"end_character":17},"updated":"2022-07-27 07:26:42.000000000","message":"do we need that both on vars and featureset_override?","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"567bbabcb7e884b9dacf42cd24f6cd7df859e7f7","unresolved":false,"context_lines":[{"line_number":972,"context_line":"- job:"},{"line_number":973,"context_line":"    name: tripleo-ci-centos-9-fips-options"},{"line_number":974,"context_line":"    vars:"},{"line_number":975,"context_line":"      enable_fips: true"},{"line_number":976,"context_line":"      nslookup_target: \u0027opendev.org\u0027"},{"line_number":977,"context_line":"      featureset_override:"},{"line_number":978,"context_line":"        enable_fips: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dc27f14b_f15cd493","line":975,"range":{"start_line":975,"start_character":6,"end_line":975,"end_character":17},"in_reply_to":"1a3748ea_7560f6bb","updated":"2022-08-03 06:49:58.000000000","message":"Done","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ba9191f6876adc86e802c230f5cec86f5df77471","unresolved":true,"context_lines":[{"line_number":972,"context_line":"- job:"},{"line_number":973,"context_line":"    name: tripleo-ci-centos-9-fips-options"},{"line_number":974,"context_line":"    vars:"},{"line_number":975,"context_line":"      enable_fips: true"},{"line_number":976,"context_line":"      nslookup_target: \u0027opendev.org\u0027"},{"line_number":977,"context_line":"      featureset_override:"},{"line_number":978,"context_line":"        enable_fips: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a3748ea_7560f6bb","line":975,"range":{"start_line":975,"start_character":6,"end_line":975,"end_character":17},"in_reply_to":"ee49e1a0_9aef65fe","updated":"2022-07-28 12:00:42.000000000","message":"I do think so, the enable_fips var is used by enable-fips pre-playbook (we can get rid of this once all jobs are enable_fips by default). The feature_override is used to enable fips during the deployment. I can double check if the feature-override one is actually needed atm. Thanks","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"75d5b5c0e29c3115f5270b64c7230b4855833a8c","unresolved":true,"context_lines":[{"line_number":995,"context_line":"# Scenario001"},{"line_number":996,"context_line":"- job:"},{"line_number":997,"context_line":"    name: tripleo-ci-centos-9-scenario001-standalone-fips"},{"line_number":998,"context_line":"    parent: tripleo-ci-centos-9-fips-options"},{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"- job:"},{"line_number":1001,"context_line":"    name: tripleo-ci-centos-9-scenario001-standalone-fips"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"15bbcad8_af843604","line":998,"updated":"2022-07-27 07:26:42.000000000","message":"what is the value of the multiparenting here if you are overriding the vars: below anyway (i.e. what are we inheriting from the fips-options job? looks like just the nslookup_target?)","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ba9191f6876adc86e802c230f5cec86f5df77471","unresolved":true,"context_lines":[{"line_number":995,"context_line":"# Scenario001"},{"line_number":996,"context_line":"- job:"},{"line_number":997,"context_line":"    name: tripleo-ci-centos-9-scenario001-standalone-fips"},{"line_number":998,"context_line":"    parent: tripleo-ci-centos-9-fips-options"},{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"- job:"},{"line_number":1001,"context_line":"    name: tripleo-ci-centos-9-scenario001-standalone-fips"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2a71e6cc_bd9b65f4","line":998,"in_reply_to":"15bbcad8_af843604","updated":"2022-07-28 12:00:42.000000000","message":"actually, I only need to override \"standalone_environment_files\" since it is a list, all other vars are being inherited from options. If you look at scn012 tempest profile [1], you will see validation.ssh_key_type there.\n\n\n[1] https://0eddaf29784a213b9d8b-74c4177143b8087413d4be21ce776c66.ssl.cf1.rackcdn.com/850689/1/check/tripleo-ci-centos-9-scenario012-standalone-fips/d9f0c52/logs/undercloud/home/zuul/tempest/etc/profile.yaml","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"152fec73c9470a165707cc91e0f35ee97d7371f0","unresolved":true,"context_lines":[{"line_number":1000,"context_line":"- job:"},{"line_number":1001,"context_line":"    name: tripleo-ci-centos-9-scenario001-standalone-fips"},{"line_number":1002,"context_line":"    parent: tripleo-ci-centos-9-scenario001-standalone"},{"line_number":1003,"context_line":"    voting: false"},{"line_number":1004,"context_line":"    vars:"},{"line_number":1005,"context_line":"      featureset_override:"},{"line_number":1006,"context_line":"        enable_fips: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa544f01_48de4787","line":1003,"updated":"2022-07-26 19:38:36.000000000","message":"Do we need to specify branches for the scenario jobs as well?","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ba9191f6876adc86e802c230f5cec86f5df77471","unresolved":true,"context_lines":[{"line_number":1000,"context_line":"- job:"},{"line_number":1001,"context_line":"    name: tripleo-ci-centos-9-scenario001-standalone-fips"},{"line_number":1002,"context_line":"    parent: tripleo-ci-centos-9-scenario001-standalone"},{"line_number":1003,"context_line":"    voting: false"},{"line_number":1004,"context_line":"    vars:"},{"line_number":1005,"context_line":"      featureset_override:"},{"line_number":1006,"context_line":"        enable_fips: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"94d2dc17_05ffdd0a","line":1003,"in_reply_to":"0d725c75_dc125962","updated":"2022-07-28 12:00:42.000000000","message":"Thanks for asking. We need this jobs running on both master and stable/wallaby, so there is no need to provide the branches so far (since fips jobs are centos-9 only for now)","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"75d5b5c0e29c3115f5270b64c7230b4855833a8c","unresolved":true,"context_lines":[{"line_number":1000,"context_line":"- job:"},{"line_number":1001,"context_line":"    name: tripleo-ci-centos-9-scenario001-standalone-fips"},{"line_number":1002,"context_line":"    parent: tripleo-ci-centos-9-scenario001-standalone"},{"line_number":1003,"context_line":"    voting: false"},{"line_number":1004,"context_line":"    vars:"},{"line_number":1005,"context_line":"      featureset_override:"},{"line_number":1006,"context_line":"        enable_fips: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0d725c75_dc125962","line":1003,"in_reply_to":"fa544f01_48de4787","updated":"2022-07-27 07:26:42.000000000","message":"we have branches: in the zuul layout (i.e. line 361/362 above) but yes we can/should also have it on the job unless there is some problem/reason not to?","commit_id":"bb3ee9e450f8603e8e141ebbc3cecbec713c8cd9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"82ff69026ed489a0dee5af519970bbd1a8cec010","unresolved":true,"context_lines":[{"line_number":989,"context_line":"    vars:"},{"line_number":990,"context_line":"      \u003c\u003c: *fips_vars"},{"line_number":991,"context_line":"      featureset_override:"},{"line_number":992,"context_line":"        standalone_environment_files:"},{"line_number":993,"context_line":"          - \u0027environments/low-memory-usage.yaml\u0027"},{"line_number":994,"context_line":"          - \u0027ci/environments/scenario001-standalone.yaml\u0027"},{"line_number":995,"context_line":"          - \u0027environments/fips.yaml\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bec34057_649a4150","line":992,"range":{"start_line":992,"start_character":0,"end_line":992,"end_character":8},"updated":"2022-08-04 06:45:54.000000000","message":"looks good with the featureset_override \n\ni guess there are no specialised fips tempest tests yet otherwise you\u0027d be adding them (or maybe it is future consideration still)","commit_id":"b2ecca12a130eec934a1052380592d227be4e2ce"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8adb5921923075335dc8774bdec7e1a89f7892e1","unresolved":true,"context_lines":[{"line_number":989,"context_line":"    vars:"},{"line_number":990,"context_line":"      \u003c\u003c: *fips_vars"},{"line_number":991,"context_line":"      featureset_override:"},{"line_number":992,"context_line":"        standalone_environment_files:"},{"line_number":993,"context_line":"          - \u0027environments/low-memory-usage.yaml\u0027"},{"line_number":994,"context_line":"          - \u0027ci/environments/scenario001-standalone.yaml\u0027"},{"line_number":995,"context_line":"          - \u0027environments/fips.yaml\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0bca4041_521c134d","line":992,"range":{"start_line":992,"start_character":0,"end_line":992,"end_character":8},"in_reply_to":"bec34057_649a4150","updated":"2022-08-04 11:44:51.000000000","message":"For now, there are no specific tests for fips. The main goal for now is to have everything running under fips enabled.","commit_id":"b2ecca12a130eec934a1052380592d227be4e2ce"}]}