)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"845aeb15c09632b38c38605d949fa3cfa846b3f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0e63fd41_897a2fc8","updated":"2022-07-25 07:21:00.000000000","message":"couple minor nits inline please check ","commit_id":"c58f2958d60ca5d5d53208524a063abff53acc49"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"9e86c02d44ec73b23fbf8eb0031e995d30c678ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"71d877f9_7de1ddc4","updated":"2022-08-01 10:12:00.000000000","message":"https://github.com/openstack/tripleo-ci/blob/master/toci-quickstart/config/testenv/multinode-vexxhost.yml#L81-L85\n\n\nBrowbeat settings are missing comparing to vexxhost file, but I don\u0027t think we use Browbeat anyway.. So lgtm \n\n","commit_id":"4e348fd9eb74f79bfddf8f1dde32436737d0e020"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9a311917338ce19aea5743afe1ce63feddeb4011","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4446b0f2_3c79c49c","updated":"2022-07-25 14:15:16.000000000","message":"recheck molecule timeout ","commit_id":"4e348fd9eb74f79bfddf8f1dde32436737d0e020"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1a3e9d72053968930dca02e83deabdbbbff00370","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0887f320_29da836b","updated":"2022-07-26 07:58:11.000000000","message":"thanks for update cant spot something else ","commit_id":"4e348fd9eb74f79bfddf8f1dde32436737d0e020"}],"toci-quickstart/config/testenv/multinode-ibm.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"845aeb15c09632b38c38605d949fa3cfa846b3f6","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"mtu: \"{{ vxlan_mtu }}\""},{"line_number":19,"context_line":"undercloud_local_mtu: \"{{ mtu }}\""},{"line_number":20,"context_line":"minion_local_mtu: \"{{ mtu }}\""},{"line_number":21,"context_line":"overcloud_neutron_global_physnet_mtu: \"{{ mtu }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ceph_use_fqdn: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf541532_e6bdbfac","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":16},"updated":"2022-07-25 07:21:00.000000000","message":"i think we can drop this one? we no longer run the minion anywhere afaik?\n\nlooks like it is only set in these files [1] and consumed by minion.conf.j2 [2]\n\n\n[1] https://codesearch.opendev.org/?q\u003dminion_local_mtu\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\n[2] https://opendev.org/openstack/tripleo-quickstart-extras/src/commit/c661d74da7be7f81f604e7b39a1744c9b8fd05f8/roles/undercloud-minion-deploy/templates/minion.conf.j2#L127","commit_id":"c58f2958d60ca5d5d53208524a063abff53acc49"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"480b573737591917fae8ce7a283cf1216ac8efd5","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"mtu: \"{{ vxlan_mtu }}\""},{"line_number":19,"context_line":"undercloud_local_mtu: \"{{ mtu }}\""},{"line_number":20,"context_line":"minion_local_mtu: \"{{ mtu }}\""},{"line_number":21,"context_line":"overcloud_neutron_global_physnet_mtu: \"{{ mtu }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"ceph_use_fqdn: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf802235_64d53921","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":16},"in_reply_to":"bf541532_e6bdbfac","updated":"2022-07-25 07:47:32.000000000","message":"Done","commit_id":"c58f2958d60ca5d5d53208524a063abff53acc49"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"845aeb15c09632b38c38605d949fa3cfa846b3f6","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# environment settings, not TRIPLEO-CI specific"},{"line_number":26,"context_line":"undercloud_local_interface: \"br-ex\"  # related to osinfra network configuration"},{"line_number":27,"context_line":"minion_local_interface: \"br-ex\"  # related to osinfra network configuration"},{"line_number":28,"context_line":"flavor_args: \"\""},{"line_number":29,"context_line":"undercloud_conf_extras: \"net_config_override \u003d /opt/stack/new/tripleo-ci/undercloud-configs/net-config-multinode.json.template\""},{"line_number":30,"context_line":"generate_pingtest_subunit: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cce80a29_d92b76a6","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":22},"updated":"2022-07-25 07:21:00.000000000","message":"same","commit_id":"c58f2958d60ca5d5d53208524a063abff53acc49"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"480b573737591917fae8ce7a283cf1216ac8efd5","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# environment settings, not TRIPLEO-CI specific"},{"line_number":26,"context_line":"undercloud_local_interface: \"br-ex\"  # related to osinfra network configuration"},{"line_number":27,"context_line":"minion_local_interface: \"br-ex\"  # related to osinfra network configuration"},{"line_number":28,"context_line":"flavor_args: \"\""},{"line_number":29,"context_line":"undercloud_conf_extras: \"net_config_override \u003d /opt/stack/new/tripleo-ci/undercloud-configs/net-config-multinode.json.template\""},{"line_number":30,"context_line":"generate_pingtest_subunit: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2c85bf05_8925976a","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":22},"in_reply_to":"cce80a29_d92b76a6","updated":"2022-07-25 07:47:32.000000000","message":"Done","commit_id":"c58f2958d60ca5d5d53208524a063abff53acc49"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"845aeb15c09632b38c38605d949fa3cfa846b3f6","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  {%- elif job.consumer_job | default(false) | bool -%}"},{"line_number":50,"context_line":"  {{ job.registry_ip_address_branch[release] }}:5001"},{"line_number":51,"context_line":"  {%- else -%}"},{"line_number":52,"context_line":"  {%- if (release not in [\"victoria\"] and ansible_distribution|lower in [\"centos\"]) -%}"},{"line_number":53,"context_line":"  quay.rdoproject.org"},{"line_number":54,"context_line":"  {%- else -%}"},{"line_number":55,"context_line":"  trunk.registry.rdoproject.org"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6ff3157f_9384ecef","line":52,"range":{"start_line":52,"start_character":27,"end_line":52,"end_character":35},"updated":"2022-07-25 07:21:00.000000000","message":"can adjust this conditional no more victoria","commit_id":"c58f2958d60ca5d5d53208524a063abff53acc49"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"480b573737591917fae8ce7a283cf1216ac8efd5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  {%- elif job.consumer_job | default(false) | bool -%}"},{"line_number":50,"context_line":"  {{ job.registry_ip_address_branch[release] }}:5001"},{"line_number":51,"context_line":"  {%- else -%}"},{"line_number":52,"context_line":"  {%- if (release not in [\"victoria\"] and ansible_distribution|lower in [\"centos\"]) -%}"},{"line_number":53,"context_line":"  quay.rdoproject.org"},{"line_number":54,"context_line":"  {%- else -%}"},{"line_number":55,"context_line":"  trunk.registry.rdoproject.org"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba6d51d1_a0095c73","line":52,"range":{"start_line":52,"start_character":27,"end_line":52,"end_character":35},"in_reply_to":"6ff3157f_9384ecef","updated":"2022-07-25 07:47:32.000000000","message":"Done","commit_id":"c58f2958d60ca5d5d53208524a063abff53acc49"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"480b573737591917fae8ce7a283cf1216ac8efd5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  {%- elif job.consumer_job | default(false) | bool -%}"},{"line_number":50,"context_line":"  {{ job.registry_ip_address_branch[release] }}:5001"},{"line_number":51,"context_line":"  {%- else -%}"},{"line_number":52,"context_line":"  {%- if (release not in [\"victoria\"] and ansible_distribution|lower in [\"centos\"]) -%}"},{"line_number":53,"context_line":"  quay.rdoproject.org"},{"line_number":54,"context_line":"  {%- else -%}"},{"line_number":55,"context_line":"  trunk.registry.rdoproject.org"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d5f5f925_ef733ede","line":52,"range":{"start_line":52,"start_character":27,"end_line":52,"end_character":35},"in_reply_to":"6ff3157f_9384ecef","updated":"2022-07-25 07:47:32.000000000","message":"Done","commit_id":"c58f2958d60ca5d5d53208524a063abff53acc49"}],"toci-quickstart/config/testenv/ovb-ibm.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"845aeb15c09632b38c38605d949fa3cfa846b3f6","unresolved":true,"context_lines":[{"line_number":35,"context_line":"  {%- elif job.consumer_job | default(false) | bool -%}"},{"line_number":36,"context_line":"  {{ job.registry_ip_address_branch[release] }}:5001"},{"line_number":37,"context_line":"  {%- else -%}"},{"line_number":38,"context_line":"  {%- if (release not in [\"victoria\"] and ansible_distribution|lower in [\"centos\"]) -%}"},{"line_number":39,"context_line":"  quay.rdoproject.org"},{"line_number":40,"context_line":"  {%- else -%}"},{"line_number":41,"context_line":"  trunk.registry.rdoproject.org"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5b2e507e_fb97477f","line":38,"range":{"start_line":38,"start_character":27,"end_line":38,"end_character":35},"updated":"2022-07-25 07:21:00.000000000","message":"remove/rework this please","commit_id":"c58f2958d60ca5d5d53208524a063abff53acc49"}]}