)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"43278bedc5a75395eb6db202655229d5ca4bf198","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dad4be2e_c884e3b3","updated":"2022-08-01 10:18:51.000000000","message":"See also https://review.rdoproject.org/r/c/rdo-infra/ansible-role-tripleo-ci-reproducer/+/42555\n\nWIP, waiting for test results.","commit_id":"ce0803599ab94a37d79ccf436168eec91edb8ef1"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"b00cec71ad99b878dd42979478d41e4df586e1ac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6915b197_8ccd3e80","updated":"2022-08-04 08:41:24.000000000","message":"Hello,\n\nMy understanding is we don\u0027t need to add vars under`allowed_overrides` if you want to use `run_test_role_vars` as suggested in comment#4[0]. but afaik.. this is something we usually do for test projects and not for the actual job defs(If you want to override in actual job def then adding in override is the correct approach).\n\n\nI have recently used run_test_role_vars in testproject[1] and was able to override `undercloud_firewall_engine` which is not under `allowed_overrides` list[2].\n\nI wonder if the approach [0] is enough for the reproducer use case (if we document it somewhere in tripleo-docs properly)?\n\nAlso, just to confirm - Have you tested the suggestion on comment#4 [0] already, Did that work for you or not?\n\n[0] https://bugs.launchpad.net/tripleo/+bug/1971605/comments/4\n[1] https://review.rdoproject.org/r/c/testproject/+/31954/58/.zuul.yaml#13\n[2] https://opendev.org/openstack/tripleo-ci/src/branch/master/roles/run-test/tasks/main.yaml#L10","commit_id":"9846d383904778dbd7f02e3cbb97db83d888cef2"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"5b85810c4d3438fc7a4c0d50a046921fe1dd3cfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"38c70452_5fd19d8a","updated":"2022-08-18 11:17:17.000000000","message":"Hey, was on PTO, testing the run_test_role_vars now. I\u0027ll post the result today and act accordingly. Thanks for all the comments.","commit_id":"9846d383904778dbd7f02e3cbb97db83d888cef2"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"56f26686f6aafc0a1aca9e6eb651b19f0ba49018","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d9a46565_70799cbd","updated":"2022-08-05 11:30:14.000000000","message":"Sofer, you can W+ this if you think the alternative suggestion is not workable for you","commit_id":"9846d383904778dbd7f02e3cbb97db83d888cef2"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"183cb82fdf55b668a49411ddd6ee441991e6e5ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a7ba5b8c_0f1e42d1","updated":"2022-08-02 11:03:06.000000000","message":"Tested and working, was able to run undercloud upgrade job on psi.","commit_id":"9846d383904778dbd7f02e3cbb97db83d888cef2"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"08b331dd74dd3d6cafcec03d9be23c78c9f0cfa6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eec5de91_4ad783f2","updated":"2022-08-04 19:10:29.000000000","message":"We have no problem is adding this patch but would like to see if Sandeep\u0027s suggestion is a workable - in which case this should not be needed.\n\nAgree that this solution is better than the abandoned patch Marios pointed to","commit_id":"9846d383904778dbd7f02e3cbb97db83d888cef2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"efee9b02045f161ef2bf65160746ff1b89dcdd5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3568b0c1_b2434c14","updated":"2022-08-04 07:23:40.000000000","message":"i am ok with this as i prefer it over the alternative \n\nbut +1 to allow others from ci team to comment\n\nI\u0027ll revisit and merge if still around on my next pass","commit_id":"9846d383904778dbd7f02e3cbb97db83d888cef2"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"f38c89057000af85d1285861782806b4f08299bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b713f596_ca6a871e","updated":"2022-08-02 12:00:50.000000000","message":"mirror_fqdn override is missing, it seems\nTake a look at review in https://review.rdoproject.org/r/c/rdo-infra/ansible-role-tripleo-ci-reproducer/+/42555","commit_id":"9846d383904778dbd7f02e3cbb97db83d888cef2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"138cc2657104c3f2a6025a677d4fc9efb0d6ab91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa617c6b_f40fd054","in_reply_to":"3568b0c1_b2434c14","updated":"2022-08-04 07:24:45.000000000","message":"added it to our reviews list https://hackmd.io/FGMoCiRfSNa8puA1BpTQ-Q?view","commit_id":"9846d383904778dbd7f02e3cbb97db83d888cef2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ad65bf73f32f3a21c2a5e0496087faae23121127","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b3f5234_a85487e4","in_reply_to":"6915b197_8ccd3e80","updated":"2022-08-08 07:58:18.000000000","message":"If we can make this work with run_test_role_vars and avoid adding the overrides then I\u0027d also vote for that :)","commit_id":"9846d383904778dbd7f02e3cbb97db83d888cef2"}],"roles/run-test/tasks/main.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"efee9b02045f161ef2bf65160746ff1b89dcdd5a","unresolved":true,"context_lines":[{"line_number":44,"context_line":"          - \u0027undercloud_undercloud_debug\u0027"},{"line_number":45,"context_line":"          - \u0027undercloud_undercloud_nameservers\u0027"},{"line_number":46,"context_line":"          - \u0027undercloud_undercloud_ntp_servers\u0027"},{"line_number":47,"context_line":"          - \u0027use_os_tempest\u0027"},{"line_number":48,"context_line":"          - \u0027validate_ha_overcloud\u0027"},{"line_number":49,"context_line":"          - \u0027validate_services\u0027"},{"line_number":50,"context_line":"          - \u0027tempest_tempestconf_profile_overrides\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e6c5d69e_70d86ad3","line":47,"updated":"2022-08-04 07:23:40.000000000","message":"adding note for other reviewers from ci team\n\nthis is proposed as alternative to https://review.opendev.org/c/openstack/tripleo-ci/+/840506 so we can avoid carrying the internal addresses in the upstream repos/config","commit_id":"9846d383904778dbd7f02e3cbb97db83d888cef2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ad65bf73f32f3a21c2a5e0496087faae23121127","unresolved":false,"context_lines":[{"line_number":44,"context_line":"          - \u0027undercloud_undercloud_debug\u0027"},{"line_number":45,"context_line":"          - \u0027undercloud_undercloud_nameservers\u0027"},{"line_number":46,"context_line":"          - \u0027undercloud_undercloud_ntp_servers\u0027"},{"line_number":47,"context_line":"          - \u0027use_os_tempest\u0027"},{"line_number":48,"context_line":"          - \u0027validate_ha_overcloud\u0027"},{"line_number":49,"context_line":"          - \u0027validate_services\u0027"},{"line_number":50,"context_line":"          - \u0027tempest_tempestconf_profile_overrides\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0bb5376d_d3ca94e7","line":47,"in_reply_to":"e6c5d69e_70d86ad3","updated":"2022-08-08 07:58:18.000000000","message":"Done","commit_id":"9846d383904778dbd7f02e3cbb97db83d888cef2"}]}