)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"619673ebf569dcd40dcf081c6d2d6139f97e0f63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"953d383b_dc563212","updated":"2022-11-10 18:45:39.000000000","message":"recheck ","commit_id":"50a510ec1a1859586c1cd1a75be66bb678ac79ab"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8284e2157adad88d58848f03f74e598cac1c2417","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3404bf61_e2add87f","updated":"2022-11-14 16:47:00.000000000","message":"some test results are here: https://review.rdoproject.org/r/c/testproject/+/46046/2#message-7f5f69c852608e66911dbc52f06c37ac09d0227a","commit_id":"50a510ec1a1859586c1cd1a75be66bb678ac79ab"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2dfb5ccef7a3951eecc4fe586cc950ed3229fb0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bf83e4ef_793ed163","updated":"2022-11-15 10:17:32.000000000","message":"please hold recheck blocked on https://lists.openstack.org/pipermail/openstack-discuss/2022-November/031186.html","commit_id":"51d3235859110eeae1b7ded49c641109ac0e99d1"}],"roles/ci-common-vars/vars/main.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1beb1b3a86b651f5ea18ef6c88558a32bd2f5eaf","unresolved":true,"context_lines":[{"line_number":40,"context_line":"  {%- elif \u0027psi-public-nodepool-tripleo\u0027 in nodepool_provider -%}"},{"line_number":41,"context_line":"  psi"},{"line_number":42,"context_line":"  {%- elif \u0027ibm-bm2-nodepool\u0027 in nodepool_provider -%}"},{"line_number":43,"context_line":"  ibm"},{"line_number":44,"context_line":"  {%- elif nodepool_provider \u003d\u003d \u0027tripleo-ci\u0027 and environment_type \u003d\u003d \u0027ovb\u0027 -%}"},{"line_number":45,"context_line":"  internal"},{"line_number":46,"context_line":"  {%- endif -%}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cb91f29f_0ab33fdf","side":"PARENT","line":43,"updated":"2022-11-14 07:31:35.000000000","message":"missing depends-on? i don\u0027t see the config for this^^ in https://github.com/rdo-infra/review.rdoproject.org-config/blob/ca25531bf399655558ba8e5990fb62a11e83bea0/roles/ovb-manage/defaults/main.yml#L97","commit_id":"56e6bc85adc03809f07a6f5627b76798a0deef33"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7873f3a1a4032d3dd136bb7c73c6cbbaf7e8dfec","unresolved":true,"context_lines":[{"line_number":40,"context_line":"  {%- elif \u0027psi-public-nodepool-tripleo\u0027 in nodepool_provider -%}"},{"line_number":41,"context_line":"  psi"},{"line_number":42,"context_line":"  {%- elif \u0027ibm-bm2-nodepool\u0027 in nodepool_provider -%}"},{"line_number":43,"context_line":"  ibm"},{"line_number":44,"context_line":"  {%- elif nodepool_provider \u003d\u003d \u0027tripleo-ci\u0027 and environment_type \u003d\u003d \u0027ovb\u0027 -%}"},{"line_number":45,"context_line":"  internal"},{"line_number":46,"context_line":"  {%- endif -%}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffdd1eb0_69b7cefa","side":"PARENT","line":43,"in_reply_to":"8049ef45_9b198c27","updated":"2022-11-14 16:54:55.000000000","message":"I wasn\u0027t so clear on my previous response:\nThe part of the code that you refer to, which are cloud setting for ovb environment, need to be validated yet. But we still can merge this change, since it is needed for other environments like standalone and multinode. /me adding more info to commit msg","commit_id":"56e6bc85adc03809f07a6f5627b76798a0deef33"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8284e2157adad88d58848f03f74e598cac1c2417","unresolved":true,"context_lines":[{"line_number":40,"context_line":"  {%- elif \u0027psi-public-nodepool-tripleo\u0027 in nodepool_provider -%}"},{"line_number":41,"context_line":"  psi"},{"line_number":42,"context_line":"  {%- elif \u0027ibm-bm2-nodepool\u0027 in nodepool_provider -%}"},{"line_number":43,"context_line":"  ibm"},{"line_number":44,"context_line":"  {%- elif nodepool_provider \u003d\u003d \u0027tripleo-ci\u0027 and environment_type \u003d\u003d \u0027ovb\u0027 -%}"},{"line_number":45,"context_line":"  internal"},{"line_number":46,"context_line":"  {%- endif -%}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8049ef45_9b198c27","side":"PARENT","line":43,"in_reply_to":"cb91f29f_0ab33fdf","updated":"2022-11-14 16:47:00.000000000","message":"No, not really. This part of the code is needed only for OVB jobs, to create the stack. This code can be merged without that.","commit_id":"56e6bc85adc03809f07a6f5627b76798a0deef33"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2dfb5ccef7a3951eecc4fe586cc950ed3229fb0d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  {%- elif \u0027psi-public-nodepool-tripleo\u0027 in nodepool_provider -%}"},{"line_number":41,"context_line":"  psi"},{"line_number":42,"context_line":"  {%- elif \u0027ibm-bm2-nodepool\u0027 in nodepool_provider -%}"},{"line_number":43,"context_line":"  ibm"},{"line_number":44,"context_line":"  {%- elif nodepool_provider \u003d\u003d \u0027tripleo-ci\u0027 and environment_type \u003d\u003d \u0027ovb\u0027 -%}"},{"line_number":45,"context_line":"  internal"},{"line_number":46,"context_line":"  {%- endif -%}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"89287efa_dd0c2c6e","side":"PARENT","line":43,"in_reply_to":"ffdd1eb0_69b7cefa","updated":"2022-11-15 10:17:32.000000000","message":"k thanks. so we need that but it can be async from this patch","commit_id":"56e6bc85adc03809f07a6f5627b76798a0deef33"}]}