)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e7e3efac8f6f67bebaa8b738c4dfc7ad44e5360c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e551817a_91b050f3","updated":"2023-03-13 08:07:24.000000000","message":"just a thought.. if we only really want just one var in fs68, maybe we don\u0027t need it?\n\neg you could pass the var from the zuul job variables wdyt?","commit_id":"74b0dfaed1035235c6223b1bf12069c54d8339e7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"af4b5f837e02abbfdfa0abef54bc3445f6069bf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6e585766_ef96c1f0","updated":"2023-03-13 08:06:25.000000000","message":"lgtm ","commit_id":"74b0dfaed1035235c6223b1bf12069c54d8339e7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c4b430ee20d05383f1b54822029408a44a5952ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d05e2cf7_a40694c8","updated":"2023-03-15 08:18:19.000000000","message":"looks right. would be good to see a green run in the tripleo-upgrade patch for the very latest version (with the update var in the job definition \u0026 fs66)\n\nlast green run there https://review.opendev.org/c/openstack/tripleo-upgrade/+/865854/17#message-2c777c381cf9c73eae647fc2863ddca194f084d9\n\nit was using the previous approach\n\nI just want to sanity check the zuul var precedence etc ;) should be fine as we aren\u0027t setting that anywhere else but well, i\u0027ve been surprised before ;) :D ","commit_id":"e625e18750bb62bde3112965b851b7e97577891e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"49c0ababa305941e1725562922788fbda4d38889","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"67722aee_671957f8","in_reply_to":"04862e77_00eb9449","updated":"2023-03-17 08:35:55.000000000","message":":/ ffs why do we do this to ourselves _ - \\o/ - _\n\n\ndo you want to try and run this with testproject and get a hold on the nodes (lasts 24 hours)? ping me and we can work out some time for that can be next week if you want too.","commit_id":"e625e18750bb62bde3112965b851b7e97577891e"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"ba1582e6c654462cb6dc138ba547f978a480942f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"04862e77_00eb9449","in_reply_to":"1cce73a8_ac84bf80","updated":"2023-03-17 07:43:44.000000000","message":"overcloud_deploy_script variable is definitively need or else we look for overcloud_deploy.sh while in upstream oooq it\u0027s overcloud-deploy.sh.  Then we proceed by failing:\n\n    awk: fatal: cannot open file `/home/zuul/overcloud_deploy.sh\u0027 for reading: No such file or directory\n    \nfor tripleo-upgrade : get network-data-file.\n\nI\u0027ll just hardcode the home path to \"/home/zuul/\" instead of working_dir var.  Maybe just overcloud-deploy.sh (relative path) would work as well.  Will try that after if that one fails.","commit_id":"e625e18750bb62bde3112965b851b7e97577891e"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"33358e8474ae9829e059ea250b56357472f75ece","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1cce73a8_ac84bf80","in_reply_to":"d05e2cf7_a40694c8","updated":"2023-03-15 11:30:38.000000000","message":"Well, working_dir is not defined there, so I\u0027ve removed it, the variable used is not used in the update job, so I guess it should be fine.  If not, then ... well we\u0027ll see.","commit_id":"e625e18750bb62bde3112965b851b7e97577891e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"49c0ababa305941e1725562922788fbda4d38889","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ffa36d8a_13b5768d","updated":"2023-03-17 08:35:55.000000000","message":"lgtm but waiting on the final touches ","commit_id":"bfde3269ad545a737599c5da480802df64aca883"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"8cd03e2eace19d3b278084db2271001f5a142c17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b4196c00_c76f981b","in_reply_to":"67722aee_671957f8","updated":"2023-03-20 10:05:44.000000000","message":"DONE","commit_id":"bcfdc1957ec9b028fcdb95060d83de268b195acc"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"567d3eb1c52c7f53bb3558ef1524105e9ad304eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3d9fbc08_476a229f","updated":"2023-03-21 07:25:17.000000000","message":"lgtm (inline sanity check but we can also merge and followup)\n\nalso added this into the ci review list for today @  https://hackmd.io/FGMoCiRfSNa8puA1BpTQ-Q?view#Mar-21-2023","commit_id":"5c586b8740e609ac9f2d6d2c8a58e64015bc7add"}],"zuul.d/base.yaml":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"ef55b58c524dddad17b0d788bb5e84df9abe36a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ede8d5ca_d2a907b1","in_reply_to":"21b9dfd9_0cb128e1","updated":"2023-03-13 13:21:54.000000000","message":"So, here, I think the refactor to fs66 is better, and shouldn\u0027t cause\nany problem as that variable will be defined in the job.","commit_id":"74b0dfaed1035235c6223b1bf12069c54d8339e7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"af4b5f837e02abbfdfa0abef54bc3445f6069bf7","unresolved":true,"context_lines":[{"line_number":152,"context_line":"        - multinode-undercloud-mixed-os.yml"},{"line_number":153,"context_line":"        - multinode-overcloud-prep.yml"},{"line_number":154,"context_line":"        - multinode-overcloud-mixed-os-deploy.yml"},{"line_number":155,"context_line":"        - multinode-overcloud-update.yml"},{"line_number":156,"context_line":"        - multinode-validate.yml"},{"line_number":157,"context_line":"      tags: *multinode_tags"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"21b9dfd9_0cb128e1","line":155,"updated":"2023-03-13 08:06:25.000000000","message":"OK. I had to go sanity check and remember that this is conditional like [1]\n\nuntil now we only set that on fs37 but you are also adding it in the depends-on fs68 lgtm \n\n\n\n\n[1] https://opendev.org/openstack/tripleo-quickstart/src/commit/3ea6e712d20e9e928585f4f8b7f5ce048e181752/config/general_config/featureset037.yml#L8","commit_id":"74b0dfaed1035235c6223b1bf12069c54d8339e7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"567d3eb1c52c7f53bb3558ef1524105e9ad304eb","unresolved":true,"context_lines":[{"line_number":152,"context_line":"        - multinode-undercloud-mixed-os.yml"},{"line_number":153,"context_line":"        - multinode-overcloud-prep.yml"},{"line_number":154,"context_line":"        - multinode-overcloud-mixed-os-deploy.yml"},{"line_number":155,"context_line":"        - multinode-overcloud-update.yml"},{"line_number":156,"context_line":"        - multinode-validate.yml"},{"line_number":157,"context_line":"      tags: *multinode_tags"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"d31b63fd_d7162a80","line":155,"updated":"2023-03-21 07:25:17.000000000","message":"looks fine and as commented at https://review.opendev.org/c/openstack/tripleo-upgrade/+/865854/20#message-d4a66ae856531fb03fcaead20d0222f4b566776e seems to be running the minor update now\n\njust a thought, i noticed we didn\u0027t add the new playbook into the template at https://opendev.org/openstack/tripleo-ci/src/commit/0caf72a59b8fbcf232119b46c304d630ccb2fe29/roles/run-test/templates/toci_quickstart.sh.j2#L101-L108 (registry_distro is used for repo setup to determine the right content provider and also in undercloud-deploy role for setting the container prep param file https://codesearch.opendev.org/?q\u003dregistry_distro\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d).\n\nBasically can you please sanity check the results at https://9599651c82878991e1c6-d7fe5bf1e92e0068733eb3b5b505c74c.ssl.cf2.rackcdn.com/865854/20/check/tripleo-ci-centos-8-9-multinode-mixed-os-update/7beccf2/logs/undercloud/home/zuul/\n\nin particular is the update fetching the expected hash/content for the minor update.\n\nI don\u0027t want to block this so I will +2 and we can followup on this point as needed (we are merging this as non voting and only wiring into tripleo-upgrade for now so fine)","commit_id":"5c586b8740e609ac9f2d6d2c8a58e64015bc7add"}],"zuul.d/multinode-jobs.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c4b430ee20d05383f1b54822029408a44a5952ff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6b1713e9_ff5a2cea","in_reply_to":"83436535_868c9b5a","updated":"2023-03-15 08:18:19.000000000","message":"ok so it really is not clear/to be discussed \u0026 determined. Unless there are *reasons* then I think we can eventually run this everywhere for tripleo wallaby.\n\nSo either this could replace the existing job assuming it is stable and has a reasonable runtime, or we can keep both and make this more targetted with files: (i.e. so it only runs when it makes sense to as far as we can express that using files:)\n\nFor now though yes lets have it in check and non voting. You can wire into tripleo-upgrade and we can then discuss next steps (like adding it into the multinode job layout... though this one is tricky. it could also go into the upgrade/wallaby template)\n\nhttps://opendev.org/openstack/tripleo-ci/src/commit/0caf72a59b8fbcf232119b46c304d630ccb2fe29/zuul.d/multinode-jobs.yaml#L69\n\nhttps://opendev.org/openstack/tripleo-ci/src/commit/0caf72a59b8fbcf232119b46c304d630ccb2fe29/zuul.d/upgrades-jobs-templates.yaml#L141","commit_id":"74b0dfaed1035235c6223b1bf12069c54d8339e7"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"ef55b58c524dddad17b0d788bb5e84df9abe36a8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"83436535_868c9b5a","in_reply_to":"f2f470cf_328b8b74","updated":"2023-03-13 13:21:54.000000000","message":"Well, I\u0027m unsure what\u0027s the most common way here.  Either adding it as\na non-voting in the project-template attached to upgrade jobs, so that\nit pops up in a lot of repos but non-voting.\n\nOr, If we keep it only on tripleo-upgrade/wallaby then I think it\u0027s\nbetter to have it voting directly.\n\nWhat\u0027s your opinion here ?","commit_id":"74b0dfaed1035235c6223b1bf12069c54d8339e7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"af4b5f837e02abbfdfa0abef54bc3445f6069bf7","unresolved":true,"context_lines":[{"line_number":372,"context_line":"    name: tripleo-ci-centos-8-9-multinode-mixed-os-update"},{"line_number":373,"context_line":"    parent: tripleo-ci-base-required-projects-multinode-mixed-os-upstream"},{"line_number":374,"context_line":"    branches: stable/wallaby"},{"line_number":375,"context_line":"    voting: false"},{"line_number":376,"context_line":"    vars:"},{"line_number":377,"context_line":"      featureset: \u0027068\u0027"},{"line_number":378,"context_line":"      nodes: 1ctlr_1comp_mixed_os"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f2f470cf_328b8b74","line":375,"range":{"start_line":375,"start_character":12,"end_line":375,"end_character":17},"updated":"2023-03-13 08:06:25.000000000","message":"ok i guess you want to revisit this after we merge and I see for now you only have it in check @ https://review.opendev.org/c/openstack/tripleo-upgrade/+/865854","commit_id":"74b0dfaed1035235c6223b1bf12069c54d8339e7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"49c0ababa305941e1725562922788fbda4d38889","unresolved":true,"context_lines":[{"line_number":375,"context_line":"    voting: false"},{"line_number":376,"context_line":"    vars:"},{"line_number":377,"context_line":"      run_test_role_vars:"},{"line_number":378,"context_line":"        overcloud_deploy_script: \"/home/zuul/overcloud-deploy.sh\""},{"line_number":379,"context_line":"        overcloud_update: true"},{"line_number":380,"context_line":"        overcloud_ssh_user: \"zuul\""},{"line_number":381,"context_line":"        tripleo_upgrade_validations_non_fatal: true"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a91fd63_afcf1411","line":378,"range":{"start_line":378,"start_character":34,"end_line":378,"end_character":45},"updated":"2023-03-17 08:35:55.000000000","message":"\"{{ ansible_user_dir }}/overcloud-deploy.sh\" \n\nif you like","commit_id":"bfde3269ad545a737599c5da480802df64aca883"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"8cd03e2eace19d3b278084db2271001f5a142c17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"96aee073_8ec547e0","in_reply_to":"1a91fd63_afcf1411","updated":"2023-03-20 10:05:44.000000000","message":"DONE","commit_id":"bcfdc1957ec9b028fcdb95060d83de268b195acc"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"8cd03e2eace19d3b278084db2271001f5a142c17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"dfd96c78_9408020a","in_reply_to":"6b1713e9_ff5a2cea","updated":"2023-03-20 10:05:44.000000000","message":"DONE","commit_id":"bcfdc1957ec9b028fcdb95060d83de268b195acc"}]}