)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"f94a61088b546520dfa623af8ec2f1cdaf240a61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9f0b3698_7c6d187b","updated":"2023-04-13 19:42:00.000000000","message":"I /think/ what I\u0027m saying make sense...","commit_id":"689886fa517ca8af9cc9d2a815ad73e12406c2df"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"85dda4cde5b2a923606992f03a59d1c3360f2385","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"47d3837c_f63ba33b","updated":"2023-06-01 06:56:37.000000000","message":"first pass before our call today","commit_id":"d75363fa75adc55fe64441e1b9a65565c6b1ab36"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"ff6c8dc591d29879f2458aecb26a5798ab41ce06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"b6b3bcec_46f6f733","updated":"2023-06-08 21:02:17.000000000","message":"https://zuul.opendev.org/t/openstack/builds?job_name\u003dtripleo-ci-centos-9-content-provider-current\u0026skip\u003d0","commit_id":"b9b10bd5f06ac1f0c6e0405464f848925b0738a0"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"83f2bf12c7f782cb0405cd031bd690dff7f75af6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"91f98585_d32fd053","updated":"2023-06-08 21:01:32.000000000","message":"see current provider jobs are run on test job:","commit_id":"b9b10bd5f06ac1f0c6e0405464f848925b0738a0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"906b03944838c7f56ccec20d1bd829c6a518e0d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"a68542ec_a1214be0","updated":"2023-06-20 07:21:04.000000000","message":"please check the linting issue","commit_id":"830d672b80d2e3a18c982e0d39ad51bd5d437f74"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5469f299a056b701e7f7aca8d2e1867d17124086","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"b86dbb39_3f9cc0ad","updated":"2023-06-21 11:23:04.000000000","message":"removing vote until periodic.yaml included here as discussed in today review call","commit_id":"fe614541967607e5872c4aa3d254f85a820762bd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c6b89a0c54d619f9653902cd2abe90d9d6f8ea91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"b55e865c_e572325b","updated":"2023-06-22 07:01:17.000000000","message":"tests need attention... looks like there was an update on v41 for test_release_name.py","commit_id":"933b651262d157086a378dda34fb25206c9f08f7"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"0b697a9e6d25bfef88f0d74e1aeff5e5eab4e685","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"2d9e5d33_74713f2f","updated":"2023-06-23 01:11:44.000000000","message":"I think I get the logic here - marking +1 to check the releases master, wallaby and train are all correctly placed","commit_id":"9e7cf3033706f578652d9bae65629bb468d860a1"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"07ffcea17ab89da03402ada0872446d3b3fe893a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"370a0ecc_f832a4c5","updated":"2023-06-26 07:37:49.000000000","message":"I took a cut at reviewing this PR.\n\nI don\u0027t know the code around emit_release very well but I couldn\u0027t spot anything obvious in this PR","commit_id":"9e7cf3033706f578652d9bae65629bb468d860a1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"43618eefb57bb6b8961ade1c32d43d787f7b6a76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"f67709d9_fa87f971","updated":"2023-06-26 11:19:56.000000000","message":"as discussed today lets go with this","commit_id":"9e7cf3033706f578652d9bae65629bb468d860a1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"47d056048fd2e439c07298adb4f118d809405fba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"60b1fe4d_5c12d413","updated":"2023-06-23 06:43:18.000000000","message":"lgtm\n\ni just hit workflow on the featureset one, once it merges i think this is next","commit_id":"9e7cf3033706f578652d9bae65629bb468d860a1"}],"playbooks/tripleo-ci/run-provider.yml":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"0b697a9e6d25bfef88f0d74e1aeff5e5eab4e685","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    - name: Combine override_repos with ci_branch variable"},{"line_number":23,"context_line":"      set_fact:"},{"line_number":24,"context_line":"        ci_branch: \"{{ ci_branch + \u0027-\u0027 + override_repos }}\""},{"line_number":25,"context_line":"      when: override_repos !\u003d \u0027\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    - name: Set branch variables"},{"line_number":28,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"aab77d56_1793b5eb","line":25,"updated":"2023-06-23 01:11:44.000000000","message":"ok - I see the default","commit_id":"9e7cf3033706f578652d9bae65629bb468d860a1"}],"roles/run-test/templates/toci_gate_test.sh.j2":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"82183d00c670a3a0a4baa412c85320054900b8e4","unresolved":true,"context_lines":[{"line_number":108,"context_line":"elif is_featureset overcloud_update \"{{ job_featureset_file }}\"; then"},{"line_number":109,"context_line":"    echo \"\""},{"line_number":110,"context_line":"    {% if provider_dlrn_hash_tag_branch is defined %}"},{"line_number":111,"context_line":"    EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --content-provider-hashes\u003d{{ provider_dlrn_hash_tag_branch.keys()|zip(provider_dlrn_hash_tag_branch.values())|map(\u0027join\u0027,\u0027:\u0027)|join(\u0027;\u0027) }} --target-branch-override\u003d$QUICKSTART_RELEASE-current --install-branch-override\u003d$QUICKSTART_RELEASE\""},{"line_number":112,"context_line":"    {% endif %}"},{"line_number":113,"context_line":"fi"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5ec06bb1_61936f6a","line":111,"updated":"2023-06-20 12:29:27.000000000","message":"${QUICKSTART_RELEASE}-current","commit_id":"94cece213b6e8c768b7d924528e9c7846f93eb0c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"eb9d26b82d5e87376582b28cda0f8b56a00ce73e","unresolved":true,"context_lines":[{"line_number":108,"context_line":"elif is_featureset overcloud_update \"{{ job_featureset_file }}\"; then"},{"line_number":109,"context_line":"    echo \"\""},{"line_number":110,"context_line":"    {% if provider_dlrn_hash_tag_branch is defined %}"},{"line_number":111,"context_line":"    EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --content-provider-hashes\u003d{{ provider_dlrn_hash_tag_branch.keys()|zip(provider_dlrn_hash_tag_branch.values())|map(\u0027join\u0027,\u0027:\u0027)|join(\u0027;\u0027) }} --target-branch-override\u003d$QUICKSTART_RELEASE-current --install-branch-override\u003d$QUICKSTART_RELEASE\""},{"line_number":112,"context_line":"    {% endif %}"},{"line_number":113,"context_line":"fi"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"973498e9_f485050d","line":111,"in_reply_to":"5ec06bb1_61936f6a","updated":"2023-06-21 06:12:09.000000000","message":"this must be an earlier comment (patchset 5?) I think it is OK now @Sofer if so please mark this resolved?","commit_id":"94cece213b6e8c768b7d924528e9c7846f93eb0c"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"cf6369fd48eb8606b490370387020e4de98d0314","unresolved":false,"context_lines":[{"line_number":108,"context_line":"elif is_featureset overcloud_update \"{{ job_featureset_file }}\"; then"},{"line_number":109,"context_line":"    echo \"\""},{"line_number":110,"context_line":"    {% if provider_dlrn_hash_tag_branch is defined %}"},{"line_number":111,"context_line":"    EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --content-provider-hashes\u003d{{ provider_dlrn_hash_tag_branch.keys()|zip(provider_dlrn_hash_tag_branch.values())|map(\u0027join\u0027,\u0027:\u0027)|join(\u0027;\u0027) }} --target-branch-override\u003d$QUICKSTART_RELEASE-current --install-branch-override\u003d$QUICKSTART_RELEASE\""},{"line_number":112,"context_line":"    {% endif %}"},{"line_number":113,"context_line":"fi"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"a7621515_4594e057","line":111,"in_reply_to":"973498e9_f485050d","updated":"2023-06-22 13:10:37.000000000","message":"It is resolved. It patchset 5 the line was --target-branch-override\u003d$QUICKSTART_RELEASE-current, in later revisions, including  current it is --target-branch-override\u003d${QUICKSTART_RELEASE}-current","commit_id":"94cece213b6e8c768b7d924528e9c7846f93eb0c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8a507bab78f2ba65eccda342999e6d6aefe28155","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    {% endif %}"},{"line_number":108,"context_line":"# For minor_update we stay on the same branch, but we need to pass zuul information of \u0027current\u0027 content provider job in target-branch-override."},{"line_number":109,"context_line":"elif is_featureset minor_update \"{{ job_featureset_file }}\"; then"},{"line_number":110,"context_line":"    echo \"Minor update job\""},{"line_number":111,"context_line":"    {% if provider_dlrn_hash_tag_branch is defined %}"},{"line_number":112,"context_line":"    EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --content-provider-hashes\u003d{{ provider_dlrn_hash_tag_branch.keys()|zip(provider_dlrn_hash_tag_branch.values())|map(\u0027join\u0027,\u0027:\u0027)|join(\u0027;\u0027) }} --target-branch-override\u003d${QUICKSTART_RELEASE}-current --install-branch-override\u003d$QUICKSTART_RELEASE\""},{"line_number":113,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":37,"id":"f33732d4_7a9f6ebd","line":110,"range":{"start_line":110,"start_character":10,"end_line":110,"end_character":26},"updated":"2023-06-07 07:36:28.000000000","message":"per comment below can you please consider something like \"minor update centos9/wallaby\"","commit_id":"b9b10bd5f06ac1f0c6e0405464f848925b0738a0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"906b03944838c7f56ccec20d1bd829c6a518e0d4","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    {% endif %}"},{"line_number":108,"context_line":"# For minor_update we stay on the same branch, but we need to pass zuul information of \u0027current\u0027 content provider job in target-branch-override."},{"line_number":109,"context_line":"elif is_featureset minor_update \"{{ job_featureset_file }}\"; then"},{"line_number":110,"context_line":"    echo \"Minor update job\""},{"line_number":111,"context_line":"    {% if provider_dlrn_hash_tag_branch is defined %}"},{"line_number":112,"context_line":"    EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --content-provider-hashes\u003d{{ provider_dlrn_hash_tag_branch.keys()|zip(provider_dlrn_hash_tag_branch.values())|map(\u0027join\u0027,\u0027:\u0027)|join(\u0027;\u0027) }} --target-branch-override\u003d${QUICKSTART_RELEASE}-current --install-branch-override\u003d$QUICKSTART_RELEASE\""},{"line_number":113,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":37,"id":"d2ada8c3_c489540d","line":110,"range":{"start_line":110,"start_character":10,"end_line":110,"end_character":26},"in_reply_to":"f33732d4_7a9f6ebd","updated":"2023-06-20 07:21:04.000000000","message":"Done","commit_id":"b9b10bd5f06ac1f0c6e0405464f848925b0738a0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8a507bab78f2ba65eccda342999e6d6aefe28155","unresolved":true,"context_lines":[{"line_number":114,"context_line":"# This is a case for train branch, which uses featureset038. In featureset038 we test update workflow itself, no containers or rpms update happens."},{"line_number":115,"context_line":"# Target branch is overridden to be exactly the same as for deployment, because only containers used during deployment are in local container registry."},{"line_number":116,"context_line":"elif is_featureset overcloud_update \"{{ job_featureset_file }}\"; then"},{"line_number":117,"context_line":"    echo \"Overcloud update job\""},{"line_number":118,"context_line":"    {% if provider_dlrn_hash_tag_branch is defined %}"},{"line_number":119,"context_line":"    EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --content-provider-hashes\u003d{{ provider_dlrn_hash_tag_branch.keys()|zip(provider_dlrn_hash_tag_branch.values())|map(\u0027join\u0027,\u0027:\u0027)|join(\u0027;\u0027) }} --target-branch-override\u003d$QUICKSTART_RELEASE\""},{"line_number":120,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":37,"id":"a492f13b_829b220c","line":117,"range":{"start_line":117,"start_character":10,"end_line":117,"end_character":30},"updated":"2023-06-07 07:36:28.000000000","message":"can we make this message more explicit to minimize confusion (they are both update jobs)\n\nsomething like \"minor update centos8/train\"","commit_id":"b9b10bd5f06ac1f0c6e0405464f848925b0738a0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"906b03944838c7f56ccec20d1bd829c6a518e0d4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"# This is a case for train branch, which uses featureset038. In featureset038 we test update workflow itself, no containers or rpms update happens."},{"line_number":115,"context_line":"# Target branch is overridden to be exactly the same as for deployment, because only containers used during deployment are in local container registry."},{"line_number":116,"context_line":"elif is_featureset overcloud_update \"{{ job_featureset_file }}\"; then"},{"line_number":117,"context_line":"    echo \"Overcloud update job\""},{"line_number":118,"context_line":"    {% if provider_dlrn_hash_tag_branch is defined %}"},{"line_number":119,"context_line":"    EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --content-provider-hashes\u003d{{ provider_dlrn_hash_tag_branch.keys()|zip(provider_dlrn_hash_tag_branch.values())|map(\u0027join\u0027,\u0027:\u0027)|join(\u0027;\u0027) }} --target-branch-override\u003d$QUICKSTART_RELEASE\""},{"line_number":120,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":37,"id":"02e2825b_75659ff4","line":117,"range":{"start_line":117,"start_character":10,"end_line":117,"end_character":30},"in_reply_to":"a492f13b_829b220c","updated":"2023-06-20 07:21:04.000000000","message":"Done","commit_id":"b9b10bd5f06ac1f0c6e0405464f848925b0738a0"}],"roles/run-test/templates/toci_quickstart.sh.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"85dda4cde5b2a923606992f03a59d1c3360f2385","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"if is_featureset minor_update \"{{ job_featureset_file }}\"; then"},{"line_number":118,"context_line":"    PLAYBOOKS_ARGS\u003d("},{"line_number":119,"context_line":"        [\"multinode-undercloud-upgrade.yml\"]\u003d\" --extra-vars container_registry_relase\u003d\u0027${QUICKSTART_RELEASE}-current\u0027 --extra-vars overcloud_update\u003d\u0027false\u0027 --extra-vars promote_source\u003d\u0027current\u0027 \""},{"line_number":120,"context_line":"        [\"multinode-overcloud-update.yml\"]\u003d\" --extra-vars container_registry_relase\u003d\u0027${QUICKSTART_RELEASE}-current\u0027 --extra-vars undercloud_update\u003d\u0027false\u0027 --extra-vars promote_source\u003d\u0027current\u0027 \""},{"line_number":121,"context_line":"    )"},{"line_number":122,"context_line":"fi"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"1692a4e6_875550d2","line":119,"range":{"start_line":119,"start_character":20,"end_line":119,"end_character":38},"updated":"2023-06-01 06:56:37.000000000","message":"why this one too","commit_id":"d75363fa75adc55fe64441e1b9a65565c6b1ab36"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"c7ef0d7b72cb311d951399d6d5807a76103181f9","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"if is_featureset minor_update \"{{ job_featureset_file }}\"; then"},{"line_number":118,"context_line":"    PLAYBOOKS_ARGS\u003d("},{"line_number":119,"context_line":"        [\"multinode-undercloud-upgrade.yml\"]\u003d\" --extra-vars container_registry_relase\u003d\u0027${QUICKSTART_RELEASE}-current\u0027 --extra-vars overcloud_update\u003d\u0027false\u0027 --extra-vars promote_source\u003d\u0027current\u0027 \""},{"line_number":120,"context_line":"        [\"multinode-overcloud-update.yml\"]\u003d\" --extra-vars container_registry_relase\u003d\u0027${QUICKSTART_RELEASE}-current\u0027 --extra-vars undercloud_update\u003d\u0027false\u0027 --extra-vars promote_source\u003d\u0027current\u0027 \""},{"line_number":121,"context_line":"    )"},{"line_number":122,"context_line":"fi"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"7e638227_ecb4f827","line":119,"range":{"start_line":119,"start_character":20,"end_line":119,"end_character":38},"in_reply_to":"1692a4e6_875550d2","updated":"2023-06-01 16:14:20.000000000","message":"This change is required, because the job is going to run minor update on undercloud  and we need containers with current tag on undercloud too.","commit_id":"d75363fa75adc55fe64441e1b9a65565c6b1ab36"}],"scripts/emit_releases_file/emit_releases_file.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"85dda4cde5b2a923606992f03a59d1c3360f2385","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            continue"},{"line_number":122,"context_line":"        if repo_file is not None and repo_file.ok:"},{"line_number":123,"context_line":"            if distro_name \u003d\u003d \u0027centos\u0027 and distro_version \u003d\u003d \u00277\u0027:"},{"line_number":124,"context_line":"                print(repo_file.text)"},{"line_number":125,"context_line":"                full_hash \u003d full_hash_pattern.findall(repo_file.text)[0]"},{"line_number":126,"context_line":"            elif distro_name \u003d\u003d \u0027centos\u0027 and distro_version in [\u00278\u0027, \u00279\u0027]:"},{"line_number":127,"context_line":"                full_hash \u003d repo_file.text"}],"source_content_type":"text/x-python","patch_set":32,"id":"10375949_70a745dc","side":"PARENT","line":124,"updated":"2023-06-01 06:56:37.000000000","message":"unnecessary change?","commit_id":"941bbcdfff116b4df2011d7a74a1a9a8dc8c26b8"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"c7ef0d7b72cb311d951399d6d5807a76103181f9","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            continue"},{"line_number":122,"context_line":"        if repo_file is not None and repo_file.ok:"},{"line_number":123,"context_line":"            if distro_name \u003d\u003d \u0027centos\u0027 and distro_version \u003d\u003d \u00277\u0027:"},{"line_number":124,"context_line":"                print(repo_file.text)"},{"line_number":125,"context_line":"                full_hash \u003d full_hash_pattern.findall(repo_file.text)[0]"},{"line_number":126,"context_line":"            elif distro_name \u003d\u003d \u0027centos\u0027 and distro_version in [\u00278\u0027, \u00279\u0027]:"},{"line_number":127,"context_line":"                full_hash \u003d repo_file.text"}],"source_content_type":"text/x-python","patch_set":32,"id":"e33e23f7_d50a6bd4","side":"PARENT","line":124,"in_reply_to":"10375949_70a745dc","updated":"2023-06-01 16:14:20.000000000","message":"Done","commit_id":"941bbcdfff116b4df2011d7a74a1a9a8dc8c26b8"}],"scripts/emit_releases_file/test_release_name.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"906b03944838c7f56ccec20d1bd829c6a518e0d4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":38,"id":"8ce46c63_ec818464","side":"PARENT","updated":"2023-06-20 07:21:04.000000000","message":"looks like this one might have a nit - fails linting see https://05a509bbc6224e1df6b0-e19ef9e6a56d7aa7489f24bbcf19f0be.ssl.cf1.rackcdn.com/880162/38/check/openstack-tox-linters/dc6cede/tox/linters/4-commands%5B0%5D.log\n\nblack....................................................................Failed\n- hook id: black\n- files were modified by this hook\n\nreformatted scripts/emit_releases_file/test_release_name.py\n\nAll done! ✨ 🍰 ✨\n1 file reformatted, 19 files left unchanged.","commit_id":"941bbcdfff116b4df2011d7a74a1a9a8dc8c26b8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3ff8286964ce48a2417c6de641c5505b56e1ae02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"29cd6902_7e12c544","side":"PARENT","in_reply_to":"8ce46c63_ec818464","updated":"2023-06-21 06:12:47.000000000","message":"Done","commit_id":"941bbcdfff116b4df2011d7a74a1a9a8dc8c26b8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c6b89a0c54d619f9653902cd2abe90d9d6f8ea91","unresolved":true,"context_lines":[{"line_number":910,"context_line":"                \u0027standalone_target_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":911,"context_line":"            },"},{"line_number":912,"context_line":"        ),"},{"line_number":913,"context_line":"        ("},{"line_number":914,"context_line":"            \u0027victoria\u0027,"},{"line_number":915,"context_line":"            {"},{"line_number":916,"context_line":"                \u0027undercloud_install_release\u0027: \u0027victoria\u0027,"},{"line_number":917,"context_line":"                \u0027undercloud_install_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":918,"context_line":"                \u0027undercloud_target_release\u0027: \u0027victoria\u0027,"},{"line_number":919,"context_line":"                \u0027undercloud_target_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":920,"context_line":"                \u0027overcloud_deploy_release\u0027: \u0027victoria\u0027,"},{"line_number":921,"context_line":"                \u0027overcloud_deploy_hash\u0027: \u0027previous-current-tripleo\u0027,"},{"line_number":922,"context_line":"                \u0027overcloud_target_release\u0027: \u0027victoria\u0027,"},{"line_number":923,"context_line":"                \u0027overcloud_target_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":924,"context_line":"                \u0027standalone_deploy_release\u0027: \u0027victoria\u0027,"},{"line_number":925,"context_line":"                \u0027standalone_deploy_newest_hash\u0027: \u0027current\u0027,"},{"line_number":926,"context_line":"                \u0027standalone_deploy_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":927,"context_line":"                \u0027standalone_target_release\u0027: \u0027victoria\u0027,"},{"line_number":928,"context_line":"                \u0027standalone_target_newest_hash\u0027: \u0027current\u0027,"},{"line_number":929,"context_line":"                \u0027standalone_target_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":930,"context_line":"            },"},{"line_number":931,"context_line":"        ),"},{"line_number":932,"context_line":"        ("},{"line_number":933,"context_line":"            \u0027ussuri\u0027,"},{"line_number":934,"context_line":"            {"},{"line_number":935,"context_line":"                \u0027undercloud_install_release\u0027: \u0027ussuri\u0027,"},{"line_number":936,"context_line":"                \u0027undercloud_install_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":937,"context_line":"                \u0027undercloud_target_release\u0027: \u0027ussuri\u0027,"},{"line_number":938,"context_line":"                \u0027undercloud_target_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":939,"context_line":"                \u0027overcloud_deploy_release\u0027: \u0027ussuri\u0027,"},{"line_number":940,"context_line":"                \u0027overcloud_deploy_hash\u0027: \u0027previous-current-tripleo\u0027,"},{"line_number":941,"context_line":"                \u0027overcloud_target_release\u0027: \u0027ussuri\u0027,"},{"line_number":942,"context_line":"                \u0027overcloud_target_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":943,"context_line":"                \u0027standalone_deploy_release\u0027: \u0027ussuri\u0027,"},{"line_number":944,"context_line":"                \u0027standalone_deploy_newest_hash\u0027: \u0027current\u0027,"}],"source_content_type":"text/x-python","patch_set":41,"id":"b2be0a35_4644cc46","line":941,"range":{"start_line":913,"start_character":9,"end_line":941,"end_character":35},"updated":"2023-06-22 07:01:17.000000000","message":"do we really need victoria/ussuri?please lets avoid adding these","commit_id":"933b651262d157086a378dda34fb25206c9f08f7"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"cf6369fd48eb8606b490370387020e4de98d0314","unresolved":false,"context_lines":[{"line_number":910,"context_line":"                \u0027standalone_target_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":911,"context_line":"            },"},{"line_number":912,"context_line":"        ),"},{"line_number":913,"context_line":"        ("},{"line_number":914,"context_line":"            \u0027victoria\u0027,"},{"line_number":915,"context_line":"            {"},{"line_number":916,"context_line":"                \u0027undercloud_install_release\u0027: \u0027victoria\u0027,"},{"line_number":917,"context_line":"                \u0027undercloud_install_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":918,"context_line":"                \u0027undercloud_target_release\u0027: \u0027victoria\u0027,"},{"line_number":919,"context_line":"                \u0027undercloud_target_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":920,"context_line":"                \u0027overcloud_deploy_release\u0027: \u0027victoria\u0027,"},{"line_number":921,"context_line":"                \u0027overcloud_deploy_hash\u0027: \u0027previous-current-tripleo\u0027,"},{"line_number":922,"context_line":"                \u0027overcloud_target_release\u0027: \u0027victoria\u0027,"},{"line_number":923,"context_line":"                \u0027overcloud_target_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":924,"context_line":"                \u0027standalone_deploy_release\u0027: \u0027victoria\u0027,"},{"line_number":925,"context_line":"                \u0027standalone_deploy_newest_hash\u0027: \u0027current\u0027,"},{"line_number":926,"context_line":"                \u0027standalone_deploy_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":927,"context_line":"                \u0027standalone_target_release\u0027: \u0027victoria\u0027,"},{"line_number":928,"context_line":"                \u0027standalone_target_newest_hash\u0027: \u0027current\u0027,"},{"line_number":929,"context_line":"                \u0027standalone_target_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":930,"context_line":"            },"},{"line_number":931,"context_line":"        ),"},{"line_number":932,"context_line":"        ("},{"line_number":933,"context_line":"            \u0027ussuri\u0027,"},{"line_number":934,"context_line":"            {"},{"line_number":935,"context_line":"                \u0027undercloud_install_release\u0027: \u0027ussuri\u0027,"},{"line_number":936,"context_line":"                \u0027undercloud_install_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":937,"context_line":"                \u0027undercloud_target_release\u0027: \u0027ussuri\u0027,"},{"line_number":938,"context_line":"                \u0027undercloud_target_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":939,"context_line":"                \u0027overcloud_deploy_release\u0027: \u0027ussuri\u0027,"},{"line_number":940,"context_line":"                \u0027overcloud_deploy_hash\u0027: \u0027previous-current-tripleo\u0027,"},{"line_number":941,"context_line":"                \u0027overcloud_target_release\u0027: \u0027ussuri\u0027,"},{"line_number":942,"context_line":"                \u0027overcloud_target_hash\u0027: \u0027tripleo-ci-testing\u0027,"},{"line_number":943,"context_line":"                \u0027standalone_deploy_release\u0027: \u0027ussuri\u0027,"},{"line_number":944,"context_line":"                \u0027standalone_deploy_newest_hash\u0027: \u0027current\u0027,"}],"source_content_type":"text/x-python","patch_set":41,"id":"1437349b_b9cf43eb","line":941,"range":{"start_line":913,"start_character":9,"end_line":941,"end_character":35},"in_reply_to":"b2be0a35_4644cc46","updated":"2023-06-22 13:10:37.000000000","message":"Done","commit_id":"933b651262d157086a378dda34fb25206c9f08f7"}],"zuul.d/content-provider.yaml":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"f94a61088b546520dfa623af8ec2f1cdaf240a61","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    nodeset: single-centos-9-node"},{"line_number":40,"context_line":"    vars:"},{"line_number":41,"context_line":"      containers_base_image: registry.access.redhat.com/ubi9:latest"},{"line_number":42,"context_line":"      buildcontainers_override_repos: current"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- job:"},{"line_number":45,"context_line":"    name: tripleo-ci-centos-9-content-provider-wallaby"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8f44da43_2618fd5e","line":42,"updated":"2023-04-13 19:42:00.000000000","message":"We might need another variable named something like override_ci_branch to be defined here that would be taken into account there https://opendev.org/openstack/tripleo-ci/src/branch/master/playbooks/tripleo-ci/run-provider.yml#L25\n\nThen we would need that variable in https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/roles/extras-common/defaults/main.yml#L43 with a fallback to ci_branch and eventually we would need it as well in https://opendev.org/openstack/tripleo-ci/src/branch/master/roles/run-test/templates/toci_quickstart.sh.j2#L101 with a test on a featureset variable to add it to the multinode-overcloud playbook.","commit_id":"689886fa517ca8af9cc9d2a815ad73e12406c2df"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"33de66a7cbe4d8def658e0cedea99a1080596133","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    nodeset: single-centos-9-node"},{"line_number":40,"context_line":"    vars:"},{"line_number":41,"context_line":"      containers_base_image: registry.access.redhat.com/ubi9:latest"},{"line_number":42,"context_line":"      buildcontainers_override_repos: current"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- job:"},{"line_number":45,"context_line":"    name: tripleo-ci-centos-9-content-provider-wallaby"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6f23d1eb_a6c6ceaf","line":42,"in_reply_to":"8f44da43_2618fd5e","updated":"2023-05-18 01:37:36.000000000","message":"Ack","commit_id":"689886fa517ca8af9cc9d2a815ad73e12406c2df"}],"zuul.d/upgrades-jobs-templates.yaml":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"ff6c8dc591d29879f2458aecb26a5798ab41ce06","unresolved":true,"context_lines":[{"line_number":8,"context_line":"      jobs:"},{"line_number":9,"context_line":"        - tripleo-ci-centos-9-content-provider"},{"line_number":10,"context_line":"        - tripleo-ci-centos-9-content-provider-current"},{"line_number":11,"context_line":"        - tripleo-ci-centos-9-content-provider-zed"},{"line_number":12,"context_line":"        - tripleo-ci-centos-9-scenario000-multinode-oooq-container-updates: \u0026cs9_update_all"},{"line_number":13,"context_line":"            irrelevant-files: \u0026multinode_ignored"},{"line_number":14,"context_line":"              - .*molecule.*"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"21db21ef_d75880df","line":11,"updated":"2023-06-08 21:02:17.000000000","message":"should this be removed?","commit_id":"b9b10bd5f06ac1f0c6e0405464f848925b0738a0"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"7b8f9d3b21142291dd92654973abb49d6b9d109d","unresolved":true,"context_lines":[{"line_number":8,"context_line":"      jobs:"},{"line_number":9,"context_line":"        - tripleo-ci-centos-9-content-provider"},{"line_number":10,"context_line":"        - tripleo-ci-centos-9-content-provider-current"},{"line_number":11,"context_line":"        - tripleo-ci-centos-9-content-provider-zed"},{"line_number":12,"context_line":"        - tripleo-ci-centos-9-scenario000-multinode-oooq-container-updates: \u0026cs9_update_all"},{"line_number":13,"context_line":"            irrelevant-files: \u0026multinode_ignored"},{"line_number":14,"context_line":"              - .*molecule.*"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"feb40919_031102a0","line":11,"in_reply_to":"21db21ef_d75880df","updated":"2023-06-09 12:22:22.000000000","message":"This is master pipeline and the zed job is a dependency for  tripleo-ci-centos-9-undercloud-upgrade job. I can remove it from here together with undercloud-upgrade. Is there a point then of keeping tripleo-upgrades-master-pipeline at all? The only job which will be left will be content provider one and oooq-container-updates job(which we want to enable for wallaby now and for train in future).","commit_id":"b9b10bd5f06ac1f0c6e0405464f848925b0738a0"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"b5fc8606e6ce161709c747e8f6e1e3fcb8f4c70e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      jobs:"},{"line_number":9,"context_line":"        - tripleo-ci-centos-9-content-provider"},{"line_number":10,"context_line":"        - tripleo-ci-centos-9-content-provider-current"},{"line_number":11,"context_line":"        - tripleo-ci-centos-9-content-provider-zed"},{"line_number":12,"context_line":"        - tripleo-ci-centos-9-scenario000-multinode-oooq-container-updates: \u0026cs9_update_all"},{"line_number":13,"context_line":"            irrelevant-files: \u0026multinode_ignored"},{"line_number":14,"context_line":"              - .*molecule.*"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"1670b6d3_c365ea9e","line":11,"in_reply_to":"734e5104_65d272a4","updated":"2023-06-23 13:49:51.000000000","message":"Ack","commit_id":"b9b10bd5f06ac1f0c6e0405464f848925b0738a0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"906b03944838c7f56ccec20d1bd829c6a518e0d4","unresolved":true,"context_lines":[{"line_number":8,"context_line":"      jobs:"},{"line_number":9,"context_line":"        - tripleo-ci-centos-9-content-provider"},{"line_number":10,"context_line":"        - tripleo-ci-centos-9-content-provider-current"},{"line_number":11,"context_line":"        - tripleo-ci-centos-9-content-provider-zed"},{"line_number":12,"context_line":"        - tripleo-ci-centos-9-scenario000-multinode-oooq-container-updates: \u0026cs9_update_all"},{"line_number":13,"context_line":"            irrelevant-files: \u0026multinode_ignored"},{"line_number":14,"context_line":"              - .*molecule.*"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"734e5104_65d272a4","line":11,"in_reply_to":"feb40919_031102a0","updated":"2023-06-20 07:21:04.000000000","message":"no lets not remove anything or otherwise update the master template.\n\nthe only reason Mikolaj is touching this @Rlandy is because he wants to use the cs9_update_all anchor defined on line 12, in the wallaby template below line line 151 (i.e. keep using that anchor there and it will work with the new dependencies added here on master).\n\nthe master pipeline is no longer running anywhere. i think this is OK for now. at some point and if we ever get rid of the master/zed definitions we can rework this and move it all into the wallaby template.","commit_id":"b9b10bd5f06ac1f0c6e0405464f848925b0738a0"}]}