)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"33734ff8e38423a4b8d136d5f592b56ca3813639","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f9e47b1b_4b89b025","updated":"2023-09-18 12:47:48.000000000","message":"recheck","commit_id":"0c355bc30edb40b0df7b5f5b2356435f088ea882"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"650393504c9b77242e84b30115fc05a3fca8310d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"acc55c4a_2f58d65d","updated":"2023-10-12 06:34:29.000000000","message":"sanity check about the conditionals please we only want these for the downstream case","commit_id":"1600d5b75cf8ee1bcde29f5f95c8ea26935f46b4"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5236b801dd920a437e982e8b3cbb6723a38b1347","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"47612f1e_d0f367a5","updated":"2023-10-17 06:31:34.000000000","message":"lgtm, but before we merge did you please get a chance to sanity check that the RDO periodic minor update job is not broken by this (and the two other patches quickstart/extras)","commit_id":"149db5491338d8740d70a4c46ca0ce612bdf4c95"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"689e48729bac8caac900834a5cd4e36ede554f73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4a87d482_f8a1164e","in_reply_to":"47612f1e_d0f367a5","updated":"2023-10-17 19:31:26.000000000","message":"Check/gate sanity test https://review.opendev.org/c/openstack/tripleo-upgrade/+/898317 \nPeriodic RDO update job sanity test: https://review.rdoproject.org/r/c/testproject/+/48809","commit_id":"149db5491338d8740d70a4c46ca0ce612bdf4c95"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"da145336d210e2ebcbc2331596f9d07d10175280","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"134b47bc_86047749","updated":"2023-10-19 05:53:59.000000000","message":"as discussed yesterday lets go with this today and watch for any fallout. then we can proceed with the quickstart/extras","commit_id":"5cf9d418c0846f7e0e430b8d5e8ce1b6f7f6fe99"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5ae583944811e8e41e1f078041ecfa83214fd3ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ee44875a_052cd06e","updated":"2023-10-18 11:29:33.000000000","message":"thanks for sanity checks Mikolaj as discussed just now on the reviews call\n\nlgtm","commit_id":"5cf9d418c0846f7e0e430b8d5e8ce1b6f7f6fe99"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7c69021124d10315c58d75c5fe90604f3b77d767","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4aea12d8_02606de0","in_reply_to":"ee44875a_052cd06e","updated":"2023-10-18 11:30:14.000000000","message":"Sanity checks https://review.rdoproject.org/r/c/testproject/+/48809 https://review.opendev.org/c/openstack/tripleo-upgrade/+/898317","commit_id":"5cf9d418c0846f7e0e430b8d5e8ce1b6f7f6fe99"}],"roles/run-test/templates/toci_gate_test.sh.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"650393504c9b77242e84b30115fc05a3fca8310d","unresolved":true,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"{% if periodic|bool %}"},{"line_number":130,"context_line":"PERIODIC\u003d1"},{"line_number":131,"context_line":"if is_featureset minor_update \"{{ job_featureset_file }}\"; then"},{"line_number":132,"context_line":"# For minor update job we need to use seperate promotion file"},{"line_number":133,"context_line":"QUICKSTART_RELEASE\u003d\"update-promotion-testing-hash-${QUICKSTART_RELEASE}\""},{"line_number":134,"context_line":"else"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"05f5747f_fa47bce5","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":29},"updated":"2023-10-12 06:34:29.000000000","message":"also if this is downstream periodic right","commit_id":"1600d5b75cf8ee1bcde29f5f95c8ea26935f46b4"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"6d5e0da67c14f12679eb358bf3ddf22c260f1684","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"{% if periodic|bool %}"},{"line_number":130,"context_line":"PERIODIC\u003d1"},{"line_number":131,"context_line":"if is_featureset minor_update \"{{ job_featureset_file }}\"; then"},{"line_number":132,"context_line":"# For minor update job we need to use seperate promotion file"},{"line_number":133,"context_line":"QUICKSTART_RELEASE\u003d\"update-promotion-testing-hash-${QUICKSTART_RELEASE}\""},{"line_number":134,"context_line":"else"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"68b80cbd_df3ba61a","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":29},"in_reply_to":"05f5747f_fa47bce5","updated":"2023-10-16 12:59:17.000000000","message":"Done","commit_id":"1600d5b75cf8ee1bcde29f5f95c8ea26935f46b4"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5236b801dd920a437e982e8b3cbb6723a38b1347","unresolved":true,"context_lines":[{"line_number":130,"context_line":"PERIODIC\u003d1"},{"line_number":131,"context_line":"QUICKSTART_RELEASE\u003d\"promotion-testing-hash-${QUICKSTART_RELEASE}\""},{"line_number":132,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --is-periodic\""},{"line_number":133,"context_line":"{% if osp_release is defined %}"},{"line_number":134,"context_line":"if is_featureset minor_update \"{{ job_featureset_file }}\"; then"},{"line_number":135,"context_line":"# In downstream minor update job we use special, seperate promotion file"},{"line_number":136,"context_line":"QUICKSTART_RELEASE\u003d\"update-promotion-testing-hash-${QUICKSTART_RELEASE}\""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"745c4692_c638f0be","line":133,"updated":"2023-10-17 06:31:34.000000000","message":"ack thanks for update.\n\nfor the record/benefit of other reviewers, this bit is likely to be removed when Mikolaj revisits this after this series is merged. we will try to remove the new release file added with https://code.engineering.redhat.com/gerrit/c/tripleo-environments/+/447281 (and referenced here line 136) and we will try to re-use the existing one with appropriate conditionals","commit_id":"149db5491338d8740d70a4c46ca0ce612bdf4c95"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"c2be73d9c66ea115961981c764a35fbaf1f87bf5","unresolved":true,"context_lines":[{"line_number":130,"context_line":"PERIODIC\u003d1"},{"line_number":131,"context_line":"QUICKSTART_RELEASE\u003d\"promotion-testing-hash-${QUICKSTART_RELEASE}\""},{"line_number":132,"context_line":"EMIT_RELEASES_EXTRA_ARGS\u003d\"$EMIT_RELEASES_EXTRA_ARGS --is-periodic\""},{"line_number":133,"context_line":"{% if osp_release is defined %}"},{"line_number":134,"context_line":"if is_featureset minor_update \"{{ job_featureset_file }}\"; then"},{"line_number":135,"context_line":"# In downstream minor update job we use special, seperate promotion file"},{"line_number":136,"context_line":"QUICKSTART_RELEASE\u003d\"update-promotion-testing-hash-${QUICKSTART_RELEASE}\""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"aff7ecbc_ec42a3a8","line":133,"in_reply_to":"745c4692_c638f0be","updated":"2023-10-17 19:33:03.000000000","message":"this is correct, update-promotion is going to be merged with promotion-testing in next revisit","commit_id":"149db5491338d8740d70a4c46ca0ce612bdf4c95"}],"roles/run-test/templates/toci_quickstart.sh.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"650393504c9b77242e84b30115fc05a3fca8310d","unresolved":true,"context_lines":[{"line_number":120,"context_line":"# Containers are required to be pulled both to undercloud and overcloud to run minor update on the same branch"},{"line_number":121,"context_line":"# Also to trigger update of undercloud and overcloud from correct playbook, overcloud_update and undercloud_update extra-vars are set to false respectively"},{"line_number":122,"context_line":"if is_featureset minor_update \"{{ job_featureset_file }}\"; then"},{"line_number":123,"context_line":"{% if periodic|bool %}"},{"line_number":124,"context_line":"    PLAYBOOKS_ARGS\u003d("},{"line_number":125,"context_line":"        [\"multinode-undercloud-upgrade.yml\"]\u003d\"--extra-vars overcloud_update\u003d\u0027false\u0027 --extra-vars override_docker_image_tag\u003d\u0027true\u0027 \""},{"line_number":126,"context_line":"        [\"multinode-overcloud-update.yml\"]\u003d\"--extra-vars undercloud_update\u003d\u0027false\u0027 --extra-vars override_docker_image_tag\u003d\u0027true\u0027\""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5e2d5555_476108f9","line":123,"updated":"2023-10-12 06:34:29.000000000","message":"we really want this only for downstream right? Please use \"osp_release\" to detect if that is the case we only set this for downstream jobs (and you have it on your job definition https://code.engineering.redhat.com/gerrit/c/openstack/tripleo-ci-internal-jobs/+/445178/13/zuul.d/rhos17.1-rhel9-jobs.yaml\n\nfor example there https://opendev.org/openstack/tripleo-quickstart-extras/src/commit/34cb52dfd23cc3314cd121aef8e8c56a99b314bb/roles/overcloud-deploy/defaults/main.yml#L173\n\n```\n   {% if osp_release is defined -%}\n   enforcing\n   {%- else -%}\n   permissive\n```\n\n[EDIT]: you already use it in the other file here (I am jumping between all the reviews open in tabs ;))","commit_id":"1600d5b75cf8ee1bcde29f5f95c8ea26935f46b4"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"6d5e0da67c14f12679eb358bf3ddf22c260f1684","unresolved":false,"context_lines":[{"line_number":120,"context_line":"# Containers are required to be pulled both to undercloud and overcloud to run minor update on the same branch"},{"line_number":121,"context_line":"# Also to trigger update of undercloud and overcloud from correct playbook, overcloud_update and undercloud_update extra-vars are set to false respectively"},{"line_number":122,"context_line":"if is_featureset minor_update \"{{ job_featureset_file }}\"; then"},{"line_number":123,"context_line":"{% if periodic|bool %}"},{"line_number":124,"context_line":"    PLAYBOOKS_ARGS\u003d("},{"line_number":125,"context_line":"        [\"multinode-undercloud-upgrade.yml\"]\u003d\"--extra-vars overcloud_update\u003d\u0027false\u0027 --extra-vars override_docker_image_tag\u003d\u0027true\u0027 \""},{"line_number":126,"context_line":"        [\"multinode-overcloud-update.yml\"]\u003d\"--extra-vars undercloud_update\u003d\u0027false\u0027 --extra-vars override_docker_image_tag\u003d\u0027true\u0027\""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"64eb5819_19832028","line":123,"in_reply_to":"5e2d5555_476108f9","updated":"2023-10-16 12:59:17.000000000","message":"Done","commit_id":"1600d5b75cf8ee1bcde29f5f95c8ea26935f46b4"}]}