)]}'
{"scripts/tripleo.sh":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"864a936af000defab6ad90dbb7c94816fbf8be78","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    echo \"      --all, -a            -- Run all of the above commands.\""},{"line_number":61,"context_line":"    echo \"      -x                   -- enable tracing\""},{"line_number":62,"context_line":"    echo \"      --help, -h           -- Print this help message.\""},{"line_number":63,"context_line":"    echo \"      --delorean-setup     -- Install local delorean build environment.\""},{"line_number":64,"context_line":"    echo"},{"line_number":65,"context_line":"    exit 1"},{"line_number":66,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a1a9d01_7e114503","line":63,"updated":"2015-09-30 08:46:56.000000000","message":"Lets move this about --undercloud as some people will want packages available when installing the undercloud.","commit_id":"40e78189931a5d989747eb6c3d142f16cb0f2e73"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"4377956723800bf0c77ea1f232530c32cfcf7c0c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    echo \"      --all, -a            -- Run all of the above commands.\""},{"line_number":61,"context_line":"    echo \"      -x                   -- enable tracing\""},{"line_number":62,"context_line":"    echo \"      --help, -h           -- Print this help message.\""},{"line_number":63,"context_line":"    echo \"      --delorean-setup     -- Install local delorean build environment.\""},{"line_number":64,"context_line":"    echo"},{"line_number":65,"context_line":"    exit 1"},{"line_number":66,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a1a9d01_e43388f4","line":63,"in_reply_to":"9a1a9d01_7e114503","updated":"2015-09-30 09:22:30.000000000","message":"Ok, I put it at the end as it\u0027s an \"optional\" additional step, but that sounds fine too.","commit_id":"40e78189931a5d989747eb6c3d142f16cb0f2e73"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"864a936af000defab6ad90dbb7c94816fbf8be78","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    echo \"TRIPLEO_OS_FAMILY\u003d$TRIPLEO_OS_FAMILY\""},{"line_number":193,"context_line":"    echo \"TRIPLEO_OS_DISTRO\u003d$TRIPLEO_OS_DISTRO\""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    export TRIPLEO_ROOT\u003d${TRIPLEO_ROOT:-/home/stack/tripleo}"},{"line_number":196,"context_line":"    mkdir -p $TRIPLEO_ROOT"},{"line_number":197,"context_line":"    [ -d $TRIPLEO_ROOT/delorean ] || git clone https://github.com/openstack-packages/delorean.git $TRIPLEO_ROOT/delorean"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a1a9d01_e305c213","line":195,"updated":"2015-09-30 08:46:56.000000000","message":"Lets make this global for use in other functions? e.g. instead of using $HOME for images?","commit_id":"40e78189931a5d989747eb6c3d142f16cb0f2e73"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"4377956723800bf0c77ea1f232530c32cfcf7c0c","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    echo \"TRIPLEO_OS_FAMILY\u003d$TRIPLEO_OS_FAMILY\""},{"line_number":193,"context_line":"    echo \"TRIPLEO_OS_DISTRO\u003d$TRIPLEO_OS_DISTRO\""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    export TRIPLEO_ROOT\u003d${TRIPLEO_ROOT:-/home/stack/tripleo}"},{"line_number":196,"context_line":"    mkdir -p $TRIPLEO_ROOT"},{"line_number":197,"context_line":"    [ -d $TRIPLEO_ROOT/delorean ] || git clone https://github.com/openstack-packages/delorean.git $TRIPLEO_ROOT/delorean"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a1a9d01_84596c37","line":195,"in_reply_to":"9a1a9d01_e305c213","updated":"2015-09-30 09:22:30.000000000","message":"+1","commit_id":"40e78189931a5d989747eb6c3d142f16cb0f2e73"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"8f48f7232b4e0cb2c1e2919c07e510d520e950ee","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    export TRIPLEO_ROOT\u003d${TRIPLEO_ROOT:-/home/stack/tripleo}"},{"line_number":196,"context_line":"    mkdir -p $TRIPLEO_ROOT"},{"line_number":197,"context_line":"    [ -d $TRIPLEO_ROOT/delorean ] || git clone https://github.com/openstack-packages/delorean.git $TRIPLEO_ROOT/delorean"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    # Install delorean as per combination of toci-instack and delorean docs"},{"line_number":200,"context_line":"    sudo yum install -y docker-io createrepo yum-plugin-priorities yum-utils python-virtualenv git-hg"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a1a9d01_1b56322a","line":197,"updated":"2015-09-29 18:31:39.000000000","message":"git isn\u0027t always installed by default it isn\u0027t on the cloud image which could likely be in use here. probably a good idea to add a yum -y install git before this line.\n\nor, possibly this could be covered in some docs on how to use tripleo.sh since we\u0027ll probably tell people to git clone tripleo-common to get this script.","commit_id":"40e78189931a5d989747eb6c3d142f16cb0f2e73"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"4377956723800bf0c77ea1f232530c32cfcf7c0c","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    export TRIPLEO_ROOT\u003d${TRIPLEO_ROOT:-/home/stack/tripleo}"},{"line_number":196,"context_line":"    mkdir -p $TRIPLEO_ROOT"},{"line_number":197,"context_line":"    [ -d $TRIPLEO_ROOT/delorean ] || git clone https://github.com/openstack-packages/delorean.git $TRIPLEO_ROOT/delorean"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    # Install delorean as per combination of toci-instack and delorean docs"},{"line_number":200,"context_line":"    sudo yum install -y docker-io createrepo yum-plugin-priorities yum-utils python-virtualenv git-hg"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a1a9d01_64a45807","line":197,"in_reply_to":"9a1a9d01_1b56322a","updated":"2015-09-30 09:22:30.000000000","message":"Ok, in my testing I\u0027ve always run this after the undercloud install, and at that point git exists.  As derek mentioned above, that may be a false assumption on how folks want to use it tho.","commit_id":"40e78189931a5d989747eb6c3d142f16cb0f2e73"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"864a936af000defab6ad90dbb7c94816fbf8be78","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    # FIXME(shardy) to run this as non-root you need to create the group and add the use"},{"line_number":203,"context_line":"    # but then we need to re-run the script as the newgrp drops us out of the script"},{"line_number":204,"context_line":"    #sudo groupadd docker || true"},{"line_number":205,"context_line":"    #sudo usermod -a -G docker $USER"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    sudo systemctl start docker"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a1a9d01_633a12e9","line":205,"updated":"2015-09-30 08:46:56.000000000","message":"I think you can remove this FIXME altogether, we can just document that the user should make sure there setup to use docker. Also delorean is soon moving to mock instead of docker so this will soon change.","commit_id":"40e78189931a5d989747eb6c3d142f16cb0f2e73"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"4377956723800bf0c77ea1f232530c32cfcf7c0c","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    # FIXME(shardy) to run this as non-root you need to create the group and add the use"},{"line_number":203,"context_line":"    # but then we need to re-run the script as the newgrp drops us out of the script"},{"line_number":204,"context_line":"    #sudo groupadd docker || true"},{"line_number":205,"context_line":"    #sudo usermod -a -G docker $USER"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    sudo systemctl start docker"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a1a9d01_e48f0873","line":205,"in_reply_to":"9a1a9d01_633a12e9","updated":"2015-09-30 09:22:30.000000000","message":"Ok, sounds good, I was following the delorean docs and trying to ensure all steps were automated.","commit_id":"40e78189931a5d989747eb6c3d142f16cb0f2e73"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"864a936af000defab6ad90dbb7c94816fbf8be78","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    sudo semanage fcontext -a -t svirt_sandbox_file_t \"$TRIPLEO_ROOT/delorean/scripts(/.)?\""},{"line_number":215,"context_line":"    sudo restorecon -R \"$TRIPLEO_ROOT/delorean\""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    sudo chown :$(id -g) /var/run/docker.sock"},{"line_number":218,"context_line":"    # Download a prebuilt build image instead of building on"},{"line_number":219,"context_line":"    # Image built as usual then exported using \"docker save delorean/centos \u003e centos-$date-$x.tar\""},{"line_number":220,"context_line":"    # FIXME(shardy) Handle pre-built and create_build_image.sh"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a1a9d01_de6171d4","line":217,"updated":"2015-09-30 08:46:56.000000000","message":"I was only doing this in CI as  workaround to groupadd/usermod, I\u0027m not sure its suitable for devs machines. Maybe as above maybe we should just document it.","commit_id":"40e78189931a5d989747eb6c3d142f16cb0f2e73"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"864a936af000defab6ad90dbb7c94816fbf8be78","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    # Download a prebuilt build image instead of building on"},{"line_number":219,"context_line":"    # Image built as usual then exported using \"docker save delorean/centos \u003e centos-$date-$x.tar\""},{"line_number":220,"context_line":"    # FIXME(shardy) Handle pre-built and create_build_image.sh"},{"line_number":221,"context_line":"    #curl http://${PYPIMIRROR}/buildimages/centos-20150921-1.tar | docker load"},{"line_number":222,"context_line":"    $TRIPLEO_ROOT/delorean/scripts/create_build_image.sh $TRIPLEO_OS_DISTRO"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    # We have a custom delorean that uses \"docker exec\" to reuse the same build"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a1a9d01_3e950d86","line":221,"updated":"2015-09-30 08:46:56.000000000","message":"You can remove the image download stuff, its not needed on dev machines, ci only does it as a speedup as its done for every CI job, devs will only be doing it as a once off per setup. And again delorean is moving to mock. I\u0027ll workaround this in CI as it should only be a temperary requirement.","commit_id":"40e78189931a5d989747eb6c3d142f16cb0f2e73"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"4377956723800bf0c77ea1f232530c32cfcf7c0c","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    # Download a prebuilt build image instead of building on"},{"line_number":219,"context_line":"    # Image built as usual then exported using \"docker save delorean/centos \u003e centos-$date-$x.tar\""},{"line_number":220,"context_line":"    # FIXME(shardy) Handle pre-built and create_build_image.sh"},{"line_number":221,"context_line":"    #curl http://${PYPIMIRROR}/buildimages/centos-20150921-1.tar | docker load"},{"line_number":222,"context_line":"    $TRIPLEO_ROOT/delorean/scripts/create_build_image.sh $TRIPLEO_OS_DISTRO"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    # We have a custom delorean that uses \"docker exec\" to reuse the same build"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a1a9d01_44dcb472","line":221,"in_reply_to":"9a1a9d01_3e950d86","updated":"2015-09-30 09:22:30.000000000","message":"Ok, I was thinking we perhaps needed to check a variable for a pre-built image instead of unconditionally running create_build_image every time?","commit_id":"40e78189931a5d989747eb6c3d142f16cb0f2e73"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"7f2a22ad9dda63181d3042bf8bb0564e5110b030","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    # Download a prebuilt build image instead of building on"},{"line_number":219,"context_line":"    # Image built as usual then exported using \"docker save delorean/centos \u003e centos-$date-$x.tar\""},{"line_number":220,"context_line":"    # FIXME(shardy) Handle pre-built and create_build_image.sh"},{"line_number":221,"context_line":"    #curl http://${PYPIMIRROR}/buildimages/centos-20150921-1.tar | docker load"},{"line_number":222,"context_line":"    $TRIPLEO_ROOT/delorean/scripts/create_build_image.sh $TRIPLEO_OS_DISTRO"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    # We have a custom delorean that uses \"docker exec\" to reuse the same build"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a1a9d01_f876c804","line":221,"in_reply_to":"9a1a9d01_44dcb472","updated":"2015-09-30 09:55:00.000000000","message":"Ya, that was what I was going to first suggest but given that docker is being removed from delorean I decided instead to just deal with the ci case in tripleo-ci, maybe to avoid confusion we can just add a simple variable like you suggest.","commit_id":"40e78189931a5d989747eb6c3d142f16cb0f2e73"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"864a936af000defab6ad90dbb7c94816fbf8be78","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    $TRIPLEO_ROOT/delorean/scripts/create_build_image.sh $TRIPLEO_OS_DISTRO"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    # We have a custom delorean that uses \"docker exec\" to reuse the same build"},{"line_number":225,"context_line":"    # container for each package, so we need to start the build container now"},{"line_number":226,"context_line":"    docker rm -f builder-centos || true"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    sed -i -e \"s%reponame\u003d.*%reponame\u003ddelorean-ci%\" projects.ini"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a1a9d01_3edc2d72","line":225,"updated":"2015-09-30 08:46:56.000000000","message":"Comment not needed (we\u0027re not starting a container here), I removed this from CI in a patch yesterday.","commit_id":"40e78189931a5d989747eb6c3d142f16cb0f2e73"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"864a936af000defab6ad90dbb7c94816fbf8be78","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    ./venv/bin/pip install -r requirements.txt"},{"line_number":237,"context_line":"    ./venv/bin/python setup.py install"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    log \"Delorean setup - DONE.\""},{"line_number":240,"context_line":"}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"function undercloud {"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a1a9d01_5e400107","line":239,"updated":"2015-09-30 08:46:56.000000000","message":"need popd ?","commit_id":"40e78189931a5d989747eb6c3d142f16cb0f2e73"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"4377956723800bf0c77ea1f232530c32cfcf7c0c","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    ./venv/bin/pip install -r requirements.txt"},{"line_number":237,"context_line":"    ./venv/bin/python setup.py install"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    log \"Delorean setup - DONE.\""},{"line_number":240,"context_line":"}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"function undercloud {"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a1a9d01_c43d2490","line":239,"in_reply_to":"9a1a9d01_5e400107","updated":"2015-09-30 09:22:30.000000000","message":"yup!","commit_id":"40e78189931a5d989747eb6c3d142f16cb0f2e73"}]}