)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"99c94bd20b8823493cad5188d529f1fbc12952d7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-06-21 10:15:43 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add node assignment workflows"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7c148f55b76caa1e6fba64af063de82f8064be65"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_9cefb186","line":8,"updated":"2016-06-23 06:47:50.000000000","message":"It would be good to describe this change more and link to any external discussion. Is this covered in the TripleO Mistral spec?","commit_id":"55f7d1e1ec650ad3e76bf3440746653692d5917c"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"96e341cc3b6ce19286d38a257ec6d232b1d61d72","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-06-21 10:15:43 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add node assignment workflows"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7c148f55b76caa1e6fba64af063de82f8064be65"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_09cde165","line":8,"in_reply_to":"3aaa91ec_9cefb186","updated":"2016-06-30 14:49:45.000000000","message":"I\u0027ll link to it in the next patchset.","commit_id":"55f7d1e1ec650ad3e76bf3440746653692d5917c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"573d87cf72ef8530a0198f5e2a792ab3501824f4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dougal Matthews \u003cdougal@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-15 18:55:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add node tagging workflow"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Co-Authored-By: Ana Krivokapic \u003cakrivoka@redhat.com\u003e"},{"line_number":10,"context_line":"Implements: blueprint assign-nodes-workflow"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a8ec9b2_89fd4570","line":7,"updated":"2016-09-16 17:18:16.000000000","message":"commit message is really bad, please improve next time so we understand what the code does.","commit_id":"411fbe5f6fd79c195d3c51d9be0e43ae980fb248"}],"tripleo_common/actions/baremetal.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d1a98392242de48fd32a2dd0a348151de4c88e8","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                baremetal_client"},{"line_number":87,"context_line":"            )"},{"line_number":88,"context_line":"        except Exception as err:"},{"line_number":89,"context_line":"            LOG.exception(\"Error updating node capability with ironic.\")"},{"line_number":90,"context_line":"            return mistral_workflow_utils.Result("},{"line_number":91,"context_line":"                \"\","},{"line_number":92,"context_line":"                err.message"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_f12e21f9","line":89,"updated":"2016-08-12 16:19:43.000000000","message":"s/with/in/","commit_id":"4b998181d40f65af2ee7bdda6a2022496a1dfbca"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"e8b41914ad27be622d420902127836de99991dd6","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                baremetal_client"},{"line_number":87,"context_line":"            )"},{"line_number":88,"context_line":"        except Exception as err:"},{"line_number":89,"context_line":"            LOG.exception(\"Error updating node capability with ironic.\")"},{"line_number":90,"context_line":"            return mistral_workflow_utils.Result("},{"line_number":91,"context_line":"                \"\","},{"line_number":92,"context_line":"                err.message"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_b64946d3","line":89,"in_reply_to":"9ad45d7e_f12e21f9","updated":"2016-08-15 04:27:03.000000000","message":"Done","commit_id":"4b998181d40f65af2ee7bdda6a2022496a1dfbca"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d1a98392242de48fd32a2dd0a348151de4c88e8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            LOG.exception(\"Error updating node capability with ironic.\")"},{"line_number":90,"context_line":"            return mistral_workflow_utils.Result("},{"line_number":91,"context_line":"                \"\","},{"line_number":92,"context_line":"                err.message"},{"line_number":93,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_51344d49","line":92,"updated":"2016-08-12 16:19:43.000000000","message":"s/err.message/str(err)/\n\nalso I\u0027d prefer the class name to be included, otherwise KeyError can become a nightmare ;) so\n\n \u0027%s: %s\u0027 % (type(err).__name__, err)","commit_id":"4b998181d40f65af2ee7bdda6a2022496a1dfbca"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"e8b41914ad27be622d420902127836de99991dd6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            LOG.exception(\"Error updating node capability with ironic.\")"},{"line_number":90,"context_line":"            return mistral_workflow_utils.Result("},{"line_number":91,"context_line":"                \"\","},{"line_number":92,"context_line":"                err.message"},{"line_number":93,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_9646cabd","line":92,"in_reply_to":"9ad45d7e_51344d49","updated":"2016-08-15 04:27:03.000000000","message":"Done","commit_id":"4b998181d40f65af2ee7bdda6a2022496a1dfbca"},{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"b5d9306775e68e5756d2bc4ae61d31a107e5bea5","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            LOG.exception(\"Error updating node capability in ironic.\")"},{"line_number":90,"context_line":"            return mistral_workflow_utils.Result("},{"line_number":91,"context_line":"                \"\","},{"line_number":92,"context_line":"                \"%s: %s\" % (type(err).__name__, err.message)"},{"line_number":93,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_5ec0ede0","line":92,"range":{"start_line":92,"start_character":52,"end_line":92,"end_character":59},"updated":"2016-09-09 10:56:05.000000000","message":"In python3 the Exception class has no message attribute.  You can get the message for both 2 and 3 by using str(err).","commit_id":"2b779e1dcc63983bd68de9db4e739dae95e05dbf"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"dae2059376c144c7eb5a6b3dabc3cc68c9afd7bb","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            LOG.exception(\"Error updating node capability in ironic.\")"},{"line_number":90,"context_line":"            return mistral_workflow_utils.Result("},{"line_number":91,"context_line":"                \"\","},{"line_number":92,"context_line":"                \"%s: %s\" % (type(err).__name__, err.message)"},{"line_number":93,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_c4f8b0c7","line":92,"range":{"start_line":92,"start_character":52,"end_line":92,"end_character":59},"in_reply_to":"9a89bdaa_5ec0ede0","updated":"2016-09-12 12:36:11.000000000","message":"Done","commit_id":"2b779e1dcc63983bd68de9db4e739dae95e05dbf"}],"tripleo_common/actions/base.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"7734878c507b57f0ef3e722bd8317d6033e07388","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from mistral import context"},{"line_number":21,"context_line":"from mistral.utils.openstack import keystone as keystone_utils"},{"line_number":22,"context_line":"from mistralclient.api import client as mistral_client"},{"line_number":23,"context_line":"from novaclient.client import Client as nova_client"},{"line_number":24,"context_line":"from swiftclient import client as swift_client"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8ec9b2_aeb415d1","line":23,"updated":"2016-09-15 12:49:24.000000000","message":"We need python-novaclient in the requirements.txt","commit_id":"a9e27cde849089f6d51c0954ba84f89a21131c86"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"ecec619aca3d6ceb077160b5cf6576ffee9efa66","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from mistral import context"},{"line_number":21,"context_line":"from mistral.utils.openstack import keystone as keystone_utils"},{"line_number":22,"context_line":"from mistralclient.api import client as mistral_client"},{"line_number":23,"context_line":"from novaclient.client import Client as nova_client"},{"line_number":24,"context_line":"from swiftclient import client as swift_client"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8ec9b2_1178cc29","line":23,"in_reply_to":"7a8ec9b2_aeb415d1","updated":"2016-09-15 12:59:46.000000000","message":"Done","commit_id":"a9e27cde849089f6d51c0954ba84f89a21131c86"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"7734878c507b57f0ef3e722bd8317d6033e07388","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        return mc"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def _get_scheduler_client(self):"},{"line_number":115,"context_line":"        ctx \u003d context.ctx()"},{"line_number":116,"context_line":"        keystone_endpoint \u003d keystone_utils.get_endpoint_for_project(\u0027keystone\u0027)"},{"line_number":117,"context_line":"        nova_endpoint \u003d keystone_utils.get_endpoint_for_project(\u0027nova\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8ec9b2_ce6ec12e","line":114,"updated":"2016-09-15 12:49:24.000000000","message":"I always thought it was \"compute\"? I feel like we should just use the project names here, but I can see this is consistent with the above.","commit_id":"a9e27cde849089f6d51c0954ba84f89a21131c86"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"ecec619aca3d6ceb077160b5cf6576ffee9efa66","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        return mc"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def _get_scheduler_client(self):"},{"line_number":115,"context_line":"        ctx \u003d context.ctx()"},{"line_number":116,"context_line":"        keystone_endpoint \u003d keystone_utils.get_endpoint_for_project(\u0027keystone\u0027)"},{"line_number":117,"context_line":"        nova_endpoint \u003d keystone_utils.get_endpoint_for_project(\u0027nova\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8ec9b2_51909443","line":114,"in_reply_to":"7a8ec9b2_ce6ec12e","updated":"2016-09-15 12:59:46.000000000","message":"Done","commit_id":"a9e27cde849089f6d51c0954ba84f89a21131c86"}],"tripleo_common/utils/nodes.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d1a98392242de48fd32a2dd0a348151de4c88e8","unresolved":false,"context_lines":[{"line_number":553,"context_line":""},{"line_number":554,"context_line":"def _get_capability_patch(node, capability, value):"},{"line_number":555,"context_line":"    \"\"\"Return a JSON patch updating a node capability\"\"\""},{"line_number":556,"context_line":"    capabilities \u003d node.properties[\u0027capabilities\u0027]"},{"line_number":557,"context_line":"    capabilities_dict \u003d capabilities_to_dict(capabilities)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    capabilities_dict[capability] \u003d value"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_112ad5e7","line":556,"updated":"2016-08-12 16:19:43.000000000","message":"node.properties.get(\u0027capabilities\u0027) as it\u0027s not a mandatory property","commit_id":"4b998181d40f65af2ee7bdda6a2022496a1dfbca"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"e8b41914ad27be622d420902127836de99991dd6","unresolved":false,"context_lines":[{"line_number":553,"context_line":""},{"line_number":554,"context_line":"def _get_capability_patch(node, capability, value):"},{"line_number":555,"context_line":"    \"\"\"Return a JSON patch updating a node capability\"\"\""},{"line_number":556,"context_line":"    capabilities \u003d node.properties[\u0027capabilities\u0027]"},{"line_number":557,"context_line":"    capabilities_dict \u003d capabilities_to_dict(capabilities)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    capabilities_dict[capability] \u003d value"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_f611feb0","line":556,"in_reply_to":"9ad45d7e_112ad5e7","updated":"2016-08-15 04:27:03.000000000","message":"Done","commit_id":"4b998181d40f65af2ee7bdda6a2022496a1dfbca"}],"tripleo_common/utils/parameters.py":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"d79749b7e547583848d09a27412118c1d6b22cde","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    return count"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def get_flavor(role):"},{"line_number":55,"context_line":"    return \u0027baremetal\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_36018caf","line":54,"updated":"2016-09-14 09:59:12.000000000","message":"This one should find a flavor which has extra_specs: \"capabilities:profile\" equal to role. If there is no such flavor, return \u0027baremetal\u0027","commit_id":"389a240f360773d0a0266c3e07e6ae2ba64dac8b"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"282c917f78aa2fe768f787fc67b54a182a95e786","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    return count"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def get_flavor(role):"},{"line_number":55,"context_line":"    return \u0027baremetal\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_2b055abb","line":54,"in_reply_to":"7a8ec9b2_36018caf","updated":"2016-09-15 11:37:56.000000000","message":"Done","commit_id":"389a240f360773d0a0266c3e07e6ae2ba64dac8b"}],"workbooks/baremetal.yaml":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"2ca16fc937d144566e4b8b45a5bbf93b154623e3","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                execution: \u003c% execution() %\u003e"},{"line_number":272,"context_line":"                introspected_nodes: \u003c% $.get(\u0027introspected_nodes\u0027, []) %\u003e"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"  # assign_node workflow:"},{"line_number":275,"context_line":"  #"},{"line_number":276,"context_line":"  # Given a node_id and a role_name (compute, swift-storage, etc),"},{"line_number":277,"context_line":"  # 1.  Retrieve the node\u0027s details using ironic"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1aa78d24_12f15701","line":274,"updated":"2016-07-13 15:21:48.000000000","message":"Please move this comment into a \"description\" property. You can see an example here: http://docs.openstack.org/developer/mistral/dsl/dsl_v2.html#workflows (multi line YAML strings are allows)","commit_id":"55f7d1e1ec650ad3e76bf3440746653692d5917c"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"089fd50855dbc1d0a5e3aab73fca8d30aaa1f847","unresolved":false,"context_lines":[{"line_number":279,"context_line":"  # 3.  Update the node with the new capabilities"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"  assign_node:"},{"line_number":282,"context_line":"    type: direct"},{"line_number":283,"context_line":"    input:"},{"line_number":284,"context_line":"      - node_id"},{"line_number":285,"context_line":"      - role_name"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_bae1f89c","line":282,"updated":"2016-07-19 07:49:46.000000000","message":"Remove \"type: direct\" as it is the default.\n\nRef: Id0c5957abec7a6ed42d3c56d52471d5bb10651b8","commit_id":"55f7d1e1ec650ad3e76bf3440746653692d5917c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d982c796fd0581baa996b298ac06e85e5632ec1e","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"      get_node_patch:"},{"line_number":300,"context_line":"        on-success: update_node"},{"line_number":301,"context_line":"        action: tripleo.create_node_role_patch node\u003d\u003c% $.node %\u003e role\u003d\u003c% $.role_name %\u003e"},{"line_number":302,"context_line":"        publish:"},{"line_number":303,"context_line":"          patch: \u003c% task(get_node_patch).result %\u003e"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_a8e98482","line":301,"range":{"start_line":301,"start_character":16,"end_line":301,"end_character":87},"updated":"2016-06-23 09:22:09.000000000","message":"First, I don\u0027t see point in separating patch creation and updating. Do you see any use cases for creating a patch other than piping it into node_update?\n\nSecond, I would like it to become slightly more generic for easier reuse in other workflows. So to sum it up:\n\n tripleo.node_update_capabilitity node_id\u003d\u003c% $.node_id %\u003e capability\u003d\"profile\" value\u003d\u003c% $.role_name %\u003e","commit_id":"55f7d1e1ec650ad3e76bf3440746653692d5917c"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"96e341cc3b6ce19286d38a257ec6d232b1d61d72","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"      get_node_patch:"},{"line_number":300,"context_line":"        on-success: update_node"},{"line_number":301,"context_line":"        action: tripleo.create_node_role_patch node\u003d\u003c% $.node %\u003e role\u003d\u003c% $.role_name %\u003e"},{"line_number":302,"context_line":"        publish:"},{"line_number":303,"context_line":"          patch: \u003c% task(get_node_patch).result %\u003e"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_e9797530","line":301,"range":{"start_line":301,"start_character":16,"end_line":301,"end_character":87},"in_reply_to":"3aaa91ec_a8e98482","updated":"2016-06-30 14:49:45.000000000","message":"Is there a way to call an action inside another action?  The get_node_patch task is here to generate a properly formatted JSON patch.  No, it doesn\u0027t have to be a task --- I thought it was necessary.\n\nI agree with the second point.","commit_id":"55f7d1e1ec650ad3e76bf3440746653692d5917c"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"089fd50855dbc1d0a5e3aab73fca8d30aaa1f847","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"  # Runs the assign_node workflow in a loop"},{"line_number":325,"context_line":"  assign_nodes:"},{"line_number":326,"context_line":"    type: direct"},{"line_number":327,"context_line":"    input:"},{"line_number":328,"context_line":"      - node_ids"},{"line_number":329,"context_line":"      - role_name"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_1aef6488","line":326,"updated":"2016-07-19 07:49:46.000000000","message":"ditto","commit_id":"55f7d1e1ec650ad3e76bf3440746653692d5917c"},{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"b5d9306775e68e5756d2bc4ae61d31a107e5bea5","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                introspected_nodes: \u003c% $.get(\u0027introspected_nodes\u0027, []) %\u003e"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"  tag_node:"},{"line_number":270,"context_line":"    type: direct"},{"line_number":271,"context_line":"    description: Tag a node with a role"},{"line_number":272,"context_line":"    input:"},{"line_number":273,"context_line":"      - node_id"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a89bdaa_3e49698f","line":270,"range":{"start_line":270,"start_character":10,"end_line":270,"end_character":16},"updated":"2016-09-09 10:56:05.000000000","message":"direct is the default.  it\u0027s being removed in the workflows previously merged.  https://review.openstack.org/#/c/341617/","commit_id":"2b779e1dcc63983bd68de9db4e739dae95e05dbf"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"dae2059376c144c7eb5a6b3dabc3cc68c9afd7bb","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                introspected_nodes: \u003c% $.get(\u0027introspected_nodes\u0027, []) %\u003e"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"  tag_node:"},{"line_number":270,"context_line":"    type: direct"},{"line_number":271,"context_line":"    description: Tag a node with a role"},{"line_number":272,"context_line":"    input:"},{"line_number":273,"context_line":"      - node_id"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a89bdaa_64d7e423","line":270,"range":{"start_line":270,"start_character":10,"end_line":270,"end_character":16},"in_reply_to":"9a89bdaa_3e49698f","updated":"2016-09-12 12:36:11.000000000","message":"Done","commit_id":"2b779e1dcc63983bd68de9db4e739dae95e05dbf"},{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"a772c8aea3b8020cb3e975b7e2c2cf8a2752c821","unresolved":false,"context_lines":[{"line_number":293,"context_line":"          messages:"},{"line_number":294,"context_line":"            body:"},{"line_number":295,"context_line":"              type: tripleo.baremetal.v1.tag_node"},{"line_number":296,"context_line":"              execution_id: \u003c% execution().id %\u003e"},{"line_number":297,"context_line":"              payload:"},{"line_number":298,"context_line":"                status: \u003c% $.get(\u0027status\u0027, \u0027FAILED\u0027) %\u003e"},{"line_number":299,"context_line":"                message: \u003c% $.get(\u0027message\u0027, \u0027\u0027) %\u003e"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a89bdaa_fd188c77","line":296,"range":{"start_line":296,"start_character":14,"end_line":296,"end_character":26},"updated":"2016-09-12 13:43:35.000000000","message":"Is there a reason why execution_id is included here?  This isn\u0027t used in any of the other baremetal workflows and the value should be in \u003c% execution() %\u003e.","commit_id":"2b779e1dcc63983bd68de9db4e739dae95e05dbf"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"b6aaf0cb0e62692ef4f4a797613c850582b6a69d","unresolved":false,"context_lines":[{"line_number":293,"context_line":"          messages:"},{"line_number":294,"context_line":"            body:"},{"line_number":295,"context_line":"              type: tripleo.baremetal.v1.tag_node"},{"line_number":296,"context_line":"              execution_id: \u003c% execution().id %\u003e"},{"line_number":297,"context_line":"              payload:"},{"line_number":298,"context_line":"                status: \u003c% $.get(\u0027status\u0027, \u0027FAILED\u0027) %\u003e"},{"line_number":299,"context_line":"                message: \u003c% $.get(\u0027message\u0027, \u0027\u0027) %\u003e"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a89bdaa_9c03c60f","line":296,"range":{"start_line":296,"start_character":14,"end_line":296,"end_character":26},"in_reply_to":"9a89bdaa_86c29983","updated":"2016-09-13 12:31:25.000000000","message":"Done","commit_id":"2b779e1dcc63983bd68de9db4e739dae95e05dbf"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"e2f523bf63f34dbad0c0a432ff82dd0dee1044e1","unresolved":false,"context_lines":[{"line_number":293,"context_line":"          messages:"},{"line_number":294,"context_line":"            body:"},{"line_number":295,"context_line":"              type: tripleo.baremetal.v1.tag_node"},{"line_number":296,"context_line":"              execution_id: \u003c% execution().id %\u003e"},{"line_number":297,"context_line":"              payload:"},{"line_number":298,"context_line":"                status: \u003c% $.get(\u0027status\u0027, \u0027FAILED\u0027) %\u003e"},{"line_number":299,"context_line":"                message: \u003c% $.get(\u0027message\u0027, \u0027\u0027) %\u003e"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a89bdaa_86c29983","line":296,"range":{"start_line":296,"start_character":14,"end_line":296,"end_character":26},"in_reply_to":"9a89bdaa_fd188c77","updated":"2016-09-13 11:53:46.000000000","message":"This patch was first proposed in June so I suspect that this is a case of things changing around us.  This should be updated to be consistent with the rest of the file.  Good catch.","commit_id":"2b779e1dcc63983bd68de9db4e739dae95e05dbf"},{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"b5d9306775e68e5756d2bc4ae61d31a107e5bea5","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                execution: \u003c% execution() %\u003e"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"  tag_nodes:"},{"line_number":303,"context_line":"    type: direct"},{"line_number":304,"context_line":"    description: Runs the tag_node workflow in a loop"},{"line_number":305,"context_line":"    input:"},{"line_number":306,"context_line":"      - node_ids"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a89bdaa_81085a2a","line":303,"range":{"start_line":303,"start_character":10,"end_line":303,"end_character":16},"updated":"2016-09-09 10:56:05.000000000","message":"see above","commit_id":"2b779e1dcc63983bd68de9db4e739dae95e05dbf"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"dae2059376c144c7eb5a6b3dabc3cc68c9afd7bb","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                execution: \u003c% execution() %\u003e"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"  tag_nodes:"},{"line_number":303,"context_line":"    type: direct"},{"line_number":304,"context_line":"    description: Runs the tag_node workflow in a loop"},{"line_number":305,"context_line":"    input:"},{"line_number":306,"context_line":"      - node_ids"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a89bdaa_04f1b8cd","line":303,"range":{"start_line":303,"start_character":10,"end_line":303,"end_character":16},"in_reply_to":"9a89bdaa_81085a2a","updated":"2016-09-12 12:36:11.000000000","message":"Done","commit_id":"2b779e1dcc63983bd68de9db4e739dae95e05dbf"},{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"d79749b7e547583848d09a27412118c1d6b22cde","unresolved":false,"context_lines":[{"line_number":413,"context_line":"                execution: \u003c% execution() %\u003e"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"  tag_nodes:"},{"line_number":417,"context_line":"    description: Runs the tag_node workflow in a loop"},{"line_number":418,"context_line":"    input:"},{"line_number":419,"context_line":"      - node_ids"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7a8ec9b2_111e5a63","line":416,"updated":"2016-09-14 09:59:12.000000000","message":"It would be beneficial if this task sent a message when finished, so client can can find out that tagging has finished","commit_id":"389a240f360773d0a0266c3e07e6ae2ba64dac8b"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"282c917f78aa2fe768f787fc67b54a182a95e786","unresolved":false,"context_lines":[{"line_number":413,"context_line":"                execution: \u003c% execution() %\u003e"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"  tag_nodes:"},{"line_number":417,"context_line":"    description: Runs the tag_node workflow in a loop"},{"line_number":418,"context_line":"    input:"},{"line_number":419,"context_line":"      - node_ids"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7a8ec9b2_8b302ea0","line":416,"in_reply_to":"7a8ec9b2_111e5a63","updated":"2016-09-15 11:37:56.000000000","message":"Done","commit_id":"389a240f360773d0a0266c3e07e6ae2ba64dac8b"}]}
