)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"e024ce75851f1bb4035d5b661d7b30f62e777778","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port Scale Down Functionality into Workflow"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch removes the ScaleDownManager and ports the logic that"},{"line_number":10,"context_line":"was contained there into a action and an associated workflow to"},{"line_number":11,"context_line":"expose it."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a95cdbc_c42cfd4c","line":9,"updated":"2016-10-06 06:56:12.000000000","message":"I\u0027m not sure if we can just delete this - if we do, we need to be very careful about landing a CLI patch at the same time. It might be safest to just leave the old file in place and delete it once the CLI has been migrated over. This patch would be broken in CI, but CI doesn\u0027t test this stuff.","commit_id":"cd409d420cbbe9387d5ecfe61cd7e1d66cb35f7e"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"d2ea78979ee4c8bdccfa0cf5b58aea77ad4b4b87","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port Scale Down Functionality into Workflow"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch removes the ScaleDownManager and ports the logic that"},{"line_number":10,"context_line":"was contained there into a action and an associated workflow to"},{"line_number":11,"context_line":"expose it."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_12050e13","line":9,"updated":"2016-10-13 15:49:12.000000000","message":"This isn\u0027t still true, is it?","commit_id":"5583c14f3e28257bd5931bcc84eea85ee7f01b08"}],"tripleo_common/actions/scale.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"ac86df0641750c5ca8e70363f86402ffea776f9a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    with any templates or environment files as needed."},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def __init__(self, timeout, nodes\u003d[],"},{"line_number":60,"context_line":"                 container\u003dconstants.DEFAULT_CONTAINER_NAME):"},{"line_number":61,"context_line":"        self.nodes \u003d nodes"},{"line_number":62,"context_line":"        self.timeout_mins \u003d timeout"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_8e947943","line":59,"updated":"2016-10-14 08:49:46.000000000","message":"as per the comment below, we need to pass in the stack name to this action.","commit_id":"0893b6c6ab984db06308e27b61ebf44b9653f3c9"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"be887d513499a3d66bfc0854e5f4d1bbdb2b56a6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        fields[\u0027parameters\u0027] \u003d parameters"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        LOG.debug(\u0027stack update params: %s\u0027, fields)"},{"line_number":93,"context_line":"        self._get_orchestration_client().stacks.update(**fields)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _get_removal_params_from_heat(self, resources_by_role, resources):"},{"line_number":96,"context_line":"        stack_params \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_ee96d5ee","line":93,"updated":"2016-10-14 08:55:46.000000000","message":"I patched my version and hard-coded the stack name. So I had:\n\nself._get_orchestration_client().stacks.update(\u0027overcloud\u0027, **fields)\n\nIt appeared to finish without an error, but I am not sure it done anything? I did just pick a node at random to delete, so maybe I done something wrong. I can still see all the baremetal nodes running.","commit_id":"0893b6c6ab984db06308e27b61ebf44b9653f3c9"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"ac86df0641750c5ca8e70363f86402ffea776f9a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        fields[\u0027parameters\u0027] \u003d parameters"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        LOG.debug(\u0027stack update params: %s\u0027, fields)"},{"line_number":93,"context_line":"        self._get_orchestration_client().stacks.update(**fields)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _get_removal_params_from_heat(self, resources_by_role, resources):"},{"line_number":96,"context_line":"        stack_params \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_0ea8698c","line":93,"updated":"2016-10-14 08:49:46.000000000","message":"This should be .update(stack_name, **fields)\n\nExample: https://github.com/openstack/tripleo-common/blob/master/tripleo_common/actions/deployment.py#L181","commit_id":"0893b6c6ab984db06308e27b61ebf44b9653f3c9"}],"tripleo_common/tests/actions/test_scale.py":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"630d1774782f6c06bce3649e293816ed22b1f594","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a95cdbc_b0d99024","updated":"2016-10-07 19:50:08.000000000","message":"This could probably use a few more tests (like skipping resources with status DELETE),  but I think that\u0027s out of scope in this context.","commit_id":"5583c14f3e28257bd5931bcc84eea85ee7f01b08"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"630d1774782f6c06bce3649e293816ed22b1f594","unresolved":false,"context_lines":[{"line_number":25,"context_line":"def mock_stack():"},{"line_number":26,"context_line":"    stack \u003d mock.Mock()"},{"line_number":27,"context_line":"    stack.name \u003d \u0027My Stack\u0027"},{"line_number":28,"context_line":"    stack.parameters \u003d {\u0027ComputeCount\u0027: \u00272\u0027}"},{"line_number":29,"context_line":"    stack.to_dict.return_value \u003d {"},{"line_number":30,"context_line":"        \u0027uuid\u0027: 5,"},{"line_number":31,"context_line":"        \u0027name\u0027: \u0027My Stack\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_30a90091","line":28,"updated":"2016-10-07 19:50:08.000000000","message":"I wasn\u0027t sure what this was here for, but perhaps it is to make sure that it isn\u0027t used instead of the actual node count.","commit_id":"5583c14f3e28257bd5931bcc84eea85ee7f01b08"}]}