)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c33d5504cd6a776293306ca0d3852eca827b76a9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"accepts a string."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"However fixing it may break command strings that happened to work previously."},{"line_number":19,"context_line":"So this change deprecates bootstrap_host_exec, replacing it with"},{"line_number":20,"context_line":"bootstrap_host_only_eval and bootstrap_host_only_exec."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I993c3354a3d9fd392fa4fa2e3b5b8ed421487a88"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f515b1d_7d26d817","line":19,"range":{"start_line":19,"start_character":15,"end_line":19,"end_character":25},"updated":"2017-09-27 08:31:16.000000000","message":":( for it being so involved.... having two functions like this isn\u0027t great but I cant think of an alternative \n(ideally we would detect if eval $* would \u0027do the right thing\u0027 and otherwise use exec but not sure how the detection would work without executing the actual args :) )\n\n will you update this for the deprecation? (Possibly add a comment and output a message in bootstrap_host_exec? add a release note?)\n\nwe\u0027d need a followup in tripleo-heat-templates to replace all the existing calls, but that can come later for sure :)","commit_id":"69265fcebbf145f7bf85d85b0d2eca3805add1d8"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"12fcec13da7ecbd19efec0f99b5299ca5e61901c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"accepts a string."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"However fixing it may break command strings that happened to work previously."},{"line_number":19,"context_line":"So this change deprecates bootstrap_host_exec, replacing it with"},{"line_number":20,"context_line":"bootstrap_host_only_eval and bootstrap_host_only_exec."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I993c3354a3d9fd392fa4fa2e3b5b8ed421487a88"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f515b1d_73ce0783","line":19,"range":{"start_line":19,"start_character":15,"end_line":19,"end_character":25},"in_reply_to":"7f515b1d_7d26d817","updated":"2017-09-27 09:42:33.000000000","message":"Discussed on IRC:\n\u003cowalsh\u003e marios: eval should be killed with fire IMO, it\u0027s just happens to work when the quoting in the command line is also wrong\n\u003cmarios\u003e owalsh: hah but sounds like there are some cases we still need it (or at least until we can change those invocations?)\n\u003cmarios\u003e owalsh: hence your latest revision with the two functions\n\u003cowalsh\u003e marios: yea, once it lands I\u0027ll follow up with a t-h-t patch to use exec everywhere on master/pike\n\u003cowalsh\u003e marios: then remove the deprecated command from master, probably the eval command too\n\u003cowalsh\u003e marios: still think this needs a reno, comment etc..? I doubt it\u0027s of interest to end users\n\u003cmarios\u003e owalsh: ok fair enough. yeah it isn\u0027t a \u0027proper\u0027 interface I guess, we are exclusively using/invoking in the tripleo-heat-templates (I think?) so no strong push on the release note then, especially since it will be highlighted further (that you are going to eventually remove that function alltogether) in the subesquent changes to tripleo-heat-templates","commit_id":"69265fcebbf145f7bf85d85b0d2eca3805add1d8"}],"scripts/bootstrap_host_exec":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7ff3af44a0431f2d4606674695d4ec570a73a145","unresolved":false,"context_lines":[{"line_number":13,"context_line":"HOSTNAME\u003d$(/bin/hostname -s)"},{"line_number":14,"context_line":"SERVICE_NODEID\u003d$(/bin/hiera -c /etc/puppet/hiera.yaml \"${SERVICE_NAME}_short_bootstrap_node_name\")"},{"line_number":15,"context_line":"if [[ \"$HOSTNAME\" \u003d\u003d \"$SERVICE_NODEID\" ]]; then"},{"line_number":16,"context_line":"  exec \"$@\""},{"line_number":17,"context_line":"else"},{"line_number":18,"context_line":"  echo \"Skipping execution since this is not the bootstrap node for this service.\""},{"line_number":19,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f515b1d_aee80916","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":6},"updated":"2017-09-22 11:11:29.000000000","message":"is this OK though (i guess still testing?)... I tried finding out more and most I got was that exec will fork a new process but eval will not. Is that OK, i.e. does anything after that then get executed (granted not much below this line) but still?","commit_id":"981c8afaf2fae9a56e68e1025fedbf794da5ff39"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"313a23a587f7c1c72cefb8e2f3ee5195619373ff","unresolved":false,"context_lines":[{"line_number":13,"context_line":"HOSTNAME\u003d$(/bin/hostname -s)"},{"line_number":14,"context_line":"SERVICE_NODEID\u003d$(/bin/hiera -c /etc/puppet/hiera.yaml \"${SERVICE_NAME}_short_bootstrap_node_name\")"},{"line_number":15,"context_line":"if [[ \"$HOSTNAME\" \u003d\u003d \"$SERVICE_NODEID\" ]]; then"},{"line_number":16,"context_line":"  exec \"$@\""},{"line_number":17,"context_line":"else"},{"line_number":18,"context_line":"  echo \"Skipping execution since this is not the bootstrap node for this service.\""},{"line_number":19,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f515b1d_2ecbf953","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":6},"in_reply_to":"7f515b1d_8ea54db8","updated":"2017-09-22 11:29:44.000000000","message":"The bash exec is just a thin wrapper around the libc exec https://linux.die.net/man/3/exec\n\nForking is different, that duplicates the current process: https://linux.die.net/man/2/fork.\n\nOften an exec is run immediately after forking e.g if you run a command in a shell then the shell will fork then exec the command.","commit_id":"981c8afaf2fae9a56e68e1025fedbf794da5ff39"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f003c9afb899f0357e71ea3466e8ae4ad27f4afc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"HOSTNAME\u003d$(/bin/hostname -s)"},{"line_number":14,"context_line":"SERVICE_NODEID\u003d$(/bin/hiera -c /etc/puppet/hiera.yaml \"${SERVICE_NAME}_short_bootstrap_node_name\")"},{"line_number":15,"context_line":"if [[ \"$HOSTNAME\" \u003d\u003d \"$SERVICE_NODEID\" ]]; then"},{"line_number":16,"context_line":"  exec \"$@\""},{"line_number":17,"context_line":"else"},{"line_number":18,"context_line":"  echo \"Skipping execution since this is not the bootstrap node for this service.\""},{"line_number":19,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f515b1d_8ea54db8","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":6},"in_reply_to":"7f515b1d_aee80916","updated":"2017-09-22 11:22:57.000000000","message":"Not still testing.\n\nexec doesn\u0027t fork, it replaces the current process. This is fine as the eval is the final command run.","commit_id":"981c8afaf2fae9a56e68e1025fedbf794da5ff39"}]}
