)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"32008c8d82d22c8f5cedee1c2f71b1ef0e65afb5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Before moving overcloudrc generation from tripleoclient to a Mistral"},{"line_number":14,"context_line":"action OS_TENANT_NAME was being used instead of OS_PROJECT_NAME."},{"line_number":15,"context_line":"So, adding back OS_TENANT_NAME in overcloudrc."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1]:https://github.com/openstack/python-glanceclient/blob/stable/newton/glanceclient/shell.py#L388"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id2226eb2bd9ad5c24cc87f0cf6c61324018ceeac"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_702d6b93","line":16,"updated":"2017-10-03 07:41:38.000000000","message":"Please can we raise a bug, which can be targetted to Newton, and add Closes-Bug: #nnnn","commit_id":"c18503aa479e67779305684c337e8da2cb7308f8"}],"tripleo_common/utils/overcloudrc.py":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"32008c8d82d22c8f5cedee1c2f71b1ef0e65afb5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \u0027NOVA_VERSION\u0027: \u00271.1\u0027,"},{"line_number":81,"context_line":"        \u0027COMPUTE_API_VERSION\u0027: \u00271.1\u0027,"},{"line_number":82,"context_line":"        \u0027OS_USERNAME\u0027: \u0027admin\u0027,"},{"line_number":83,"context_line":"        \u0027OS_TENANT_NAME\u0027: \u0027admin\u0027,"},{"line_number":84,"context_line":"        \u0027OS_NO_CACHE\u0027: \u0027True\u0027,"},{"line_number":85,"context_line":"        \u0027OS_CLOUDNAME\u0027: stack.stack_name,"},{"line_number":86,"context_line":"        \u0027no_proxy\u0027: \u0027,\u0027.join(no_proxy_list),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_b015233f","line":83,"updated":"2017-10-03 07:41:38.000000000","message":"https://github.com/openstack/python-glanceclient/blob/stable/newton/glanceclient/shell.py#L378\n\nAre we fixing the right thing here - e.g should we really be adding OS_PROJECT_DOMAIN_NAME","commit_id":"c18503aa479e67779305684c337e8da2cb7308f8"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"ad65de30f21d5b7f8b997bd9d73466560596859d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \u0027NOVA_VERSION\u0027: \u00271.1\u0027,"},{"line_number":81,"context_line":"        \u0027COMPUTE_API_VERSION\u0027: \u00271.1\u0027,"},{"line_number":82,"context_line":"        \u0027OS_USERNAME\u0027: \u0027admin\u0027,"},{"line_number":83,"context_line":"        \u0027OS_TENANT_NAME\u0027: \u0027admin\u0027,"},{"line_number":84,"context_line":"        \u0027OS_NO_CACHE\u0027: \u0027True\u0027,"},{"line_number":85,"context_line":"        \u0027OS_CLOUDNAME\u0027: stack.stack_name,"},{"line_number":86,"context_line":"        \u0027no_proxy\u0027: \u0027,\u0027.join(no_proxy_list),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_d0f1bf96","line":83,"in_reply_to":"7f515b1d_90eb4711","updated":"2017-10-03 08:10:25.000000000","message":"Yeah it seems like either adding the domain (if that works) or adding OS_TENANT_NAME as well as OS_PROJECT_NAME would be less risky?\n\nIt seems https://review.openstack.org/#/c/410255/ is the reason this is needed, but given that landed 10 months ago, I\u0027m a little wary of just removing OS_PROJECT_NAME in case it breaks some other client","commit_id":"c18503aa479e67779305684c337e8da2cb7308f8"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"ab34b70242be69921466dc79920b7af76b175f0e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \u0027NOVA_VERSION\u0027: \u00271.1\u0027,"},{"line_number":81,"context_line":"        \u0027COMPUTE_API_VERSION\u0027: \u00271.1\u0027,"},{"line_number":82,"context_line":"        \u0027OS_USERNAME\u0027: \u0027admin\u0027,"},{"line_number":83,"context_line":"        \u0027OS_TENANT_NAME\u0027: \u0027admin\u0027,"},{"line_number":84,"context_line":"        \u0027OS_NO_CACHE\u0027: \u0027True\u0027,"},{"line_number":85,"context_line":"        \u0027OS_CLOUDNAME\u0027: stack.stack_name,"},{"line_number":86,"context_line":"        \u0027no_proxy\u0027: \u0027,\u0027.join(no_proxy_list),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_90eb4711","line":83,"in_reply_to":"7f515b1d_b015233f","updated":"2017-10-03 07:48:39.000000000","message":"well, this is for stable/newton. probably OS_TENANT_NAME and OS_PROJECT_NAME could co-exist. As IIRC, in newton mistral didn\u0027t have support for OS_PROJECT_NAME (or at least it ignored domains).\n\nAnd I agree with shardy, maybe we should add the domain here.","commit_id":"c18503aa479e67779305684c337e8da2cb7308f8"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"2aaff7bf1f9b0a2f53b6f775302d5789aa0f8190","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \u0027NOVA_VERSION\u0027: \u00271.1\u0027,"},{"line_number":81,"context_line":"        \u0027COMPUTE_API_VERSION\u0027: \u00271.1\u0027,"},{"line_number":82,"context_line":"        \u0027OS_USERNAME\u0027: \u0027admin\u0027,"},{"line_number":83,"context_line":"        \u0027OS_TENANT_NAME\u0027: \u0027admin\u0027,"},{"line_number":84,"context_line":"        \u0027OS_NO_CACHE\u0027: \u0027True\u0027,"},{"line_number":85,"context_line":"        \u0027OS_CLOUDNAME\u0027: stack.stack_name,"},{"line_number":86,"context_line":"        \u0027no_proxy\u0027: \u0027,\u0027.join(no_proxy_list),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_107997c6","line":83,"in_reply_to":"7f515b1d_d0f1bf96","updated":"2017-10-03 08:24:40.000000000","message":"Agree with adding both if we can do that. I\u0027m also wary about this late change.","commit_id":"c18503aa479e67779305684c337e8da2cb7308f8"}]}