)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"c26f8d6039b74a9ede181d31868d3284ffa8830d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"sorting on tags and this no longer works. Instead sort on the"},{"line_number":15,"context_line":"step number given in the \u0027when:\u0027 value."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related-Bug: #TODO(marios) file LP i am aware of some BZ"},{"line_number":18,"context_line":"Depends-On: I6adc5619a28099f4e241351b63377f1e96933810"},{"line_number":19,"context_line":"Change-Id: I68c032c5f23393a77109f182541cc6bfcc019a41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f96bb07_09ab1189","line":17,"updated":"2018-01-23 15:55:45.000000000","message":"actually this needs to be sorted out before merging","commit_id":"b37606341c0e48e5f4a84429b1573acccf649e98"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8fe9c961a369586f76ebfabe48534baf6ba6074e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"sorting on tags and this no longer works. Instead sort on the"},{"line_number":15,"context_line":"step number given in the \u0027when:\u0027 value."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related-Bug: #TODO(marios) file LP i am aware of some BZ"},{"line_number":18,"context_line":"Depends-On: I6adc5619a28099f4e241351b63377f1e96933810"},{"line_number":19,"context_line":"Change-Id: I68c032c5f23393a77109f182541cc6bfcc019a41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f96bb07_efaca536","line":17,"in_reply_to":"7f96bb07_09ab1189","updated":"2018-01-23 16:53:23.000000000","message":"ack thanks I might use this one (it is for ffu but the root cause is the same one the ordering being addressed here) https://bugs.launchpad.net/tripleo/+bug/1743758","commit_id":"b37606341c0e48e5f4a84429b1573acccf649e98"}],"tripleo_common/utils/config.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"22496a4cfa522c0fcf0114d82166bd69213fff8f","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _write_playbook_get_tasks(self, tasks, role, filepath):"},{"line_number":104,"context_line":"        playbook \u003d []"},{"line_number":105,"context_line":"        sorted_tasks \u003d sorted(tasks, key\u003dlambda x: x.get(\u0027tags\u0027, None))"},{"line_number":106,"context_line":"        playbook.append({\u0027name\u0027: \u0027%s playbook\u0027 % role,"},{"line_number":107,"context_line":"                         \u0027hosts\u0027: role,"},{"line_number":108,"context_line":"                         \u0027tasks\u0027: sorted_tasks})"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_b9871ed8","line":105,"range":{"start_line":105,"start_character":0,"end_line":105,"end_character":71},"updated":"2017-12-21 10:11:38.000000000","message":"so we probably want to update this too right? we are no longer sorting on tags)","commit_id":"e01b046536fcebd134ee37f22435bebcba3df8ad"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"22496a4cfa522c0fcf0114d82166bd69213fff8f","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def _write_playbook_get_tasks(self, tasks, role, filepath):"},{"line_number":103,"context_line":"        playbook \u003d []"},{"line_number":104,"context_line":"        sorted_tasks \u003d sorted(tasks, key\u003dlambda x: x.get(\u0027tags\u0027, None))"},{"line_number":105,"context_line":"        playbook.append({\u0027name\u0027: \u0027%s playbook\u0027 % role,"},{"line_number":106,"context_line":"                         \u0027hosts\u0027: role,"},{"line_number":107,"context_line":"                         \u0027tasks\u0027: sorted_tasks})"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8cb3f7_1c1b981b","line":104,"range":{"start_line":104,"start_character":11,"end_line":104,"end_character":71},"updated":"2017-12-21 10:11:38.000000000","message":"want to update this too, we shouldn\u0027t use tags for sorting","commit_id":"24216a69caa75652ef3f3d4f8132650101dde0ed"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"310a8121782336cc640684355f150784a34132b6","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def _write_playbook_get_tasks(self, tasks, role, filepath):"},{"line_number":103,"context_line":"        playbook \u003d []"},{"line_number":104,"context_line":"        sorted_tasks \u003d sorted(tasks, key\u003dlambda x: x.get(\u0027when\u0027, \u0027\u0027))"},{"line_number":105,"context_line":"        # sorted_tasks \u003d sorted(tasks, key\u003dlambda x: x.get(\u0027when\u0027, \u0027\u0027)["},{"line_number":106,"context_line":"        #                      x.get(\u0027when\u0027, \u0027\u0027)[0].find(\"step|int \u003d\u003d \"):"},{"line_number":107,"context_line":"        #                      x.get(\u0027when\u0027, \u0027\u0027)[0].find(\"step|int \u003d\u003d \") + 13])"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf8cb3f7_cdb7bcd8","line":104,"range":{"start_line":104,"start_character":11,"end_line":104,"end_character":60},"updated":"2017-12-21 12:45:15.000000000","message":"still don\u0027t think this is doing what we want here need to revisit","commit_id":"41f80d74f6522f2b290c1396abefaa2e6789cba8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"58e2e62b597d7e8b94d87012e54b45e6fe8b9dd9","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def _write_playbook_get_tasks(self, tasks, role, filepath):"},{"line_number":103,"context_line":"        playbook \u003d []"},{"line_number":104,"context_line":"        sorted_tasks \u003d sorted(tasks, key\u003dlambda x: x.get(\u0027when\u0027, \u0027\u0027))"},{"line_number":105,"context_line":"        # sorted_tasks \u003d sorted(tasks, key\u003dlambda x: x.get(\u0027when\u0027, \u0027\u0027)["},{"line_number":106,"context_line":"        #                      x.get(\u0027when\u0027, \u0027\u0027)[0].find(\"step|int \u003d\u003d \"):"},{"line_number":107,"context_line":"        #                      x.get(\u0027when\u0027, \u0027\u0027)[0].find(\"step|int \u003d\u003d \") + 13])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_e5aab6d0","line":104,"range":{"start_line":104,"start_character":11,"end_line":104,"end_character":60},"in_reply_to":"bf8cb3f7_cdb7bcd8","updated":"2018-01-22 12:58:34.000000000","message":"updating in a while i have a fix for it now spent some time looking","commit_id":"41f80d74f6522f2b290c1396abefaa2e6789cba8"}]}