)]}'
{"tripleo_common/actions/templates.py":[{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"65b2c69abf90649958480067f06d4067764512db","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                         os.path.basename(f).replace(\u0027.role.j2.yaml\u0027,"},{"line_number":266,"context_line":"                                                     \u0027.yaml\u0027)])"},{"line_number":267,"context_line":"                    out_f_path \u003d os.path.join(os.path.dirname(f), out_f)"},{"line_number":268,"context_line":"                    if (\u0027network/config\u0027 in file_path and"},{"line_number":269,"context_line":"                        r_map[role].get(\u0027deprecated_nic_config_name\u0027)):"},{"line_number":270,"context_line":"                        d_name \u003d r_map[role].get("},{"line_number":271,"context_line":"                            \u0027deprecated_nic_config_name\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_8bb49981","line":268,"range":{"start_line":268,"start_character":44,"end_line":268,"end_character":53},"updated":"2018-02-01 01:37:35.000000000","message":"undefined variable","commit_id":"be09baa1c1d45ee759ef4dc46d6752a4041a5717"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"65b2c69abf90649958480067f06d4067764512db","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                        r_map[role].get(\u0027deprecated_nic_config_name\u0027)):"},{"line_number":270,"context_line":"                        d_name \u003d r_map[role].get("},{"line_number":271,"context_line":"                            \u0027deprecated_nic_config_name\u0027)"},{"line_number":272,"context_line":"                        out_f_path \u003d os.path.join(out_dir, d_name)"},{"line_number":273,"context_line":"                    elif (\u0027network/config\u0027 in file_path):"},{"line_number":274,"context_line":"                        d_name \u003d \"%s.yaml\" % role.lower()"},{"line_number":275,"context_line":"                        out_f_path \u003d os.path.join(out_dir, d_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_6ba58d46","line":272,"range":{"start_line":272,"start_character":50,"end_line":272,"end_character":57},"updated":"2018-02-01 01:37:35.000000000","message":"ditto","commit_id":"be09baa1c1d45ee759ef4dc46d6752a4041a5717"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"65b2c69abf90649958480067f06d4067764512db","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                        d_name \u003d r_map[role].get("},{"line_number":271,"context_line":"                            \u0027deprecated_nic_config_name\u0027)"},{"line_number":272,"context_line":"                        out_f_path \u003d os.path.join(out_dir, d_name)"},{"line_number":273,"context_line":"                    elif (\u0027network/config\u0027 in file_path):"},{"line_number":274,"context_line":"                        d_name \u003d \"%s.yaml\" % role.lower()"},{"line_number":275,"context_line":"                        out_f_path \u003d os.path.join(out_dir, d_name)"},{"line_number":276,"context_line":"                    if not (out_f_path in excl_templates):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_2b69c5f7","line":273,"range":{"start_line":273,"start_character":46,"end_line":273,"end_character":55},"updated":"2018-02-01 01:37:35.000000000","message":"ditto","commit_id":"be09baa1c1d45ee759ef4dc46d6752a4041a5717"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"65b2c69abf90649958480067f06d4067764512db","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                        out_f_path \u003d os.path.join(out_dir, d_name)"},{"line_number":273,"context_line":"                    elif (\u0027network/config\u0027 in file_path):"},{"line_number":274,"context_line":"                        d_name \u003d \"%s.yaml\" % role.lower()"},{"line_number":275,"context_line":"                        out_f_path \u003d os.path.join(out_dir, d_name)"},{"line_number":276,"context_line":"                    if not (out_f_path in excl_templates):"},{"line_number":277,"context_line":"                        if \u0027{{role.name}}\u0027 in j2_template:"},{"line_number":278,"context_line":"                            j2_data \u003d {\u0027role\u0027: r_map[role],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_cb6b81ee","line":275,"range":{"start_line":275,"start_character":50,"end_line":275,"end_character":57},"updated":"2018-02-01 01:37:35.000000000","message":"ditto","commit_id":"be09baa1c1d45ee759ef4dc46d6752a4041a5717"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"6894b6768d479a3e0c9c92ac48604fafbe5a8ab5","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                                                     \u0027.yaml\u0027)])"},{"line_number":267,"context_line":"                    out_f_path \u003d os.path.join(os.path.dirname(f), out_f)"},{"line_number":268,"context_line":"                    if (\u0027network/config\u0027 in os.path.dirname(f) and"},{"line_number":269,"context_line":"                        r_map[role].get(\u0027deprecated_nic_config_name\u0027)):"},{"line_number":270,"context_line":"                        d_name \u003d r_map[role].get(\u0027deprecated_nic_config_name\u0027)"},{"line_number":271,"context_line":"                        out_f_path \u003d os.path.join(os.path.dirname(f), d_name)"},{"line_number":272,"context_line":"                    elif (\u0027network/config\u0027 in os.path.dirname(f)):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_e97e69ad","line":269,"range":{"start_line":269,"start_character":24,"end_line":269,"end_character":71},"updated":"2018-02-01 23:37:06.000000000","message":"move this line to the right four spaces","commit_id":"bde4eed96ae770cb4af8ae320f2864521956306c"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"d0c77812cae48eba87be8740a66694a5bb5b7a4f","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                         os.path.basename(f).replace(\u0027.role.j2.yaml\u0027,"},{"line_number":266,"context_line":"                                                     \u0027.yaml\u0027)])"},{"line_number":267,"context_line":"                    out_f_path \u003d os.path.join(os.path.dirname(f), out_f)"},{"line_number":268,"context_line":"                    if (\u0027network/config\u0027 in os.path.dirname(f) and"},{"line_number":269,"context_line":"                            r_map[role].get(\u0027deprecated_nic_config_name\u0027)):"},{"line_number":270,"context_line":"                        d_name \u003d r_map[role].get(\u0027deprecated_nic_config_name\u0027)"},{"line_number":271,"context_line":"                        out_f_path \u003d os.path.join(os.path.dirname(f), d_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_95454173","line":268,"updated":"2018-02-05 17:21:10.000000000","message":"What if they don\u0027t have their nic configs in network/config?  I feel like that\u0027s probably more common than people who are using templates in the tht tree.","commit_id":"bc65df3c32ac770f84b8a93af64dc1f8b650f637"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"c8eba2b950fa9c76583cafd37b99045844ed0346","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                         os.path.basename(f).replace(\u0027.role.j2.yaml\u0027,"},{"line_number":266,"context_line":"                                                     \u0027.yaml\u0027)])"},{"line_number":267,"context_line":"                    out_f_path \u003d os.path.join(os.path.dirname(f), out_f)"},{"line_number":268,"context_line":"                    if (\u0027network/config\u0027 in os.path.dirname(f) and"},{"line_number":269,"context_line":"                            r_map[role].get(\u0027deprecated_nic_config_name\u0027)):"},{"line_number":270,"context_line":"                        d_name \u003d r_map[role].get(\u0027deprecated_nic_config_name\u0027)"},{"line_number":271,"context_line":"                        out_f_path \u003d os.path.join(os.path.dirname(f), d_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_3adc5473","line":268,"in_reply_to":"3fa0c359_492404c7","updated":"2018-02-05 20:50:16.000000000","message":"Ah, okay, that makes sense.  I agree that it\u0027s unlikely people will be creating custom jinja templates.","commit_id":"bc65df3c32ac770f84b8a93af64dc1f8b650f637"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"f4f651b546c857b5a7f1100b6a0d4f47b5380b33","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                         os.path.basename(f).replace(\u0027.role.j2.yaml\u0027,"},{"line_number":266,"context_line":"                                                     \u0027.yaml\u0027)])"},{"line_number":267,"context_line":"                    out_f_path \u003d os.path.join(os.path.dirname(f), out_f)"},{"line_number":268,"context_line":"                    if (\u0027network/config\u0027 in os.path.dirname(f) and"},{"line_number":269,"context_line":"                            r_map[role].get(\u0027deprecated_nic_config_name\u0027)):"},{"line_number":270,"context_line":"                        d_name \u003d r_map[role].get(\u0027deprecated_nic_config_name\u0027)"},{"line_number":271,"context_line":"                        out_f_path \u003d os.path.join(os.path.dirname(f), d_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_492404c7","line":268,"in_reply_to":"3fa0c359_95454173","updated":"2018-02-05 19:30:06.000000000","message":"The only thing this logic does is to make sure that the legacy NIC config templates for the default roles still get rendered with the name format \"\u003crole_name\u003e.yaml\" instead of \"\u003crole_name\u003e-role.yaml\". If there are people creating jinja2 templates (rather than custom YAML templates) outside of network/config, they can deal with the names being rendered differently. I don\u0027t really expect that many people will create custom jinja2 templates, instead they would customize the YAML file output for their needs.","commit_id":"bc65df3c32ac770f84b8a93af64dc1f8b650f637"}]}