)]}'
{"tripleo_common/utils/swift.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"f529bd1ef5e67ea10ade41a3766ec8a107775ffc","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                          \"TripleO deployment plan and was not \""},{"line_number":39,"context_line":"                          \"deleted.\".format(name\u003dname))"},{"line_number":40,"context_line":"            raise ValueError(error_text)"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            object_names \u003d [obj[\"name\"] for obj in objects]"},{"line_number":43,"context_line":"            # This will perform a batch/bulk-delete on the objects"},{"line_number":44,"context_line":"            del_iter \u003d swiftservice.delete(container\u003dname,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_58862268","line":41,"updated":"2018-04-09 21:02:00.000000000","message":"\"else\" block is unnecessary","commit_id":"bbd900d41f18fed09d396b7564be77a45f06f260"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"f529bd1ef5e67ea10ade41a3766ec8a107775ffc","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def delete_container(swiftclient, swiftservice, name):"},{"line_number":57,"context_line":"    try:"},{"line_number":58,"context_line":"        empty_container(swiftclient, swiftservice, name)"},{"line_number":59,"context_line":"        swiftclient.delete_container(name)"},{"line_number":60,"context_line":"    except ValueError as e:"},{"line_number":61,"context_line":"        # ValueError is raised when we can\u0027t find the container, which means"},{"line_number":62,"context_line":"        # that it\u0027s already deleted."}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_bce6ed15","line":59,"range":{"start_line":58,"start_character":8,"end_line":59,"end_character":42},"updated":"2018-04-09 21:02:00.000000000","message":"As I know bulk delete is used by default in the service. So, these two lines can be replaced with:\n\nswiftservice.delete(container\u003dname)\n\nwhich is simpler.\nhttps://github.com/openstack/python-swiftclient/blob/master/swiftclient/service.py#L2606","commit_id":"bbd900d41f18fed09d396b7564be77a45f06f260"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"341e2718c997617906842df6b39113fd90b00ebb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def empty_container(swiftclient, name):"},{"line_number":31,"context_line":"    container_names \u003d [container[\"name\"] for container"},{"line_number":32,"context_line":"                       in swiftclient.get_account()[1]]"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_b66a1db0","side":"PARENT","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":19},"updated":"2018-09-06 15:23:42.000000000","message":"This was still in use by tripleoclient so it broke stuff.","commit_id":"d82e9ed668b34e087b867ed8f4ede1afd2f0aeb9"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"74eacede6a7e0080b6839a77f7d0b9edad5785c1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def empty_container(swiftclient, name):"},{"line_number":31,"context_line":"    container_names \u003d [container[\"name\"] for container"},{"line_number":32,"context_line":"                       in swiftclient.get_account()[1]]"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_56edc922","side":"PARENT","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":19},"in_reply_to":"3f79a3b5_b66a1db0","updated":"2018-09-06 15:24:42.000000000","message":"https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/workflows/plan_management.py#L207","commit_id":"d82e9ed668b34e087b867ed8f4ede1afd2f0aeb9"}]}