)]}'
{"playbooks/roles/octavia-undercloud/tasks/image_mgmt.yml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"c709a9eedb4c6ecf4f564523fdd8a6e53d549148","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    when: amphora_image is not defined and image_file_result.stat.exists and not symlnk_check.stat.islnk"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  - name: check there an image in glance already"},{"line_number":23,"context_line":"    shell: |"},{"line_number":24,"context_line":"      openstack image show {{ amphora_image }} -c checksum -f value"},{"line_number":25,"context_line":"    register: glance_results"},{"line_number":26,"context_line":"    ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f6a8fd7_3319cdd6","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":12},"updated":"2018-04-17 21:32:46.000000000","message":"This probably adds a newline at the end to the stdout. This means the value of glance_results.stdout might differ from image_file_result.stat.md5 simply on that trailing newline. If that\u0027s so, simply strip it with:\n\nshell: |-","commit_id":"63813984de6c4c814e57edf2a0208df2c05565d2"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"11a1478aaba574ff29077970059e401222409432","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    when: amphora_image is not defined and image_file_result.stat.exists and not symlnk_check.stat.islnk"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  - name: check there an image in glance already"},{"line_number":23,"context_line":"    shell: |"},{"line_number":24,"context_line":"      openstack image show {{ amphora_image }} -c checksum -f value"},{"line_number":25,"context_line":"    register: glance_results"},{"line_number":26,"context_line":"    ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f6a8fd7_a584b25f","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":12},"in_reply_to":"9f6a8fd7_3319cdd6","updated":"2018-04-18 00:10:20.000000000","message":"It might, but it seems to work. I\u0027ll change this if/when I respin again.","commit_id":"63813984de6c4c814e57edf2a0208df2c05565d2"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"c709a9eedb4c6ecf4f564523fdd8a6e53d549148","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  - name: upload image to glance"},{"line_number":52,"context_line":"    shell: |"},{"line_number":53,"context_line":"      glance image-create --name {{ amphora_image }} --disk-format qcow2 \\"},{"line_number":54,"context_line":"        --container-format bare --tags {{ amp_image_tag }} --file {{ image_filename }}"},{"line_number":55,"context_line":"    register: image_result"},{"line_number":56,"context_line":"    changed_when: \"image_result.stdout !\u003d \u0027\u0027\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f6a8fd7_33654db6","line":53,"range":{"start_line":53,"start_character":6,"end_line":53,"end_character":12},"updated":"2018-04-17 21:32:46.000000000","message":"can we use this opportunity to switch to the openstack cli?","commit_id":"63813984de6c4c814e57edf2a0208df2c05565d2"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bbe25ee1ce30b4a10b1218065eaf3c52b5597001","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  - name: upload image to glance"},{"line_number":52,"context_line":"    shell: |"},{"line_number":53,"context_line":"      glance image-create --name {{ amphora_image }} --disk-format qcow2 \\"},{"line_number":54,"context_line":"        --container-format bare --tags {{ amp_image_tag }} --file {{ image_filename }}"},{"line_number":55,"context_line":"    register: image_result"},{"line_number":56,"context_line":"    changed_when: \"image_result.stdout !\u003d \u0027\u0027\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f6a8fd7_febf90f8","line":53,"updated":"2018-04-18 08:35:58.000000000","message":"nit: could you please use openstack CLI?","commit_id":"9807a08c222c2db26f831ef949de390e33d14402"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"7017c659d73bbbf0a895813685b3cff896135bde","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      amphora_image: \"{{ (image_file_result.stat.path | basename | splitext)[0] }}\""},{"line_number":20,"context_line":"    when: amphora_image is not defined and image_file_result.stat.exists and not symlnk_check.stat.islnk"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  - name: check there an image in glance already"},{"line_number":23,"context_line":"    shell: |"},{"line_number":24,"context_line":"      openstack image show {{ amphora_image }} -c checksum -f value"},{"line_number":25,"context_line":"    register: glance_results"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_d71d17be","line":22,"range":{"start_line":22,"start_character":16,"end_line":22,"end_character":21},"updated":"2018-05-03 12:20:03.000000000","message":"if there is","commit_id":"549f9e004c37682cb9c1232099ea63cadf36511b"}],"playbooks/roles/octavia-undercloud/tasks/main.yml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"c709a9eedb4c6ecf4f564523fdd8a6e53d549148","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    register: image_file_result"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  - include_tasks: image_mgmt.yml"},{"line_number":25,"context_line":"    when: image_file_result.stat.exists"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f6a8fd7_53f001ca","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":39},"updated":"2018-04-17 21:32:46.000000000","message":"What do you think of informing user when image does not exist? Something like:\n\n\n- debug: msg\u003d\"Image file {{ image_filename }} does not exist. Skipping upload of amphora image\"\n  when: not image_file_result.stat.exists","commit_id":"63813984de6c4c814e57edf2a0208df2c05565d2"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"11a1478aaba574ff29077970059e401222409432","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    register: image_file_result"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  - include_tasks: image_mgmt.yml"},{"line_number":25,"context_line":"    when: image_file_result.stat.exists"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f6a8fd7_e5b86a2b","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":39},"in_reply_to":"9f6a8fd7_53f001ca","updated":"2018-04-18 00:10:20.000000000","message":"We can but it is going to be in a pretty non-obvious place - e.g. /var/log/mistral/engine.log on the undercloud.","commit_id":"63813984de6c4c814e57edf2a0208df2c05565d2"}]}