)]}'
{"workbooks/package_update.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4b0fc5f26fce20bf00571208c4f7b299c82ea33d","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        on-error: set_update_failed"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"      upgrade_converge:"},{"line_number":241,"context_line":"        action: tripleo.deployment.deploy"},{"line_number":242,"context_line":"        input:"},{"line_number":243,"context_line":"          timeout: \u003c% $.timeout %\u003e"},{"line_number":244,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":245,"context_line":"          skip_deploy_identifier: \u003c% $.skip_deploy_identifier %\u003e"},{"line_number":246,"context_line":"        on-success: send_message"},{"line_number":247,"context_line":"        on-error: set_update_failed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f6a8fd7_77d643c6","side":"PARENT","line":244,"range":{"start_line":241,"start_character":20,"end_line":244,"end_character":16},"updated":"2018-04-18 10:46:31.000000000","message":"no i think we want/need to keep it. in particular we aren\u0027t using config download with the major upgrade, so there are some things that aren\u0027t included in the deploy tasks and so we want a full heat stack update on the converge lets discuss on the review","commit_id":"33de4303bbb95d3964f8b511a2031ec4c3c01ed6"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"7ea33f4950b0000e795cb5b01449d64ce8786dd9","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        on-error: set_update_failed"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"      upgrade_converge:"},{"line_number":241,"context_line":"        action: tripleo.deployment.deploy"},{"line_number":242,"context_line":"        input:"},{"line_number":243,"context_line":"          timeout: \u003c% $.timeout %\u003e"},{"line_number":244,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":245,"context_line":"          skip_deploy_identifier: \u003c% $.skip_deploy_identifier %\u003e"},{"line_number":246,"context_line":"        on-success: send_message"},{"line_number":247,"context_line":"        on-error: set_update_failed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f6a8fd7_b11b8619","side":"PARENT","line":244,"range":{"start_line":241,"start_character":20,"end_line":244,"end_character":16},"in_reply_to":"9f6a8fd7_312216a6","updated":"2018-04-18 12:43:20.000000000","message":"Ack i get that the final stack update is helpful to uncover any potential issues, and i was actually very much in favor of it, that is until we started discussing Ceph upgrade separation, then i took the stack update removal as \"necessary evil\". \n\nAnd we should actually be recommending a final `overcloud deploy` *after* the Ceph update/upgrade is done, as a sanity check. And not just for normal upgrades, the degree of sanity check necessity is IMHO exactly the same for FFWD (if not greater given that we jump 3 versions). And still somewhat present for minor updates, even though perhaps less importantly as we don\u0027t expect big changes in the templates there.","commit_id":"33de4303bbb95d3964f8b511a2031ec4c3c01ed6"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"d5b2cd0d30c44898a10cf35560da5092a2c65728","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        on-error: set_update_failed"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"      upgrade_converge:"},{"line_number":241,"context_line":"        action: tripleo.deployment.deploy"},{"line_number":242,"context_line":"        input:"},{"line_number":243,"context_line":"          timeout: \u003c% $.timeout %\u003e"},{"line_number":244,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":245,"context_line":"          skip_deploy_identifier: \u003c% $.skip_deploy_identifier %\u003e"},{"line_number":246,"context_line":"        on-success: send_message"},{"line_number":247,"context_line":"        on-error: set_update_failed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f6a8fd7_edbfe4cd","side":"PARENT","line":244,"range":{"start_line":241,"start_character":20,"end_line":244,"end_character":16},"in_reply_to":"9f6a8fd7_77d643c6","updated":"2018-04-18 11:56:10.000000000","message":"But that will break Ceph -- we\u0027d have to back off from the Ceph CLI plan AFAICT.\n\nCan you please expand why does it matter to do a full stack update here, but not on update and ffwd? I might be missing something.","commit_id":"33de4303bbb95d3964f8b511a2031ec4c3c01ed6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d46ee5657f696e4630f744c9ca320bccaed6a0b7","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        on-error: set_update_failed"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"      upgrade_converge:"},{"line_number":241,"context_line":"        action: tripleo.deployment.deploy"},{"line_number":242,"context_line":"        input:"},{"line_number":243,"context_line":"          timeout: \u003c% $.timeout %\u003e"},{"line_number":244,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":245,"context_line":"          skip_deploy_identifier: \u003c% $.skip_deploy_identifier %\u003e"},{"line_number":246,"context_line":"        on-success: send_message"},{"line_number":247,"context_line":"        on-error: set_update_failed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f6a8fd7_7f4a55ac","side":"PARENT","line":244,"range":{"start_line":241,"start_character":20,"end_line":244,"end_character":16},"in_reply_to":"9f6a8fd7_802b8a80","updated":"2018-04-20 15:25:50.000000000","message":"as an update i filed this today https://bugzilla.redhat.com/show_bug.cgi?id\u003d1570042","commit_id":"33de4303bbb95d3964f8b511a2031ec4c3c01ed6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"99ac76ea1fb330884b9b52beceddbb80ef894e30","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        on-error: set_update_failed"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"      upgrade_converge:"},{"line_number":241,"context_line":"        action: tripleo.deployment.deploy"},{"line_number":242,"context_line":"        input:"},{"line_number":243,"context_line":"          timeout: \u003c% $.timeout %\u003e"},{"line_number":244,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":245,"context_line":"          skip_deploy_identifier: \u003c% $.skip_deploy_identifier %\u003e"},{"line_number":246,"context_line":"        on-success: send_message"},{"line_number":247,"context_line":"        on-error: set_update_failed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f6a8fd7_312216a6","side":"PARENT","line":244,"range":{"start_line":241,"start_character":20,"end_line":244,"end_character":16},"in_reply_to":"9f6a8fd7_8d0e688b","updated":"2018-04-18 12:27:47.000000000","message":"15:27 \u003c marios\u003e jistr: some related discussion here \n                https://review.openstack.org/#/c/526656/4/doc/source/install/developer/upgrades/fast_fw_upgrade.rst@32","commit_id":"33de4303bbb95d3964f8b511a2031ec4c3c01ed6"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"e31c122f1c47095096098985206caab9c9893937","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        on-error: set_update_failed"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"      upgrade_converge:"},{"line_number":241,"context_line":"        action: tripleo.deployment.deploy"},{"line_number":242,"context_line":"        input:"},{"line_number":243,"context_line":"          timeout: \u003c% $.timeout %\u003e"},{"line_number":244,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":245,"context_line":"          skip_deploy_identifier: \u003c% $.skip_deploy_identifier %\u003e"},{"line_number":246,"context_line":"        on-success: send_message"},{"line_number":247,"context_line":"        on-error: set_update_failed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f6a8fd7_ad700cde","side":"PARENT","line":244,"range":{"start_line":241,"start_character":20,"end_line":244,"end_character":16},"in_reply_to":"9f6a8fd7_8d0e688b","updated":"2018-04-18 12:18:18.000000000","message":"We wanted a full stack update being done here until we had the calls about how to upgrade Ceph, AFAIR.\n\nWe probably could remove the WorkflowSteps un-noop from the converge file, but that affects more than just Ceph and it would defeat the purpose of doing converge in the first place...\n\nOr we could remove Ceph from the list of services but IMO that\u0027s quite a dirty way to do this.\n\nI\u0027d like if we could expand on the concern that you discussed w/ slagle, either here or on IRC perhaps? At the moment i still don\u0027t see a better option than what\u0027s proposed here.","commit_id":"33de4303bbb95d3964f8b511a2031ec4c3c01ed6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"02d3033ae9af07213032302252a8dfee5027a607","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        on-error: set_update_failed"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"      upgrade_converge:"},{"line_number":241,"context_line":"        action: tripleo.deployment.deploy"},{"line_number":242,"context_line":"        input:"},{"line_number":243,"context_line":"          timeout: \u003c% $.timeout %\u003e"},{"line_number":244,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":245,"context_line":"          skip_deploy_identifier: \u003c% $.skip_deploy_identifier %\u003e"},{"line_number":246,"context_line":"        on-success: send_message"},{"line_number":247,"context_line":"        on-error: set_update_failed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f6a8fd7_802b8a80","side":"PARENT","line":244,"range":{"start_line":241,"start_character":20,"end_line":244,"end_character":16},"in_reply_to":"9f6a8fd7_b11b8619","updated":"2018-04-18 15:21:47.000000000","message":"as discussed on the phone just now i\u0027m happy to do this, given there is a specific need for it (ceph cli) as long as we simultaneously track a docs strong reccomendation that you should run a full stack deploy with all the env files you have just used for your upgrade/update/ffwd after you have completed the converge operation there.","commit_id":"33de4303bbb95d3964f8b511a2031ec4c3c01ed6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3eaca2979b9e5e813e4990d72190a88ccb2eeb52","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        on-error: set_update_failed"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"      upgrade_converge:"},{"line_number":241,"context_line":"        action: tripleo.deployment.deploy"},{"line_number":242,"context_line":"        input:"},{"line_number":243,"context_line":"          timeout: \u003c% $.timeout %\u003e"},{"line_number":244,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":245,"context_line":"          skip_deploy_identifier: \u003c% $.skip_deploy_identifier %\u003e"},{"line_number":246,"context_line":"        on-success: send_message"},{"line_number":247,"context_line":"        on-error: set_update_failed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f6a8fd7_8d0e688b","side":"PARENT","line":244,"range":{"start_line":241,"start_character":20,"end_line":244,"end_character":16},"in_reply_to":"9f6a8fd7_edbfe4cd","updated":"2018-04-18 12:07:58.000000000","message":"ack. I recall discussing at PTG with slagle about some resources not being included here since we aren\u0027t using \u0027proper\u0027 config download here but just no-oping the OS::TripleO::DeploymentSteps. Besides that however, all our conversations thus far have been about upgrade converge running the heat stack update, if nothing else as a sanity check since it is the first heat stack update with the new config (the first in prepare was not applying the config), before we declare that the upgrade is complete. Furthermore we\u0027ve commented on how that was/is different from the updates and ffwd-upgrade but yes lets change that in the future.\n\nWe aren\u0027t bound like ffwd-upgrade in the timeout here so a heat stack update is not out of the question. \n\nI see the point about the ceph upgrade... can we not set something here to prevent the ceph from running during the upgrade converge?","commit_id":"33de4303bbb95d3964f8b511a2031ec4c3c01ed6"}]}