)]}'
{"id":"openstack%2Ftripleo-common~566554","triplet_id":"openstack%2Ftripleo-common~stable%2Fqueens~I41f81dc9d68bcf23e6171e35bb053a3943f50c01","project":"openstack/tripleo-common","branch":"stable/queens","topic":"bug/1765727","hashtags":[],"change_id":"I41f81dc9d68bcf23e6171e35bb053a3943f50c01","subject":"Allow fencing config generation before deployment.","status":"MERGED","created":"2018-05-07 11:41:18.000000000","updated":"2018-05-08 10:31:48.000000000","submitted":"2018-05-08 10:31:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"566554-1525775508723-a66f025f","meta_rev_id":"8694518daf46c4636ddbf0c1cccf9b5a16929f13","_number":566554,"virtual_id_number":566554,"owner":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2018-05-08 10:31:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-05-07 14:19:21.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":0,"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2018-05-08 07:49:14.000000000","_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":0,"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2018-05-08 07:49:14.000000000","_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":0,"date":"2018-05-07 11:41:18.000000000","_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-05-07 11:41:18.000000000","updated_by":{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},"reviewer":{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},"state":"REVIEWER"},{"updated":"2018-05-07 14:19:21.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-05-08 07:49:14.000000000","updated_by":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"reviewer":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"state":"REVIEWER"},{"updated":"2018-05-08 10:31:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a10aed9fa33981d100681335358e8a99aeb133eb","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2018-05-07 11:41:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b726eb34be8fedb9db60d3c70eea8ff5f03a5ab1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-07 14:06:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/54/566554/1/check/build-openstack-sphinx-docs/19e69fc/html/ : SUCCESS in 4m 13s\n- openstack-tox-pep8 http://logs.openstack.org/54/566554/1/check/openstack-tox-pep8/8172019/ : SUCCESS in 3m 55s\n- openstack-tox-py27 http://logs.openstack.org/54/566554/1/check/openstack-tox-py27/7f395fa/ : SUCCESS in 4m 56s\n- openstack-tox-py35 http://logs.openstack.org/54/566554/1/check/openstack-tox-py35/543fbcf/ : SUCCESS in 3m 51s\n- openstack-tox-cover http://logs.openstack.org/54/566554/1/check/openstack-tox-cover/2f3adf7/cover/ : SUCCESS in 4m 30s (non-voting)\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/54/566554/1/check/tripleo-ci-centos-7-undercloud-oooq/bb1e88b/ : SUCCESS in 1h 07m 27s\n- tripleo-ci-centos-7-undercloud-upgrades http://logs.openstack.org/54/566554/1/check/tripleo-ci-centos-7-undercloud-upgrades/afeba9c/ : SUCCESS in 1h 18m 41s (non-voting)\n- tripleo-ci-centos-7-3nodes-multinode http://logs.openstack.org/54/566554/1/check/tripleo-ci-centos-7-3nodes-multinode/847bc11/ : SUCCESS in 2h 18m 56s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/54/566554/1/check/tripleo-ci-centos-7-containers-multinode/db4bbfb/ : SUCCESS in 2h 14m 15s","accounts_in_message":[],"_revision_number":1},{"id":"ee55ea88c021108775db9c4c8b66376d9ad21d0d","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2018-05-07 14:19:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-queens https://review.rdoproject.org/jenkins/job/gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-queens/589/ : SUCCESS in 2h 09m 34s\n- gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035-queens https://review.rdoproject.org/jenkins/job/gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035-queens/595/ : SUCCESS in 2h 00m 32s","accounts_in_message":[],"_revision_number":1},{"id":"ea2a4b17e0e054bcf3710e7959827c0f0c2160bd","author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"date":"2018-05-08 07:49:14.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"2c9e0ab485f2d2dbe3741af9019bb29332773fc5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-08 07:49:29.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b68eed45879722f1ec491e9a7591070d92710cad","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-08 10:31:48.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/54/566554/1/gate/build-openstack-sphinx-docs/9b518bb/html/ : SUCCESS in 3m 54s\n- openstack-tox-pep8 http://logs.openstack.org/54/566554/1/gate/openstack-tox-pep8/0c63523/ : SUCCESS in 4m 29s\n- openstack-tox-py27 http://logs.openstack.org/54/566554/1/gate/openstack-tox-py27/8828e61/ : SUCCESS in 4m 11s\n- openstack-tox-py35 http://logs.openstack.org/54/566554/1/gate/openstack-tox-py35/39ad355/ : SUCCESS in 6m 01s\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/54/566554/1/gate/tripleo-ci-centos-7-undercloud-oooq/6ca4156/ : SUCCESS in 1h 11m 44s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/54/566554/1/gate/tripleo-ci-centos-7-containers-multinode/b5b2c4b/ : SUCCESS in 2h 13m 11s","accounts_in_message":[],"_revision_number":1},{"id":"ea31af911e2eeb17663b0a9fe88a6cd7d7352158","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-08 10:31:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1d3aefbe2f0aac2828eba69ee9efc57a7b7bf385","revisions":{"1d3aefbe2f0aac2828eba69ee9efc57a7b7bf385":{"kind":"REWORK","_number":1,"created":"2018-05-07 11:41:18.000000000","uploader":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"ref":"refs/changes/54/566554/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-common","ref":"refs/changes/54/566554/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/54/566554/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/54/566554/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-common refs/changes/54/566554/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-common refs/changes/54/566554/1"}}},"commit":{"parents":[{"commit":"ee9ace2087e979326a890eccad8f9010fa1e6440","subject":"Use scheduler hints in derived_parameters workflow","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/ee9ace2087e979326a890eccad8f9010fa1e6440"}]}],"author":{"name":"Chris Jones","email":"cmsj@tenshu.net","date":"2017-10-12 08:35:59.000000000","tz":60},"committer":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2018-05-07 11:40:59.000000000","tz":120},"subject":"Allow fencing config generation before deployment.","message":"Allow fencing config generation before deployment.\n\nWith this commit we are able to generate the fencing configuration for\nIPMI hosts before deployment, and thus use it as part of the initial\ndeployment run.\n\nThe reason we can generate it before hand is the following:\npuppet::tripleo is capable of matching its own host via\nhttps://github.com/openstack/puppet-tripleo/blob/master/manifests/fencing.pp#L73\nand by doing that each node will create its own stonith device.\nIt does so by looking at the macaddress\u003c-\u003eIPMI table and if it detects\nit\u0027s own macaddress it will create the IPMI stonith device\nfor its own hostname.\n\nConcurrent stonith resource creation from different nodes is possible\nin puppet-pacemaker since change I8be5d5d1a9894b0e2915459b10ea2feed703ba8e\ngot merged.\n\nTested as follows on a virtual vbmc environment:\n1. Before deployment:\n$ openstack overcloud generate fencing instackenv.json --output fence.yaml\n2. Deployed overcloud adding \"fence.yaml\"\n3. Verified stonith configuration:\n[root@controller-0 ~]# pcs status |grep stonith\n stonith-fence_ipmilan-525400c36fc9     (stonith:fence_ipmilan):        Started controller-0\n stonith-fence_ipmilan-5254005c160d     (stonith:fence_ipmilan):        Started controller-2\n stonith-fence_ipmilan-525400ed3293     (stonith:fence_ipmilan):        Started controller-1\n[root@controller-0 ~]# pcs property |grep stonith\n stonith-enabled: true\n4. Verified the fencing of a specific node:\n[root@controller-0 ~]# pcs stonith fence controller-1\nNode: controller-1 fenced\n\n\u003cindeed controller-1 has been fenced\u003e\n\nSame test run on BM:\n1. Before deployment:\n$ openstack overcloud generate fencing instackenv.json --output fence.yaml\n2. Deployed overcloud adding \"fence.yaml\"\n3. Verified stonith configuration:\n[root@controller-0 ~]# pcs status |grep stonith\n stonith-fence_ipmilan-1866da6126a0     (stonith:fence_ipmilan):        Started overcloud-controller-0\n stonith-fence_ipmilan-1866da612109     (stonith:fence_ipmilan):        Started overcloud-controller-1\n stonith-fence_ipmilan-1866da5faed8     (stonith:fence_ipmilan):        Started overcloud-controller-2\n stonith-fence_ipmilan-1866da612373     (stonith:fence_ipmilan):        Started overcloud-controller-2\n stonith-fence_ipmilan-1866da612295     (stonith:fence_ipmilan):        Started overcloud-controller-0\n[root@overcloud-controller-0 ~]# pcs property |grep stonith\n stonith-enabled: true\n4. Verified the fencing of a specific node:\n[root@overcloud-controller-0 ~]# pcs stonith fence overcloud-controller-1 \u0026 ping overcloud-controller-1\n[1] 168504\nPING overcloud-controller-1.localdomain (172.17.0.14) 56(84) bytes of data.\n64 bytes from overcloud-controller-1.localdomain (172.17.0.14): icmp_seq\u003d1 ttl\u003d64 time\u003d0.139 ms\n64 bytes from overcloud-controller-1.localdomain (172.17.0.14): icmp_seq\u003d2 ttl\u003d64 time\u003d0.135 ms\n64 bytes from overcloud-controller-1.localdomain (172.17.0.14): icmp_seq\u003d3 ttl\u003d64 time\u003d0.132 ms\n64 bytes from overcloud-controller-1.localdomain (172.17.0.14): icmp_seq\u003d4 ttl\u003d64 time\u003d0.150 ms\n64 bytes from overcloud-controller-1.localdomain (172.17.0.14): icmp_seq\u003d5 ttl\u003d64 time\u003d0.161 ms\n\u003ctimeout\u003e\n\nCloses-Bug: #1765727\nChange-Id: I41f81dc9d68bcf23e6171e35bb053a3943f50c01\n(cherry picked from commit 19f3e7a325696cf33a8d85a0d4ccc8358f750f1d)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/1d3aefbe2f0aac2828eba69ee9efc57a7b7bf385"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-common/commit/1d3aefbe2f0aac2828eba69ee9efc57a7b7bf385"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}