)]}'
{"workbooks/deployment.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3fff611b372a99d29157a21d7ceed483a565ddb5","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        publish:"},{"line_number":78,"context_line":"          servers_with_name: \u003c% task().result._info.where($.name.indexOf(execution().input.server_name) \u003e -1) %\u003e"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"      get_all_servers:"},{"line_number":81,"context_line":"        action: nova.servers_list"},{"line_number":82,"context_line":"        on-success: deploy_on_servers"},{"line_number":83,"context_line":"        publish:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_4949ffcd","line":80,"updated":"2018-05-09 18:58:59.000000000","message":"+1, \"all servers belong to the current stack\" is a dangerous assumption. valid now, but not future-proof at all.","commit_id":"8407b9bf2bd6ab3e17263a8e25cad1b0e3b87608"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"6a66c95d8ab91c7166baece09fa5e85bbc84924e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        publish:"},{"line_number":78,"context_line":"          servers_with_name: \u003c% task().result._info.where($.name.indexOf(execution().input.server_name) \u003e -1) %\u003e"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"      get_all_servers:"},{"line_number":81,"context_line":"        action: nova.servers_list"},{"line_number":82,"context_line":"        on-success: deploy_on_servers"},{"line_number":83,"context_line":"        publish:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_b2aa84cf","line":80,"updated":"2018-05-09 15:24:16.000000000","message":"It\u0027s hard to imagine valid \u0026\u0026 correct use cases for this. In the use case referenced from the commit message, it would break if the undercloud manages more than one overcloud. I\u0027m not sure how common this is in the field.\n\nNot giving -1 until we figure out an alternative solution though. It may still be worth going forward with this but essentially we\u0027d already know we\u0027re merging something which will break at some point.","commit_id":"8407b9bf2bd6ab3e17263a8e25cad1b0e3b87608"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a902a1de71e062e0011c843eecd378b59ca8faa6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        publish:"},{"line_number":78,"context_line":"          servers_with_name: \u003c% task().result._info.where($.name.indexOf(execution().input.server_name) \u003e -1) %\u003e"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"      get_all_servers:"},{"line_number":81,"context_line":"        action: nova.servers_list"},{"line_number":82,"context_line":"        on-success: deploy_on_servers"},{"line_number":83,"context_line":"        publish:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_d9c87323","line":80,"in_reply_to":"5f7c97a3_4949ffcd","updated":"2018-05-10 09:07:47.000000000","message":"thanks for the review folks. yes, indeed, multi stack deployments and servers not managed by nova are both valid things in tripleo. However the use case here is for FFU, which means this ^^^ will be run on an OSP10 deployment. I think assuming \u0027all servers deployed with nova\u0027 is  a safe enough bet (no split stack osp10 afaik?).","commit_id":"8407b9bf2bd6ab3e17263a8e25cad1b0e3b87608"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"ad0ed13019be898a9ee6737b455d9925cf2dcee1","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        publish:"},{"line_number":78,"context_line":"          servers_with_name: \u003c% task().result._info.where($.name.indexOf(execution().input.server_name) \u003e -1) %\u003e"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"      get_all_servers:"},{"line_number":81,"context_line":"        action: nova.servers_list"},{"line_number":82,"context_line":"        on-success: deploy_on_servers"},{"line_number":83,"context_line":"        publish:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_143312f8","line":80,"in_reply_to":"5f7c97a3_d9c87323","updated":"2018-05-10 09:20:29.000000000","message":"Ok i\u0027ve reported a tech debt bug:\n\nhttps://bugs.launchpad.net/tripleo/+bug/1770356\n\nI think for 13-\u003e16 we may not need this at all so we can probably revert it later.","commit_id":"8407b9bf2bd6ab3e17263a8e25cad1b0e3b87608"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3fff611b372a99d29157a21d7ceed483a565ddb5","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        action: nova.servers_list"},{"line_number":82,"context_line":"        on-success: deploy_on_servers"},{"line_number":83,"context_line":"        publish:"},{"line_number":84,"context_line":"          servers_with_name: \u003c% task().result._info %\u003e"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"      deploy_on_servers:"},{"line_number":87,"context_line":"        on-success: send_success_message"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_6944fbb7","line":84,"updated":"2018-05-09 18:58:59.000000000","message":"I wonder if we should filter out servers that are not in active state..","commit_id":"8407b9bf2bd6ab3e17263a8e25cad1b0e3b87608"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a902a1de71e062e0011c843eecd378b59ca8faa6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        action: nova.servers_list"},{"line_number":82,"context_line":"        on-success: deploy_on_servers"},{"line_number":83,"context_line":"        publish:"},{"line_number":84,"context_line":"          servers_with_name: \u003c% task().result._info %\u003e"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"      deploy_on_servers:"},{"line_number":87,"context_line":"        on-success: send_success_message"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_79b03f8b","line":84,"in_reply_to":"5f7c97a3_6944fbb7","updated":"2018-05-10 09:07:47.000000000","message":"i don\u0027t think that is something we support, i.e. start your upgrade when some of your nodes are in some state other than active/running. \n\nYou\u0027re right like this is will fail trying to run the command on nodes that are off and I think that is OK.","commit_id":"8407b9bf2bd6ab3e17263a8e25cad1b0e3b87608"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"ad0ed13019be898a9ee6737b455d9925cf2dcee1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        action: nova.servers_list"},{"line_number":82,"context_line":"        on-success: deploy_on_servers"},{"line_number":83,"context_line":"        publish:"},{"line_number":84,"context_line":"          servers_with_name: \u003c% task().result._info %\u003e"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"      deploy_on_servers:"},{"line_number":87,"context_line":"        on-success: send_success_message"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_947ba279","line":84,"in_reply_to":"5f7c97a3_79b03f8b","updated":"2018-05-10 09:20:29.000000000","message":"Yea this kinda goes with the above assumption of \"all belongs to the overcloud stack\", so if we already assume that i think it\u0027s probably fine. We don\u0027t support upgrades with some servers being in broken state. (You could still have unused servers in Ironic though, and that\u0027s fine, as this does Nova list.)","commit_id":"8407b9bf2bd6ab3e17263a8e25cad1b0e3b87608"}]}
