)]}'
{"playbooks/roles/octavia-undercloud/tasks/main.yml":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"c9d131538bd50a38c153a58eedc31ca75b1a7340","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  - name: install Octavia amphora image if Red Hat"},{"line_number":13,"context_line":"    block:"},{"line_number":14,"context_line":"      - yum: name\u003doctavia-amphora-image state\u003dlatest"},{"line_number":15,"context_line":"      - set_fact:"},{"line_number":16,"context_line":"        image_filename: \"/usr/share/rhosp-director-images/octavia-amphora.qcow2\""},{"line_number":17,"context_line":"    when: ansible_distribution \u003d\u003d \u0027RedHat\u0027 and not image_filename is defined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_545c577d","line":14,"updated":"2018-05-08 17:17:02.000000000","message":"Couple of questions: \n1. Does this set the fact if the yum operation fails? \n2. Do we want this to *always* run when this ansible is run or only on upgrade/update? I was initially thinking that there may be scenarios where we want to avoid it.","commit_id":"5ef1aa08628f50d4b554802fe6c96843a66e5bf0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"03aff2bfc2f4830e15c1fcaa7dfffe54f7adf879","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  - name: install Octavia amphora image if Red Hat"},{"line_number":13,"context_line":"    block:"},{"line_number":14,"context_line":"      - yum: name\u003doctavia-amphora-image state\u003dlatest"},{"line_number":15,"context_line":"      - set_fact:"},{"line_number":16,"context_line":"        image_filename: \"/usr/share/rhosp-director-images/octavia-amphora.qcow2\""},{"line_number":17,"context_line":"    when: ansible_distribution \u003d\u003d \u0027RedHat\u0027 and not image_filename is defined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_3e5ad2f2","line":14,"in_reply_to":"5f7c97a3_545c577d","updated":"2018-05-08 21:40:31.000000000","message":"1. It will not be set if yum operation fails. Play will exit with error. I believe this is the expected behavior from a one-click install deployment specially on an OpenStack commercial edition.\n\n2. In which way does this code change changes the current behavior (besides ensuring latest RPM package is installed)? If package gets updated it means it provides a new amphora image hence different md5sum of qcow2 leading to image upload/rotation. If package is not updated, md5sum stays untouched and so does the glance image.","commit_id":"5ef1aa08628f50d4b554802fe6c96843a66e5bf0"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"8502d61d743318f8baf769c168c7d66b4b5d6200","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  - name: install Octavia amphora image if Red Hat"},{"line_number":13,"context_line":"    block:"},{"line_number":14,"context_line":"      - yum: name\u003doctavia-amphora-image state\u003dlatest"},{"line_number":15,"context_line":"      - set_fact:"},{"line_number":16,"context_line":"        image_filename: \"/usr/share/rhosp-director-images/octavia-amphora.qcow2\""},{"line_number":17,"context_line":"    when: ansible_distribution \u003d\u003d \u0027RedHat\u0027 and not image_filename is defined"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_a0af93e1","line":14,"updated":"2018-05-09 11:06:29.000000000","message":"Will this fail the deploy if the yum install fails? If so, is that what we want? Where this happens at step 5 that would be pretty unfortunate. I would be inclined to separate this into two tasks and put an ignore_errors:true  on the yum part.","commit_id":"bdf74e0a69a0dc16d4ee085db692ea84427779d0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"b677e0ca61767f97ee426f2a1baa51ff7106aa38","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  - name: install Octavia amphora image if Red Hat"},{"line_number":13,"context_line":"    block:"},{"line_number":14,"context_line":"      - yum: name\u003doctavia-amphora-image state\u003dlatest"},{"line_number":15,"context_line":"      - set_fact:"},{"line_number":16,"context_line":"        image_filename: \"/usr/share/rhosp-director-images/octavia-amphora.qcow2\""},{"line_number":17,"context_line":"    when: ansible_distribution \u003d\u003d \u0027RedHat\u0027 and not image_filename is defined"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_0f61cfa9","line":14,"in_reply_to":"5f7c97a3_a0af93e1","updated":"2018-05-09 14:53:14.000000000","message":"Done. Image upload to overcloud will be skipped if package fails to install.","commit_id":"bdf74e0a69a0dc16d4ee085db692ea84427779d0"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ccfae8a3013c9eeacd1c4446de69d9d994e4a38d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    when: ansible_distribution \u003d\u003d \u0027CentOS\u0027 and not image_filename is defined"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  - name: install Octavia amphora image if Red Hat"},{"line_number":13,"context_line":"    yum: name\u003doctavia-amphora-image state\u003dlatest"},{"line_number":14,"context_line":"    when: ansible_distribution \u003d\u003d \u0027RedHat\u0027 and not image_filename is defined"},{"line_number":15,"context_line":"    ignore_errors: yes"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_daeb2e75","line":13,"range":{"start_line":13,"start_character":9,"end_line":13,"end_character":48},"updated":"2018-05-15 09:23:42.000000000","message":"nit: please use YAML notation for all values","commit_id":"ca725a099090bd8ff57de0d4ea4fec208c3c3d6b"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"62b8f8e8c8c5448e9eb1b99f3104b29a3e4d8587","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - name: install Octavia amphora image if Red Hat"},{"line_number":13,"context_line":"    yum: name\u003doctavia-amphora-image state\u003dlatest"},{"line_number":14,"context_line":"    when: ansible_distribution \u003d\u003d \u0027RedHat\u0027 and not image_filename is defined"},{"line_number":15,"context_line":"    ignore_errors: yes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  - name: set location if Red Hat"},{"line_number":18,"context_line":"    set_fact:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_3a9102f2","line":15,"range":{"start_line":15,"start_character":18,"end_line":15,"end_character":19},"updated":"2018-05-15 09:22:45.000000000","message":"Why do we want ignore_errors here?  Won\u0027t it cause problems if e.g the wrong repos/channels are enabled and the install fails?","commit_id":"ca725a099090bd8ff57de0d4ea4fec208c3c3d6b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ccfae8a3013c9eeacd1c4446de69d9d994e4a38d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - name: install Octavia amphora image if Red Hat"},{"line_number":13,"context_line":"    yum: name\u003doctavia-amphora-image state\u003dlatest"},{"line_number":14,"context_line":"    when: ansible_distribution \u003d\u003d \u0027RedHat\u0027 and not image_filename is defined"},{"line_number":15,"context_line":"    ignore_errors: yes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  - name: set location if Red Hat"},{"line_number":18,"context_line":"    set_fact:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_fa970aeb","line":15,"updated":"2018-05-15 09:23:42.000000000","message":"Why do we want to continue with errors ignored? W/o the image installed, wouldn\u0027t it be deemed to fail?","commit_id":"ca725a099090bd8ff57de0d4ea4fec208c3c3d6b"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"427d07c576176432922718e1f01721cb731cd595","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - name: install Octavia amphora image if Red Hat"},{"line_number":13,"context_line":"    yum: name\u003doctavia-amphora-image state\u003dlatest"},{"line_number":14,"context_line":"    when: ansible_distribution \u003d\u003d \u0027RedHat\u0027 and not image_filename is defined"},{"line_number":15,"context_line":"    ignore_errors: yes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  - name: set location if Red Hat"},{"line_number":18,"context_line":"    set_fact:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_ce292c37","line":15,"in_reply_to":"5f7c97a3_534e2938","updated":"2018-05-15 12:17:46.000000000","message":"I agree that it is less optimal, but I have my reasons :) Let\u0027s chat about it.","commit_id":"ca725a099090bd8ff57de0d4ea4fec208c3c3d6b"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"9e1a875f72d90c05dab4f1e9f670a02e92a92698","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - name: install Octavia amphora image if Red Hat"},{"line_number":13,"context_line":"    yum: name\u003doctavia-amphora-image state\u003dlatest"},{"line_number":14,"context_line":"    when: ansible_distribution \u003d\u003d \u0027RedHat\u0027 and not image_filename is defined"},{"line_number":15,"context_line":"    ignore_errors: yes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  - name: set location if Red Hat"},{"line_number":18,"context_line":"    set_fact:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_534e2938","line":15,"in_reply_to":"5f7c97a3_ba443275","updated":"2018-05-15 11:18:18.000000000","message":"Ok, still not sure I really get why this would be expected, or if it\u0027s going to be desirable for an operator to have this sort of issue silently ignored - maybe we can chat with Brent about it?","commit_id":"ca725a099090bd8ff57de0d4ea4fec208c3c3d6b"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"59ab169c5d9d71bd6b1d8840092ab02da19a5c3b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - name: install Octavia amphora image if Red Hat"},{"line_number":13,"context_line":"    yum: name\u003doctavia-amphora-image state\u003dlatest"},{"line_number":14,"context_line":"    when: ansible_distribution \u003d\u003d \u0027RedHat\u0027 and not image_filename is defined"},{"line_number":15,"context_line":"    ignore_errors: yes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  - name: set location if Red Hat"},{"line_number":18,"context_line":"    set_fact:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_ba443275","line":15,"in_reply_to":"5f7c97a3_fa970aeb","updated":"2018-05-15 09:29:51.000000000","message":"Good point. This was discussed between Octavia and TripleO folks and agreed to ignore errors. For example, see Brent\u0027s comment: https://review.openstack.org/#/c/566913/2/playbooks/roles/octavia-undercloud/tasks/main.yml@14","commit_id":"ca725a099090bd8ff57de0d4ea4fec208c3c3d6b"}]}