)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"083b0b3fcefe9396790e580b6d16ee493642e145","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix generate fencing command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On master this command is currently broken:"},{"line_number":10,"context_line":"(undercloud) [stack@undercloud ~]$ openstack overcloud generate fencing instackenv.json --output fencing.yaml"},{"line_number":11,"context_line":"Invalid input [name\u003dgenerate_fencing_parameters, class\u003dDirectWorkflowSpec, missing\u003d[\u0027os_auth\u0027, \u0027fence_action\u0027]]"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The reason for this is that via (A)"},{"line_number":14,"context_line":"I63f3a579af5aa70080f8c9cdd5eb0e8f5b3d17da (Add workflow to generate"},{"line_number":15,"context_line":"fencing parameters) we moved to use a workflow in order to generate"},{"line_number":16,"context_line":"fencing parameters. This workflow took a bunch of inputs which we then"},{"line_number":17,"context_line":"deprecated via two different ways:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"(B) os_auth"},{"line_number":20,"context_line":"https://review.openstack.org/#/c/570349/ and"},{"line_number":21,"context_line":"https://review.openstack.org/#/c/567896/ we removed some for pxe_ssh but"},{"line_number":22,"context_line":"we did not do it fully in the workbooks"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"(C) fence_action"},{"line_number":25,"context_line":"Same goes for https://review.openstack.org/#/c/550028/ and"},{"line_number":26,"context_line":"https://review.openstack.org/#/c/556211/ we removed fence_action but"},{"line_number":27,"context_line":"since the workflow still used it as a parameter we broke things"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Problem is that the review at (A) got proposed before(B) and (C), but"},{"line_number":30,"context_line":"was merged after them. So it was never amended to account for the"},{"line_number":31,"context_line":"changes introduced in (B) and (C). This change amends things so that"},{"line_number":32,"context_line":"the command works correctly again:"},{"line_number":33,"context_line":"(undercloud) [stack@undercloud ~]$ openstack overcloud generate fencing instackenv.json --output fencing.yaml"},{"line_number":34,"context_line":"(undercloud) [stack@undercloud ~]$ ls -l fencing.yaml"},{"line_number":35,"context_line":"-rw-rw-r--. 1 stack stack 513 Jun 28 15:46 fencing.yaml"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Change-Id: I0262c493c217b64891e7da1bb3853b0d1366faef"},{"line_number":38,"context_line":"Closes-Bug: #1779168"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_3ab187e1","line":35,"range":{"start_line":9,"start_character":6,"end_line":35,"end_character":9},"updated":"2018-07-02 08:04:18.000000000","message":"thanks very much for the detail bandini it is always excellent to have on posterity. To be honest it is a little difficult to quickly follow all the context here, given all the reviews being referenced above. \n\nIMO the most important bit here, is that \"this removes the parameters from the mistral workflow\" please consider putting this somewhere prominent\n\n+2 because i trust you and the change itself makes sense, if we\u0027ve removed use of those from the client","commit_id":"d830d0b15e5853118200c1cb221ee1c44b321193"}]}