)]}'
{"roles/tripleo-ssh-known-hosts/tasks/main.yml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"16b25f4412ae41e4b6be4d6cd53116709a5d2989","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: Template /etc/ssh/ssh_known_hosts"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  template:"},{"line_number":6,"context_line":"    src: ssh_known_hosts.j2"},{"line_number":7,"context_line":"    dest: /etc/ssh/ssh_known_hosts"},{"line_number":8,"context_line":"  tags:"},{"line_number":9,"context_line":"    - tripleo_ssh_known_hosts"},{"line_number":10,"context_line":"  when: ansible_limit is not defined"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Add line in /etc/ssh/ssh_known_hosts if --limit is used"},{"line_number":13,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_b6ab9d6f","line":10,"range":{"start_line":3,"start_character":0,"end_line":10,"end_character":36},"updated":"2018-07-24 09:40:19.000000000","message":"I think it would be better to drop this. Going sometimes with template and sometimes with lineinfile could result in difficult to debug errors if the two methods produce (slightly) different results.","commit_id":"121228b3ca9852bdc78bb6d89fb6aad90a3322b7"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"fe22aa2e10323fa3adb72d521a57e41c49ab45a1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    path: /etc/ssh/ssh_known_hosts"},{"line_number":16,"context_line":"    line: \"{{ ssh_known_hosts[hostvars[item][\u0027ansible_hostname\u0027]] + \u0027 \u0027 + hostvars[item][\u0027ansible_ssh_host_key_ecdsa_public\u0027] }}\""},{"line_number":17,"context_line":"    create: yes"},{"line_number":18,"context_line":"  with_items: \"{{ groups[\u0027overcloud\u0027]|intersect(play_hosts) }}\""},{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    - tripleo_ssh_known_hosts"},{"line_number":21,"context_line":"  when: ansible_limit is defined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_9898101b","line":18,"updated":"2018-07-24 08:06:22.000000000","message":"play_hosts contains the list of all the hosts in which a play can run. If --limit is used, the host[s]/group[s] not passed in the argument won\u0027t be included in the play_hosts var. By intersecting it with the \u0027overcloud\u0027 group we ensure we set the known_hosts only on the available hosts.","commit_id":"121228b3ca9852bdc78bb6d89fb6aad90a3322b7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1c97573d94528b3861fd458251a489fd9f3c924a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  lineinfile:"},{"line_number":5,"context_line":"    path: /etc/ssh/ssh_known_hosts"},{"line_number":6,"context_line":"    line: \"{{ ssh_known_hosts[hostvars[item][\u0027ansible_hostname\u0027]] + \u0027 \u0027 + hostvars[item][\u0027ansible_ssh_host_key_ecdsa_public\u0027] }}\""},{"line_number":7,"context_line":"    create: yes"},{"line_number":8,"context_line":"  with_items: \"{{ groups[\u0027overcloud\u0027]|intersect(play_hosts) }}\""},{"line_number":9,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_dc03bc74","line":6,"range":{"start_line":6,"start_character":68,"end_line":6,"end_character":71},"updated":"2018-07-25 08:37:20.000000000","message":"you\u0027ve missed + \u0027 ssh-rsa \u0027 +\nIIRC that was a recent change fixing some bug...","commit_id":"23214ece675caec1207be98e21c8c84f0d60f478"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"50117e4986499a932d0f830ea77677b755d9dd6f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  lineinfile:"},{"line_number":5,"context_line":"    path: /etc/ssh/ssh_known_hosts"},{"line_number":6,"context_line":"    line: \"{{ ssh_known_hosts[hostvars[item][\u0027ansible_hostname\u0027]] + \u0027 \u0027 + hostvars[item][\u0027ansible_ssh_host_key_ecdsa_public\u0027] }}\""},{"line_number":7,"context_line":"    create: yes"},{"line_number":8,"context_line":"  with_items: \"{{ groups[\u0027overcloud\u0027]|intersect(play_hosts) }}\""},{"line_number":9,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_f5032b74","line":6,"range":{"start_line":6,"start_character":68,"end_line":6,"end_character":71},"in_reply_to":"5f7c97a3_dc03bc74","updated":"2018-07-25 10:38:55.000000000","message":"need to change the fact too - https://review.openstack.org/581442","commit_id":"23214ece675caec1207be98e21c8c84f0d60f478"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"adf6473f861e123c3837024c56a926b131857ac9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  lineinfile:"},{"line_number":5,"context_line":"    path: /etc/ssh/ssh_known_hosts"},{"line_number":6,"context_line":"    line: \"{{ ssh_known_hosts[hostvars[item][\u0027ansible_hostname\u0027]] + \u0027 ssh-rsa \u0027 + hostvars[item][\u0027ansible_ssh_host_key_ecdsa_public\u0027] }}\""},{"line_number":7,"context_line":"    create: yes"},{"line_number":8,"context_line":"  with_items: \"{{ groups[\u0027overcloud\u0027]|intersect(play_hosts) }}\""},{"line_number":9,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_7fedb18b","line":6,"range":{"start_line":6,"start_character":98,"end_line":6,"end_character":131},"updated":"2018-07-25 15:45:29.000000000","message":"now needs to be the rsa key - ansible_ssh_host_key_rsa_public","commit_id":"fb6520118060d540864ef56b0f04c6ad6e5bb649"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"3b8c36f40031eda2fb254aededf2243cc177e139","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  lineinfile:"},{"line_number":5,"context_line":"    path: /etc/ssh/ssh_known_hosts"},{"line_number":6,"context_line":"    line: \"{{ ssh_known_hosts[hostvars[item][\u0027ansible_hostname\u0027]] + \u0027 ssh-rsa \u0027 + hostvars[item][\u0027ansible_ssh_host_key_ecdsa_public\u0027] }}\""},{"line_number":7,"context_line":"    create: yes"},{"line_number":8,"context_line":"  with_items: \"{{ groups[\u0027overcloud\u0027]|intersect(play_hosts) }}\""},{"line_number":9,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_d5d5b8b9","line":6,"range":{"start_line":6,"start_character":98,"end_line":6,"end_character":131},"in_reply_to":"5f7c97a3_7fedb18b","updated":"2018-07-26 06:35:04.000000000","message":"Done","commit_id":"fb6520118060d540864ef56b0f04c6ad6e5bb649"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b4cbfa824003def245807c61d110eb2a72e1c1bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Add hosts key in /etc/ssh/ssh_known_hosts for live/cold-migration"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  lineinfile:"},{"line_number":5,"context_line":"    path: /etc/ssh/ssh_known_hosts"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_af916055","line":2,"updated":"2018-07-31 15:22:52.000000000","message":"Yes this is for cold migration but I don\u0027t think that\u0027s the only goal here anyway. I\u0027m wondering if we should really mention that in the task name.","commit_id":"44ed2ea4b8bb0126c5b4a65e7712000d9b9f4655"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"557e8219af513c3fa8fa55621ea37c8a85286dea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Add hosts key in /etc/ssh/ssh_known_hosts for live/cold-migration"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  lineinfile:"},{"line_number":5,"context_line":"    path: /etc/ssh/ssh_known_hosts"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_5ba4c508","line":2,"in_reply_to":"5f7c97a3_29a53aa0","updated":"2018-08-06 09:30:22.000000000","message":"Ack, seems like a nit though. At least personally i\u0027m not aware of another use case for setting up cross product of known_hosts in overcloud.","commit_id":"44ed2ea4b8bb0126c5b4a65e7712000d9b9f4655"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"d381f5149c205c44ca5503e3da25bb0f290578e3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Add hosts key in /etc/ssh/ssh_known_hosts for live/cold-migration"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  lineinfile:"},{"line_number":5,"context_line":"    path: /etc/ssh/ssh_known_hosts"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_29a53aa0","line":2,"in_reply_to":"5f7c97a3_af916055","updated":"2018-08-01 09:56:46.000000000","message":"Well, in that case I believe we should briefly explain what it is for if the task enables other functionality. I added it because when I inspected the role I didn\u0027t have any idea what it was meant to until  I asked. The whole role is little documented and by the tasks is not easily inferred.","commit_id":"44ed2ea4b8bb0126c5b4a65e7712000d9b9f4655"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"c0a7cb9de88b1466a7be5593d6b2c3828b1cb4a2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    path: /etc/ssh/ssh_known_hosts"},{"line_number":6,"context_line":"    line: \"{{ ssh_known_hosts[hostvars[item][\u0027ansible_hostname\u0027]] + \u0027 ssh-rsa \u0027 + hostvars[item][\u0027ansible_ssh_host_key_rsa_public\u0027] }}\""},{"line_number":7,"context_line":"    create: yes"},{"line_number":8,"context_line":"  with_items: \"{{ groups[\u0027overcloud\u0027]|intersect(play_hosts) }}\""},{"line_number":9,"context_line":"  tags:"},{"line_number":10,"context_line":"    - tripleo_ssh_known_hosts"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_b180d44a","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":63},"updated":"2018-08-01 10:25:50.000000000","message":"potential gotcha if all computes are not included in the play but IIUC this is mostly for upgrades where the task should be a no-op","commit_id":"44ed2ea4b8bb0126c5b4a65e7712000d9b9f4655"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"ff3b5f94b41dc734a4865e79f4dc332959867954","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    path: /etc/ssh/ssh_known_hosts"},{"line_number":6,"context_line":"    line: \"{{ ssh_known_hosts[hostvars[item][\u0027ansible_hostname\u0027]] + \u0027 ssh-rsa \u0027 + hostvars[item][\u0027ansible_ssh_host_key_rsa_public\u0027] }}\""},{"line_number":7,"context_line":"    create: yes"},{"line_number":8,"context_line":"  with_items: \"{{ groups[\u0027overcloud\u0027]|intersect(play_hosts) }}\""},{"line_number":9,"context_line":"  tags:"},{"line_number":10,"context_line":"    - tripleo_ssh_known_hosts"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_0df374a0","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":63},"in_reply_to":"3f79a3b5_3b1ea90c","updated":"2018-08-06 10:42:58.000000000","message":"But hopefully with \"!\" as the value for --limit, all hosts would still be included.","commit_id":"44ed2ea4b8bb0126c5b4a65e7712000d9b9f4655"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"c704af9e782acfbb913433c711dd5791e58394cd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    path: /etc/ssh/ssh_known_hosts"},{"line_number":6,"context_line":"    line: \"{{ ssh_known_hosts[hostvars[item][\u0027ansible_hostname\u0027]] + \u0027 ssh-rsa \u0027 + hostvars[item][\u0027ansible_ssh_host_key_rsa_public\u0027] }}\""},{"line_number":7,"context_line":"    create: yes"},{"line_number":8,"context_line":"  with_items: \"{{ groups[\u0027overcloud\u0027]|intersect(play_hosts) }}\""},{"line_number":9,"context_line":"  tags:"},{"line_number":10,"context_line":"    - tripleo_ssh_known_hosts"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_3b1ea90c","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":63},"in_reply_to":"3f79a3b5_bb7ab985","updated":"2018-08-06 09:43:35.000000000","message":"Well, this is not something completely correct (it\u0027s something I still need to investigate further), but it seems that when we call \u0027overcloud deploy\u0027 command the --limit parameter is always added: http://logs.openstack.org/49/586249/9/check/tripleo-ci-centos-7-containers-multinode/62dbc1b/logs/undercloud/var/lib/mistral/overcloud/ansible-playbook-command.sh.txt.gz","commit_id":"44ed2ea4b8bb0126c5b4a65e7712000d9b9f4655"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"e246f656da73a9f44745e00ef90a1900a2da7a71","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    path: /etc/ssh/ssh_known_hosts"},{"line_number":6,"context_line":"    line: \"{{ ssh_known_hosts[hostvars[item][\u0027ansible_hostname\u0027]] + \u0027 ssh-rsa \u0027 + hostvars[item][\u0027ansible_ssh_host_key_rsa_public\u0027] }}\""},{"line_number":7,"context_line":"    create: yes"},{"line_number":8,"context_line":"  with_items: \"{{ groups[\u0027overcloud\u0027]|intersect(play_hosts) }}\""},{"line_number":9,"context_line":"  tags:"},{"line_number":10,"context_line":"    - tripleo_ssh_known_hosts"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_b1e53440","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":63},"in_reply_to":"5f7c97a3_b180d44a","updated":"2018-08-01 10:27:25.000000000","message":"NB need to be careful if we use a similar approach for scale-up","commit_id":"44ed2ea4b8bb0126c5b4a65e7712000d9b9f4655"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"557e8219af513c3fa8fa55621ea37c8a85286dea","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    path: /etc/ssh/ssh_known_hosts"},{"line_number":6,"context_line":"    line: \"{{ ssh_known_hosts[hostvars[item][\u0027ansible_hostname\u0027]] + \u0027 ssh-rsa \u0027 + hostvars[item][\u0027ansible_ssh_host_key_rsa_public\u0027] }}\""},{"line_number":7,"context_line":"    create: yes"},{"line_number":8,"context_line":"  with_items: \"{{ groups[\u0027overcloud\u0027]|intersect(play_hosts) }}\""},{"line_number":9,"context_line":"  tags:"},{"line_number":10,"context_line":"    - tripleo_ssh_known_hosts"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_bb7ab985","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":63},"in_reply_to":"5f7c97a3_b1e53440","updated":"2018-08-06 09:30:22.000000000","message":"Yea operations like repeated `overcloud deploy` (either config change or scale up etc.) should not include --limit i think.\n\nThis should be an improvement over current situation either way, so landing.","commit_id":"44ed2ea4b8bb0126c5b4a65e7712000d9b9f4655"}]}