)]}'
{"workbooks/plan_management.yaml":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"7293ce7405fca6561dc8d9cb024fe3f20fde32a0","unresolved":false,"context_lines":[{"line_number":291,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":292,"context_line":"          queue_name: \u003c% $.queue_name %\u003e"},{"line_number":293,"context_line":"          container_suffix: \"_ceph_ansible_fetch_dir\""},{"line_number":294,"context_line":"          swift_tar: \"temporary_dir.tar.gz\""},{"line_number":295,"context_line":"          get_url_parm: SwiftFetchDirGetTempurl"},{"line_number":296,"context_line":"          put_url_parm: SwiftFetchDirPutTempurl"},{"line_number":297,"context_line":"          use_default_templates: true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_177212e4","line":294,"range":{"start_line":294,"start_character":22,"end_line":294,"end_character":35},"updated":"2018-09-18 11:35:58.000000000","message":"why not name this to be explicitly ceph-related?","commit_id":"bdde61dec0ce2882bd9a591acfb94502b27a297e"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"7816ee2b7b2f70c45767adff7f28f9b9af27e92b","unresolved":false,"context_lines":[{"line_number":291,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":292,"context_line":"          queue_name: \u003c% $.queue_name %\u003e"},{"line_number":293,"context_line":"          container_suffix: \"_ceph_ansible_fetch_dir\""},{"line_number":294,"context_line":"          swift_tar: \"temporary_dir.tar.gz\""},{"line_number":295,"context_line":"          get_url_parm: SwiftFetchDirGetTempurl"},{"line_number":296,"context_line":"          put_url_parm: SwiftFetchDirPutTempurl"},{"line_number":297,"context_line":"          use_default_templates: true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_545e3de9","line":294,"range":{"start_line":294,"start_character":22,"end_line":294,"end_character":35},"in_reply_to":"3f79a3b5_177212e4","updated":"2018-09-18 17:59:46.000000000","message":"The name of the container it will be in will be Ceph specific. I didn\u0027t insert \"ceph\" into the file name in order to more closely follow the name that was being used in Queens.\n\nAs per line 111 of files.py [1], Queens used the same name except it also inserted a timepstamp. Rocky won\u0027t use the timestamp and during upgrade I need a follow up change to rename the file on upgrade from Queens to Rocky and then temporary_dir.tar.gz will always refer to the latest. \n\n[1] https://github.com/openstack/tripleo-common/blob/master/tripleo_common/actions/files.py#L111","commit_id":"bdde61dec0ce2882bd9a591acfb94502b27a297e"}],"workbooks/swift_backup.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"c7fa59e5f7e7878946e8124a252ac01b75c5996d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        action: tripleo.parameters.update"},{"line_number":41,"context_line":"        input:"},{"line_number":42,"context_line":"          parameters:"},{"line_number":43,"context_line":"            SwiftRingGetTempurl: \u003c% task(get_tempurl).result %\u003e"},{"line_number":44,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":45,"context_line":"        on-success: put_tempurl"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_7460bd0e","line":43,"updated":"2018-08-28 21:02:57.000000000","message":"This still needs generalization","commit_id":"604ed5e709d39dd102caf0a1d6db79ea63d8dccf"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"c7fa59e5f7e7878946e8124a252ac01b75c5996d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        action: tripleo.parameters.update"},{"line_number":57,"context_line":"        input:"},{"line_number":58,"context_line":"          parameters:"},{"line_number":59,"context_line":"            SwiftRingPutTempurl: \u003c% task(put_tempurl).result %\u003e"},{"line_number":60,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":61,"context_line":"        on-success: set_status_success"},{"line_number":62,"context_line":"        on-error: set_put_tempurl_failed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_b47df5b3","line":59,"updated":"2018-08-28 21:02:57.000000000","message":"This still needs generalization","commit_id":"604ed5e709d39dd102caf0a1d6db79ea63d8dccf"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"44762a6d66334c308fd31a8ad6494602962a3db1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        action: tripleo.parameters.update"},{"line_number":41,"context_line":"        input:"},{"line_number":42,"context_line":"          parameters:"},{"line_number":43,"context_line":"            SwiftRingGetTempurl: \u003c% task(get_tempurl).result %\u003e"},{"line_number":44,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":45,"context_line":"        on-success: put_tempurl"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_6a869816","line":43,"updated":"2018-08-28 22:09:12.000000000","message":"need to generalize this so I can have SwiftCephAnsibleFetchGetTempURL","commit_id":"8641553b938560d6d55b2e155252c294b68758c9"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"44762a6d66334c308fd31a8ad6494602962a3db1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        action: tripleo.parameters.update"},{"line_number":57,"context_line":"        input:"},{"line_number":58,"context_line":"          parameters:"},{"line_number":59,"context_line":"            SwiftRingPutTempurl: \u003c% task(put_tempurl).result %\u003e"},{"line_number":60,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":61,"context_line":"        on-success: set_status_success"},{"line_number":62,"context_line":"        on-error: set_put_tempurl_failed"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_ca748c39","line":59,"updated":"2018-08-28 22:09:12.000000000","message":"need to generalize this so I can have SwiftCephAnsibleFetchPutTempURL","commit_id":"8641553b938560d6d55b2e155252c294b68758c9"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9cce5bfe16f701b9b464a5ebfa2979788f23189c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        action: tripleo.parameters.update"},{"line_number":43,"context_line":"        input:"},{"line_number":44,"context_line":"          parameters:"},{"line_number":45,"context_line":"            \u003c% $.get_url_parm %\u003e: \u003c% task(get_tempurl).result %\u003e"},{"line_number":46,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":47,"context_line":"        on-success: put_tempurl"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_1a2119a0","line":45,"updated":"2018-08-31 22:43:15.000000000","message":"This will likely fail so I suspect I\u0027ll have this task\nexecuted only if swift, with hard coded Swift URL, OR another task executed only if ceph. \n\nhttps://github.com/openstack/tripleo-common/blob/master/setup\nhttps://github.com/openstack/tripleo-common/blob/master/tripleo_common/actions/parameters.py#L125","commit_id":"5e6e46445c74c2dfc4cbf16377fef45cfe6f2d0b"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"692f7cb874c12dcba22cfbcfc6b16f510b12aa10","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        action: tripleo.parameters.update"},{"line_number":43,"context_line":"        input:"},{"line_number":44,"context_line":"          parameters:"},{"line_number":45,"context_line":"            \u003c% $.get_url_parm %\u003e: \u003c% task(get_tempurl).result %\u003e"},{"line_number":46,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":47,"context_line":"        on-success: put_tempurl"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_f6a52e04","line":45,"in_reply_to":"3f79a3b5_1a2119a0","updated":"2018-09-04 15:39:41.000000000","message":"Try this:\n\nparameters: \u003c% {$.get_url_parm \u003d\u003e task(get_tempurl).result} %\u003e","commit_id":"5e6e46445c74c2dfc4cbf16377fef45cfe6f2d0b"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"ac08b9abb1ab63708c927ac51f5009e28b14beeb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        action: tripleo.parameters.update"},{"line_number":43,"context_line":"        input:"},{"line_number":44,"context_line":"          parameters:"},{"line_number":45,"context_line":"            \u003c% $.get_url_parm %\u003e: \u003c% task(get_tempurl).result %\u003e"},{"line_number":46,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":47,"context_line":"        on-success: put_tempurl"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_d92b337f","line":45,"in_reply_to":"3f79a3b5_f6a52e04","updated":"2018-09-07 16:33:48.000000000","message":"Thanks that seemed to work.","commit_id":"5e6e46445c74c2dfc4cbf16377fef45cfe6f2d0b"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"182b7fb22826954d53e2ca336e2022bfb747453d","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"      ceph_fetch_variables:"},{"line_number":31,"context_line":"        publish:"},{"line_number":32,"context_line":"          swift_container: \"\u003c% $.container %\u003e_ceph_ansible_fetch_dir\""},{"line_number":33,"context_line":"          swift_tar: \"temporary_dir.tar.gz\""},{"line_number":34,"context_line":"        on-complete: check_container"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_ef048c80","line":32,"updated":"2018-09-03 13:07:40.000000000","message":"This naming convention is consistent with what\u0027s in queens for the container name: \n\nhttps://review.openstack.org/#/c/567782/14/workbooks/ceph-ansible.yaml","commit_id":"87c596fe352c2487967d1165aae955f801387167"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"182b7fb22826954d53e2ca336e2022bfb747453d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      ceph_fetch_variables:"},{"line_number":31,"context_line":"        publish:"},{"line_number":32,"context_line":"          swift_container: \"\u003c% $.container %\u003e_ceph_ansible_fetch_dir\""},{"line_number":33,"context_line":"          swift_tar: \"temporary_dir.tar.gz\""},{"line_number":34,"context_line":"        on-complete: check_container"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"      check_container:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_af33f461","line":33,"updated":"2018-09-03 13:07:40.000000000","message":"As per line 111 of files.py [1], queens used the same name except it inserted a timepstamp. Rocky won\u0027t use the timestamp and during upgrade we\u0027ll need to rename the file OR make a swift symlink so temporary_dir.tar.gz always refers to the latest.\n\nhttps://review.openstack.org/#/c/567782/14/tripleo_common/actions/files.py","commit_id":"87c596fe352c2487967d1165aae955f801387167"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e74b23670a834ac612c1f017a84329b4a876041e","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"      swift_rings_variables:"},{"line_number":25,"context_line":"        publish:"},{"line_number":26,"context_line":"          swift_container: \"\u003c% $.container %\u003e-swift-rings\""},{"line_number":27,"context_line":"          swift_tar: \"swift-rings.tar.gz\""},{"line_number":28,"context_line":"        on-complete: check_container"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_616c0136","line":26,"updated":"2018-09-04 12:59:50.000000000","message":"I think we could make these input parameters for the workflow with swift-rings defaults ... and override them from the caller when doing ceph-fetch?\n\nThis is so that we avid \"task_switch_variables\"; this can be done in a followup where we try to parametrize the urls as well","commit_id":"16bddc84d6871279c47efbe09ec935a3e6f14be9"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"08a1f1f2990d1dfc91e00afb133ea737321f57be","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"      swift_rings_variables:"},{"line_number":25,"context_line":"        publish:"},{"line_number":26,"context_line":"          swift_container: \"\u003c% $.container %\u003e-swift-rings\""},{"line_number":27,"context_line":"          swift_tar: \"swift-rings.tar.gz\""},{"line_number":28,"context_line":"        on-complete: check_container"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_7ad026f8","line":26,"in_reply_to":"3f79a3b5_616c0136","updated":"2018-09-04 14:23:57.000000000","message":"OK, let\u0027s try to land this to solve the bug quickly but work on a follow up patch. The follow up patch will need a way to deal with keys in a map which are mistral variables.\n\nhttps://review.openstack.org/#/c/597221/3..6/workbooks/swift_backup.yaml","commit_id":"16bddc84d6871279c47efbe09ec935a3e6f14be9"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"ac08b9abb1ab63708c927ac51f5009e28b14beeb","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"      swift_rings_variables:"},{"line_number":25,"context_line":"        publish:"},{"line_number":26,"context_line":"          swift_container: \"\u003c% $.container %\u003e-swift-rings\""},{"line_number":27,"context_line":"          swift_tar: \"swift-rings.tar.gz\""},{"line_number":28,"context_line":"        on-complete: check_container"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_99085b27","line":26,"in_reply_to":"3f79a3b5_7ad026f8","updated":"2018-09-07 16:33:48.000000000","message":"Just wrapping up the review. We were able to address this in this submission.","commit_id":"16bddc84d6871279c47efbe09ec935a3e6f14be9"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@redhat.com","username":"cschwede"},"change_message_id":"c75f43917def6c3f4d65858ce74f0955c21b7fd7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"          swift_tar: \"temporary_dir.tar.gz\""},{"line_number":34,"context_line":"        on-complete: check_container"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"      check_container:"},{"line_number":37,"context_line":"        workflow: tripleo.swift.v1.container_exists container\u003d\u003c% $.swift_container %\u003e"},{"line_number":38,"context_line":"        input:"},{"line_number":39,"context_line":"          create_container: true"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_3dd84f50","line":36,"updated":"2018-09-05 11:37:13.000000000","message":"Could you try to do remove this? The tempurl action will also create a container; might be a race condition here","commit_id":"16bddc84d6871279c47efbe09ec935a3e6f14be9"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"d2e15ddfa83f565cf6d8628e7ebb3af5b36fcc32","unresolved":false,"context_lines":[{"line_number":33,"context_line":"          swift_tar: \"temporary_dir.tar.gz\""},{"line_number":34,"context_line":"        on-complete: check_container"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"      check_container:"},{"line_number":37,"context_line":"        workflow: tripleo.swift.v1.container_exists container\u003d\u003c% $.swift_container %\u003e"},{"line_number":38,"context_line":"        input:"},{"line_number":39,"context_line":"          create_container: true"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_a77f42dd","line":36,"in_reply_to":"3f79a3b5_3dd84f50","updated":"2018-09-07 02:03:16.000000000","message":"Yes, removed in patch set 7. Let\u0027s see if I get a 401 again when posting in the CI for this review https://review.openstack.org/#/c/582811","commit_id":"16bddc84d6871279c47efbe09ec935a3e6f14be9"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"11a5036c4209c4ce96d448d484331262bd7870c1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"          swift_tar: \"temporary_dir.tar.gz\""},{"line_number":34,"context_line":"        on-complete: check_container"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"      check_container:"},{"line_number":37,"context_line":"        workflow: tripleo.swift.v1.container_exists container\u003d\u003c% $.swift_container %\u003e"},{"line_number":38,"context_line":"        input:"},{"line_number":39,"context_line":"          create_container: true"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_42e640b2","line":36,"in_reply_to":"3f79a3b5_a77f42dd","updated":"2018-09-08 16:21:52.000000000","message":"Christian,\n\nThanks for the suggestion. I removed it and now I am getting a 201 when PUT\u0027ing to the temp pur url [1]. Looking forward to your review of this submission.\n\n  John\n\n[1] http://logs.openstack.org/11/582811/25/check/tripleo-ci-centos-7-scenario004-multinode-oooq-container/31c82b9/logs/undercloud/var/lib/mistral/overcloud/ansible.log.txt.gz#_2018-09-07_18_52_53_839","commit_id":"16bddc84d6871279c47efbe09ec935a3e6f14be9"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"7293ce7405fca6561dc8d9cb024fe3f20fde32a0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    input:"},{"line_number":12,"context_line":"      - container"},{"line_number":13,"context_line":"      - queue_name: tripleo"},{"line_number":14,"context_line":"      - container_suffix: \"-swift-rings\""},{"line_number":15,"context_line":"      - swift_tar: \"swift-rings.tar.gz\""},{"line_number":16,"context_line":"      - get_url_parm: SwiftRingGetTempurl"},{"line_number":17,"context_line":"      - put_url_parm: SwiftRingPutTempurl"},{"line_number":18,"context_line":"    tags:"},{"line_number":19,"context_line":"      - tripleo-common-managed"},{"line_number":20,"context_line":"    tasks:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_175bf253","line":17,"range":{"start_line":14,"start_character":6,"end_line":17,"end_character":41},"updated":"2018-09-18 11:35:58.000000000","message":"might want to get rid of these defaults if we always expect users to pass them. which is what\u0027s happening right now.","commit_id":"bdde61dec0ce2882bd9a591acfb94502b27a297e"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9b15fae754d38c00498dfecea013d9eb18af4d97","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      set_get_tempurl:"},{"line_number":35,"context_line":"        action: tripleo.parameters.update"},{"line_number":36,"context_line":"        input:"},{"line_number":37,"context_line":"          parameters: \u003c% {$.get_url_parm \u003d\u003e task(get_tempurl).result} %\u003e"},{"line_number":38,"context_line":"          container: \u003c% $.container %\u003e"},{"line_number":39,"context_line":"        on-success: put_tempurl"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_3656f45d","line":37,"updated":"2018-09-07 16:22:03.000000000","message":"Thanks d0ugal, \n\nThis seemed to work because in tripleo-ci-centos-7-scenario001-multinode-oooq-container in the executor.log.1 [1] I see the SwiftFetchDirGetTempurl got set:\n\n\n[fultonj@skagra mistral]$ grep GetTempurl executor.log.1 | tail -1 | jq . | grep GetTempurl \n    \"SwiftFetchDirGetTempurl\": \"http://192.168.24.1:8080/v1/AUTH_cb931712e3224d66a9622f004ed8d53f/overcloud_ceph_ansible_fetch_dir/temporary_dir.tar.gz?temp_url_sig\u003db88c49cf947b081e728b08b41ec5a439f548aa64\u0026temp_url_expires\u003d1536410496\",\n    \"SwiftRingGetTempurl\": \"http://192.168.24.1:8080/v1/AUTH_cb931712e3224d66a9622f004ed8d53f/overcloud-swift-rings/swift-rings.tar.gz?temp_url_sig\u003d6ed0b0494d8897bff4f1736574d94e91b371525b\u0026temp_url_expires\u003d1536410432\",\n[fultonj@skagra mistral]$\n\n\n[1] http://logs.openstack.org/21/597221/8/check/tripleo-ci-centos-7-scenario001-multinode-oooq-container/dd99eeb/logs/undercloud/var/log/containers/mistral/","commit_id":"bdde61dec0ce2882bd9a591acfb94502b27a297e"}]}