)]}'
{"tripleo_common/image/kolla_builder.py":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"71d71d299431771bb9667f148e09228372d40814","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import jinja2"},{"line_number":18,"context_line":"import logging"},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import re"},{"line_number":21,"context_line":"import subprocess"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ef26ccba","line":18,"updated":"2018-09-03 12:35:19.000000000","message":"better to replace to \u0027from oslo_log import log as logging\u0027","commit_id":"1ba45e70b8fb85e20da291ed7049a00e406244c8"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"aab85e50e257cb4b30038e60f0548523a03c32b2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":"import tempfile"},{"line_number":24,"context_line":"import time"},{"line_number":25,"context_line":"import yaml"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from tripleo_common.image import base"},{"line_number":28,"context_line":"from tripleo_common.image import image_uploader"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9c07541e","line":25,"updated":"2018-09-03 12:33:31.000000000","message":"from oslo_log import log as logging","commit_id":"1ba45e70b8fb85e20da291ed7049a00e406244c8"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ac2bba22c79e2b8124905e749b15cb759c66a787","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                     \u0027overcloud_containers.yaml.j2\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":68,"context_line":"handler \u003d logging.StreamHandler(sys.stdout)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_45659f1c","line":67,"updated":"2018-09-12 16:06:27.000000000","message":"shouldn\u0027t that also be  + \u0027.KollaImageBuilder\u0027 ?","commit_id":"f548369641945ecb8de90e7b7b1c41d2a247d1ac"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ac2bba22c79e2b8124905e749b15cb759c66a787","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    pd \u003d environment.get(\u0027parameter_defaults\u0027, {})"},{"line_number":132,"context_line":"    cip \u003d pd.get(\u0027ContainerImagePrepare\u0027)"},{"line_number":133,"context_line":"    if not cip:"},{"line_number":134,"context_line":"        LOG.info(\"No ContainerImagePrepare parameter defined.\")"},{"line_number":135,"context_line":"        return"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    env_params \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_65a8db1f","line":134,"updated":"2018-09-12 16:06:27.000000000","message":"nit: please use _()","commit_id":"f548369641945ecb8de90e7b7b1c41d2a247d1ac"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"9b64eff77f2f84470297c59bf20c1910fc4dffda","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        process \u003d subprocess.Popen(cmd, env\u003denv, stdout\u003dsubprocess.PIPE)"},{"line_number":439,"context_line":"        out, err \u003d process.communicate()"},{"line_number":440,"context_line":"        if process.returncode !\u003d 0:"},{"line_number":441,"context_line":"            raise subprocess.CalledProcessError(process.returncode, cmd, err)"},{"line_number":442,"context_line":"        return out"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_65c2c255","line":441,"updated":"2018-09-04 18:54:52.000000000","message":"nit: Can we also add log for process error when process is terminated with return code?","commit_id":"f548369641945ecb8de90e7b7b1c41d2a247d1ac"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"9b64eff77f2f84470297c59bf20c1910fc4dffda","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        out, err \u003d process.communicate()"},{"line_number":440,"context_line":"        if process.returncode !\u003d 0:"},{"line_number":441,"context_line":"            raise subprocess.CalledProcessError(process.returncode, cmd, err)"},{"line_number":442,"context_line":"        return out"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c5a636c1","line":442,"updated":"2018-09-04 18:54:52.000000000","message":"nit: Can we add log for process result info?","commit_id":"f548369641945ecb8de90e7b7b1c41d2a247d1ac"}]}