)]}'
{"tripleo_common/image/image_uploader.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"01ee93cc5d4197739c44667af096f7d97ec99792","unresolved":false,"context_lines":[{"line_number":51,"context_line":"if \u0027no_verify_registry\u0027 in os.environ:"},{"line_number":52,"context_line":"    NO_VERIFY_REGISTRIES \u003d os.environ[\u0027no_verify_registry\u0027].split(\u0027,\u0027)"},{"line_number":53,"context_line":"else:"},{"line_number":54,"context_line":"    NO_VERIFY_REGISTRIES \u003d ()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"CLEANUP \u003d ("},{"line_number":57,"context_line":"    CLEANUP_FULL, CLEANUP_PARTIAL, CLEANUP_NONE"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_a19da667","line":54,"updated":"2019-03-05 20:53:16.000000000","message":"I would want a very good justification for opening up an environment variable based interface to configure this. Prepare is not only run from the command line, it is also run inside mistral and from ansible.","commit_id":"4f8664a3128949bb18e3dfd0325c019e3be4ee62"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"de25016fecf2640d43126e6d645eacc399dbb136","unresolved":false,"context_lines":[{"line_number":51,"context_line":"if \u0027no_verify_registry\u0027 in os.environ:"},{"line_number":52,"context_line":"    NO_VERIFY_REGISTRIES \u003d os.environ[\u0027no_verify_registry\u0027].split(\u0027,\u0027)"},{"line_number":53,"context_line":"else:"},{"line_number":54,"context_line":"    NO_VERIFY_REGISTRIES \u003d ()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"CLEANUP \u003d ("},{"line_number":57,"context_line":"    CLEANUP_FULL, CLEANUP_PARTIAL, CLEANUP_NONE"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_c01b0371","line":54,"in_reply_to":"5fc1f717_a19da667","updated":"2019-03-06 06:25:30.000000000","message":"So apparently my internal review hard-coding the internal registry doesn\u0027t make ppl happy, and I was requested to make this var configurable :/. If you have another way, I\u0027d be really happy - not convinced myself on this specific thing.","commit_id":"4f8664a3128949bb18e3dfd0325c019e3be4ee62"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"01ee93cc5d4197739c44667af096f7d97ec99792","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        return session"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    @classmethod"},{"line_number":351,"context_line":"    def _build_url(cls, url, path, self\u003dNone):"},{"line_number":352,"context_line":"        netloc \u003d url.netloc"},{"line_number":353,"context_line":"        if self is not None:"},{"line_number":354,"context_line":"            obj \u003d self"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_a12046f9","line":351,"updated":"2019-03-05 20:53:16.000000000","message":"I don\u0027t understand why this is required. These class attributes are created at the class level then never replaced at the instance level. So calling self._build_url should be identical to calling cls._build_url","commit_id":"4f8664a3128949bb18e3dfd0325c019e3be4ee62"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"de25016fecf2640d43126e6d645eacc399dbb136","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        return session"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    @classmethod"},{"line_number":351,"context_line":"    def _build_url(cls, url, path, self\u003dNone):"},{"line_number":352,"context_line":"        netloc \u003d url.netloc"},{"line_number":353,"context_line":"        if self is not None:"},{"line_number":354,"context_line":"            obj \u003d self"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_a0511711","line":351,"in_reply_to":"5fc1f717_a12046f9","updated":"2019-03-06 06:25:30.000000000","message":"During my tests with hard-coding the registry in the NO_VERIFY_REGISTRIES, I saw it didn\u0027t take it into account until I used \"self\" whenever it was possible :/.","commit_id":"4f8664a3128949bb18e3dfd0325c019e3be4ee62"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"7f7dfdb3e179b9fb093fda5d91a130fb8c7e7fa7","unresolved":false,"context_lines":[{"line_number":310,"context_line":"    def authenticate(self, image_url, username\u003dNone, password\u003dNone):"},{"line_number":311,"context_line":"        netloc \u003d image_url.netloc"},{"line_number":312,"context_line":"        image, tag \u003d self._image_tag_from_url(image_url)"},{"line_number":313,"context_line":"        self.is_insecure_registry(netloc)"},{"line_number":314,"context_line":"        url \u003d self._build_url(image_url, path\u003d\u0027/\u0027)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        session \u003d requests.Session()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_b382b74e","line":313,"updated":"2019-03-07 07:21:44.000000000","message":"Damn... this function is quite misleading. So it not only checks if a registry is insecure, it also adds stuff to the lists of secure/insecure registries. Might wanna rename it.","commit_id":"4bd2857e87e88aca2dd64ad5178f781c31f3e609"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"8859a9419d495624007ff3e9b25739f9bb52f9a0","unresolved":false,"context_lines":[{"line_number":310,"context_line":"    def authenticate(self, image_url, username\u003dNone, password\u003dNone):"},{"line_number":311,"context_line":"        netloc \u003d image_url.netloc"},{"line_number":312,"context_line":"        image, tag \u003d self._image_tag_from_url(image_url)"},{"line_number":313,"context_line":"        self.is_insecure_registry(netloc)"},{"line_number":314,"context_line":"        url \u003d self._build_url(image_url, path\u003d\u0027/\u0027)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        session \u003d requests.Session()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_930e9be3","line":313,"in_reply_to":"5fc1f717_b382b74e","updated":"2019-03-07 07:27:50.000000000","message":"Not really imho. If a certificate is invalid, it IS insecure.","commit_id":"4bd2857e87e88aca2dd64ad5178f781c31f3e609"}]}
