)]}'
{"healthcheck/zaqar-socket":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"663c89e65d4a32b74437685aa045aca3274215b4","unresolved":false,"context_lines":[{"line_number":3,"context_line":". ${HEALTHCHECK_SCRIPTS:-/usr/share/openstack-tripleo-common/healthcheck}/common.sh"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"process\u003dzaqar-server"},{"line_number":6,"context_line":"args\u003d\"${@:-9000}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if healthcheck_listen $process $args; then"},{"line_number":9,"context_line":"  exit 0"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ffb9cba7_51e21431","line":6,"updated":"2019-04-26 13:28:39.000000000","message":"if SSL is disabled, I think the port is 8888 - how the healthcheck will now? In your patch I don\u0027t see any args:\n\nhttps://review.opendev.org/#/c/655901/1/deployment/zaqar/zaqar-container-puppet.yaml","commit_id":"4f5a275086a6fab538a69bfdb74e002489d7e599"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"5962e7c869bbe98281061e209b9e58a4998a0d80","unresolved":false,"context_lines":[{"line_number":3,"context_line":". ${HEALTHCHECK_SCRIPTS:-/usr/share/openstack-tripleo-common/healthcheck}/common.sh"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"process\u003dzaqar-server"},{"line_number":6,"context_line":"args\u003d\"${@:-9000}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if healthcheck_listen $process $args; then"},{"line_number":9,"context_line":"  exit 0"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ffb9cba7_1109fcdb","line":6,"in_reply_to":"ffb9cba7_315520c7","updated":"2019-04-26 13:35:55.000000000","message":"still, we want the defaults to match what it is set to in heat right? Should it default to 8888?","commit_id":"4f5a275086a6fab538a69bfdb74e002489d7e599"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e14555b05bc844ffa221d544d38e65a1560a5ccf","unresolved":false,"context_lines":[{"line_number":3,"context_line":". ${HEALTHCHECK_SCRIPTS:-/usr/share/openstack-tripleo-common/healthcheck}/common.sh"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"process\u003dzaqar-server"},{"line_number":6,"context_line":"args\u003d\"${@:-9000}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if healthcheck_listen $process $args; then"},{"line_number":9,"context_line":"  exit 0"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ffb9cba7_315520c7","line":6,"in_reply_to":"ffb9cba7_51e21431","updated":"2019-04-26 13:33:39.000000000","message":"hmm, -1 should be on the pointed change, not the current one. Have to add some \"if\" voodoo on the t-h-t change.","commit_id":"4f5a275086a6fab538a69bfdb74e002489d7e599"}]}