)]}'
{"roles/tripleo-hieradata/README.md":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"18bc97546a3df0b5722ca06b982161c91107b83d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Required:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* `hieradata_template` -- path to template of hieradata content"},{"line_number":12,"context_line":"* `variable_start_string` -- string marking the beginning of a template print statement."},{"line_number":13,"context_line":"* `variable_end_string` -- string marking the end of a template print statement."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":4,"id":"bfb3d3c7_e25ca37f","line":11,"updated":"2019-05-23 10:10:23.000000000","message":"please also document for hieradata_file","commit_id":"ac94ffe5337b0ccd5cfcd22ab1f5803aa64aa1d1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c07771e0b948c4ce6b0e0c8363137fda8ef8420e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Required:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* `hieradata_template` -- path to template of hieradata content"},{"line_number":12,"context_line":"* `variable_start_string` -- string marking the beginning of a template print statement."},{"line_number":13,"context_line":"* `variable_end_string` -- string marking the end of a template print statement."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test playbook"}],"source_content_type":"text/x-gfm","patch_set":4,"id":"bfb3d3c7_82728710","line":12,"updated":"2019-05-23 10:09:54.000000000","message":"nit: that\u0027s hieradata_*","commit_id":"ac94ffe5337b0ccd5cfcd22ab1f5803aa64aa1d1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c07771e0b948c4ce6b0e0c8363137fda8ef8420e","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* `hieradata_template` -- path to template of hieradata content"},{"line_number":12,"context_line":"* `variable_start_string` -- string marking the beginning of a template print statement."},{"line_number":13,"context_line":"* `variable_end_string` -- string marking the end of a template print statement."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test playbook"},{"line_number":16,"context_line":"-------------"}],"source_content_type":"text/x-gfm","patch_set":4,"id":"bfb3d3c7_22639b44","line":13,"updated":"2019-05-23 10:09:54.000000000","message":"ditto","commit_id":"ac94ffe5337b0ccd5cfcd22ab1f5803aa64aa1d1"}],"roles/tripleo-hieradata/defaults/main.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3828473c21d11fd3820dd8e030ff03d7f911c246","unresolved":false,"context_lines":[{"line_number":1,"context_line":"hieradata_template: \"\""},{"line_number":2,"context_line":"hieradata_file: \"\""},{"line_number":3,"context_line":"variable_start_string: \"{{\""},{"line_number":4,"context_line":"variable_end_string: \"}}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_e0399fd6","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":19},"updated":"2019-05-15 15:18:44.000000000","message":"isn\u0027t those supposed to be hieradata_* prefixed?","commit_id":"4ef5e28b4bd5c9cbec44a35e4ff65a9bf4de8f15"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"96940a1b03b58fb580c4e485ec8b48c1172e4c94","unresolved":false,"context_lines":[{"line_number":1,"context_line":"hieradata_template: \"\""},{"line_number":2,"context_line":"hieradata_file: \"\""},{"line_number":3,"context_line":"variable_start_string: \"{{\""},{"line_number":4,"context_line":"variable_end_string: \"}}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfb3d3c7_36654fb6","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":19},"in_reply_to":"dfbec78f_e0399fd6","updated":"2019-05-21 09:16:06.000000000","message":"I may be wrong, but instead variable_end_string et al, these need to be named hieradata_variable_end_string, isn\u0027t it?","commit_id":"4ef5e28b4bd5c9cbec44a35e4ff65a9bf4de8f15"}],"roles/tripleo-hieradata/tasks/main.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3828473c21d11fd3820dd8e030ff03d7f911c246","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    src: \"{{ hieradata_template }}\""},{"line_number":13,"context_line":"    dest: \"{{ hieradata_template ~ \u0027.rendered\u0027 }}\""},{"line_number":14,"context_line":"    variable_start_string: \"{{ hieradata_variable_start_string }}\""},{"line_number":15,"context_line":"    variable_end_string: \"{{ hieradata_variable_end_string }}\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Copy hieradata files"},{"line_number":18,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_803463df","line":15,"range":{"start_line":15,"start_character":29,"end_line":15,"end_character":58},"updated":"2019-05-15 15:18:44.000000000","message":"^^","commit_id":"4ef5e28b4bd5c9cbec44a35e4ff65a9bf4de8f15"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b611e59d1c0930846c6c6b264ccbfe9508a59d69","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  template:"},{"line_number":12,"context_line":"    src: \"{{ hieradata_template }}\""},{"line_number":13,"context_line":"    dest: \"{{ hieradata_template ~ \u0027.rendered\u0027 }}\""},{"line_number":14,"context_line":"    variable_start_string: \"{{ hieradata_variable_start_string }}\""},{"line_number":15,"context_line":"    variable_end_string: \"{{ hieradata_variable_end_string }}\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Copy hieradata files"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bfb3d3c7_566d6396","line":14,"range":{"start_line":14,"start_character":31,"end_line":14,"end_character":61},"updated":"2019-05-21 09:17:02.000000000","message":"what is this war? isn\u0027t there is only variable_start_string defined for it?","commit_id":"748208014c62e13f09fea99f7d685138fe131f84"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"7e94bc8887b56059211a0ec11752721b9fbb0688","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  template:"},{"line_number":12,"context_line":"    src: \"{{ hieradata_template }}\""},{"line_number":13,"context_line":"    dest: \"{{ hieradata_template ~ \u0027.rendered\u0027 }}\""},{"line_number":14,"context_line":"    variable_start_string: \"{{ hieradata_variable_start_string }}\""},{"line_number":15,"context_line":"    variable_end_string: \"{{ hieradata_variable_end_string }}\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Copy hieradata files"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bfb3d3c7_533eb1da","line":14,"range":{"start_line":14,"start_character":31,"end_line":14,"end_character":61},"in_reply_to":"bfb3d3c7_566d6396","updated":"2019-05-22 17:44:36.000000000","message":"your comments on the previous PS are correct, i need to fix the name in defaults/main.yaml","commit_id":"748208014c62e13f09fea99f7d685138fe131f84"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b611e59d1c0930846c6c6b264ccbfe9508a59d69","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    src: \"{{ hieradata_template }}\""},{"line_number":13,"context_line":"    dest: \"{{ hieradata_template ~ \u0027.rendered\u0027 }}\""},{"line_number":14,"context_line":"    variable_start_string: \"{{ hieradata_variable_start_string }}\""},{"line_number":15,"context_line":"    variable_end_string: \"{{ hieradata_variable_end_string }}\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Copy hieradata files"},{"line_number":18,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bfb3d3c7_766ae780","line":15,"updated":"2019-05-21 09:17:02.000000000","message":"ditto","commit_id":"748208014c62e13f09fea99f7d685138fe131f84"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c34090786a743788b16969929e652cfb37da92f6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  file:"},{"line_number":3,"context_line":"    path: /etc/puppet/hieradata"},{"line_number":4,"context_line":"    state: directory"},{"line_number":5,"context_line":"    mode: 0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Template hieradata file"},{"line_number":8,"context_line":"  when: hieradata_template !\u003d \"\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_c6454019","line":5,"updated":"2019-06-03 22:14:00.000000000","message":"do we need selinux contexts for the dir \u0026 files?","commit_id":"ba3891b3382878cdf0c9c1c8b790ce30fe32706a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ba82eac3dfe5bdc55ea43c59bb87ef9745868b95","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  file:"},{"line_number":3,"context_line":"    path: /etc/puppet/hieradata"},{"line_number":4,"context_line":"    state: directory"},{"line_number":5,"context_line":"    mode: 0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Template hieradata file"},{"line_number":8,"context_line":"  when: hieradata_template !\u003d \"\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_6470e8a6","line":5,"in_reply_to":"9fb8cfa7_2413d05e","updated":"2019-06-05 13:59:54.000000000","message":"just checking as we\u0027ve historically had issues with selinux contexts when managing files via ansible.  I thought this was created via packaging but no harm in ensuring it exists","commit_id":"ba3891b3382878cdf0c9c1c8b790ce30fe32706a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"68594ba79b850a45c003c2dc094271c9dc57005a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  file:"},{"line_number":3,"context_line":"    path: /etc/puppet/hieradata"},{"line_number":4,"context_line":"    state: directory"},{"line_number":5,"context_line":"    mode: 0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Template hieradata file"},{"line_number":8,"context_line":"  when: hieradata_template !\u003d \"\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_a49b40c7","line":5,"in_reply_to":"9fb8cfa7_6470e8a6","updated":"2019-06-05 14:00:49.000000000","message":"Actually are we ensuring puppet is installed first? If not this won\u0027t exist and then the context won\u0027t be correct","commit_id":"ba3891b3382878cdf0c9c1c8b790ce30fe32706a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bcad544025ba7fa21c8010b19075aa4f23dbaf9c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  file:"},{"line_number":3,"context_line":"    path: /etc/puppet/hieradata"},{"line_number":4,"context_line":"    state: directory"},{"line_number":5,"context_line":"    mode: 0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Template hieradata file"},{"line_number":8,"context_line":"  when: hieradata_template !\u003d \"\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_581d840d","line":5,"in_reply_to":"9fb8cfa7_a49b40c7","updated":"2019-06-05 14:54:26.000000000","message":"I tried on my host in selinux enforced and it\u0027s all good, I\u0027ve not seen context issue, so let\u0027s merge it.","commit_id":"ba3891b3382878cdf0c9c1c8b790ce30fe32706a"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"2098dffc6bd1ad9ba2244753a7c2a2d60993a761","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  file:"},{"line_number":3,"context_line":"    path: /etc/puppet/hieradata"},{"line_number":4,"context_line":"    state: directory"},{"line_number":5,"context_line":"    mode: 0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Template hieradata file"},{"line_number":8,"context_line":"  when: hieradata_template !\u003d \"\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_58ffc433","line":5,"in_reply_to":"9fb8cfa7_a49b40c7","updated":"2019-06-05 15:10:42.000000000","message":"puppet will get pulled in as a dep by the tripleo-bootstrap role.\n\nwe know that role has been applied before this one. i\u0027m not sure this role will be really usable outside of a tripleo deployment.\n\nbut if we thought it might be, we could add an explicit check to make sure puppet is already installed.","commit_id":"ba3891b3382878cdf0c9c1c8b790ce30fe32706a"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"f7732a79ffc187714babcbac20d89255b95471ef","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  file:"},{"line_number":3,"context_line":"    path: /etc/puppet/hieradata"},{"line_number":4,"context_line":"    state: directory"},{"line_number":5,"context_line":"    mode: 0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Template hieradata file"},{"line_number":8,"context_line":"  when: hieradata_template !\u003d \"\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_2413d05e","line":5,"in_reply_to":"9fb8cfa7_c6454019","updated":"2019-06-05 13:56:20.000000000","message":"by default, it inherits the context from the parent directory. why would we not want to just use the default?\n\neven if we explicitly set the default value here (puppet_etc_t), why would we need to manage that? If the default contexts/policy provided by puppet ever changed, we\u0027d be broken.","commit_id":"ba3891b3382878cdf0c9c1c8b790ce30fe32706a"}],"roles/tripleo-hieradata/test-playbook.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3f62021d6f9ae22b3c81b6d48fe37e2785fdb98c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      vars:"},{"line_number":7,"context_line":"        hieradata_template: hieradata.j2.yaml"},{"line_number":8,"context_line":"        variable_start_string: \"{{\""},{"line_number":9,"context_line":"        variable_end_string: \"}}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_02d537b9","line":9,"updated":"2019-05-23 10:12:15.000000000","message":"these guys have been also left behind","commit_id":"ac94ffe5337b0ccd5cfcd22ab1f5803aa64aa1d1"}]}