)]}'
{"tripleo_common/tests/fake_config/fakes.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"fe0b7cc462f524eb83b07526318b5b7797166ccd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"         \u0027output_value\u0027: {"},{"line_number":32,"context_line":"             \u0027foo_config\u0027: \u0027foo\u0027}},"},{"line_number":33,"context_line":"        {\u0027output_key\u0027: \u0027HostnameNetworkConfigMap\u0027,"},{"line_number":34,"context_line":"         \u0027output_value\u0027: {}},"},{"line_number":35,"context_line":"        {\u0027output_key\u0027: \u0027RoleData\u0027,"},{"line_number":36,"context_line":"         \u0027output_value\u0027: {"},{"line_number":37,"context_line":"             \u0027FakeCompute\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_077aadb8","line":34,"range":{"start_line":34,"start_character":25,"end_line":34,"end_character":27},"updated":"2019-06-14 10:50:10.000000000","message":"nit, would be good to have something here?","commit_id":"0ecdbd575f6c014347b13d4905cb7814ffb451eb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d46a2b86906b0c9d77e80206083adab90bb8bf55","unresolved":false,"context_lines":[{"line_number":31,"context_line":"         \u0027output_value\u0027: {"},{"line_number":32,"context_line":"             \u0027foo_config\u0027: \u0027foo\u0027}},"},{"line_number":33,"context_line":"        {\u0027output_key\u0027: \u0027HostnameNetworkConfigMap\u0027,"},{"line_number":34,"context_line":"         \u0027output_value\u0027: {}},"},{"line_number":35,"context_line":"        {\u0027output_key\u0027: \u0027RoleData\u0027,"},{"line_number":36,"context_line":"         \u0027output_value\u0027: {"},{"line_number":37,"context_line":"             \u0027FakeCompute\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_ddb6a23e","line":34,"range":{"start_line":34,"start_character":25,"end_line":34,"end_character":27},"in_reply_to":"9fb8cfa7_077aadb8","updated":"2019-06-14 12:01:13.000000000","message":"James is on PTO today, I\u0027ll work on it.","commit_id":"0ecdbd575f6c014347b13d4905cb7814ffb451eb"}],"tripleo_common/tests/utils/test_config.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"fe0b7cc462f524eb83b07526318b5b7797166ccd","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                         \u00278b07cd31-3083-4b88-a433-955f72039e2c\u0027,"},{"line_number":302,"context_line":"                         \u0027169b46f8-1965-4d90-a7de-f36fb4a830fe\u0027]}}},"},{"line_number":303,"context_line":"            {\u0027output_key\u0027: \u0027HostnameNetworkConfigMap\u0027,"},{"line_number":304,"context_line":"             \u0027output_value\u0027: {}},"},{"line_number":305,"context_line":"            {\u0027output_key\u0027: \u0027RoleGroupVars\u0027,"},{"line_number":306,"context_line":"             \u0027output_value\u0027: {"},{"line_number":307,"context_line":"                 \u0027Controller\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_87477d77","line":304,"range":{"start_line":304,"start_character":29,"end_line":304,"end_character":31},"updated":"2019-06-14 10:50:10.000000000","message":"Ditto.","commit_id":"0ecdbd575f6c014347b13d4905cb7814ffb451eb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2dc03157753d2a73869df605810371101f2c1452","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                         \u00278b07cd31-3083-4b88-a433-955f72039e2c\u0027,"},{"line_number":302,"context_line":"                         \u0027169b46f8-1965-4d90-a7de-f36fb4a830fe\u0027]}}},"},{"line_number":303,"context_line":"            {\u0027output_key\u0027: \u0027HostnameNetworkConfigMap\u0027,"},{"line_number":304,"context_line":"             \u0027output_value\u0027: {}},"},{"line_number":305,"context_line":"            {\u0027output_key\u0027: \u0027RoleGroupVars\u0027,"},{"line_number":306,"context_line":"             \u0027output_value\u0027: {"},{"line_number":307,"context_line":"                 \u0027Controller\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_bd65eeb6","line":304,"range":{"start_line":304,"start_character":29,"end_line":304,"end_character":31},"in_reply_to":"9fb8cfa7_87477d77","updated":"2019-06-14 12:09:36.000000000","message":"Done","commit_id":"0ecdbd575f6c014347b13d4905cb7814ffb451eb"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"f99e071cfab8aac1a7b2e6e4218d997bd9a45ddc","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                         \u00278b07cd31-3083-4b88-a433-955f72039e2c\u0027,"},{"line_number":302,"context_line":"                         \u0027169b46f8-1965-4d90-a7de-f36fb4a830fe\u0027]}}},"},{"line_number":303,"context_line":"            {\u0027output_key\u0027: \u0027HostnameNetworkConfigMap\u0027,"},{"line_number":304,"context_line":"             \u0027output_value\u0027: {}},"},{"line_number":305,"context_line":"            {\u0027output_key\u0027: \u0027RoleGroupVars\u0027,"},{"line_number":306,"context_line":"             \u0027output_value\u0027: {"},{"line_number":307,"context_line":"                 \u0027Controller\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_2980e0f4","line":304,"range":{"start_line":304,"start_character":29,"end_line":304,"end_character":31},"in_reply_to":"9fb8cfa7_8eeb1276","updated":"2019-06-14 14:56:50.000000000","message":"It\u0027s a nit. A follow up change later can add it.","commit_id":"0ecdbd575f6c014347b13d4905cb7814ffb451eb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f1a3bc122a4dae3975c539a1f4eb64aa6def9981","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                         \u00278b07cd31-3083-4b88-a433-955f72039e2c\u0027,"},{"line_number":302,"context_line":"                         \u0027169b46f8-1965-4d90-a7de-f36fb4a830fe\u0027]}}},"},{"line_number":303,"context_line":"            {\u0027output_key\u0027: \u0027HostnameNetworkConfigMap\u0027,"},{"line_number":304,"context_line":"             \u0027output_value\u0027: {}},"},{"line_number":305,"context_line":"            {\u0027output_key\u0027: \u0027RoleGroupVars\u0027,"},{"line_number":306,"context_line":"             \u0027output_value\u0027: {"},{"line_number":307,"context_line":"                 \u0027Controller\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_8eeb1276","line":304,"range":{"start_line":304,"start_character":29,"end_line":304,"end_character":31},"in_reply_to":"9fb8cfa7_bd65eeb6","updated":"2019-06-14 14:38:55.000000000","message":"I started to look at it and it\u0027s a bit more complex to mock out. Probably James is the best person to write tests for the new format. I wonder if we can add unit tests later, I would be fine with it now.","commit_id":"0ecdbd575f6c014347b13d4905cb7814ffb451eb"}],"tripleo_common/utils/config.py":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"82aab3eb12a83f99d816b2bc395f967a83524961","unresolved":false,"context_lines":[{"line_number":495,"context_line":"                server_deployment_dir, \"NetworkConfig\")"},{"line_number":496,"context_line":"            s_config \u003d self.client.software_configs.get(config)"},{"line_number":497,"context_line":"            with open(network_config_path, \u0027w\u0027) as f:"},{"line_number":498,"context_line":"                f.write(s_config.config)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"        shutil.copyfile("},{"line_number":501,"context_line":"            os.path.join(templates_path, \u0027deployments.yaml\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fb8cfa7_a9ba90bd","line":498,"updated":"2019-06-14 14:57:44.000000000","message":"Please follow up with unit tests that exercise this bit of code","commit_id":"85b7a4eea5c9a36f5a4d2bc4bef5836e2338ab8d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"3c5cfc34c410c0a322c632b2649875826a4ce0a3","unresolved":false,"context_lines":[{"line_number":495,"context_line":"                server_deployment_dir, \"NetworkConfig\")"},{"line_number":496,"context_line":"            s_config \u003d self.client.software_configs.get(config)"},{"line_number":497,"context_line":"            with open(network_config_path, \u0027w\u0027) as f:"},{"line_number":498,"context_line":"                f.write(s_config.config)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"        shutil.copyfile("},{"line_number":501,"context_line":"            os.path.join(templates_path, \u0027deployments.yaml\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fb8cfa7_413e488b","line":498,"in_reply_to":"9fb8cfa7_a9ba90bd","updated":"2019-07-01 21:06:52.000000000","message":"https://review.opendev.org/#/c/668560","commit_id":"85b7a4eea5c9a36f5a4d2bc4bef5836e2338ab8d"}]}