)]}'
{"tripleo_common/utils/config.py":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"24a2cf33e80ff6036c0417f98788e7becf94b45a","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        for config_name, config in six.iteritems(role_config):"},{"line_number":248,"context_line":"            conf_path \u003d os.path.join(config_dir, config_name)"},{"line_number":249,"context_line":"            # Add .yaml extension only if there\u0027s no extension already"},{"line_number":250,"context_line":"            if \u0027.\u0027 not in conf_path:"},{"line_number":251,"context_line":"                conf_path \u003d conf_path + \".yaml\""},{"line_number":252,"context_line":"            with self._open_file(conf_path) as conf_file:"},{"line_number":253,"context_line":"                if isinstance(config, list) or isinstance(config, dict):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_7d9851bf","line":250,"updated":"2019-06-07 10:24:39.000000000","message":"nit: perhaps it should be\n\nif \u0027.yaml\u0027 not in ...","commit_id":"f1e5cfdc910845dbb5c8a215963cfe33c0a2f497"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"2e8ebc6d16c2212c23e1fc8d287c23b74e813d49","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        for config_name, config in six.iteritems(role_config):"},{"line_number":248,"context_line":"            conf_path \u003d os.path.join(config_dir, config_name)"},{"line_number":249,"context_line":"            # Add .yaml extension only if there\u0027s no extension already"},{"line_number":250,"context_line":"            if \u0027.\u0027 not in conf_path:"},{"line_number":251,"context_line":"                conf_path \u003d conf_path + \".yaml\""},{"line_number":252,"context_line":"            with self._open_file(conf_path) as conf_file:"},{"line_number":253,"context_line":"                if isinstance(config, list) or isinstance(config, dict):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_c63baee8","line":250,"in_reply_to":"9fb8cfa7_7d9851bf","updated":"2019-06-07 13:50:28.000000000","message":"I agree with Bogdan the dot may be part of name such as\na.b.c.yaml\nit would be better to do something like\nif not conf_path.endswith(\u0027.yaml\u0027):\nor\nif not re.search(r\u0027( \u0027.yaml$\u0027, conf_path, re.M|re.I):","commit_id":"f1e5cfdc910845dbb5c8a215963cfe33c0a2f497"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a42afdbb8042fcc700831487c75a4fca6e517a8f","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        for config_name, config in six.iteritems(role_config):"},{"line_number":248,"context_line":"            conf_path \u003d os.path.join(config_dir, config_name)"},{"line_number":249,"context_line":"            # Add .yaml extension only if there\u0027s no extension already"},{"line_number":250,"context_line":"            if \u0027.\u0027 not in conf_path:"},{"line_number":251,"context_line":"                conf_path \u003d conf_path + \".yaml\""},{"line_number":252,"context_line":"            with self._open_file(conf_path) as conf_file:"},{"line_number":253,"context_line":"                if isinstance(config, list) or isinstance(config, dict):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_31dbe21b","line":250,"in_reply_to":"9fb8cfa7_c63baee8","updated":"2019-06-07 14:15:57.000000000","message":"So the goal here is to not look for .yaml but rather if there is an extension, don\u0027t bother adding one.  The point is to allow a .json or .sh and if there\u0027s a dot, assume an extension exists. Yea it\u0027s not ideal but we don\u0027t want to be in the business of writing out all the possible extensions here.  The likelihood that we have something.filename without an extension and assuming it should magically get the .yaml is probably small.  Generally folks use - or _ in filenames as separators and not .","commit_id":"f1e5cfdc910845dbb5c8a215963cfe33c0a2f497"}]}