)]}'
{"tripleo_common/actions/baremetal_deploy.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3929393f200e3cbcddc4b9839dae2373a6f154e8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        found \u003d []"},{"line_number":113,"context_line":"        for request in self.instances:"},{"line_number":114,"context_line":"            if \u0027hostname\u0027 not in request:"},{"line_number":115,"context_line":"                continue"},{"line_number":116,"context_line":"            try:"},{"line_number":117,"context_line":"                instance \u003d provisioner.show_instance(request[\u0027hostname\u0027])"},{"line_number":118,"context_line":"            # TODO(dtantsur): replace Error with a specific exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_5e682bf4","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":24},"updated":"2019-07-08 08:18:05.000000000","message":"Shouldn\u0027t we use the generated hostname here? Otherwise scaling up won\u0027t be possible for instances without hostname, we will try to deploy more instances each time.","commit_id":"c35aa14ed68e2be55c75ede3853c2f0f9acefec9"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9d63ef3078e73a3008438d9c1f54b2818e5d03a2","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        found \u003d []"},{"line_number":113,"context_line":"        for request in self.instances:"},{"line_number":114,"context_line":"            if \u0027hostname\u0027 not in request:"},{"line_number":115,"context_line":"                continue"},{"line_number":116,"context_line":"            try:"},{"line_number":117,"context_line":"                instance \u003d provisioner.show_instance(request[\u0027hostname\u0027])"},{"line_number":118,"context_line":"            # TODO(dtantsur): replace Error with a specific exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_14228453","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":24},"in_reply_to":"7faddb67_5e682bf4","updated":"2019-07-08 22:33:09.000000000","message":"The deploy_roles workflow runs the expand_roles action before running the deploy_instances workflow. This means the change on line #363 will ensure the hostname is populated with the generated name if it is missing.","commit_id":"c35aa14ed68e2be55c75ede3853c2f0f9acefec9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3929393f200e3cbcddc4b9839dae2373a6f154e8","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                error\u003d\"%s: %s\" % (type(exc).__name__, exc)"},{"line_number":209,"context_line":"            )"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        LOG.error(\u0027reservations: %s\u0027 % result)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        return {\u0027reservations\u0027: result}"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_fe455771","line":211,"range":{"start_line":211,"start_character":0,"end_line":211,"end_character":45},"updated":"2019-07-08 08:18:05.000000000","message":"Should be removed?","commit_id":"c35aa14ed68e2be55c75ede3853c2f0f9acefec9"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9d63ef3078e73a3008438d9c1f54b2818e5d03a2","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                error\u003d\"%s: %s\" % (type(exc).__name__, exc)"},{"line_number":209,"context_line":"            )"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        LOG.error(\u0027reservations: %s\u0027 % result)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        return {\u0027reservations\u0027: result}"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_d402acb4","line":211,"range":{"start_line":211,"start_character":0,"end_line":211,"end_character":45},"in_reply_to":"7faddb67_fe455771","updated":"2019-07-08 22:33:09.000000000","message":"yes","commit_id":"c35aa14ed68e2be55c75ede3853c2f0f9acefec9"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"51e4a14fe6a95ea25d8dd174ccb1b51469aeff7f","unresolved":false,"context_lines":[{"line_number":378,"context_line":"                    instances.append(inst)"},{"line_number":379,"context_line":"                    hostname_map[hostname] \u003d hostname"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        LOG.error(\u0027instances: %s\u0027 % json.dumps(instances, indent\u003d2))"},{"line_number":382,"context_line":"        return {\u0027instances\u0027: instances,"},{"line_number":383,"context_line":"                \u0027environment\u0027: {\u0027parameter_defaults\u0027: parameter_defaults}}"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_4047f91e","line":381,"range":{"start_line":381,"start_character":12,"end_line":381,"end_character":17},"updated":"2019-07-05 10:39:15.000000000","message":"is this error log intentional?","commit_id":"c35aa14ed68e2be55c75ede3853c2f0f9acefec9"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9d63ef3078e73a3008438d9c1f54b2818e5d03a2","unresolved":false,"context_lines":[{"line_number":378,"context_line":"                    instances.append(inst)"},{"line_number":379,"context_line":"                    hostname_map[hostname] \u003d hostname"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        LOG.error(\u0027instances: %s\u0027 % json.dumps(instances, indent\u003d2))"},{"line_number":382,"context_line":"        return {\u0027instances\u0027: instances,"},{"line_number":383,"context_line":"                \u0027environment\u0027: {\u0027parameter_defaults\u0027: parameter_defaults}}"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_f4fd68b1","line":381,"range":{"start_line":381,"start_character":12,"end_line":381,"end_character":17},"in_reply_to":"7faddb67_1ebdd364","updated":"2019-07-08 22:33:09.000000000","message":"Will do","commit_id":"c35aa14ed68e2be55c75ede3853c2f0f9acefec9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3929393f200e3cbcddc4b9839dae2373a6f154e8","unresolved":false,"context_lines":[{"line_number":378,"context_line":"                    instances.append(inst)"},{"line_number":379,"context_line":"                    hostname_map[hostname] \u003d hostname"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        LOG.error(\u0027instances: %s\u0027 % json.dumps(instances, indent\u003d2))"},{"line_number":382,"context_line":"        return {\u0027instances\u0027: instances,"},{"line_number":383,"context_line":"                \u0027environment\u0027: {\u0027parameter_defaults\u0027: parameter_defaults}}"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_1ebdd364","line":381,"range":{"start_line":381,"start_character":12,"end_line":381,"end_character":17},"in_reply_to":"7faddb67_4047f91e","updated":"2019-07-08 08:18:05.000000000","message":"I think it has to be removed","commit_id":"c35aa14ed68e2be55c75ede3853c2f0f9acefec9"}]}